Le dimanche 5 janvier 2014, 20:10:17 Kenneth Graunke a écrit :
> Using the get_local_param_pointer helper ensures that the LocalParams
> arrays have actually been allocated before attempting to use them.
>
> glProgramLocalParameters4fvEXT needs to do a bit of extra checking,
> but it can be simpli
On Fre, 2013-12-27 at 19:41 +0100, Marek Olšák wrote:
> Okay. Using Axxx for transfers only is a good idea, just please make
> sure the formats are not advertised to the state tracker.
Advertising the format to the state tracker is the whole point :), as
it's the format that matches the X11 semant
This series is
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=72877
--- Comment #4 from Michel Dänzer ---
(In reply to comment #3)
> Is the bug fixed?
Not yet. To fix it, the r600g driver needs to be adapted to changes in the way
the Gallium3D infrastructure deals with big endian hosts.
--
You are receiving th
On Sun, 5 Jan 2014 18:51:18 -0800
Tom Stellard wrote:
> struct rc_test_file test_file;
> + struct rc_instruction *inst;
> unsigned optimizations = 1;
> unsigned do_full_regalloc = 1;
> - struct rc_instruction *inst;
> unsigned pass = 1;
This doesn't do what the t
v2: Move to a timing thread to minimize overhead.
Signed-off-by: Lauri Kasanen
---
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 25 +++
src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 12 +++
2 files changed, 37 insertions(+)
diff --git a/src/gallium/winsy
No measurable overhead when off (glxgears within 0.5%).
v2: Cosmetic changes.
Signed-off-by: Lauri Kasanen
---
src/gallium/drivers/radeon/r600_pipe_common.c | 32 +++
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 17
These will be used later on for optimizing the VRAM placement.
No measurable overhead (glxgears).
Signed-off-by: Lauri Kasanen
---
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++
src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16
src/gallium/winsys/radeon/drm/radeon_dr
Signed-off-by: Lauri Kasanen
---
src/gallium/drivers/radeon/r600_buffer_common.c | 8
src/gallium/drivers/radeon/radeon_uvd.c | 4 ++--
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4
src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 1 +
src/gallium/winsys/radeon/drm/r
https://bugs.freedesktop.org/show_bug.cgi?id=69101
--- Comment #11 from Alexander Mezin ---
Even with UXA, I still have black window instead of fullscreen games
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mai
https://bugs.freedesktop.org/show_bug.cgi?id=72877
--- Comment #5 from Christian Zigotzky ---
(In reply to comment #4)
> (In reply to comment #3)
> > Is the bug fixed?
>
> Not yet. To fix it, the r600g driver needs to be adapted to changes in the
> way the Gallium3D infrastructure deals with big
On Sun, Jan 5, 2014 at 10:26 PM, Axel Davy wrote:
> Signed-off-by: Axel Davy
> ---
> src/gallium/state_trackers/dri/drm/dri2.c | 49
> +--
> 1 file changed, 47 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/state_trackers/dri/drm/dri2.c
> b/src/gallium/s
Hello,
many of the files in radeonsi originally came from other places where
they had different names and were never renamed.
Most of them now have names that don't tell what the files are for
(r600 is not actually the first hardware supported by them, they start
at radeonsi), and even those with
It sounds good, but I'd like the prefix to be si_ everywhere.
Marek
On Mon, Jan 6, 2014 at 2:47 PM, Andreas Hartmetz wrote:
> Hello,
>
> many of the files in radeonsi originally came from other places where
> they had different names and were never renamed.
> Most of them now have names that don
On Sun, Jan 5, 2014 at 6:53 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> NUM_BANKS is not constant on CIK.
Reviewed-by: Alex Deucher
> ---
> src/gallium/drivers/radeonsi/si_state.c | 23
> +++
> src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 5 +
> s
---
src/gallium/drivers/r600/compute_memory_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600/compute_memory_pool.c
index fd3a04c..7a7b057 100644
--- a/src/gallium/drivers/r600/compute_memory_po
Am 05.01.2014 00:42, schrieb Maxence Le Doré:
> From: Maxence Le Doré
>
> ---
> src/gallium/auxiliary/util/u_cpu_detect.c | 5 +
> src/gallium/auxiliary/util/u_cpu_detect.h | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c
> b/src/gallium
Am 05.01.2014 01:34, schrieb Maxence Le Doré:
> FMA(a,b,c) keeps extra precision (usually 1 more bit of mantissa,
> afaik) for the result a*b and add this to c, to finally produce a
> IEEE754 32bit float result.
>
> MAD(a,b,c) product a IEEE754 32bit float product a*b and add it to C.
>
> So, fma
Hi,
This is the second version of my previous patches.
I have cleaned a bit compute_memory_pool.c, added some
NULL checks to the code, corrected a typo and removed
an unneeded decraration of a function.
Patches 1 and 2 are the same.
Patch 3 changes Returns to @returns so doxygen can
parse it
---
src/gallium/drivers/r600/compute_memory_pool.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600/compute_memory_pool.c
index 7a7b057..62d1a5c 100644
--- a/src/gallium/drivers/r600/compute_memory_pool.c
+++ b/s
Explanation of the changes, as requested by Tom Stellard:
Let's take need after is calculated as
item->size_in_dw+2048 - (pool->size_in_dw - allocated)
BEFORE:
If need is positive or 0:
we calculate need += 1024 - (need % 1024), which is like
cealing to the nearest multiple of 1024, f
Removed compute_memory_defrag declaration
because it seems to be unimplemented.
I think that this function would have been the one that
solves the problem with fragmentation that
compute_memory_finalize_pending has.
Also removed comments that are already at
compute_memory_pool.c
---
src/gallium/
On 01/03/2014 04:44 PM, Nathan Kidd wrote:
From: Nathan Kidd
Fixed what I noticed; no warranty for exhaustiveness.
Signed-off-by: Nathan Kidd
---
docs/conform.html|2 +-
docs/devinfo.html|2 +-
docs/dispatch.html | 10 +-
docs/egl.html|8
On Sun, Jan 5, 2014 at 12:42 AM, Maxence Le Doré
wrote:
> From: Maxence Le Doré
Huh, user.email not configured properly?
> static void
> +micro_fma(union tgsi_exec_channel *dst,
> + const union tgsi_exec_channel *src0,
> + const union tgsi_exec_channel *src1,
> + con
In this case, NULL checks are added to compute_memory_grow_pool,
so it returns -1 when it fails. This makes necesary
to handle such cases in compute_memory_finalize_pending
when it is needed to grow the pool
---
src/gallium/drivers/r600/compute_memory_pool.c | 30 --
src/ga
On 01/03/2014 06:39 AM, servuswiege...@yahoo.de wrote:
when you create the patches with git, you can add --cover-letter to the
command line. then you get a PATCH 0/X file with an overview over all
changes and a central place where you can describe what you've done in
general/which extension etc.
On 01/05/2014 09:10 PM, Kenneth Graunke wrote:
Using the get_local_param_pointer helper ensures that the LocalParams
arrays have actually been allocated before attempting to use them.
glProgramLocalParameters4fvEXT needs to do a bit of extra checking,
but it can be simplified since the helper ha
On 01/06/2014 08:15 AM, Bruno Jiménez wrote:
Hi,
This is the second version of my previous patches.
I have cleaned a bit compute_memory_pool.c, added some
NULL checks to the code, corrected a typo and removed
an unneeded decraration of a function.
Patches 1 and 2 are the same.
Patch 3 changes R
On 01/02/2014 11:38 AM, Aaron Watry wrote:
ctx->DrawIndirectBuffer wasn't being free'd in _mesa_free_buffer_objects
With this patch, "valgrind --leak-check=full glxgears" on evergreen (CEDAR)
now shows:
LEAK SUMMARY:
definitely lost: 0 bytes in 0 blocks
indirectly lost: 0 bytes in 0 blo
On 01/03/2014 05:57 AM, Juha-Pekka Heikkila wrote:
Still Klocwork related patches.
Juha-Pekka Heikkila (2):
glx: Add missing null check in __glXNewIndirectAPI()
glx: check memory allocations in __glXInitVertexArrayState()
src/glx/indirect_vertex_array.c | 27 +++
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 01/02/2014 05:27 PM, Maxence Le Doré wrote:
From: Maxence Le Doré
---
src/mesa/main/texobj.c | 40
1 file changed, 40 insertions(+)
diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
index d6510fe..bddbc50 100644
--- a/src/mesa/main/texo
On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez wrote:
> ---
> src/gallium/drivers/r600/compute_memory_pool.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
> b/src/gallium/drivers/r600/compute_memory_pool.c
> index 7a7b057..62d1a5c
On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez wrote:
> In this case, NULL checks are added to compute_memory_grow_pool,
> so it returns -1 when it fails. This makes necesary
> to handle such cases in compute_memory_finalize_pending
> when it is needed to grow the pool
Same comment as 2/5. Pleas
On 12/31/2013 09:03 PM, Alexander von Gluck IV wrote:
* The Haiku renderers need to link to libGL to function properly
in all usage contexts. As mesa drivers build before gallium
targets, we couldn't properly link the mesa swrast driver to
the gallium libGL target for Haiku.
* This is li
On Mon, 2014-01-06 at 12:51 -0500, Alex Deucher wrote:
> On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez wrote:
> > ---
> > src/gallium/drivers/r600/compute_memory_pool.c | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
> > b/sr
On Sun, Jan 5, 2014 at 2:28 PM, Eric Anholt wrote:
> Anuj Phogat writes:
>
>> On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote:
>>> Noticed by tex3d-maxsize on my next commit to check that our addresses
>>> don't overflow.
>>> ---
>>> src/mesa/drivers/dri/i965/intel_blit.c| 20 +++
https://bugs.freedesktop.org/show_bug.cgi?id=73174
Brian Paul changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
https://bugs.freedesktop.org/show_bug.cgi?id=73144
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 01/03/2014 04:51 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> No piglit regressions on IVB.
>
> With minor tweaks to the arb_map_buffer_alignment-map-invalidate-range
> test (disable the extension check, set alignment to 64 instead of
> querying), the i965 driver would fail the test witho
On 01/03/2014 04:51 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer':
"old_"? :)
> intel_buffer_objects.c:471:17: warning: unused parameter 'flag'
> [-Wunused-parameter]
>
> The parameter hasn't been used since the i915 and i965
On 01/05/2014 02:28 PM, Eric Anholt wrote:
> Anuj Phogat writes:
>
>> On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote:
>>> Noticed by tex3d-maxsize on my next commit to check that our addresses
>>> don't overflow.
>>> ---
>>> src/mesa/drivers/dri/i965/intel_blit.c| 20 +++
On 12/23/2013 04:08 PM, Eric Anholt wrote:
> Noticed by tex3d-maxsize on my next commit to check that our addresses
> don't overflow.
Should this also go to stable branches?
> ---
> src/mesa/drivers/dri/i965/intel_blit.c| 20
> src/mesa/drivers/dri/i965/intel_mipmap_
Series is
Reviewed-by: Ian Romanick
On 12/23/2013 04:08 PM, Eric Anholt wrote:
> ---
> src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c
> b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> index c653828..c2ca10d
On 01/06/2014 10:51 AM, Kenneth Graunke wrote:
> On 01/03/2014 04:51 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer':
>
> "old_"? :)
There are #defines that wrap the names in i915 that are duplicates of
names in i965 (for megad
On 01/06/2014 10:43 AM, Kenneth Graunke wrote:
> On 01/03/2014 04:51 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> No piglit regressions on IVB.
>>
>> With minor tweaks to the arb_map_buffer_alignment-map-invalidate-range
>> test (disable the extension check, set alignment to 64 instead of
>
On 06/01/2014, Marek Olšák wrote :
On Sun, Jan 5, 2014 at 10:26 PM, Axel Davy wrote:
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/dri/drm/dri2.c | 49 +--
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/dri/drm
On 01/02/2014 10:38 AM, Aaron Watry wrote:
> Note: I don't have hardware to test this, but I believe it to be correct.
>
> Found while tracking down a related leak in evergreen context management.
> ---
> src/mesa/drivers/dri/radeon/radeon_common_context.c | 4 ++--
> 1 file changed, 2 insertions
On 01/05/2014 01:26 PM, Axel Davy wrote:
> This may require changes to the driconf gui.
>
> Signed-off-by: Axel Davy
> ---
> src/mesa/drivers/dri/common/xmlconfig.c | 24
> src/mesa/drivers/dri/common/xmlconfig.h | 7 ++-
> 2 files changed, 30 insertions(+), 1 delet
On 01/02/2014 05:18 PM, Maxence Le Doré wrote:
> ---
> src/mesa/drivers/dri/i915/i830_state.c | 12
> src/mesa/drivers/dri/i965/brw_util.c | 24 +---
> 2 files changed, 25 insertions(+), 11 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i915/i830_state.c
>
On Mon, Jan 6, 2014 at 1:26 PM, Ian Romanick wrote:
> On 01/02/2014 10:38 AM, Aaron Watry wrote:
>> Note: I don't have hardware to test this, but I believe it to be correct.
>>
>> Found while tracking down a related leak in evergreen context management.
>> ---
>> src/mesa/drivers/dri/radeon/radeo
https://bugs.freedesktop.org/show_bug.cgi?id=73096
Brian Paul changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |bri...@vmware.com
|org
This is part of the GL_EXT_packed_float extension.
Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096
Cc: 10.0
---
src/mesa/main/formats.c | 19 +++
src/mesa/main/formats.h |3 +++
src/mesa/main/get.c | 21 +
src
On 01/02/2014 04:27 PM, Maxence Le Doré wrote:
> ---
> src/mesa/main/bufferobj.c | 158
> ++
> src/mesa/main/bufferobj.h | 9 ++-
> 2 files changed, 165 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferob
On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul wrote:
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -611,6 +611,9 @@ descriptor=[
> # GL_ARB_fragment_program
>[ "FRAGMENT_PROGRAM_ARB", "CONTEXT_BOOL(FragmentProgram.Enabled),
> extra_ARB_fragment_program"
On 01/06/2014 01:01 PM, Chris Forbes wrote:
On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul wrote:
--- a/src/mesa/main/get_hash_params.py
+++ b/src/mesa/main/get_hash_params.py
@@ -611,6 +611,9 @@ descriptor=[
# GL_ARB_fragment_program
[ "FRAGMENT_PROGRAM_ARB", "CONTEXT_BOOL(FragmentProgram.En
This patch fixes this build error with gcc <= 4.5 and clang <= 3.1.
CC clientattrib.lo
In file included from ../../include/GL/glx.h:333:0,
from glxclient.h:45,
from clientattrib.c:32:
../../include/GL/glxext.h:275:13: error: redefinition of typedef 'GLXConte
On 01/06/2014 12:17 PM, Vinson Lee wrote:
> This patch fixes this build error with gcc <= 4.5 and clang <= 3.1.
>
> CC clientattrib.lo
> In file included from ../../include/GL/glx.h:333:0,
> from glxclient.h:45,
> from clientattrib.c:32:
> ../../include/GL/g
+ const GLboolean signd =
+rb ? _mesa_is_format_signed(rb->
Format) : GL_FALSE;
+ v->value_int_4[0] =
+ v->value_int_4[1] =
+ v->value_int_4[2] =
+ v->value_int_4[3] = signd;
Might have gone with something like is_signed rather than dropping a
le
On 12/23/2013 04:08 PM, Eric Anholt wrote:
> This was one of the things we always wanted to do to this, to make it more
> useful than just (value << FIELD_MASK).
> ---
> src/mesa/drivers/dri/i965/brw_defines.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/mes
On 01/06/2014 11:57 AM, Brian Paul wrote:
> This is part of the GL_EXT_packed_float extension.
>
> Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096
> Cc: 10.0
Thanks, Brian!
Reviewed-by: Kenneth Graunke
___
mesa-dev mailing list
mesa-dev@
On 01/06/2014 01:21 PM, Chris Forbes wrote:
+ const GLboolean signd =
+rb ? _mesa_is_format_signed(rb->
Format) : GL_FALSE;
+ v->value_int_4[0] =
+ v->value_int_4[1] =
+ v->value_int_4[2] =
+ v->value_int_4[3] = signd;
Might have gone with some
https://bugs.freedesktop.org/show_bug.cgi?id=72877
--- Comment #6 from Christian Zigotzky ---
Created attachment 91561
--> https://bugs.freedesktop.org/attachment.cgi?id=91561&action=edit
Lubuntu 13.10 PowerPC (Kernel 3.13-rc7) with the old Mesa 8.0.2
Lubuntu 13.10 PowerPC (Kernel 3.13-rc7) wi
https://bugs.freedesktop.org/show_bug.cgi?id=72877
Christian Zigotzky changed:
What|Removed |Added
Attachment #91561|text/plain |image/jpeg
mime type|
---
src/gallium/drivers/r600/compute_memory_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600/compute_memory_pool.c
index fd3a04c..7a7b057 100644
--- a/src/gallium/drivers/r600/compute_memory_po
Hi,
Third version of the patches.
Now with r600g in the commit messages.
Patches 2 and 3 have spaces between 'if' and '('.
Patches 1,4 and 5 are the same.
Thanks!
[PATCH 1/5] [r600g] Fixing a typo and some indentation
[PATCH 2/5] [r600g] Adding checks for NULL after CALLOC
[PATCH 3/5] [r600g] A
In this case, NULL checks are added to compute_memory_grow_pool,
so it returns -1 when it fails. This makes necesary
to handle such cases in compute_memory_finalize_pending
when it is needed to grow the pool
---
src/gallium/drivers/r600/compute_memory_pool.c | 30 --
src/ga
Removed compute_memory_defrag declaration because it seems
to be unimplemented.
I think that this function would have been the one that solves
the problem with fragmentation that compute_memory_finalize_pending has.
Also removed comments that are already at compute_memory_pool.c
---
src/gallium/
---
src/gallium/drivers/r600/compute_memory_pool.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600/compute_memory_pool.c
index 7a7b057..da351d8 100644
--- a/src/gallium/drivers/r600/compute_memory_pool.c
+++ b/s
Explanation of the changes, as requested by Tom Stellard:
Let's take need after is calculated as
item->size_in_dw+2048 - (pool->size_in_dw - allocated)
BEFORE:
If need is positive or 0:
we calculate need += 1024 - (need % 1024), which is like
cealing to the nearest multiple of 1024, f
On Haswell, POW takes 24 cycles, while EXP2 only takes 14. Plus, using
POW requires putting 2.0 in a register, while EXP2 doesn't.
I believe that EXP2 will be faster than POW on basically all GPUs, so
it makes sense to optimize it.
Looking at the savage2 subset of shader-db:
total instructions i
This patch creates a new generic is_value() method, which checks if an
ir_constant has a particular value. (For vectors, it must have the
single value repeated across all components.)
It then rewrites the is_zero/is_one/is_negative_one methods to use this
generic helper. All three were basically
On 01/02/2014 03:22 PM, Maxence Le Doré wrote:
> - Correct typo in predicate function
> - Split the patch that introduces ir_builder changes
> - Drop trivial min3_expr(), max3_expr(), mid3_expr()
> - Thanks to Roland Scheidegger and Mario Rugiero, catch all cases for
> evaluation of mid3
> - Squash
https://bugs.freedesktop.org/show_bug.cgi?id=72877
--- Comment #7 from Christian Zigotzky ---
Created attachment 91566
--> https://bugs.freedesktop.org/attachment.cgi?id=91566&action=edit
glxgears has wrong colors with Mesa 10.0.1
--
You are receiving this mail because:
You are the assignee f
The type of all three parameters are identical, so we don't need to
specify it three times. The predicate is always identical too, so we
don't need to make it a parameter, either.
Signed-off-by: Kenneth Graunke
Cc: Maxence Le Doré
---
src/glsl/builtin_functions.cpp | 137 ++
On Sun, Jan 5, 2014 at 7:00 PM, Tom Stellard wrote:
> On Sun, Jan 05, 2014 at 09:49:53PM -0500, Ilia Mirkin wrote:
>> On Sun, Jan 5, 2014 at 9:49 PM, Tom Stellard wrote:
>> > From: Tom Stellard
>> >
>> > The xvmc unit tests are failing on r300g and r600g.
>>
>> FWIW it works fine on nv40-nv96. (
https://bugs.freedesktop.org/show_bug.cgi?id=73337
Priority: medium
Bug ID: 73337
Keywords: regression
CC: kenn...@whitecape.org
Assignee: mesa-dev@lists.freedesktop.org
Summary: ir_builder.h(187) : error C2226: syntax error :
The r600g prefix is wrong. Your commit messages should follow the same
conventions the other Mesa developers use (see the git log for examples).
Since you're changing compute, you should use the prefix
"r600g/compute:" ("r600g:" is okay too), but never "[r600g]". The
subjects of your emails don't
Evidently, there's some other definition of "min" and "max" that
causes MSVC to choke on these function names. Renaming to min2()
and max2() fixes things.
---
src/glsl/builtin_functions.cpp |6 +++---
src/glsl/ir_builder.cpp|4 ++--
src/glsl/ir_builder.h |4 ++--
3 fi
Is the logging really needed apart from initial debugging and
validation of the code? I don't see a reason to have this in master.
Also, pipe_screen functions must not change the contents of
radeon_winsys. They are different objects. The two can only
communicate using the functions declared in the
On Mon, Jan 6, 2014 at 11:00 AM, Kenneth Graunke wrote:
> On 01/05/2014 02:28 PM, Eric Anholt wrote:
>> Anuj Phogat writes:
>>
>>> On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote:
Noticed by tex3d-maxsize on my next commit to check that our addresses
don't overflow.
---
s
On 01/06/2014 03:12 PM, Brian Paul wrote:
> Evidently, there's some other definition of "min" and "max" that
> causes MSVC to choke on these function names. Renaming to min2()
> and max2() fixes things.
That's really strange...but I'm fine with renaming them. Sorry for the
trouble.
Reviewed-by:
https://bugs.freedesktop.org/show_bug.cgi?id=73337
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Mon, Jan 6, 2014 at 12:18 PM, Lauri Kasanen wrote:
> Signed-off-by: Lauri Kasanen
> ---
> src/gallium/drivers/radeon/r600_buffer_common.c | 8
> src/gallium/drivers/radeon/radeon_uvd.c | 4 ++--
> src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4
> src/gallium/winsys/
On Tue, Jan 7, 2014 at 12:12 AM, Brian Paul wrote:
> Evidently, there's some other definition of "min" and "max" that
> causes MSVC to choke on these function names. Renaming to min2()
> and max2() fixes things.
Wouldn't it be easier to just make sure NOMINMAX is defined before
including any sys
On Mon, Jan 6, 2014 at 12:17 PM, Lauri Kasanen wrote:
> These will be used later on for optimizing the VRAM placement.
>
> No measurable overhead (glxgears).
I recommend testing torcs (the Forza track) next time. glxgears is not
useful here.
>
> Signed-off-by: Lauri Kasanen
> ---
> src/gallium
On Mon, 2014-01-06 at 12:50 +0100, Marek Olšák wrote:
>
> Fences might not be implemented by some drivers. I recommend setting
> the fence pointer to NULL, then calling flush and then checking if
> it's not NULL.
That's not necessary, Gallium drivers have to implement the fence
interfaces.
--
Hi,
There are still 5 slots open for the FOSDEM graphics DevRoom, and the
deadline is this friday, the 10th. Get a move on.
If you have requested an account reset with me before, but if you then
haven't bothered filing a talk, you do NOT have a slot. Please file a
talk ASAP to still secure a p
Maxence, while I think it's great that you're interested in working
on this extension, I'm afraid I have another implementation in
a branch in my mesa tree:
http://cgit.freedesktop.org/~fredrik/mesa/log/?h=arb-multi-bind
I've looked at your patches, and noticed you've implemented the
functions by
89 matches
Mail list logo
