[Mesa-dev] [PATCH] st/xvmc/tests: avoid non portable error.h functions

2013-06-26 Thread Jonathan Gray
Signed-off-by: Jonathan Gray --- src/gallium/state_trackers/xvmc/tests/xvmc_bench.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git src/gallium/state_trackers/xvmc/tests/xvmc_bench.c src/gallium/state_trackers/xvmc/tests/xvmc_bench.c index fe85802..37360a6 100644

[Mesa-dev] [PATCH] r300g: add program name check for BSD

2013-06-26 Thread Jonathan Gray
program_invocation_short_name is glibc specific. Provide an alternative using getprogname(), which can be found on *BSD and OS X. Signed-off-by: Jonathan Gray --- src/gallium/drivers/r300/r300_chipset.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git src/gallium/driv

[Mesa-dev] [PATCH] configure.ac: add OpenBSD

2013-06-26 Thread Jonathan Gray
Signed-off-by: Jonathan Gray --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git configure.ac configure.ac index 6832b0d..6a817d0 100644 --- configure.ac +++ configure.ac @@ -449,7 +449,7 @@ if test "x$enable_asm" = xyes; then case "$host_cpu" in i?8

Re: [Mesa-dev] [PATCH] st/xvmc/tests: avoid non portable error.h functions

2013-06-26 Thread Christian König
Am 26.06.2013 09:10, schrieb Jonathan Gray: Signed-off-by: Jonathan Gray Looks good on first glance, patch is: Reviewed-by: Christian König --- src/gallium/state_trackers/xvmc/tests/xvmc_bench.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git src/gallium/

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-26 Thread Christian König
Am 26.06.2013 05:29, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 2:13 PM, Christian König wrote: Am 24.06.2013 18:39, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 4:48 AM, Christian König wrote: Am 23.06.2013 18:59, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin --- These changes make

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-26 Thread Maarten Lankhorst
Op 26-06-13 10:33, Christian König schreef: > Am 26.06.2013 05:29, schrieb Ilia Mirkin: >> On Mon, Jun 24, 2013 at 2:13 PM, Christian König >> wrote: >>> Am 24.06.2013 18:39, schrieb Ilia Mirkin: >>> On Mon, Jun 24, 2013 at 4:48 AM, Christian König wrote: > Am 23.06.2013 18:59, schr

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-26 Thread Ilia Mirkin
On Wed, Jun 26, 2013 at 4:33 AM, Christian König wrote: > Am 26.06.2013 05:29, schrieb Ilia Mirkin: > >> On Mon, Jun 24, 2013 at 2:13 PM, Christian König >> wrote: >>> >>> Am 24.06.2013 18:39, schrieb Ilia Mirkin: >>> On Mon, Jun 24, 2013 at 4:48 AM, Christian König wrote: > >

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-26 Thread Christian König
Am 26.06.2013 10:56, schrieb Ilia Mirkin: On Wed, Jun 26, 2013 at 4:33 AM, Christian König wrote: Am 26.06.2013 05:29, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 2:13 PM, Christian König wrote: Am 24.06.2013 18:39, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 4:48 AM, Christian König w

Re: [Mesa-dev] [PATCH 1/3] draw: account for elem size when computing overflow

2013-06-26 Thread Jose Fonseca
- Original Message - > We weren't taking into account the size of element > that is to be fetched, which meant that it was possible > to overflow the buffer reads if the stride was very > close to the end of the buffer, e.g. stride = 3, buffer > size = 4, and the element to be read = 4. T

Re: [Mesa-dev] [PATCH] r300g: add program name check for BSD

2013-06-26 Thread Patrick Baggett
On Wed, Jun 26, 2013 at 2:11 AM, Jonathan Gray wrote: > program_invocation_short_name is glibc specific. Provide an > alternative using getprogname(), which can be found on *BSD and OS X. > > Signed-off-by: Jonathan Gray > --- > src/gallium/drivers/r300/r300_chipset.c | 10 +- > 1 file

Re: [Mesa-dev] [PATCH] r300g: add program name check for BSD

2013-06-26 Thread Jonathan Gray
On Wed, Jun 26, 2013 at 07:21:59AM -0500, Patrick Baggett wrote: > On Wed, Jun 26, 2013 at 2:11 AM, Jonathan Gray wrote: > > > program_invocation_short_name is glibc specific. Provide an > > alternative using getprogname(), which can be found on *BSD and OS X. > > > > Signed-off-by: Jonathan Gra

[Mesa-dev] [PATCH] configure.ac: On some systems, "x86-64" is called "amd64"

2013-06-26 Thread Jean-Sébastien Pédron
Hello, On FreeBSD, the x86-64 arch is named "amd64". This patch fixes its detection in the configure script. -- Jean-Sébastien Pédron From 6393428a12f454f88157af9810a89161b0606769 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Wed, 5 Jun 2013 13:27:37 +0200 S

[Mesa-dev] [PATCH] Fix symlinking of libraries in /lib on non-Linux systems

2013-06-26 Thread Jean-Sébastien Pédron
Hello, Makefiles were explicitly looking for a libraries suffixed with the full libtool versioning, such as "libglapi.so.0.0.0". However, on some systems (at least FreeBSD and OpenBSD), libtool only uses a shorter name, such as "libglapi.so.0". Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?

[Mesa-dev] [PATCH] Add $(LIBDRM_CFLAGS) in CPPFLAGS where it's missing

2013-06-26 Thread Jean-Sébastien Pédron
Hello, Without this change, the build would pick the system-wide libdrm, not the one given to the configure script (through PKG_CONFIG_PATH for instance). -- Jean-Sébastien Pédron From 08d12cdfd4d653cebaf30cec4a2b1e970ecef0d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9

[Mesa-dev] [PATCH] Fix typo in "ETIMEOUT" (should be "ETIMEDOUT")

2013-06-26 Thread Jean-Sébastien Pédron
Hello, The subject should be explicit :) -- Jean-Sébastien Pédron From 0126159ee03f8c432129c5966cfa41462d5d2fa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Wed, 5 Jun 2013 13:44:34 +0200 Subject: [PATCH 5/9] Fix typo in "ETIMEOUT" (should be "ETIMEDOUT")

[Mesa-dev] [PATCH] Fix parsing of language code when making options.mo

2013-06-26 Thread Jean-Sébastien Pédron
Hello, The patch uses the $* GNU make variable instead of shell parameter expansion to find the language code. -- Jean-Sébastien Pédron From fed4ca6ef4134dfc34a6e25e5b8de3ef905d2efa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Wed, 5 Jun 2013 13:45:29 +0200

[Mesa-dev] [PATCH] Use and bswap32(x) on FreeBSD

2013-06-26 Thread Jean-Sébastien Pédron
Hello, This is the equivalent to and bswap_32(x) on Linux. -- Jean-Sébastien Pédron From 48fd41784d4c39059c68ecfc4e01197555ec48dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Fri, 14 Jun 2013 17:39:31 +0200 Subject: [PATCH 9/9] Use and bswap32(x) on Free

[Mesa-dev] [PATCH] Use "-I$(srcdir)/include", not "-Iinclude" in AM_CPPFLAGS

2013-06-26 Thread Jean-Sébastien Pédron
Hello, This fixes the build when the build directory is not the source directory. -- Jean-Sébastien Pédron From 15b05331ac969c9f86d8782da07dfd17c0c8a9ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Wed, 5 Jun 2013 13:35:01 +0200 Subject: [PATCH 3/9] Use "-I

Re: [Mesa-dev] [PATCH] Fix symlinking of libraries in /lib on non-Linux systems

2013-06-26 Thread Jonathan Gray
On Wed, Jun 26, 2013 at 02:39:40PM +0200, Jean-Sébastien Pédron wrote: > On 26.06.2013 14:37, Jean-Sébastien Pédron wrote: > > Makefiles were explicitly looking for a libraries suffixed with the full > > libtool versioning, such as "libglapi.so.0.0.0". However, on some > > systems (at least FreeBSD

Re: [Mesa-dev] [PATCH] Use and bswap32(x) on FreeBSD

2013-06-26 Thread Jonathan Gray
On Wed, Jun 26, 2013 at 03:05:47PM +0200, Jean-Sébastien Pédron wrote: > Hello, > > This is the equivalent to and bswap_32(x) on Linux. this is already fixed in a cleaner way, see ebd68dd02998a8595cb10844c37a6b02dc3078a8 ___ mesa-dev mailing list mesa-

Re: [Mesa-dev] [PATCH] Use and bswap32(x) on FreeBSD

2013-06-26 Thread Jean-Sébastien Pédron
On 26.06.2013 15:14, Jonathan Gray wrote: > this is already fixed in a cleaner way, see > ebd68dd02998a8595cb10844c37a6b02dc3078a8 You're right, thanks for pointing me to it! -- Jean-Sébastien Pédron signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH] configure.ac: On some systems, "x86-64" is called "amd64"

2013-06-26 Thread Jonathan Gray
On Wed, Jun 26, 2013 at 02:54:34PM +0200, Jean-Sébastien Pédron wrote: > Hello, > > On FreeBSD, the x86-64 arch is named "amd64". This patch fixes its > detection in the configure script. Shouldn't config.guess/config.sub remap it? from config.log here: uname -m = amd64 uname -r = 5.3 uname -s

Re: [Mesa-dev] [PATCH] mesa: update glext.h to version 20130624

2013-06-26 Thread Jose Fonseca
- Original Message - > In glapi_priv.h we always need the typedef for the GLclampx type > since GL_OES_fixed_point is now defined in glext.h but the > GLclampx type is not. GLclampx is not used by anything in glext.h > but we need it for GL ES dispatch. > --- > include/GL/glext.h

Re: [Mesa-dev] [PATCH] mesa: update glext.h to version 20130624

2013-06-26 Thread Brian Paul
On 06/26/2013 07:48 AM, Jose Fonseca wrote: - Original Message - In glapi_priv.h we always need the typedef for the GLclampx type since GL_OES_fixed_point is now defined in glext.h but the GLclampx type is not. GLclampx is not used by anything in glext.h but we need it for GL ES dispatc

Re: [Mesa-dev] [PATCH 2/2] softpipe: honor predication for clear_render_target and clear_depth_stencil

2013-06-26 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > From: Roland Scheidegger > > trivial, copied from llvmpipe > --- > src/gallium/drivers/softpipe/sp_surface.c | 42 > +++-- > 1 file changed, 40 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/s

Re: [Mesa-dev] [PATCH] Fix symlinking of libraries in /lib on non-Linux systems

2013-06-26 Thread Jean-Sébastien Pédron
On 26.06.2013 15:10, Jonathan Gray wrote: > This misses a few places see > http://marc.info/?l=mesa3d-dev&m=137179411405480&w=2 > > namely > > src/gbm/Makefile.am > src/mapi/es1api/Makefile.am > src/mapi/es2api/Makefile.am > src/mapi/vgapi/Makefile.am I attached a new patch, fixing the Makefile.

[Mesa-dev] [Bug 64959] Cannot build against EGL without X11

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64959 --- Comment #4 from Ross Burton --- For fun, current mesa master doesn't even compile without X11 headers: | In file included from /.../mesa/2_9.2.0~gitAUTOINC+9aebad618c-r9.0/git/include/EGL/egl.h:36:0, | from /.../mesa/2_9.2.0

Re: [Mesa-dev] [PATCH] Fix typo in "ETIMEOUT" (should be "ETIMEDOUT")

2013-06-26 Thread Chia-I Wu
On Wed, Jun 26, 2013 at 8:58 PM, Jean-Sébastien Pédron wrote: > Hello, > > The subject should be explicit :) Applied, thanks. > > -- > Jean-Sébastien Pédron > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/m

Re: [Mesa-dev] [PATCH] configure.ac: On some systems, "x86-64" is called "amd64"

2013-06-26 Thread Jean-Sébastien Pédron
On 26.06.2013 15:35, Jonathan Gray wrote: > On Wed, Jun 26, 2013 at 02:54:34PM +0200, Jean-Sébastien Pédron wrote: >> Hello, >> >> On FreeBSD, the x86-64 arch is named "amd64". This patch fixes its >> detection in the configure script. > > Shouldn't config.guess/config.sub remap it? > > from conf

Re: [Mesa-dev] [PATCH] Fix parsing of language code when making options.mo

2013-06-26 Thread Jean-Sébastien Pédron
On 26.06.2013 14:58, Jean-Sébastien Pédron wrote: > The patch uses the $* GNU make variable instead of shell parameter > expansion to find the language code. Please disregard this patch. The problem was fixed in 95e145aaee1c535aa4d55b1765c717968efdf18c, between the day I made the patch (a few wee

Re: [Mesa-dev] [PATCH] glsl: Initialize member variable is_ubo_var in constructor.

2013-06-26 Thread Ian Romanick
On 06/25/2013 09:40 PM, Vinson Lee wrote: Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee Reviewed-by: Ian Romanick --- src/glsl/link_uniforms.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/s

Re: [Mesa-dev] [PATCH] r300g: add program name check for BSD

2013-06-26 Thread Brian Paul
On 06/26/2013 01:11 AM, Jonathan Gray wrote: program_invocation_short_name is glibc specific. Provide an alternative using getprogname(), which can be found on *BSD and OS X. Signed-off-by: Jonathan Gray --- src/gallium/drivers/r300/r300_chipset.c | 10 +- 1 file changed, 9 insertio

[Mesa-dev] Build fails without X11 present

2013-06-26 Thread Burton, Ross
Hi, I'm routinely building Mesa and Weston in an environment without X11, and currently both Mesa and Weston are failing to build for the same reason: eglplatform.h is attempting to include X11/Xlib.h. There was a patch last year that attempted to solve the Mesa part of this: http://lists.freede

Re: [Mesa-dev] R600 Patches: Add support for the local address space

2013-06-26 Thread Tom Stellard
Hi Vincent, Here is an updated version of patch #3. -Tom On Fri, Jun 14, 2013 at 08:35:03AM -0700, Vincent Lejeune wrote: > Hi, > > Thank for your work on this ! > Patch 2, 4 and 5 have my rb. > > > >diff --git a/lib/Target/R600/R600InstrInfo.cpp > >b/lib/Target/R600/R600InstrInfo.cpp > >ind

[Mesa-dev] [Bug 66213] New: Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Priority: medium Bug ID: 66213 Assignee: mesa-dev@lists.freedesktop.org Summary: Certain Mesa Demos Rendering Inverted (vertically) Severity: major Classification: Unclassified

Re: [Mesa-dev] [PATCH] intel: Move irb null check before dereference.

2013-06-26 Thread Eric Anholt
Vinson Lee writes: > Fixes "Dereference before null check" defect reported by Coverity. The irb->mt check should be dropped, instead -- _mesa_source_buffer_exists() or _mesa_clip_copytexsubimage() should have failed in that case, and we would never have reached this. pgpULYupmvnzH.pgp Descript

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 --- Comment #1 from Jesus Cortez --- Created attachment 81484 --> https://bugs.freedesktop.org/attachment.cgi?id=81484&action=edit demonstrates winpos inversion -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Mesa-dev] forking shared intel directory?

2013-06-26 Thread Chad Versace
On 06/21/2013 10:09 PM, Kenneth Graunke wrote: On 06/21/2013 11:29 AM, Eric Anholt wrote: Long ago, when porting FBO and memory management support to i965, I merged a bunch of code between the i915 and i965 drivers and put it in the intel directory. I think it served us well for a long time, as

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Jesus Cortez changed: What|Removed |Added Attachment #81483|0 |1 is obsolete|

[Mesa-dev] [PATCH 1/2] mesa: remove const from glDebugMessageCallbackARB() function parameter

2013-06-26 Thread Brian Paul
The new 20130624 version of glext.h removed the const qualifier on the 'userParam' parameter. --- src/mapi/glapi/gen/ARB_debug_output.xml |2 +- src/mesa/main/errors.c |4 ++-- src/mesa/main/errors.h |2 +- 3 files changed, 4 insertions(+), 4 deletions

[Mesa-dev] [PATCH 2/2] mesa: add const qualifier to glMultiDrawElementsEXT() indices param

2013-06-26 Thread Brian Paul
The 20130624 version of glext.h changed this to match the glMultiDrawElements() function which already had the extra const qualifier. Fixes warnings/errors that seem to vary from one compiler to the next. --- src/mapi/glapi/gen/gl_API.xml |2 +- src/mesa/vbo/vbo_exec_array.c |2 +- src/me

[Mesa-dev] breakage from new glext.h

2013-06-26 Thread Brian Paul
A couple of our automated builds failed with the new glext.h header. But I didn't see any issues with my local builds. It seems some compilers (or versions of compilers) are more sensitive to const qualifiers on function parameters than others. Hopefully the two patches I just posted will cle

Re: [Mesa-dev] [PATCH 2/2] mesa: add const qualifier to glMultiDrawElementsEXT() indices param

2013-06-26 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > The 20130624 version of glext.h changed this to match the > glMultiDrawElements() function which already had the extra const > qualifier. > > Fixes warnings/errors that seem to vary from one compiler to the next. > --- > src/mapi/glap

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Ian Romanick

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 --- Comment #4 from Ian Romanick --- Also, what driver are you using? The output of "glxinfo | grep renderer" should provide the necessary information. -- You are receiving this mail because: You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH] mesa: update glext.h to version 20130624

2013-06-26 Thread Ian Romanick
On 06/26/2013 07:13 AM, Brian Paul wrote: On 06/26/2013 07:48 AM, Jose Fonseca wrote: - Original Message - In glapi_priv.h we always need the typedef for the GLclampx type since GL_OES_fixed_point is now defined in glext.h but the GLclampx type is not. GLclampx is not used by anything

Re: [Mesa-dev] [PATCH] i965: Split surface format code into a new file (brw_surface_formats.c).

2013-06-26 Thread Eric Anholt
Kenneth Graunke writes: > brw_wm_surface_state.c has gotten rather large and unwieldy. At this > point, it consists of two separate portions: > > 1. Surface format code > >This includes the giant table of surface formats and what features >they support on each generation, as well as the

[Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
--- src/mesa/program/register_allocate.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/register_allocate.c b/src/mesa/program/register_allocate.c index ea06a07..4eed0b5 100644 --- a/src/mesa/program/register_allocate.c +++ b/src/mesa/program/register

[Mesa-dev] [PATCH 2/4] glx: move declarations before code

2013-06-26 Thread Brian Paul
--- src/glx/glxcmds.c | 15 +++ src/glx/single2.c |3 ++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 5c79073..224e402 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -575,20 +575,19 @@ static Bool __glXIsD

[Mesa-dev] [PATCH 3/4] configure.ac: warn when declarations follow code

2013-06-26 Thread Brian Paul
Since it's an error with MSVC. --- configure.ac |5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index 6832b0d..16f11aa 100644 --- a/configure.ac +++ b/configure.ac @@ -209,6 +209,11 @@ if test "x$GCC" = xyes; then # http://gcc.gnu.org/bugzilla/show_bug.

[Mesa-dev] [PATCH 4/4] glx: return True/False instead of GL_TRUE/GL_FALSE

2013-06-26 Thread Brian Paul
Just to be consistent with the functions' Bool return type. --- src/glx/glxcmds.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 224e402..019165a 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -2

Re: [Mesa-dev] [PATCH 3/4] configure.ac: warn when declarations follow code

2013-06-26 Thread Jose Fonseca
Several components are never expected to be built with MSVC (glx, most dri drivers), so this would put (most likely undesired) burden on those maintainers. I suspect we'll need to do this on a per directory basis... Jose - Original Message - > Since it's an error with MSVC. > --- > con

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 --- Comment #5 from Jesus Cortez --- Created attachment 81511 --> https://bugs.freedesktop.org/attachment.cgi?id=81511&action=edit output of /usr/lib64/glinfo -- You are receiving this mail because: You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH 3/4] configure.ac: warn when declarations follow code

2013-06-26 Thread Jose Fonseca
The other patches look fine though. Jose - Original Message - > Several components are never expected to be built with MSVC (glx, most dri > drivers), so this would put (most likely undesired) burden on those > maintainers. > > I suspect we'll need to do this on a per directory basis...

[Mesa-dev] [PATCH] i965, i915: Return early if miptree allocation fails

2013-06-26 Thread Chad Versace
If allocation fails in intel_miptree_create_layout(), don't proceed to dereference the miptree. Return an early NULL. Fixes static analysis error reported by Klocwork. Note: This is a candidate for the 9.1 branch. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 2

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Andy Furniss changed: What|Removed |Added Attachment #81483|text/plain |image/png mime type|

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 --- Comment #6 from Jesus Cortez --- I am on Scientific Linux 6.3. How can I install the 9.1 version? I'm not able to find that on the Add/Remove software, and trying to compile the source results in errors such as "Requested 'libdrm_radeon >= 2.

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Ian Romanick
Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSVC. For patch 2, I think this is unnecessary if patch 3 is re-done. Right? On 06/26/2013 12:50 PM, Brian Pa

Re: [Mesa-dev] [PATCH] i965, i915: Return early if miptree allocation fails

2013-06-26 Thread Ian Romanick
On 06/26/2013 02:42 PM, Chad Versace wrote: If allocation fails in intel_miptree_create_layout(), don't proceed to dereference the miptree. Return an early NULL. Fixes static analysis error reported by Klocwork. Note: This is a candidate for the 9.1 branch. Signed-off-by: Chad Versace Review

Re: [Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-26 Thread Anuj Phogat
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry wrote: > On 19 June 2013 19:45, Anuj Phogat wrote: >> >> Current implementation of ext_framebuffer_multisample_blit_scaled in >> i965/blorp uses nearest filtering for multisample scaled blits. Using >> nearest filtering produces blocky artifacts and ne

Re: [Mesa-dev] [PATCH] i965, i915: Return early if miptree allocation fails

2013-06-26 Thread Chad Versace
On 06/26/2013 02:57 PM, Ian Romanick wrote: On 06/26/2013 02:42 PM, Chad Versace wrote: If allocation fails in intel_miptree_create_layout(), don't proceed to dereference the miptree. Return an early NULL. Fixes static analysis error reported by Klocwork. Note: This is a candidate for the 9.1

Re: [Mesa-dev] [PATCH] i965, i915: Return early if miptree allocation fails

2013-06-26 Thread Anuj Phogat
On Wed, Jun 26, 2013 at 2:42 PM, Chad Versace wrote: > If allocation fails in intel_miptree_create_layout(), don't proceed to > dereference the miptree. Return an early NULL. > > Fixes static analysis error reported by Klocwork. > > Note: This is a candidate for the 9.1 branch. > Signed-off-by: Ch

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
On 06/26/2013 03:56 PM, Ian Romanick wrote: Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSVC. Yeah, sounds good, but off-hand I have no idea how to do this

[Mesa-dev] [PATCH] llvmpipe: fix a bug in opaque optimization

2013-06-26 Thread sroland
From: Roland Scheidegger If there are queries active the opaque optimization reseting the bin needs to be disabled. (Not really tested since the bug was discovered by code inspection not an actual test failure.) --- src/gallium/drivers/llvmpipe/lp_query.c |2 ++ src/gallium/drivers/llvmp

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Eric Anholt
Brian Paul writes: > On 06/26/2013 03:56 PM, Ian Romanick wrote: >> Patches 1 and 4 are >> >> Reviewed-by: Ian Romanick >> >> For patch 3, I share Jose's concern. I would very much like to see this >> happen in directories containing code that will be built with MSVC. > > Yeah, sounds good, but

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
On 06/26/2013 04:33 PM, Eric Anholt wrote: Brian Paul writes: On 06/26/2013 03:56 PM, Ian Romanick wrote: Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSV

Re: [Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-26 Thread Paul Berry
On 26 June 2013 14:57, Anuj Phogat wrote: > On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry > wrote: > > This seems like a lot of work to accomplish what is effectively a lookup > > table. If this winds up becoming a performance bottleneck, you might > want > > to consider passing the table in via

[Mesa-dev] [PATCH] llvmpipe: handle offset_clamp

2013-06-26 Thread sroland
From: Roland Scheidegger This was just ignored (unless for some reason like unfilled polys draw was handling this). I'm not convinced of that code, putting the float for the clamp in the key isn't really a good idea. Then again the other floats for depth bias are already in there too anyway (shou

Re: [Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-26 Thread Anuj Phogat
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry wrote: > > On 19 June 2013 19:45, Anuj Phogat wrote: >> >> Current implementation of ext_framebuffer_multisample_blit_scaled in >> i965/blorp uses nearest filtering for multisample scaled blits. Using >> nearest filtering produces blocky artifacts and

[Mesa-dev] [PATCH V4 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-26 Thread Anuj Phogat
Current implementation of ext_framebuffer_multisample_blit_scaled in i965/blorp uses nearest filtering for multisample scaled blits. Using nearest filtering produces blocky artifacts and negates the benefits of MSAA. That is the reason why extension was not enabled on i965. This patch implements t

Re: [Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-26 Thread Paul Berry
On 26 June 2013 19:41, Anuj Phogat wrote: > On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry > wrote: > > > > On 19 June 2013 19:45, Anuj Phogat wrote: > >> > >> Current implementation of ext_framebuffer_multisample_blit_scaled in > >> i965/blorp uses nearest filtering for multisample scaled blits.

Re: [Mesa-dev] [PATCH] r300g: add program name check for BSD

2013-06-26 Thread Jonathan Gray
On Wed, Jun 26, 2013 at 09:49:08AM -0600, Brian Paul wrote: > On 06/26/2013 01:11 AM, Jonathan Gray wrote: > >program_invocation_short_name is glibc specific. Provide an > >alternative using getprogname(), which can be found on *BSD and OS X. > > > >Signed-off-by: Jonathan Gray > >--- > > src/ga

[Mesa-dev] [PATCH 1/3] r300g: Fix make check

2013-06-26 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r300/Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r300/Makefile.am b/src/gallium/drivers/r300/Makefile.am index 49264c4..f82b8e9 100644 --- a/src/gallium/drivers/r300/Makefile.am +++ b/src/g

[Mesa-dev] [PATCH 3/3] r300g/compiler: Prevent the regalloc from swizzling texture operands v2

2013-06-26 Thread Tom Stellard
From: Tom Stellard https://bugs.freedesktop.org/show_bug.cgi?id=63520 NOTE: This is a candidate for the stable branches. --- src/gallium/drivers/r300/Makefile.am |1 + .../drivers/r300/compiler/radeon_pair_regalloc.c |8 ++ .../r300/compiler/tests/r300_compiler_tests.c

[Mesa-dev] [PATCH 2/3] r300g/compiler/tests: Add an assembly parser

2013-06-26 Thread Tom Stellard
From: Tom Stellard The assembly parser can be used to load r300 assembly dumps and run them through any of the r300 compiler passes. --- .../r300/compiler/tests/omod_two_writers.test |5 + .../r300/compiler/tests/r300_compiler_tests.h |1 + .../tests/radeon_compiler_optimize_te

[Mesa-dev] [Bug 66236] New: glext.h:4609: error: redefinition of typedef 'GLclampf'

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66236 Priority: medium Bug ID: 66236 Keywords: regression Assignee: mesa-dev@lists.freedesktop.org Summary: glext.h:4609: error: redefinition of typedef 'GLclampf' Severi

[Mesa-dev] [Bug 66236] glext.h:4609: error: redefinition of typedef 'GLclampf'

2013-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66236 Vinson Lee changed: What|Removed |Added CC||bri...@vmware.com --- Comment #1 from Vinso