Re: [Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_*

2013-02-13 Thread Christian König
Am 12.02.2013 21:49, schrieb Michel Dänzer: On Die, 2013-02-12 at 18:13 +0100, Christian König wrote: From: Christian König Mark all the operands that can also have an immediate. Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 32 +- lib/Target/R600/SIInst

Re: [Mesa-dev] [PATCH 07/12] R600/SI: move *_Helper definitions to SIInstrFormat.td

2013-02-13 Thread Christian König
Am 13.02.2013 01:20, schrieb Tom Stellard: On Tue, Feb 12, 2013 at 06:13:19PM +0100, Christian König wrote: From: Christian König SIInstrFormats.td should contain the instruction encoding definitions and everything else should go in SIInstrInfo.td. I got this backwards, when I first created

Re: [Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_*

2013-02-13 Thread Michel Dänzer
On Mit, 2013-02-13 at 10:16 +0100, Christian König wrote: > Am 12.02.2013 21:49, schrieb Michel Dänzer: > > On Die, 2013-02-12 at 18:13 +0100, Christian König wrote: > >> From: Christian König > >> > >> Mark all the operands that can also have an immediate. > >> > >> Signed-off-by: Christian Köni

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling

2013-02-13 Thread Christian König
Am 13.02.2013 01:39, schrieb Tom Stellard: [SNIP] Way back when I first started working on the backend I was using immediate operands in instructions defined to only uses registers, and it worked most of the time, but I ran into a few cases where some of the passes weren't able to handle it. So

Re: [Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-13 Thread Chris Forbes
Ouch. Thanks for catching that -- are there any other similar things I need to be aware of? On Wed, Feb 13, 2013 at 8:19 PM, Kenneth Graunke wrote: > On 02/08/2013 01:19 AM, Chris Forbes wrote: >> >> V2: - emit `sample` parameter properly for multisample texelFetch() >> - fix spurious whites

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling

2013-02-13 Thread Christian König
Am 13.02.2013 08:00, schrieb Michel Dänzer: On Die, 2013-02-12 at 19:39 -0500, Tom Stellard wrote: On Tue, Feb 12, 2013 at 06:13:22PM +0100, Christian König wrote: From: Christian König Seems to be allot simpler, and also paves the way for further improvements. [...] diff --git a/lib/Targe

[Mesa-dev] [PATCH v2] gles2: a stub implementation for GL_EXT_discard_framebuffer

2013-02-13 Thread Tapani Pälli
This patch implements a stub for GL_EXT_discard_framebuffer with required checks listed by the extension specification. This extension is required by GLBenchmark 2.5 when compiled with OpenGL ES 2.0 as the rendering backend. Signed-off-by: Tapani Pälli --- src/mapi/glapi/gen/es_EXT.xml

Re: [Mesa-dev] [PATCH] R600: Do not fold single instruction with more that 3 kcache read

2013-02-13 Thread Tom Stellard
On Tue, Feb 12, 2013 at 10:45:27PM +0100, Vincent Lejeune wrote: > It fixes around 100 tfb piglit tests and 16 glean tests. > > NOTE: This is a candidate for the Mesa stable branch. Reviewed-by: Tom Stellard > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 2 ++ > lib/Target/R600/R600LowerCon

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix texture buffer objects

2013-02-13 Thread Brian Paul
On 02/12/2013 06:11 PM, Marek Olšák wrote: Broken by 624528834f53f54c7a934f929769b7e6b230a0b1. --- src/mesa/state_tracker/st_atom_texture.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/s

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try to find exact format matching user format and type for DrawPixels

2013-02-13 Thread Brian Paul
On 02/12/2013 06:11 PM, Marek Olšák wrote: --- src/mesa/state_tracker/st_cb_drawpixels.c | 28 +++ src/mesa/state_tracker/st_cb_texture.c| 30 ++--- src/mesa/state_tracker/st_format.c| 35 + src/mesa/state_

Re: [Mesa-dev] [PATCH] gles2: a stub implementation for GL_EXT_discard_framebuffer

2013-02-13 Thread Ian Romanick
On 02/12/2013 11:04 PM, Tapani Pälli wrote: On 02/12/2013 08:45 PM, Eric Anholt wrote: Tapani Pälli writes: On 02/12/2013 12:38 AM, Eric Anholt wrote: Tapani Pälli writes: --- src/mapi/glapi/gen/es_EXT.xml | 13 + src/mesa/drivers/dri/intel/intel_extensions.c |

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix texture buffer objects

2013-02-13 Thread Marek Olšák
On Wed, Feb 13, 2013 at 4:03 PM, Brian Paul wrote: > On 02/12/2013 06:11 PM, Marek Olšák wrote: >> >> Broken by 624528834f53f54c7a934f929769b7e6b230a0b1. >> --- >> src/mesa/state_tracker/st_atom_texture.c | 14 ++ >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --gi

[Mesa-dev] [PATCH] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a special register class for the parameter slot

[Mesa-dev] [PATCH] radeonsi: Fix up and enable flat shading.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer Requires corresponding LLVM R600 backend fix to work correctly, but even without that it doesn't hang anymore. 13 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 11 +-

[Mesa-dev] [Bug 59187] [Steam] Black screen but audio song On TF2 (Intel HM 55/ Ironlake Mobile)

2013-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59187 --- Comment #2 from Ian Romanick --- *** Bug 60481 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list m

[Mesa-dev] [PATCH] radeonsi: Fix w component of TGSI_SEMANTIC_POSITION fragment shader inputs.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer It's the reciprocal of the register value. Fixes piglit fragcoord_w and glsl-fs-fragcoord-zw-perspective. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 8 1 file changed, 8 insertio

Re: [Mesa-dev] [PATCH] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 04:34:23PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > The important fix is that the constant interpolation value is stored in the > parameter slot P0, which is encoded as 2. > > In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 > instead of

[Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a special register class for the parameter slot

Re: [Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 05:07:43PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > The important fix is that the constant interpolation value is stored in the > parameter slot P0, which is encoded as 2. > > In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 > instead of

Re: [Mesa-dev] [PATCH 07/12] R600/SI: move *_Helper definitions to SIInstrFormat.td

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 10:18:23AM +0100, Christian König wrote: > Am 13.02.2013 01:20, schrieb Tom Stellard: > > On Tue, Feb 12, 2013 at 06:13:19PM +0100, Christian König wrote: > >> From: Christian König > >> > > SIInstrFormats.td should contain the instruction encoding definitions > > and every

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 10:34:12AM +0100, Christian König wrote: > Am 13.02.2013 01:39, schrieb Tom Stellard: > > [SNIP] > > > > Way back when I first started working on the backend I was using > > immediate operands in instructions defined to only uses registers, and > > it worked most of the time

Re: [Mesa-dev] [PATCH 12/12] R600/SI: Add pattern to simplify i64 loading

2013-02-13 Thread Tom Stellard
On Tue, Feb 12, 2013 at 06:13:24PM +0100, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > lib/Target/R600/SIInstrInfo.td|4 > lib/Target/R600/SIInstructions.td |5 + > 2 files changed, 9 insertions(+) > > diff --git a/lib/Target/R6

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Tom Stellard
There's just the one cleanup on patch 10 that you mentioned, but otherwise the series looks good to me. Should we mark all these patches as candidates for the stable branch? For the series: Reviewed-by: Tom Stellard On Tue, Feb 12, 2013 at 06:13:13PM +0100, Christian König wrote: > From: Chris

Re: [Mesa-dev] [PATCH 12/12] R600/SI: Add pattern to simplify i64 loading

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 11:24:24AM -0500, Tom Stellard wrote: > On Tue, Feb 12, 2013 at 06:13:24PM +0100, Christian König wrote: > > From: Christian König > > > > Signed-off-by: Christian König > > --- > > lib/Target/R600/SIInstrInfo.td|4 > > lib/Target/R600/SIInstructions.td |

[Mesa-dev] [PATCH 1/5] R600: Fix tracking of implicit defs in the IndirectAddressing pass

2013-02-13 Thread Tom Stellard
From: Tom Stellard In some cases, we were losing track of live implicit registers which was creating dead defs and causing the scheduler to produce invalid code. NOTE: This is a candidate for the Mesa stable branch. --- lib/Target/R600/AMDGPUIndirectAddressing.cpp | 35 ---

[Mesa-dev] [PATCH 2/5] R600: Fix scheduler crash caused by invalid MachinePointerInfo

2013-02-13 Thread Tom Stellard
From: Tom Stellard Kernel function arguments are lowered to loads from the PARAM_I address space. When creating these load instructions, we were initializing their MachinePointerInfo with an Arguement object that was not attached to any function. This was causing the MachineScheduler to crash w

[Mesa-dev] [PATCH 3/5] R600: Mark all members of the TRegMem register class as reserved

2013-02-13 Thread Tom Stellard
From: Tom Stellard This stops the Machine Verifier from complaining about uses of undefined physical registers. NOTE: This is a candidate for the Mesa stable branch. --- lib/Target/R600/R600RegisterInfo.cpp |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/Target

[Mesa-dev] [PATCH 4/5] R600: Add AR_X to the R600_TReg_X register class.

2013-02-13 Thread Tom Stellard
From: Tom Stellard NOTE: This is a candidate for the Mesa stable branch. --- lib/Target/R600/R600RegisterInfo.td |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Target/R600/R600RegisterInfo.td b/lib/Target/R600/R600RegisterInfo.td index 3812eb7..a7d847a 100644 ---

[Mesa-dev] [PATCH 5/5] R600: initial scheduler code

2013-02-13 Thread Tom Stellard
From: Vadim Girlin This is a skeleton for a pre-RA MachineInstr scheduler strategy. Currently it only tries to expose more parallelism for ALU instructions (this also makes the distribution of GPR channels more uniform and increases the chances of ALU instructions to be packed together in a singl

Re: [Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Christian König
Am 13.02.2013 17:07, schrieb Michel Dänzer: From: Michel Dänzer The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a

[Mesa-dev] [PATCH] r600g: Report Instructions Group count with R600_DUMP_SHADERS=1

2013-02-13 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_asm.c | 7 ++- src/gallium/drivers/r600/r600_asm.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index 3632aa5..eacdb0c 100644 --- a/src/gallium/drivers/r600/r600

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Michel Dänzer
On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: > There's just the one cleanup on patch 10 that you mentioned, but > otherwise the series looks good to me. Should we mark all these patches > as candidates for the stable branch? I think so, at least the parts which prevent things such as V

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Christian König
Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: There's just the one cleanup on patch 10 that you mentioned, but otherwise the series looks good to me. Should we mark all these patches as candidates for the stable branch? I think so, at least

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Michel Dänzer
On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: > Am 13.02.2013 18:11, schrieb Michel Dänzer: > > On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: > >> There's just the one cleanup on patch 10 that you mentioned, but > >> otherwise the series looks good to me. Should we mark all t

Re: [Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-13 Thread Kenneth Graunke
On 02/13/2013 01:39 AM, Chris Forbes wrote: Ouch. Thanks for catching that -- are there any other similar things I need to be aware of? Not that I can think of, no. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

[Mesa-dev] [PATCH 3/3] R600/SI: Add pattern for fceil.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer 9 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer --- lib/Target/R600/SIInstructions.td | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Tar

[Mesa-dev] [PATCH 1/3] R600/SI: Add pattern for sign extension of i1 to i32.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer 16 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer --- lib/Target/R600/SIInstructions.td | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIIn

[Mesa-dev] [PATCH 2/3] R600/SI: Add pattern for logical or of i1 values.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer 24 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer --- lib/Target/R600/SIInstructions.td | 4 1 file changed, 4 insertions(+) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIIns

Re: [Mesa-dev] [PATCH] radeonsi: Fix up and enable flat shading.

2013-02-13 Thread Tom Stellard
On Wed, Feb 13, 2013 at 04:34:24PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Requires corresponding LLVM R600 backend fix to work correctly, but even > without that it doesn't hang anymore. > > 13 more little piglits. > > NOTE: This is a candidate for the 9.1 branch. Since this cha

[Mesa-dev] [PATCH 1/2] r600g: Add $(DEFINES) to AM_CXXFLAGS

2013-02-13 Thread Tom Stellard
From: Tom Stellard This way llvm_wrapper.cpp is compiled with -DHAVE_LLVM=0x --- src/gallium/drivers/r600/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/Makefile.am b/src/gallium/drivers/r600/Makefile.am index 6f48b56..e1c8574 1006

[Mesa-dev] [PATCH 2/2] radeon/llvm: Fix build with LLVM 3.3

2013-02-13 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r600/llvm_wrapper.cpp | 4 src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 9 - 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/llvm_wrapper.cpp b/src/gallium/drivers/r600/llvm_wrapper.cpp in

Re: [Mesa-dev] [PATCH v2] shaderapi: Fix AttachShader error

2013-02-13 Thread Chad Versace
Thanks, committed. On 02/11/2013 10:42 PM, Tapani Pälli wrote: > From: bma > > Detect a duplicate Shader type as and error instead of silently allowing > it, restrict to ES2 API. > > v2: Tapani Pälli > - make the check run time instead of compile time > > Signed-off-by: bma > Signed-off-

Re: [Mesa-dev] [PATCH v2] gles2: a stub implementation for GL_EXT_discard_framebuffer

2013-02-13 Thread Chad Versace
On 02/13/2013 04:38 AM, Tapani Pälli wrote: > This patch implements a stub for GL_EXT_discard_framebuffer with > required checks listed by the extension specification. This extension > is required by GLBenchmark 2.5 when compiled with OpenGL ES 2.0 > as the rendering backend. > > Signed-off-by: Ta

Re: [Mesa-dev] [PATCH v2] gles2: a stub implementation for GL_EXT_discard_framebuffer

2013-02-13 Thread Chad Versace
On 02/13/2013 02:25 PM, Chad Versace wrote: > On 02/13/2013 04:38 AM, Tapani Pälli wrote: >> This patch implements a stub for GL_EXT_discard_framebuffer with >> required checks listed by the extension specification. This extension >> is required by GLBenchmark 2.5 when compiled with OpenGL ES 2.0 >

Re: [Mesa-dev] [PATCH] r600g: properly implement S8Z24 depth-stencil format for Evergreen

2013-02-13 Thread Jerome Glisse
On Tue, Feb 12, 2013 at 8:06 PM, Marek Olšák wrote: > I should say "fix", but it has never been used until now. > S8Z24 is the format equivalent to the GL_UNSIGNED_INT_24_8 packing, > so we'll start to see it more often with st/mesa now making smart decisions > about formats. > > The DB<->CB copy

[Mesa-dev] r600g: status of my work on the shader optimization

2013-02-13 Thread Vadim Girlin
Hi, Last month I finally found the time to work on the rewrite of my previous shader optimization branch, now it's mostly done in terms of the correctness of produced code and feature support (at least on evergreen), though it's still a work in progress in terms of the efficiency of generated

Re: [Mesa-dev] [PATCH 2/3] i965: Don't record a WAW dependency between implicit MRF operations.

2013-02-13 Thread Eric Anholt
Kenneth Graunke writes: > Meta-instructions that implicitly write then read/consume a MRF value > don't pose write-after-write conflicts with each other, since they're > actually: > > - Write value 1, then consume it. > - Write value 2, then consume it. OK, here's the case I'm thinking of: 1: M

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Do a general SEND dependency workaround for the original 965.

2013-02-13 Thread Kenneth Graunke
On 02/06/2013 05:29 PM, Eric Anholt wrote: We'd been ad-hoc inserting instructions in some SEND messages with no knowledge of when it was required (so extra instructions), but not all SENDs (so not often enough). This should do much better than that, though it's still flow-control-ignorant. Bug

Re: [Mesa-dev] [PATCH 2/3] i965: Don't record a WAW dependency between implicit MRF operations.

2013-02-13 Thread Kenneth Graunke
On 02/13/2013 06:31 PM, Eric Anholt wrote: Kenneth Graunke writes: Meta-instructions that implicitly write then read/consume a MRF value don't pose write-after-write conflicts with each other, since they're actually: - Write value 1, then consume it. - Write value 2, then consume it. OK, he

Re: [Mesa-dev] [PATCH 2/3] i965: Don't record a WAW dependency between implicit MRF operations.

2013-02-13 Thread Eric Anholt
Kenneth Graunke writes: > On 02/13/2013 06:31 PM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> Meta-instructions that implicitly write then read/consume a MRF value >>> don't pose write-after-write conflicts with each other, since they're >>> actually: >>> >>> - Write value 1, then consu

Re: [Mesa-dev] [PATCH] gles2: a stub implementation for GL_EXT_discard_framebuffer

2013-02-13 Thread Tapani Pälli
On 02/13/2013 05:23 PM, Ian Romanick wrote: > On 02/12/2013 11:04 PM, Tapani Pälli wrote: >> On 02/12/2013 08:45 PM, Eric Anholt wrote: >>> Tapani Pälli writes: >>> On 02/12/2013 12:38 AM, Eric Anholt wrote: > Tapani Pälli writes: >> --- >>src/mapi/glapi/gen/es_EXT.xml