[Mesa-dev] [Bug 49777] New: git head produces many libraries that are not properly linked

https://bugs.freedesktop.org/show_bug.cgi?id=49777 Bug #: 49777 Summary: git head produces many libraries that are not properly linked Classification: Unclassified Product: Mesa Version: git Platform: Other OS/

[Mesa-dev] [Bug 49504] [Bisected] Mesa master compilation broke when built with --with-llvm-shared-libs

https://bugs.freedesktop.org/show_bug.cgi?id=49504 Fabio Pedretti changed: What|Removed |Added CC||fabio@libero.it -- Configure bugma

[Mesa-dev] [Bug 49717] SCons build error with clang

https://bugs.freedesktop.org/show_bug.cgi?id=49717 --- Comment #3 from Michel Dänzer 2012-05-11 00:51:23 PDT --- (In reply to comment #2) > Perhaps linking should be done with clang++ instead of with clang? I suspect so. Is $CXX set to clang++? -- Configure bugmail: https://bugs.freedesktop.o

[Mesa-dev] [Bug 49788] New: vega statetracker unpack methof for RGB 565 is wrong

https://bugs.freedesktop.org/show_bug.cgi?id=49788 Bug #: 49788 Summary: vega statetracker unpack methof for RGB 565 is wrong Classification: Unclassified Product: Mesa Version: git Platform: All OS/Version: All Status

[Mesa-dev] [Bug 49788] vega statetracker unpack method for RGB 565 is wrong

https://bugs.freedesktop.org/show_bug.cgi?id=49788 Andreas Betz changed: What|Removed |Added Summary|vega statetracker unpack|vega statetracker unpack

Re: [Mesa-dev] [PATCH v3 01/13] gallium: Basic compute interface.

Francisco Jerez writes: > Tom Stellard writes: > >> Hi, >> >> I've been testing these updated compute patches all week and they look >> good to me. I don't think there are any outstanding complaints, so I'll >> give my ACK for merging these into master. >> >> Very nice work! >> >> -Tom Stellard

[Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

From: José Fonseca For consistency. --- src/gallium/auxiliary/tgsi/tgsi_build.c|4 ++-- .../drivers/nv50/codegen/nv50_ir_from_tgsi.cpp |3 +-- src/gallium/include/pipe/p_shader_tokens.h |2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 1/2] gallium/tgsi: Redefine the TGSI_TEXTURE_UNKNOWN texture target.

From: José Fonseca Some code relies on the existing of an invalid texture target. It seems safer to bring it back than to deal with unintended consequences. This partially reverts commit a4ebb04214bab1cd9bd41967232ec89441e31744. --- src/gallium/auxiliary/tgsi/tgsi_build.c|2 +-

[Mesa-dev] [Bug 49788] vega statetracker unpack method for RGB 565 is wrong

https://bugs.freedesktop.org/show_bug.cgi?id=49788 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

On 05/11/2012 06:42 AM, jfons...@vmware.com wrote: From: José Fonseca For consistency. For both patches: Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] gallium-userbuf branch (was: Re: [PATCH 3/9] st/mesa: make user index buffers optional)

I didn't have time to test, but it looks good to me AFAICT. If there are any issues we can deal with them. Jose - Original Message - > Hi, > > I'd like to merge this branch soon. Does friday May 11 sound good or > should I wait more? > > Marek > > On Mon, Apr 30, 2012 at 1:38 AM, Mare

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

jfons...@vmware.com writes: > From: José Fonseca > > For consistency. I'm OK with this change, but, just so that you know, the only reason I called it TGSI_BUFFER instead of TGSI_TEXTURE_BUFFER was to keep it consistent with the pipe_texture_target enumeration. > --- > src/gallium/auxiliary/tg

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

On 11.05.2012 16:03, Francisco Jerez wrote: > jfons...@vmware.com writes: > >> From: José Fonseca >> >> For consistency. > I'm OK with this change, but, just so that you know, the only reason I > called it TGSI_BUFFER instead of TGSI_TEXTURE_BUFFER was to keep it > consistent with the pipe_texture

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

On Fri, May 11, 2012 at 10:03 AM, Francisco Jerez wrote: > jfons...@vmware.com writes: > >> From: José Fonseca >> >> For consistency. > > I'm OK with this change, but, just so that you know, the only reason I > called it TGSI_BUFFER instead of TGSI_TEXTURE_BUFFER was to keep it > consistent with

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

- Original Message - > On Fri, May 11, 2012 at 10:03 AM, Francisco Jerez > wrote: > > jfons...@vmware.com writes: > > > >> From: José Fonseca > >> > >> For consistency. > > > > I'm OK with this change, but, just so that you know, the only > > reason I > > called it TGSI_BUFFER instead o

Re: [Mesa-dev] [PATCH 2/2] gallium/tgsi: s/TGSI_BUFFER/TGSI_TEXTURE_BUFFER/

On Fri, May 11, 2012 at 11:00 AM, Jose Fonseca wrote: > > > - Original Message - >> On Fri, May 11, 2012 at 10:03 AM, Francisco Jerez >> wrote: >> > jfons...@vmware.com writes: >> > >> >> From: José Fonseca >> >> >> >> For consistency. >> > >> > I'm OK with this change, but, just so that

[Mesa-dev] [PATCH 0/8] move software primitive restart into VBO module

v1: * move software primitive restart from mesa/state_tracker/st_draw.c into src/mesa/vbo/vbo_primitive_restart.c * if the gallium PIPE_CAP_PRIMITIVE_RESTART param is set, then the VBO software primitive restart support is disabled * enable the NV_primitive_restart extension by default *

[Mesa-dev] [PATCH 1/8] vbo: add software primitive restart support

vbo_sw_primitive_restart implements primitive restart in software by splitting primitive draws apart. This is based on similar support in mesa/state_tracker/st_draw.c. Signed-off-by: Jordan Justen --- src/mesa/SConscript |1 + src/mesa/sources.mak |1 +

[Mesa-dev] [PATCH 2/8] mesa: add PrimitiveRestartInSoftware to gl_context.Const

If set, then the VBO module will handle all primitive restart scenarios before calling the any driver vbo_draw_func. It defaults to forcing software primitive restart support. Signed-off-by: Jordan Justen --- src/mesa/main/context.c |3 +++ src/mesa/main/mtypes.h |5 + 2 files chan

[Mesa-dev] [PATCH 3/8] state_tracker: clear PrimitiveRestartInSoftware if needed

If the PIPE_CAP_PRIMITIVE_RESTART screen param is enabled, then clear PrimitiveRestartInSoftware to disable software primitive restart support in the VBO module. Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_extensions.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/m

[Mesa-dev] [PATCH 4/8] vbo: use software primitive restart in the VBO module

When PrimitiveRestartInSoftware is set, the VBO module will handle primitive restart scenarios before calling the vbo_draw_func drawing function. Signed-off-by: Jordan Justen --- src/mesa/vbo/vbo_exec_array.c | 50 ++--- 1 file changed, 37 insertions(+), 13

[Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

Signed-off-by: Jordan Justen --- src/mesa/main/extensions.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a843a40..5389dfc 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -370,6 +370,8 @@ static c

[Mesa-dev] [PATCH 6/8] state_tracker: NV_primitive_restart is now enabled by default

Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_extensions.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e72deb8..559336e 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/

[Mesa-dev] [PATCH 7/8] state_tracker: remove software handling of primitive restart

The VBO module now can handle primitive restart in software if required. Therefore this support is no londer required. Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_draw.c | 180 +- 1 file changed, 2 insertions(+), 178 deletions(-) diff --git a/

[Mesa-dev] [PATCH 8/8] state_tracker: remove sw_primitive_restart from st_context

The VBO module now can handle primitive restart in software if required. Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_context.h|1 - src/mesa/state_tracker/st_extensions.c |4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_c

Re: [Mesa-dev] [PATCH 0/8] move software primitive restart into VBO module

On Fri, May 11, 2012 at 08:15:50AM -0700, Jordan Justen wrote: > * enable the NV_primitive_restart extension by default I think the intel gen4/5 (and maybe more) can do primitive restart in hardware but only if if the restart pattern is ~0 (which it often is). Does your patch make it possible to

Re: [Mesa-dev] [PATCH 0/8] move software primitive restart into VBO module

On Fri, May 11, 2012 at 8:35 AM, Olivier Galibert wrote: > On Fri, May 11, 2012 at 08:15:50AM -0700, Jordan Justen wrote: >>  * enable the NV_primitive_restart extension by default > > I think the intel gen4/5 (and maybe more) can do primitive restart in > hardware but only if if the restart patte

Re: [Mesa-dev] [PATCH] mesa: Use the proper feature test macros for strtod_l and strtof[_l].

>Android does not have strtod_l. Yet, the old co de successfully compiled >because Android does not define _GNU_SOURCE. Just to make sure we're all on the same page: NOBODY defines _GNU_SOURCE. At least they shouldn't. Used correctly, _GNU_SOURCE is something that gets defined by a #define in the

Re: [Mesa-dev] [PATCH 4/8] vbo: use software primitive restart in the VBO module

On Fri, May 11, 2012 at 5:15 PM, Jordan Justen wrote: > When PrimitiveRestartInSoftware is set, the VBO module will handle > primitive restart scenarios before calling the vbo_draw_func > drawing function. > > Signed-off-by: Jordan Justen > --- >  src/mesa/vbo/vbo_exec_array.c |   50 > +

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

I think a more preferable way to enable an extension for everybody by default is to do something like this: > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index a843a40..71b7721 100644 > --- a/src/mesa/main/extensions.c > +++ b/src/mesa/main/extensions.c > @@ -298,7 +298,

Re: [Mesa-dev] [PATCH 4/8] vbo: use software primitive restart in the VBO module

On Fri, May 11, 2012 at 9:48 AM, Marek Olšák wrote: > On Fri, May 11, 2012 at 5:15 PM, Jordan Justen > wrote: >> When PrimitiveRestartInSoftware is set, the VBO module will handle >> primitive restart scenarios before calling the vbo_draw_func >> drawing function. >> >> Signed-off-by: Jordan Just

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On 05/11/2012 11:08 AM, Marek Olšák wrote: I think a more preferable way to enable an extension for everybody by default is to do something like this: diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a843a40..71b7721 100644 --- a/src/mesa/main/extensions.c +++ b/src/me

[Mesa-dev] r600g compute support

Hi, Attached are patches to enable compute on r600g. These patches can also be found in the gallium-compute-r600 branch here: cgit.freedesktop.org/~tstellar/mesa You will need to install patched versions of llvm, clang, and libclc to be able to use this code. Full build instructions can be foun

[Mesa-dev] [PATCH 01/11] configure.ac: Add HAVE_OPENCL AM_CONDITIONAL

--- configs/autoconf.in |1 + configure.ac|3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configs/autoconf.in b/configs/autoconf.in index 3c8f4c1..28f3cb4 100644 --- a/configs/autoconf.in +++ b/configs/autoconf.in @@ -222,3 +222,4 @@ HAVE_XF86VIDMODE = @HAVE_

[Mesa-dev] [PATCH 02/11] gallium: Add PIPE_SHADER_IR_LLVM_R600 to enum pipe_shader_ir

--- src/gallium/include/pipe/p_defines.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 1e05cc4..030a547 100644 --- a/src/gallium/include/pipe/p_defines.h +++ b/src/gallium/include/pipe/p

[Mesa-dev] [PATCH 03/11] r600g: Handle PIPE_SHADER_CAP_PREFERRED_IR

--- src/gallium/drivers/r600/r600_pipe.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 11f0fde..595b384 100644 --- a/src/gallium/drivers/r600/r600_pipe.c +++ b/src/gallium/drivers/r6

[Mesa-dev] [PATCH 04/11] clover: Handle PIPE_SHADER_IR_LLVM_R600

--- src/gallium/state_trackers/clover/core/device.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index 8390f3f..e900da7 100644 --- a/src/gallium/state_trackers/clov

[Mesa-dev] [PATCH 05/11] configure.ac: Add option for libclc path

--- configs/autoconf.in |3 +++ configure.ac|8 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/configs/autoconf.in b/configs/autoconf.in index 28f3cb4..bb77187 100644 --- a/configs/autoconf.in +++ b/configs/autoconf.in @@ -187,6 +187,9 @@ VA_LIB_INSTALL_DI

[Mesa-dev] [PATCH 06/11] configure.ac: Add variables LLVM_CPPFLAGS and LLVM_LIBDIR

--- configs/autoconf.in |2 ++ configure.ac|4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configs/autoconf.in b/configs/autoconf.in index bb77187..90d2d1b 100644 --- a/configs/autoconf.in +++ b/configs/autoconf.in @@ -34,8 +34,10 @@ X11_LIBS = @X11_LIBS@ X

[Mesa-dev] [PATCH 08/11] clover: Add necessary flags to libclllvm_la_CXXFLAGS

$(LLVM_CFLAGS) for LLVM defines -DLIBCLC_PATH for libclc path -DCLANG_RESOURCE_DIR for clang includes $(DEFINES) for -DHAVE_LLVM --- src/gallium/state_trackers/clover/Makefile.am |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/clover/Makefil

[Mesa-dev] [PATCH 07/11] clover: Link to the necessary LLVM and Clang libs

--- configure.ac |3 +++ src/gallium/targets/opencl/Makefile.am | 18 +- 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 2203851..29a1be7 100644 --- a/configure.ac +++ b/configure.ac @@ -1848,6 +1848,

[Mesa-dev] [PATCH 09/11] clover: Add constructors to some of the module classes

This is for the llvm code that can't use extended initializers. --- src/gallium/state_trackers/clover/core/module.hpp | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/module.hpp b/src/gallium/state_trackers/clover/core/mo

[Mesa-dev] [PATCH 10/11] clover: Add function for building a clover::module for non-TGSI targets

--- .../state_trackers/clover/llvm/invocation.cpp | 174 +++- 1 files changed, 165 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 89e21bf..b31fddc 100644 --- a/sr

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On Fri, May 11, 2012 at 7:17 PM, Brian Paul wrote: > On 05/11/2012 11:08 AM, Marek Olšák wrote: >> >> I think a more preferable way to enable an extension for everybody by >> default is to do something like this: >> >>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c >>> index

Re: [Mesa-dev] [PATCH 3/8] state_tracker: clear PrimitiveRestartInSoftware if needed

On 05/11/2012 08:15 AM, Jordan Justen wrote: If the PIPE_CAP_PRIMITIVE_RESTART screen param is enabled, then clear PrimitiveRestartInSoftware to disable software primitive restart support in the VBO module. Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_extensions.c |2 ++ 1 f

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On 05/11/2012 10:35 AM, Marek Olšák wrote: On Fri, May 11, 2012 at 7:17 PM, Brian Paul wrote: On 05/11/2012 11:08 AM, Marek Olšák wrote: I think a more preferable way to enable an extension for everybody by default is to do something like this: diff --git a/src/mesa/main/extensions.c b/src/

Re: [Mesa-dev] [PATCH 3/8] state_tracker: clear PrimitiveRestartInSoftware if needed

On 05/11/2012 10:43 AM, Ian Romanick wrote: On 05/11/2012 08:15 AM, Jordan Justen wrote: If the PIPE_CAP_PRIMITIVE_RESTART screen param is enabled, then clear PrimitiveRestartInSoftware to disable software primitive restart support in the VBO module. Signed-off-by: Jordan Justen --- src/mesa/st

[Mesa-dev] [PATCH 00/15] i965/gen7: Begin implementing MSAA.

This patch series provides preliminary support for MSAA (multisample antialiasing) in i965/gen7. It depends on my previous MSAA patch series "[PATCH v2 0/5] i965/gen6: Begin implementing MSAA." The patches can be grouped into 3 sets: Patch 01 fixes a small bug in the Gen6 MSAA implementation: whe

[Mesa-dev] [PATCH 01/15] i965/msaa: Expand odd-sized MSAA surfaces to account for interleaving pattern.

Gen6 MSAA buffers (and Gen7 MSAA depth/stencil buffers) interleave MSAA samples in a complex pattern that repeats every 2x2 pixel block. Therefore, when allocating an MSAA buffer, we need to make sure to allocate an integer number of 2x2 blocks; if we don't, then some of the samples in the last row

[Mesa-dev] [PATCH 02/15] i965/blorp: Generalize sampling code in preparation for Gen7

This patch generalizes the function brw_blorp_blit_program::texture_lookup() so that it prepares the arguments to the sampler message based on a caller-provided array rather than assuming the argument order is always (u, v). This paves the way for the messages we will need to use in Gen7, which us

[Mesa-dev] [PATCH 03/15] i965/blorp: Emit sample index in SAMPLE_LD message when necessary

This patch modifies the function brw_blorp_blit_program::texel_fetch() to emit the SI (sample index) argument to the SAMPLE_LD message when reading from a sample index other than zero. Previously we were using the ugly hack of configuring multisampled source surfaces as single-sampled, and accessi

[Mesa-dev] [PATCH 04/15] i965/blorp: Use MSDISPMODE_PERSAMPLE rendering when necessary

This patch modifies the "blorp" WM program so that it can be run in MSDISPMODE_PERSAMPLE (which means that every single sample of a multisampled render target is dispatched to the WM program, not just every pixel). Previously we were using the ugly hack of configuring multisampled destination surf

[Mesa-dev] [PATCH 05/15] i965/blorp: Factor gen6_blorp_emit_batch_head into separate functions.

This patch separates out the portions of gen6_blorp_emit_batch_head() that emit 3DSTATE_MULTISAMPLE, 3DSTATE_SAMPLE_MASK, and STATE_BASE_ADDRESS. This paves the way for making the blorp code work on Gen7, where additional command packets (3DSTATE_PUSH_CONSTANT_ALLOC_VS and 3DSTATE_PUSH_CONSTANT_AL

[Mesa-dev] [PATCH 06/15] i965/blorp: Allocate space for push constants on Gen7.

On Gen7, push constants for shader programs are stored in the URB, so blorp code needs to set aside space for them. This was previously unnecessary because blorp code was based on HiZ operations, which don't require any shaders. This patch adds a call from gen7_blorp_exec() to gen7_allocate_push_

[Mesa-dev] [PATCH 07/15] i965/blorp: Use 16 pixel dispatch on Gen7 when there is a WM program.

When executing a blorp operation on Gen7 that does not need a WM program (i.e. a HiZ operation), we use 32-pixel dispatch mode because it's faster. However, when executing a blorp operation that does need a WM program, we need to use 16-pixel dispatch, because blorp WM programs are compiled assumi

[Mesa-dev] [PATCH 08/15] i965/blorp: Implement proper texel fetch messages for Gen7.

On Gen6, texel fetch is always accomplished using the SAMPLE_LD message, which accepts arguments (u, v, r, lod, si). On Gen7, there are two* texel fetch messages: SAMPLE_LD for non-MSAA surfaces, taking arguments (u, lod, v), and SAMPLE_LD2DSS for MSAA surfaces, taking arguments (si, u, v). *Tech

[Mesa-dev] [PATCH 09/15] i965/blorp: Enable blorp blits on Gen7.

Gen7 support for blorp (blits using the render bath) now works for non-MSAA purposes. This patch enables it. Since blorp operations re-use the logic for HiZ ops, this required adding a case to the switch statement in gen7_blorp_emit_wm_config(), to allow for the case where no HiZ op is being perf

[Mesa-dev] [PATCH 10/15] i965/msaa: Add defines for Gen7.

--- src/mesa/drivers/dri/i965/brw_defines.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index a087f70..4ad905b 100644 --- a/src/mesa/drivers/dri/i965/brw_defines.h +++ b/src/mesa/dri

[Mesa-dev] [PATCH 11/15] i965/msaa: Properly handle sliced layout for Gen7.

Starting in Gen7, there are two possible layouts for MSAA surfaces: - Interleaved, in which additional samples are accommodated by scaling up the width and height of the surface. This is the only layout available in Gen6. On Gen7 it is used for depth and stencil surfaces only. - Sliced, i

[Mesa-dev] [PATCH 12/15] i965/msaa: Validate Gen7 surface state constraints.

When a Gen7 SURFACE_STATE is configured for MSAA, a number of additional constaints come in to play. This patch adds a function gen7_check_surface_setup() which verifies that all of those constraints are met. --- src/mesa/drivers/dri/i965/brw_state.h |2 + src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 13/15] i965/msaa: Modify blorp code to account for Gen7 MSAA layouts.

Since blorp uses color textures and render targets to do all its work (even when blitting stencil and depth data), it always has to configure the Gen7 GPU to use the new "sliced" MSAA layout. However, when blitting stencil or depth data, the actual MSAA layout is interleaved (as in Gen6). Therefo

[Mesa-dev] [PATCH 14/15] i965/msaa: Implement manual blending operation for Gen7.

On Gen6, the blending necessary to blit an MSAA surface to a non-MSAA surface could be accomplished with a single texturing operation. On Gen7, the WM program must fetch each sample and blend them together manually. This patch implements the manual blend operation. --- src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 15/15] i965/msaa: Enable 4x MSAA on Gen7.

Basic 4x MSAA support now works on Gen7. This patch enables it. As with Gen6, MSAA support is still fairly preliminary. In particular, the following are not yet supported: - 8x oversampling (Gen7 has hardware support for this, but we do not yet expose it). - Fully general blits between MSAA an

Re: [Mesa-dev] [PATCH] mesa: Use the proper feature test macros for strtod_l and strtof[_l].

On May 11, 2012, at 08:58, Bryan Henderson wrote: >> Android does not have strtod_l. Yet, the old co de successfully compiled >> because Android does not define _GNU_SOURCE. > > Just to make sure we're all on the same page: NOBODY defines _GNU_SOURCE. > At least they shouldn't. Tell that to th

[Mesa-dev] [PATCH] clover, gallium: add PIPE_COMPUTE_CAP_MAX_THREADS_PER_BLOCK

This is not necessarily the product of MAX_BLOCK_SIZE[i]. --- src/gallium/docs/source/screen.rst|5 + src/gallium/include/pipe/p_defines.h |1 + src/gallium/state_trackers/clover/api/device.cpp |3 ++- src/gallium/state_trackers/clover/core/device.cpp

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On Fri, May 11, 2012 at 10:49 AM, Ian Romanick wrote: > On 05/11/2012 10:35 AM, Marek Olšák wrote: >> On Fri, May 11, 2012 at 7:17 PM, Brian Paul  wrote: >>> So setting MESA_EXTENSION_OVERRIDE=-GL_NV_primitive_restart should be an >>> option.  The o(dummy_true) convention might prevent that, but I

Re: [Mesa-dev] [PATCH v2 1/5] i965: Parameterize HiZ code to prepare for adding blitting.

On 05/10/2012 11:21 AM, Paul Berry wrote: > This patch groups together the parameters used by the HiZ functions > into a new data structure, brw_hiz_resolve_params, rather than passing > each parameter individually between the HiZ functions. This data > structure is a subclass of brw_blorp_params,

Re: [Mesa-dev] [PATCH v2 3/5] i965: Expose surface setup internals for use by blits.

On 05/10/2012 11:21 AM, Paul Berry wrote: > This patch exposes the functions brw_get_surface_tiling_bits and > gen7_set_surface_tiling, so that they can be re-used when setting up > surface states in gen6_blorp.cpp and gen7_blorp.cpp. > --- > src/mesa/drivers/dri/i965/brw_state.h |

Re: [Mesa-dev] [PATCH v2 4/5] i965/gen6+: Add code to perform blits on the render path ("blorp").

On 05/10/2012 11:21 AM, Paul Berry wrote: > This patch expands the "blorp" component to be able to perform blits > as well as HiZ resolves. The new blitting code is located in > brw_blorp_blit.cpp. This includes the necessary fragment shader code > to look up pixels in the source buffer (which is

Re: [Mesa-dev] [PATCH] clover, gallium: add PIPE_COMPUTE_CAP_MAX_THREADS_PER_BLOCK

On Fri, May 11, 2012 at 08:30:07PM +0200, Christoph Bumiller wrote: > This is not necessarily the product of MAX_BLOCK_SIZE[i]. Reviewed-by: Tom Stellard > --- > src/gallium/docs/source/screen.rst|5 + > src/gallium/include/pipe/p_defines.h |1 + > src/g

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

On 05/10/2012 11:21 AM, Paul Berry wrote: > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > understand multisampled buffers, adapting the rendering pipeline setup > to enable multisampled rendering, and adding multisample resolve > operations to brw_blorp_blit.cpp. Some prepar

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

On 11 May 2012 12:40, Chad Versace wrote: > On 05/10/2012 11:21 AM, Paul Berry wrote: > > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > > understand multisampled buffers, adapting the rendering pipeline setup > > to enable multisampled rendering, and adding multisample res

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On Fri, May 11, 2012 at 8:37 PM, Jordan Justen wrote: > On Fri, May 11, 2012 at 10:49 AM, Ian Romanick wrote: >> On 05/11/2012 10:35 AM, Marek Olšák wrote: >>> On Fri, May 11, 2012 at 7:17 PM, Brian Paul  wrote: So setting MESA_EXTENSION_OVERRIDE=-GL_NV_primitive_restart should be an op

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Use a const reference in fs_reg::equals instead of a pointer.

On 05/10/2012 04:10 PM, Kenneth Graunke wrote: This lets you omit some ampersands and is more idiomatic C++. Using const also marks the function as not altering either register (which was obvious, but nice to enforce). I'm increasingly *not* a fan of this sort of weird infix notation. Infix n

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Add a local common subexpression elimination pass.

On 05/10/2012 04:10 PM, Kenneth Graunke wrote: Total instructions: 18210 -> 17836 49/163 programs affected (30.1%) 12888 -> 12514 instructions in affected programs (2.9% reduction) This reduces Lightsmark's "Scale down filter" shader from 395 instructions to 283, a whopping 28%. It also reduc

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Use a const reference in fs_reg::equals instead of a pointer.

On Fri, May 11, 2012 at 02:25:45PM -0700, Ian Romanick wrote: > On 05/10/2012 04:10 PM, Kenneth Graunke wrote: > > This lets you omit some ampersands and is more idiomatic C++. Using > > const also marks the function as not altering either register (which > > was obvious, but nice to enforce). >

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On 05/11/2012 11:35 AM, Marek Olšák wrote: On Fri, May 11, 2012 at 7:17 PM, Brian Paul wrote: On 05/11/2012 11:08 AM, Marek Olšák wrote: I think a more preferable way to enable an extension for everybody by default is to do something like this: diff --git a/src/mesa/main/extensions.c b/src/

Re: [Mesa-dev] [PATCH 1/2] i965: Implement guardband clipping on Sandybridge.

On 05/08/2012 04:07 PM, Eric Anholt wrote: On Fri, 4 May 2012 17:06:38 -0700, Kenneth Graunke wrote: - vp->xmin = -1.0; - vp->xmax = 1.0; - vp->ymin = -1.0; - vp->ymax = 1.0; + /* According to the Sandybridge PRM, Volume 2, Part 1, Section 6.3.8 +* "Vertex X,Y Clamping and Quant

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On Fri, May 11, 2012 at 2:41 PM, Brian Paul wrote: > On 05/11/2012 11:35 AM, Marek Olšák wrote: >> In that case, I think we should disable it in the state tracker if >> there's no driver support. If it's faster for svga, it's very likely >> faster for the other DX9-level drivers too. > > Some View

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

On 05/11/2012 01:37 PM, Paul Berry wrote: > On 11 May 2012 12:40, Chad Versace > wrote: > > On 05/10/2012 11:21 AM, Paul Berry wrote: > > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > > understand multisampled buffers, adapt

Re: [Mesa-dev] [PATCH 5/8] main: enable NV_primitive_restart extension by default

On 05/11/2012 04:26 PM, Jordan Justen wrote: On Fri, May 11, 2012 at 2:41 PM, Brian Paul wrote: On 05/11/2012 11:35 AM, Marek Olšák wrote: In that case, I think we should disable it in the state tracker if there's no driver support. If it's faster for svga, it's very likely faster for the othe

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

No. Please don't push code until people have reviewed it (and more than just one person). A small schedule slip is reasonable, and if people do have concerns/requests, cleaning it up afterwards may just result in more churn and effort. ___ mesa-dev