On 27 June 2015 at 09:03, Marek Olšák wrote:
> If you write VIEWPORT_INDEX at location 0, it overwrites POSITION
> which happens to be at location 0 too and that's why the test fails.
>
> The fix is not to call si_shader_io_get_unique_index (or its caller
> get_param_index) for LAYER and VIEWPORT_
If you write VIEWPORT_INDEX at location 0, it overwrites POSITION
which happens to be at location 0 too and that's why the test fails.
The fix is not to call si_shader_io_get_unique_index (or its caller
get_param_index) for LAYER and VIEWPORT_INDEX.
LAYER and VIEWPORT_INDEX should be ignored in
s
On 26 June 2015 at 07:43, Dave Airlie wrote:
> On 26 June 2015 at 07:11, Marek Olšák wrote:
>> Wait a moment, how did it fail with si_shader_io_get_unique_index? The
>> function shouldn't be called for ES with the viewport index, because
>> ES can't pass the output to GS. If it was called, ignori
On 26 June 2015 at 07:11, Marek Olšák wrote:
> Wait a moment, how did it fail with si_shader_io_get_unique_index? The
> function shouldn't be called for ES with the viewport index, because
> ES can't pass the output to GS. If it was called, ignoring the
> viewport index in si_llvm_emit_es_epilogue
Wait a moment, how did it fail with si_shader_io_get_unique_index? The
function shouldn't be called for ES with the viewport index, because
ES can't pass the output to GS. If it was called, ignoring the
viewport index in si_llvm_emit_es_epilogue should fix it.
Marek
On Thu, Jun 25, 2015 at 10:29
In that case, feel free to push.
Reviewed-by: Marek Olšák
Marek
On Thu, Jun 25, 2015 at 10:25 PM, Dave Airlie wrote:
> On 26 June 2015 at 00:26, Marek Olšák wrote:
>> Hi Dave,
>>
>> The change in si_shader_io_get_unique_index can be dropped. The
>> function is only used for shaders before GS.
On 26 June 2015 at 00:26, Marek Olšák wrote:
> Hi Dave,
>
> The change in si_shader_io_get_unique_index can be dropped. The
> function is only used for shaders before GS.
>
Ok okay I was hitting the assert in there for the layer/viewport index cases,
but if the patch you pushed to master helps I'l
Hi Dave,
The change in si_shader_io_get_unique_index can be dropped. The
function is only used for shaders before GS.
This looks good, but I've had a different plan for this feature:
I'd like the states to be converted into 2 atoms:
1 r600_atom for all 16 viewports
1 r600_atom for all 16 scisso
