Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Marek Olšák
On Wed, Nov 14, 2018, 10:36 AM Rob Clark On Wed, Nov 14, 2018 at 10:13 AM Marek Olšák wrote: > > > > > > > > On Wed, Nov 14, 2018, 7:54 AM Rob Clark >> > >> On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > >> > > >> > > >> > > >> > On Tue, Nov 13, 2018, 6:00 PM Rob Clark >> >> > >> >> On T

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Wed, Nov 14, 2018 at 10:13 AM Marek Olšák wrote: > > > > On Wed, Nov 14, 2018, 7:54 AM Rob Clark > >> On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: >> > >> > >> > >> > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > >> >> >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: >> >> > >> >> > Ro

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Marek Olšák
On Wed, Nov 14, 2018, 7:54 AM Rob Clark On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > > > > > > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark >> > >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > >> > > >> > Rob Clark writes: > >> > > >> > > If we can't clear all the buffers with p

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Wed, Nov 14, 2018 at 6:32 AM Erik Faye-Lund wrote: > > On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > > wrote: > > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > > wrote: > > > > Rob Clark writes: > > > > > > > > > On Tue, Nov 13, 201

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: >> > >> > Rob Clark writes: >> > >> > > If we can't clear all the buffers with pctx->clear() (say, for example, >> > > because of ColorMask),

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 21:53 -0500, Marek Olšák wrote: > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > wrote: > > > > > > Rob Clark writes: > > > > > > > If we can't clear all the buffers with pctx->clear() (say, for > > example, > > > > because o

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > wrote: > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > wrote: > > > Rob Clark writes: > > > > > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > > > wrote: > > > > > Rob Clark writes: >

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Marek Olšák
On Tue, Nov 13, 2018, 6:00 PM Rob Clark On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > > > > Rob Clark writes: > > > > > If we can't clear all the buffers with pctx->clear() (say, for example, > > > because of ColorMask), push the buffers we *can* clear with > pctx->clear() > > > first. T

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Ilia Mirkin
On Tue, Nov 13, 2018 at 6:50 PM Rob Clark wrote: > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt wrote: > > > > Rob Clark writes: > > > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > > >> > > >> Rob Clark writes: > > >> > > >> > If we can't clear all the buffers with pctx->clear() (s

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Rob Clark
On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt wrote: > > Rob Clark writes: > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > >> > >> Rob Clark writes: > >> > >> > If we can't clear all the buffers with pctx->clear() (say, for example, > >> > because of ColorMask), push the buffers we *ca

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Eric Anholt
Rob Clark writes: > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: >> >> Rob Clark writes: >> >> > If we can't clear all the buffers with pctx->clear() (say, for example, >> > because of ColorMask), push the buffers we *can* clear with pctx->clear() >> > first. Tilers want to see clears co

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Rob Clark
On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > > Rob Clark writes: > > > If we can't clear all the buffers with pctx->clear() (say, for example, > > because of ColorMask), push the buffers we *can* clear with pctx->clear() > > first. Tilers want to see clears coming before draws to enable

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-13 Thread Eric Anholt
Rob Clark writes: > If we can't clear all the buffers with pctx->clear() (say, for example, > because of ColorMask), push the buffers we *can* clear with pctx->clear() > first. Tilers want to see clears coming before draws to enable fast- > paths, and clearing one of the attachments with a quad-