Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Ian Romanick
On 06/24/2014 01:09 PM, Cody Northrop wrote: > > > > On Tue, Jun 24, 2014 at 10:23 AM, Kenneth Graunke > wrote: > > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this > message

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 02:11:42 PM Cody Northrop wrote: [snip] > > Hi Cody, > > > > I noticed that the Piglit test is a hack to an existing SSO test - would > > it be > > possible to create a new Piglit test for this, and submit it to > > pig...@lists.freedesktop.org for inclusion upstream? It'

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
On Tue, Jun 24, 2014 at 10:29 AM, Kenneth Graunke wrote: > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this message > > and apply it to origin/master using git-am to see why. > > > > Hopefully Matt or Ken can review thi

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
On Tue, Jun 24, 2014 at 10:23 AM, Kenneth Graunke wrote: > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this message > > and apply it to origin/master using git-am to see why. > > > > Hopefully Matt or Ken can review thi

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
On Tue, Jun 24, 2014 at 9:17 AM, Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17c7ead

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Ian Romanick
Send patches with git-send-email and no other method. Save this message and apply it to origin/master using git-am to see why. Hopefully Matt or Ken can review this... On 06/12/2014 12:35 PM, Cody Northrop wrote: > Commit 17c7ead7 exposed a bug in how uniform loading happens in the > presence of

[Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-12 Thread Cody Northrop
Commit 17c7ead7 exposed a bug in how uniform loading happens in the presence of discard. It manifested itself in an application as randomly incorrect pixels on the borders of conditional areas. We believe it is due to how discards jump to the end of the shader incorrectly for some channels. The