Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-09 Thread Roland Scheidegger
_ > From: Marek Olšák > Sent: 08 February 2015 11:27 > To: Jose Fonseca > Cc: Matt Turner; Emil Velikov; ML mesa-dev > Subject: Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add > u_bit_scan64) > > I kind of like the "util_&q

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-08 Thread Jose Fonseca
seca Cc: Matt Turner; Emil Velikov; ML mesa-dev Subject: Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64) I kind of like the "util_" prefix everywhere. u_math only depends on p_config.h and p_compiler.h. I don't think it would be hard to move those two into src/

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-08 Thread Marek Olšák
I kind of like the "util_" prefix everywhere. u_math only depends on p_config.h and p_compiler.h. I don't think it would be hard to move those two into src/util as well. We have always wanted Mesa to use more of Gallium. This might be a good start. Just my 2 cents. Marek On Sat, Feb 7, 2015 at 3

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-07 Thread Jose Fonseca
On 07/02/15 00:10, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:58 PM, Emil Velikov wrote: "util" is meant to be for shared utility across the entire code base - both Mesa and Gallium. It's been growing slowly as people move things there. It might make sense to move a lot of src/gallium/auxili

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-06 Thread Emil Velikov
On 7 February 2015 at 00:10, Matt Turner wrote: > On Fri, Feb 6, 2015 at 3:58 PM, Emil Velikov wrote: >>> "util" is meant to be for shared utility across the entire code base - >>> both Mesa and Gallium. It's been growing slowly as people move things >>> there. It might make sense to move a lot

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-06 Thread Brian Paul
On 02/06/2015 05:10 PM, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:58 PM, Emil Velikov wrote: "util" is meant to be for shared utility across the entire code base - both Mesa and Gallium. It's been growing slowly as people move things there. It might make sense to move a lot of src/gallium/a

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-06 Thread Kenneth Graunke
On Friday, February 06, 2015 11:58:52 PM Emil Velikov wrote: [snip] > If I can speculate - I would assume that bikeshedding is one of the > reasons why things got copied over into gallium. People chose to have > some form of explicit structure and naming scheme, that will be easier > to follow as t

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-06 Thread Matt Turner
On Fri, Feb 6, 2015 at 3:58 PM, Emil Velikov wrote: >> "util" is meant to be for shared utility across the entire code base - >> both Mesa and Gallium. It's been growing slowly as people move things >> there. It might make sense to move a lot of src/gallium/auxiliary/util >> there, in fact - the

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-06 Thread Emil Velikov
Hi all, Fwiw, I'm 100% behind Jose's arguments, let me try and justify why: On 4 February 2015 at 20:18, Kenneth Graunke wrote: > On Wednesday, February 04, 2015 02:04:38 PM Jose Fonseca wrote: >> This change broke MinGW/MSVC builds because ffsll is not available there. >> >> >> There is a ffsll

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-04 Thread Jose Fonseca
On 04/02/15 20:18, Kenneth Graunke wrote: On Wednesday, February 04, 2015 02:04:38 PM Jose Fonseca wrote: This change broke MinGW/MSVC builds because ffsll is not available there. There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So rather than duplicating it in src/gallium

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-04 Thread Kenneth Graunke
On Wednesday, February 04, 2015 02:04:38 PM Jose Fonseca wrote: > This change broke MinGW/MSVC builds because ffsll is not available there. > > > There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So > rather than duplicating it in src/gallium/auxiliary/util/u_math.h I'd > pr

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-04 Thread Brian Paul
On 02/04/2015 07:04 AM, Jose Fonseca wrote: This change broke MinGW/MSVC builds because ffsll is not available there. There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So rather than duplicating it in src/gallium/auxiliary/util/u_math.h I'd prefer move it to src/util. And

[Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-04 Thread Jose Fonseca
This change broke MinGW/MSVC builds because ffsll is not available there. There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So rather than duplicating it in src/gallium/auxiliary/util/u_math.h I'd prefer move it to src/util. And here lies the problem: what header name sh