Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Ian Romanick
On 09/28/2012 07:14 AM, Brian Paul wrote: On 09/27/2012 05:41 PM, Ian Romanick wrote: On 09/27/2012 06:28 AM, Brian Paul wrote: If an extension like this is marked as being "ES2" in extensions.c why do we need to check ctx->API==API_OPENGLES2? It seems to me that we should only have to test ctx

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 08:14:29AM -0600, Brian Paul wrote: > On 09/27/2012 05:41 PM, Ian Romanick wrote: > > On 09/27/2012 06:28 AM, Brian Paul wrote: > >> Looks good to me, Oliver. > >> > >> Reviewed-by: Brian Paul > >> > >> One question below... > >> > >> On 09/27/2012 02:56 AM, Oliver McFadden

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Brian Paul
On 09/27/2012 05:41 PM, Ian Romanick wrote: On 09/27/2012 06:28 AM, Brian Paul wrote: Looks good to me, Oliver. Reviewed-by: Brian Paul One question below... On 09/27/2012 02:56 AM, Oliver McFadden wrote: Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)'

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 02:29:12AM -0700, Kenneth Graunke wrote: > On 09/28/2012 02:20 AM, Oliver McFadden wrote: > > On Fri, Sep 28, 2012 at 01:12:55AM -0700, Kenneth Graunke wrote: > >> On 09/27/2012 01:56 AM, Oliver McFadden wrote: > >>> Signed-off-by: Oliver McFadden > >>> --- > >>> v4: Off-by

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Kenneth Graunke
On 09/28/2012 02:20 AM, Oliver McFadden wrote: > On Fri, Sep 28, 2012 at 01:12:55AM -0700, Kenneth Graunke wrote: >> On 09/27/2012 01:56 AM, Oliver McFadden wrote: >>> Signed-off-by: Oliver McFadden >>> --- >>> v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could >>> cause a >>>

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Thu, Sep 27, 2012 at 07:28:47AM -0600, Brian Paul wrote: > Looks good to me, Oliver. > > Reviewed-by: Brian Paul Thanks Brian. Please also check Kenneth's comments and my reply; I'd like your input there. > > One question below... OK. > > On 09/27/2012 02:56 AM, Oliver McFadden wrote: >

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 01:12:55AM -0700, Kenneth Graunke wrote: > On 09/27/2012 01:56 AM, Oliver McFadden wrote: > > Signed-off-by: Oliver McFadden > > --- > > v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could > > cause a > > crash. > > > > src/glx/glxextensions.h

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Kenneth Graunke
On 09/27/2012 01:56 AM, Oliver McFadden wrote: > Signed-off-by: Oliver McFadden > --- > v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a > crash. > > src/glx/glxextensions.h |3 ++- > src/mapi/glapi/gen/es_EXT.xml |6 +++

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-27 Thread Ian Romanick
On 09/27/2012 06:28 AM, Brian Paul wrote: Looks good to me, Oliver. Reviewed-by: Brian Paul One question below... On 09/27/2012 02:56 AM, Oliver McFadden wrote: Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-27 Thread Brian Paul
Looks good to me, Oliver. Reviewed-by: Brian Paul One question below... On 09/27/2012 02:56 AM, Oliver McFadden wrote: Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx/glxextensions.h |

[Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-27 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx/glxextensions.h |3 ++- src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel_extensions.c |1 +