Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Emil Velikov
On 8 February 2018 at 04:30, Timothy Arceri wrote: > > > On 07/02/18 19:17, Dieter Nützel wrote: >> >> Am 06.02.2018 00:23, schrieb Timothy Arceri: >>> >>> On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: > > On 02/02/18 19:26, Dieter Nützel wr

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Timothy Arceri
On 09/02/18 11:53, Marek Olšák wrote: On Fri, Feb 9, 2018 at 1:45 AM, Timothy Arceri wrote: On 09/02/18 10:49, Marek Olšák wrote: Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 1

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Marek Olšák
On Fri, Feb 9, 2018 at 1:45 AM, Timothy Arceri wrote: > On 09/02/18 10:49, Marek Olšák wrote: >> >> Does this fix the cache/no cache conflict? >> >> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c >> b/src/gallium/drivers/radeonsi/si_pipe.c >> index 26835d6..97f11ea 100644 >> --- a/src/gallium

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Timothy Arceri
On 09/02/18 10:49, Marek Olšák wrote: Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src/gallium/drivers/radeonsi/si_pipe.c @@

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Dieter Nützel
Marek, great work. This one solve it. I've tested both ways: NO_NIR -> NIR : OK NIR -> NO_NIR : OK (deleted cache files before both tests) Tested-by: Dieter Nützel Land this stuff...;-) Dieter Am 09.02.2018 00:49, schrieb Marek Olšák: Does this fix the cache/no cache conflict? diff --git a

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Marek Olšák
Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src/gallium/drivers/radeonsi/si_pipe.c @@ -642,7 +642,8 @@ static void si_disk_ca

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-08 Thread Dieter Nützel
Am 08.02.2018 05:30, schrieb Timothy Arceri: On 07/02/18 19:17, Dieter Nützel wrote: Am 06.02.2018 00:23, schrieb Timothy Arceri: On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH,

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-07 Thread Timothy Arceri
On 07/02/18 19:17, Dieter Nützel wrote: Am 06.02.2018 00:23, schrieb Timothy Arceri: On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-07 Thread Dieter Nützel
Am 06.02.2018 00:23, schrieb Timothy Arceri: On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache fil

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier

2018-02-06 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 2, 2018 at 7:08 AM, Timothy Arceri wrote: > We move the nir check before the shader cache call so that we can > call a nir based caching function in a following patch. > > Also with this change we simply check if vertex shaders support

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-05 Thread Timothy Arceri
On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache file(s). The cache currently needs to be delete

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-04 Thread Dieter Nützel
Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache file(s). The cache currently needs to be deleted when switching between nir and tgsi. I'

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier

2018-02-02 Thread Timothy Arceri
On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache file(s). The cache currently needs to be deleted when switching between nir and tgsi. I'm not sure it I should try to avoid this or not

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier

2018-02-02 Thread Dieter Nützel
Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache file(s). export R600_DEBUG sisched,nir UH and UV: Start menu OK and then both: Loading "core/properties/unigine.prop" 2 properties 0ms Received signal SIGSEGV, invalid memory

[Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier

2018-02-01 Thread Timothy Arceri
We move the nir check before the shader cache call so that we can call a nir based caching function in a following patch. Also with this change we simply check if vertex shaders support NIR rather than looping over the stages as mixing of shader types is not supported anyway. --- src/mesa/state_t