Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-12-07 Thread Emil Velikov
On 20 November 2015 at 18:47, Sarah Sharp wrote: > On Fri, Nov 20, 2015 at 02:18:56PM +, Emil Velikov wrote: >> On 18 November 2015 at 21:59, Ilia Mirkin wrote: >> > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp >> > wrote: >> >>> There's not really a consensus I guess, but most people do lea

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-12-07 Thread Sarah Sharp
Ping? I believe all the concerns about this patchset (and the DRM patch to add KBL) have been addressed. Can someone push this to master? Shall I rebase and resend the patches? Sarah Sharp On Tue, Nov 17, 2015 at 11:40:53AM -0800, Sarah Sharp wrote: > Add PCI IDs for the Intel Kabylake platforms.

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-20 Thread Ilia Mirkin
On Fri, Nov 20, 2015 at 2:01 PM, Ben Widawsky wrote: >> > FWIW I wholeheartedly agree with this line of reasoning. I never put >> > the version info into my commits either, and find it >> > confusing/misleading when others do. I want to know the final state of >> > things when looking at the commi

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-20 Thread Ben Widawsky
On Fri, Nov 20, 2015 at 02:18:56PM +, Emil Velikov wrote: > On 18 November 2015 at 21:59, Ilia Mirkin wrote: > > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > > wrote: > >>> There's not really a consensus I guess, but most people do leave the > >>> version > >>> information in the final com

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-20 Thread Sarah Sharp
On Fri, Nov 20, 2015 at 02:18:56PM +, Emil Velikov wrote: > On 18 November 2015 at 21:59, Ilia Mirkin wrote: > > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > > wrote: > >>> There's not really a consensus I guess, but most people do leave the > >>> version > >>> information in the final com

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-20 Thread Emil Velikov
On 18 November 2015 at 21:59, Ilia Mirkin wrote: > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > wrote: >>> There's not really a consensus I guess, but most people do leave the version >>> information in the final commit message. >> >> I personally feel like that's leaving boredom doodles on a f

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-18 Thread Kristian Høgsberg
On Wed, Nov 18, 2015 at 1:54 PM, Sarah Sharp wrote: > On Tue, Nov 17, 2015 at 02:20:28PM -0800, Ben Widawsky wrote: >> On Tue, Nov 17, 2015 at 11:40:53AM -0800, Sarah Sharp wrote: >> > Add PCI IDs for the Intel Kabylake platforms. The IDs are taken >> > directly from the Linux kernel patches, whi

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-18 Thread Ilia Mirkin
On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp wrote: >> There's not really a consensus I guess, but most people do leave the version >> information in the final commit message. > > I personally feel like that's leaving boredom doodles on a final > architectural drawing. If people want to know the b

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-18 Thread Sarah Sharp
On Tue, Nov 17, 2015 at 02:20:28PM -0800, Ben Widawsky wrote: > On Tue, Nov 17, 2015 at 11:40:53AM -0800, Sarah Sharp wrote: > > Add PCI IDs for the Intel Kabylake platforms. The IDs are taken > > directly from the Linux kernel patches, which are under review: > > > > http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-17 Thread Ben Widawsky
On Tue, Nov 17, 2015 at 11:40:53AM -0800, Sarah Sharp wrote: > Add PCI IDs for the Intel Kabylake platforms. The IDs are taken > directly from the Linux kernel patches, which are under review: > > http://lists.freedesktop.org/archives/intel-gfx/2015-October/078967.html > http://cgit.freedesktop.o

[Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

2015-11-17 Thread Sarah Sharp
Add PCI IDs for the Intel Kabylake platforms. The IDs are taken directly from the Linux kernel patches, which are under review: http://lists.freedesktop.org/archives/intel-gfx/2015-October/078967.html http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=kbl-upstream-v2 The Kabylake PCI IDs take