Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Connor Abbott
On Sun, Feb 1, 2015 at 6:54 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt wrote: >>> We've probably never seen this ridiculous pattern in the wild, so it >>> didn't matter. >> >> I don't think this pattern is 'ridiculous' at all -- GLSL doesn't h

Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Eric Anholt
Connor Abbott writes: > On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt wrote: >> We've probably never seen this ridiculous pattern in the wild, so it >> didn't matter. > > I don't think this pattern is 'ridiculous' at all -- GLSL doesn't have > a sat operation, so shaders wanting to do a saturate h

Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Matt Turner
On Sun, Feb 1, 2015 at 2:07 PM, Connor Abbott wrote: > On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt wrote: >> We've probably never seen this ridiculous pattern in the wild, so it >> didn't matter. > > I don't think this pattern is 'ridiculous' at all -- GLSL doesn't have > a sat operation, so shad

Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Jason Ekstrand
On Feb 1, 2015 2:07 PM, "Connor Abbott" wrote: > > On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt wrote: > > We've probably never seen this ridiculous pattern in the wild, so it > > didn't matter. > > I don't think this pattern is 'ridiculous' at all -- GLSL doesn't have > a sat operation, so shader

Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Connor Abbott
On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt wrote: > We've probably never seen this ridiculous pattern in the wild, so it > didn't matter. I don't think this pattern is 'ridiculous' at all -- GLSL doesn't have a sat operation, so shaders wanting to do a saturate have to do this already. Rather, w

Re: [Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Feb 1, 2015 1:17 PM, "Eric Anholt" wrote: > We've probably never seen this ridiculous pattern in the wild, so it > didn't matter. > --- > src/glsl/nir/nir_opt_algebraic.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir_op

[Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.

2015-02-01 Thread Eric Anholt
We've probably never seen this ridiculous pattern in the wild, so it didn't matter. --- src/glsl/nir/nir_opt_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py index 8a14fe0..84c60ec 100644 --- a/s