Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-18 Thread Kenneth Graunke
On 01/17/2014 01:57 PM, Chris Forbes wrote: > Ken, > > Assuming the caches don't completely derail things, you ought to be > able to make this work with pretty minimal impact: > > - Keep the low four bits of the sampler index where they are > - If the 5th bit is set: > - Force message header

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Chris Forbes
Ken, Assuming the caches don't completely derail things, you ought to be able to make this work with pretty minimal impact: - Keep the low four bits of the sampler index where they are - If the 5th bit is set: - Force message header on - Add 16*sizeof(sampler_state) to the copy of r0.3 in

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Ian Romanick
On 01/17/2014 01:08 PM, Marek Olšák wrote: > The test seems to work correctly with 32 textures per stage. It tests > that all textures return the correct color, but the sampler state is > always the same. Which is the problem. The method we're using to access samplers works fine for up to 16, but

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Marek Olšák
The test seems to work correctly with 32 textures per stage. It tests that all textures return the correct color, but the sampler state is always the same. Marek On Thu, Jan 16, 2014 at 1:28 AM, Kenneth Graunke wrote: > On 01/15/2014 12:56 PM, Chris Forbes wrote: >> Does this actually work for >

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-15 Thread Kenneth Graunke
On 01/15/2014 12:56 PM, Chris Forbes wrote: > Does this actually work for >16? > > Sampler messages' descriptor only has 4 bits for the sampler index, so > it seems you'd silently lose the top bit and get the wrong sampler > parameters. Oh, wow. No...no, it can't possibly work then. (Apparently

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-15 Thread Chris Forbes
Does this actually work for >16? Sampler messages' descriptor only has 4 bits for the sampler index, so it seems you'd silently lose the top bit and get the wrong sampler parameters. On Thu, Jan 16, 2014 at 8:08 AM, Kenneth Graunke wrote: > This causes us to advertise: > - GL_MAX_TEXTURE_IMAGE_U

[Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-15 Thread Kenneth Graunke
This causes us to advertise: - GL_MAX_TEXTURE_IMAGE_UNITS = 32 - GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS = 32 - GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS = 96 instead of the old values of 16, 16, and 48. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 ins