Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-31 Thread Ian Romanick
On 05/31/2018 10:48 AM, Eric Anholt wrote: > Ian Romanick writes: > >> On 05/31/2018 10:34 AM, Ian Romanick wrote: >>> There are GLSL IR lowering passes for a lot (all?) of this that I added >>> when I did GL_MESA_shader_integer_functions. Is there a reason to not >>> use those? >> >> Which I no

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-31 Thread Eric Anholt
Ian Romanick writes: > On 05/31/2018 10:34 AM, Ian Romanick wrote: >> There are GLSL IR lowering passes for a lot (all?) of this that I added >> when I did GL_MESA_shader_integer_functions. Is there a reason to not >> use those? > > Which I now see that you mentioned in the commit messages. Sti

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-31 Thread Ian Romanick
On 05/31/2018 10:34 AM, Ian Romanick wrote: > There are GLSL IR lowering passes for a lot (all?) of this that I added > when I did GL_MESA_shader_integer_functions. Is there a reason to not > use those? Which I now see that you mentioned in the commit messages. Still, just curious... > On 05/08

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-31 Thread Ian Romanick
There are GLSL IR lowering passes for a lot (all?) of this that I added when I did GL_MESA_shader_integer_functions. Is there a reason to not use those? On 05/08/2018 01:13 PM, Eric Anholt wrote: > If you don't have HW to do bfi, then lowering bitfieldInsert to bfi makes > things harder than keep

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-31 Thread Matt Turner
Whole series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-30 Thread Eric Anholt
Eric Anholt writes: > If you don't have HW to do bfi, then lowering bitfieldInsert to bfi makes > things harder than keeping the "bits" argument around. > > This still uses bfm, but I've added the obvious lowering of bfm if you > need it. Anyone? Even just an ack, assuming that I'm passing the

[Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-08 Thread Eric Anholt
If you don't have HW to do bfi, then lowering bitfieldInsert to bfi makes things harder than keeping the "bits" argument around. This still uses bfm, but I've added the obvious lowering of bfm if you need it. --- src/compiler/nir/nir.h| 5 + src/compiler/nir/nir_opt_algebraic