Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Brian Paul
On 05/26/2015 02:03 PM, Jose Fonseca wrote: On 25/05/15 15:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that ca

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Jose Fonseca
On 25/05/15 15:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that case to prevent the error. Mesa now matches nv

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Emil Velikov
On 26/05/15 19:11, Brian Paul wrote: > On 05/26/2015 02:05 PM, Emil Velikov wrote: >> On 25/05/15 14:41, Brian Paul wrote: >>> If the glPushAttrib() mask value was zero we didn't actually push >>> anything onto the attribute stack. A subsequent glPopAttrib() call >>> would generate a GL_STACK_UNDE

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Brian Paul
On 05/26/2015 02:05 PM, Emil Velikov wrote: On 25/05/15 14:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that ca

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Emil Velikov
On 25/05/15 14:41, Brian Paul wrote: > If the glPushAttrib() mask value was zero we didn't actually push > anything onto the attribute stack. A subsequent glPopAttrib() call > would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute > in that case to prevent the error. > > Mesa now

[Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-25 Thread Brian Paul
If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that case to prevent the error. Mesa now matches nvidia's behavior. --- src/mesa/main/att