Re: [Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-30 Thread Jordan Justen
On Wed, Oct 29, 2014 at 5:30 PM, Kristian Høgsberg wrote: > On Tue, Oct 28, 2014 at 5:30 PM, Matt Turner wrote: >> On Tue, Oct 28, 2014 at 3:59 PM, Matt Turner wrote: > - assert(stage == MESA_SHADER_FRAGMENT); I like removing these asserts from the function bodies, but I'm c

Re: [Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-29 Thread Kristian Høgsberg
On Tue, Oct 28, 2014 at 5:30 PM, Matt Turner wrote: > On Tue, Oct 28, 2014 at 3:59 PM, Matt Turner wrote: - assert(stage == MESA_SHADER_FRAGMENT); >>> >>> I like removing these asserts from the function bodies, but I'm >>> confused why you're doing it. The VS isn't going to call >>> fire_f

Re: [Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-28 Thread Matt Turner
On Tue, Oct 28, 2014 at 3:59 PM, Matt Turner wrote: >>> - assert(stage == MESA_SHADER_FRAGMENT); >> >> I like removing these asserts from the function bodies, but I'm >> confused why you're doing it. The VS isn't going to call >> fire_fb_write, or emit a derivative instruction. > > Oh, you're ac

Re: [Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-28 Thread Matt Turner
On Tue, Oct 28, 2014 at 3:58 PM, Matt Turner wrote: > On Tue, Oct 28, 2014 at 3:17 PM, Kristian Høgsberg wrote: >> This removes all stage specific data from the generator, and lets us >> create a generator for any stage. >> >> Signed-off-by: Kristian Høgsberg >> --- >> src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-28 Thread Matt Turner
On Tue, Oct 28, 2014 at 3:17 PM, Kristian Høgsberg wrote: > This removes all stage specific data from the generator, and lets us > create a generator for any stage. > > Signed-off-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 5 ++--- > src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

2014-10-28 Thread Kristian Høgsberg
This removes all stage specific data from the generator, and lets us create a generator for any stage. Signed-off-by: Kristian Høgsberg --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 5 ++--- src/mesa/drivers/dri/i965/brw_fs.cpp| 2 +- src/mesa/drivers/dri/i965/brw_fs.h