On Tue, Oct 28, 2014 at 3:59 PM, Matt Turner <matts...@gmail.com> wrote: >>> - assert(stage == MESA_SHADER_FRAGMENT); >> >> I like removing these asserts from the function bodies, but I'm >> confused why you're doing it. The VS isn't going to call >> fire_fb_write, or emit a derivative instruction. > > Oh, you're actually removing the stage member entirely. Isn't that > useful to have? > > Maybe I need to keep reading the series..
Okay, still don't understand. It seems like your objective in patch 3 is to be able to print things other than "fragment" under various INTEL_DEBUG=... settings. Wouldn't it be simpler to contain that logic in the generator using the stage member -- which would be nice to have for assertions anyway? _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
