Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-07-01 Thread Eduardo Lima Mitev
On 07/01/2015 01:46 AM, Jason Ekstrand wrote: > Ok, I think I've looked through more-or-less the whole thing. The > only thing I haven't looked at is the texturing stuff but I think I'd > like (and Ken agrees) to just refactor the old code to split the guts > into something re-usable and make a mu

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-30 Thread Jason Ekstrand
Ok, I think I've looked through more-or-less the whole thing. The only thing I haven't looked at is the texturing stuff but I think I'd like (and Ken agrees) to just refactor the old code to split the guts into something re-usable and make a much shorter NIR function. Most of it really looks pret

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-30 Thread Jason Ekstrand
Another general comment: It seems like you may have copied+pasted a bit much when it comes to handling arrays in the backend. In the FS backend, we have to multiply lots of stuff by reg->num_components because we need to scalarize it. In the vec4 backend, we don't need to do this because reg->nu

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-29 Thread Eduardo Lima Mitev
On 06/30/2015 01:49 AM, Jason Ekstrand wrote: > As a general comment, please remove the Bugzilla tags from the > commits. This is a new feature, not a bugfix. If you want to leave a > reference to the bug, pick a commit and put it there but it doesn't > need to be in all of them. > --Jason > Ok

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-29 Thread Jason Ekstrand
As a general comment, please remove the Bugzilla tags from the commits. This is a new feature, not a bugfix. If you want to leave a reference to the bug, pick a commit and put it there but it doesn't need to be in all of them. --Jason On Mon, Jun 29, 2015 at 4:29 PM, Jason Ekstrand wrote: > Goo

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-29 Thread Jason Ekstrand
Good work guys! I've started reviewing but review will probably take a few days so please be patient. On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote: > Hello, > > This series adds a new vec4 backend for i965 based on NIR. It is the result > of working on > https://bugs.freedesktop.o

[Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-26 Thread Eduardo Lima Mitev
Hello, This series adds a new vec4 backend for i965 based on NIR. It is the result of working on https://bugs.freedesktop.org/show_bug.cgi?id=89580. This backend is activated if all the following conditions are met: * INTEL_USE_NIR environment variable is set to 1 (or true) * The stage is a GLS