On 06/10/2014 04:39 PM, Thomas Helland wrote:
Thanks for the review!
These patches, along with 5 more I've put together,
don't have any significant impact on compile time.
But that's only 16 files, so it really shouldn't be expected I guess.
A similar effort on firefox gave a 12.5% compile-time
On Tue, Jun 10, 2014 at 3:39 PM, Thomas Helland
wrote:
> Where I do see an impact though is recompiling after changes.
> Less object-files needs to be recompiled, so it's often a lot faster.
> I don't have any specific numbers here though.
Oh, that's a good point that I hadn't considered. Thanks!
Thanks for the review!
These patches, along with 5 more I've put together,
don't have any significant impact on compile time.
But that's only 16 files, so it really shouldn't be expected I guess.
A similar effort on firefox gave a 12.5% compile-time improvement though,
so eventually we should be s
On Mon, Jun 9, 2014 at 3:57 PM, wrote:
> From: Thomas Helland
>
> This series removes some unused includes in the glsl-directory.
Thanks. A lot of people use ccache, so series like this cause them to
have to rebuild (and not use ccache).
I've just sent a series that touches src/glsl's list.h,
On Tue, Jun 10, 2014 at 12:57:31AM +0200, thomashellan...@gmail.com wrote:
> From: Thomas Helland
>
For the series:
Reviewed-by: Tom Stellard
Do these patches make any measurable improvement in compile time?
-Tom
> This series removes some unused includes in the glsl-directory.
> These were
From: Thomas Helland
This series removes some unused includes in the glsl-directory.
These were found with Google's include-what-you-use plugin for clang.
Patches have been compile-tested and a quick glxgears-run has been done.
I have not done a full piglit-run, let me know if that's wanted.
Oh,
