Thanks for the review! These patches, along with 5 more I've put together, don't have any significant impact on compile time. But that's only 16 files, so it really shouldn't be expected I guess. A similar effort on firefox gave a 12.5% compile-time improvement though, so eventually we should be seeing some effects. [1]
Where I do see an impact though is recompiling after changes. Less object-files needs to be recompiled, so it's often a lot faster. I don't have any specific numbers here though. I see that I've managed to get a "From: ...." line in my mails, and sender is not showing up correctly in the mailing-list. Anyone git-savvy who've had similar problems? If not I'll delve into the dark caves of man-pages and read up. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=903816 2014-06-10 19:58 GMT+02:00 Tom Stellard <t...@stellard.net>: > On Tue, Jun 10, 2014 at 12:57:31AM +0200, thomashellan...@gmail.com wrote: > > From: Thomas Helland <thomashellan...@gmail.com> > > > > For the series: > > Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > > Do these patches make any measurable improvement in compile time? > > -Tom > > This series removes some unused includes in the glsl-directory. > > These were found with Google's include-what-you-use plugin for clang. > > Patches have been compile-tested and a quick glxgears-run has been done. > > I have not done a full piglit-run, let me know if that's wanted. > > > > Oh, and excuse me if I've messed up something. > > First run with git and mailing-lists, so lots to learn. > > > > Thomas Helland (11): > > glsl: Remove unused includes in link_uniform_init. > > glsl: Remove unused includes in link_uniform_block_active_visitor.h > > glsl: Remove unused include in ast_to_hir.cpp > > glsl: Remove unused include from builtin_variables.cpp > > glsl: Remove unused include from glsl_types.cpp > > glsl: Remove unused include from glsl_symbol_table.h > > glsl: Remove unused include from hir_field_selection.cpp > > glsl: Remove unused include from ir_basic_block.cpp > > glsl: Remove unused include from ir_constant_expression.cpp > > glsl: Remove unused include in ir.cpp > > glsl: Remove unused include in expr.flatt. > > > > src/glsl/ast_to_hir.cpp | 1 - > > src/glsl/builtin_variables.cpp | 1 - > > src/glsl/glsl_symbol_table.h | 2 +- > > src/glsl/glsl_types.cpp | 4 +--- > > src/glsl/hir_field_selection.cpp | 1 - > > src/glsl/ir.cpp | 1 - > > src/glsl/ir_basic_block.cpp | 2 -- > > src/glsl/ir_constant_expression.cpp | 1 - > > src/glsl/ir_expression_flattening.cpp | 2 -- > > src/glsl/link_uniform_block_active_visitor.h | 2 -- > > src/glsl/link_uniform_initializers.cpp | 2 -- > > 11 files changed, 2 insertions(+), 17 deletions(-) > > > > -- > > 2.0.0 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
