Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-11 Thread Brian Paul
Just two minor nits below. On 11/10/2015 07:34 PM, Dave Airlie wrote: From: Dave Airlie This should fix the getteximage-depth test that currently asserts. I was hitting problem with virgl as well in this area. This moves the 1D array handling code to a single place. Signed-off-by: Dave Air

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ben Skeggs
On 11/11/2015 12:34 PM, Dave Airlie wrote: > From: Dave Airlie > > This should fix the getteximage-depth test that currently asserts. > > I was hitting problem with virgl as well in this area. > > This moves the 1D array handling code to a single place. This fixes the exceptions that some NVIDI

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ian Romanick
Reviewed-by: Ian Romanick On 11/10/2015 06:34 PM, Dave Airlie wrote: > From: Dave Airlie > > This should fix the getteximage-depth test that currently asserts. > > I was hitting problem with virgl as well in this area. > > This moves the 1D array handling code to a single place. > > Signed-o

[Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Dave Airlie
From: Dave Airlie This should fix the getteximage-depth test that currently asserts. I was hitting problem with virgl as well in this area. This moves the 1D array handling code to a single place. Signed-off-by: Dave Airlie --- src/mesa/main/texgetimage.c | 24 +--- 1 fil