Re: [Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-16 Thread samuel.pitoiset
Seems reasonable. Please, let me know the result of the full piglit run. If everything is okay, this patch is : Reviewed-by: Samuel Pitoiset On 13/07/2015 20:08, Ilia Mirkin wrote: This was, btw, introduced in commit 3a8ae6ac243b (nvc0: adapt to new clip state). Back then there was no real ge

Re: [Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-13 Thread Ilia Mirkin
This was, btw, introduced in commit 3a8ae6ac243b (nvc0: adapt to new clip state). Back then there was no real geometry support yet. On Mon, Jul 13, 2015 at 2:05 PM, Ilia Mirkin wrote: > Any one which, after using a geometry shader, enables an extra clip > distance. i.e. none. > > On Mon, Jul 13,

Re: [Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-13 Thread Ilia Mirkin
Any one which, after using a geometry shader, enables an extra clip distance. i.e. none. On Mon, Jul 13, 2015 at 4:16 AM, Samuel Pitoiset wrote: > What piglit test does this fix? > > On Sat, Jul 11, 2015 at 7:13 PM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> Cc: mesa-sta...@lists.fr

Re: [Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-13 Thread Samuel Pitoiset
What piglit test does this fix? On Sat, Jul 11, 2015 at 7:13 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop.org > --- > > Even though in practice a geometry program will never be using UCP's, > we still were revalidating (aka recompiling) the program whe

[Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- Even though in practice a geometry program will never be using UCP's, we still were revalidating (aka recompiling) the program when more clip planes became enabled (which also are used for regular clip distances). This seems li