Re: [Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 11:22 AM, Chad Versace wrote: > The function segfaulted when a game called glTexSubImage2D on a texture > with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. Wait, is that what it was doing? Specifying a four component format but a single component (and sRGB,

Re: [Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Paul Berry
On 26 September 2012 11:22, Chad Versace wrote: > The function segfaulted when a game called glTexSubImage2D on a texture > with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. > > The function only supports MESA_FORMAT_ARGB and returns early if it > detects an unsupporte

[Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Chad Versace
The function segfaulted when a game called glTexSubImage2D on a texture with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. The function only supports MESA_FORMAT_ARGB and returns early if it detects an unsupported format. Clearly, its detection condition was insufficien