Re: [Mesa-dev] [PATCH] glsl: report builtin variables in getActiveVariables()

2015-05-31 Thread Martin Peres
On 01/06/2015 08:17, Tapani wrote: On 05/31/2015 10:07 AM, Tapani wrote: Hi Martin; This patch together with 'reference built-in uniforms into gl_uniform_storage' fixes the "builtins missing" issue and also exposes some bugs with program_interface_query which I'm about to address soon. I played

Re: [Mesa-dev] [PATCH] glsl: report builtin variables in getActiveVariables()

2015-05-31 Thread Tapani
On 05/31/2015 10:07 AM, Tapani wrote: Hi Martin; This patch together with 'reference built-in uniforms into gl_uniform_storage' fixes the "builtins missing" issue and also exposes some bugs with program_interface_query which I'm about to address soon. I played around with idea of adding some

Re: [Mesa-dev] [PATCH] glsl: report builtin variables in getActiveVariables()

2015-05-31 Thread Tapani
Hi Martin; This patch together with 'reference built-in uniforms into gl_uniform_storage' fixes the "builtins missing" issue and also exposes some bugs with program_interface_query which I'm about to address soon. I played around with idea of adding some 'dummy resource' in the resource list

[Mesa-dev] [PATCH] glsl: report builtin variables in getActiveVariables()

2015-05-19 Thread Martin Peres
It seems like there were restrictions on builtin variables introduced in 2011 (07731ed1692eb5d72110b3c5b693f37e581e3809) that never got lifted when proper support got added. At least, getting rid of them do not introduce any regression while fixing the following piglit tests: - glsl-getactiveunifo