Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-22 Thread Juan A. Suarez Romero
On Thu, 2017-06-22 at 09:27 +1000, Timothy Arceri wrote: > > On 22/06/17 02:41, Juan A. Suarez Romero wrote: > > On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote: > > > On 21/06/17 18:13, Juan A. Suarez Romero wrote: > > > > link_xfb_stride_layout_qualifiers() can be called multiple times,

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-21 Thread Timothy Arceri
On 22/06/17 02:41, Juan A. Suarez Romero wrote: On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote: On 21/06/17 18:13, Juan A. Suarez Romero wrote: link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0.

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-21 Thread Juan A. Suarez Romero
On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote: > On 21/06/17 18:13, Juan A. Suarez Romero wrote: > > link_xfb_stride_layout_qualifiers() can be called multiple times, and > > each time we call prog->TransformFeedback.BufferStride is reset to 0. > > > > Thus it is loosing the values set i

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-21 Thread Timothy Arceri
On 21/06/17 20:24, Timothy Arceri wrote: On 21/06/17 18:13, Juan A. Suarez Romero wrote: link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0. Thus it is loosing the values set in previous call. Do not perf

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-21 Thread Timothy Arceri
On 21/06/17 18:13, Juan A. Suarez Romero wrote: link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0. Thus it is loosing the values set in previous call. Do not perform such reset. Fixes: KHR-GL45.enhanced_la

[Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

2017-06-21 Thread Juan A. Suarez Romero
link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0. Thus it is loosing the values set in previous call. Do not perform such reset. Fixes: KHR-GL45.enhanced_layouts.xfb_stride_of_empty_list KHR-GL45.enhanced_l