Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-26 Thread Ian Romanick
On 04/22/2014 12:19 PM, Sarah Sharp wrote: > On Sat, Apr 19, 2014 at 12:34:37PM -0700, Stéphane Marchesin wrote: >> On Fri, Apr 18, 2014 at 3:37 PM, Sarah Sharp >> wrote: >> >>> Chromium defined a new GL extension (that isn't registered with Khronos). >>> >> >> This here is the problem IMO. I'll se

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-26 Thread Ian Romanick
On 04/19/2014 10:23 AM, Chad Versace wrote: > On Fri, Apr 18, 2014 at 05:30:02PM -0700, Ian Romanick wrote: >> On 04/18/2014 05:07 PM, Jamey Sharp wrote: >>> On Fri, Apr 18, 2014 at 4:49 PM, Ian Romanick wrote: On 04/18/2014 03:37 PM, Sarah Sharp wrote: > >> If you use the unchecked >>> vari

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-22 Thread Stéphane Marchesin
On Tue, Apr 22, 2014 at 12:19 PM, Sarah Sharp wrote: > On Sat, Apr 19, 2014 at 12:34:37PM -0700, Stéphane Marchesin wrote: > > On Fri, Apr 18, 2014 at 3:37 PM, Sarah Sharp > > wrote: > > > > > Chromium defined a new GL extension (that isn't registered with > Khronos). > > > > > > > This here is t

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-22 Thread Sarah Sharp
On Sat, Apr 19, 2014 at 12:34:37PM -0700, Stéphane Marchesin wrote: > On Fri, Apr 18, 2014 at 3:37 PM, Sarah Sharp > wrote: > > > Chromium defined a new GL extension (that isn't registered with Khronos). > > > > This here is the problem IMO. I'll see next week what we can do about > pushing for t

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-20 Thread Jamey Sharp
On Fri, Apr 18, 2014 at 5:30 PM, Ian Romanick wrote: > On 04/18/2014 05:07 PM, Jamey Sharp wrote: >> if you're using Xlib, then by default it will be abort()ing your >> client as soon as it pulls the error out of the event queue. > > Unless the client has an error handler, right? Well, sure, the

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-19 Thread Stéphane Marchesin
On Fri, Apr 18, 2014 at 3:37 PM, Sarah Sharp wrote: > Chromium defined a new GL extension (that isn't registered with Khronos). > This here is the problem IMO. I'll see next week what we can do about pushing for this to become a registered extension. Intel would be our 2nd implementation, so I th

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-19 Thread Chad Versace
On Fri, Apr 18, 2014 at 06:19:06PM -0700, Sarah Sharp wrote: > [I missed Chad on the original Cc somehow; hopefully he can find the > original mails.] I have some comments too. Some of my comments conflict with Ian's, and also conflict with advice I previously gave you (sorry). > On Fri, Apr 18,

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-19 Thread Chad Versace
On Fri, Apr 18, 2014 at 05:30:02PM -0700, Ian Romanick wrote: > On 04/18/2014 05:07 PM, Jamey Sharp wrote: > > On Fri, Apr 18, 2014 at 4:49 PM, Ian Romanick wrote: > >> On 04/18/2014 03:37 PM, Sarah Sharp wrote: > If you use the unchecked > > variant of the request, then the error is placed in th

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-18 Thread Sarah Sharp
[I missed Chad on the original Cc somehow; hopefully he can find the original mails.] On Fri, Apr 18, 2014 at 04:49:43PM -0700, Ian Romanick wrote: > On 04/18/2014 03:37 PM, Sarah Sharp wrote: > > Chromium defined a new GL extension (that isn't registered with Khronos). > > We need to add an EGL e

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-18 Thread Ian Romanick
On 04/18/2014 05:07 PM, Jamey Sharp wrote: > On Fri, Apr 18, 2014 at 4:49 PM, Ian Romanick wrote: >> On 04/18/2014 03:37 PM, Sarah Sharp wrote: >>> One open question: >>> >>> I've used the normal (error checked) version of xcb_dri2_get_msc. The >>> GLX implementation of glXGetSyncValuesOML uses t

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-18 Thread Jamey Sharp
On Fri, Apr 18, 2014 at 4:49 PM, Ian Romanick wrote: > On 04/18/2014 03:37 PM, Sarah Sharp wrote: >> One open question: >> >> I've used the normal (error checked) version of xcb_dri2_get_msc. The >> GLX implementation of glXGetSyncValuesOML uses the unchecked version, >> but I'm not convinced it'

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-18 Thread Ian Romanick
On 04/18/2014 03:37 PM, Sarah Sharp wrote: > Chromium defined a new GL extension (that isn't registered with Khronos). > We need to add an EGL extension for it, so we can migrate ChromeOS on > Intel systems to use EGL instead of GLX. > > http://git.chromium.org/gitweb/?p=chromium/src/third_party/k

[Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-18 Thread Sarah Sharp
Chromium defined a new GL extension (that isn't registered with Khronos). We need to add an EGL extension for it, so we can migrate ChromeOS on Intel systems to use EGL instead of GLX. http://git.chromium.org/gitweb/?p=chromium/src/third_party/khronos.git;a=commitdiff;h=27cbfdab35c601f70aa150581ad