If the local work group size is variable it won't be available
at compile time so we can't lower it in nir_lower_system_values().
Signed-off-by: Plamena Manolova
---
src/compiler/nir/nir_lower_system_values.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletion
If the local work group size is variable it won't be available
at compile time so we can't lower it in nir_lower_system_values().
Signed-off-by: Plamena Manolova
---
src/compiler/nir/nir_lower_system_values.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletion
ff-by: Plamena Manolova
---
src/compiler/nir/nir_lower_system_values.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/compiler/nir/nir_lower_system_values.c
b/src/compiler/nir/nir_lower_system_values.c
index bde7eb1180..6fdf9f9c51 100644
--- a/src/compile
Lowering the global invocation id and the local work group
size in nir_lower_system_values is only possible if the
local work group size isn't variable, otherwise this should
be handled by the native driver (if it supports
ARB_compute_variable_group_size).
Signed-off-by: Plamena Man
(Jordan)
Use alphabetical order in features.txt (Matt)
Set the extension constants properly in brw_context.c
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/18.2.0.html| 1 +
src/compiler/nir
This looks good to me :)
Reviewed-by: Plamena Manolova
On Wed, 6 Jun 2018 at 18:51, Jordan Justen
wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106810
> Fixes: b4c37ce2140 "i965: Add ARB_get_program_binary support using
> nir_serialization"
> Ref: 3f
v2 is Reviewed-by: Plamena Manolova
On Wed, 6 Jun 2018 at 15:59, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Found by Eero.
>
> v2: Add G16R16 formats (Lionel)
>
> Signed-off-by: Lionel Landwerlin
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=
Reviewed-by: Plamena Manolova
On Wed, 6 Jun 2018 at 13:53, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Signed-off-by: Lionel Landwerlin
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642
> ---
> src/mesa/drivers/dri/common/dri_util.c | 8
On Mon, 4 Jun 2018 at 21:36, Ilia Mirkin wrote:
> On Mon, Jun 4, 2018 at 4:30 PM, Plamena Manolova
> wrote:
> > Thank you for the review Ilia!
> >
> > On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote:
> >>
> >> On Fri, Jun 1, 201
Thank you for the review Ilia!
On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote:
> On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova
> wrote:
> > This patch adds the implentation of ARB_compute_variable_group_size
> > for i965. We do this by storing the group size i
Thank you for reviewing this Jordan!
On Fri, 1 Jun 2018 at 23:45, Jordan Justen
wrote:
> On 2018-06-01 15:21:34, Plamena Manolova wrote:
> > This patch adds the implentation of ARB_compute_variable_group_size
> > for i965. We do this by storing the group size in a buffer surface
Ah, that's true, I'll switch them around. Thank you for reviewing Matt!
On Sat, 2 Jun 2018 at 04:58, Matt Turner wrote:
> On Fri, Jun 1, 2018 at 3:21 PM, Plamena Manolova
> wrote:
> > This patch adds the implentation of ARB_compute_variable_group_size
> > for i96
This patch adds the implentation of ARB_compute_variable_group_size
for i965. We do this by storing the group size in a buffer surface,
similarly to the work group number.
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/18.2.0.html
Add the missing nir intrinsic for the gl_GlobalInvocationID
compute shader variable.
Signed-off-by: Plamena Manolova
---
src/compiler/nir/nir.c | 4
src/compiler/nir/nir_intrinsics.py | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/compiler/nir/nir.c b/src/compiler
These patches add support for ARB_compute_variable_group_size
for i965.
Plamena Manolova (2):
nir: Add global invocation id intrinsic.
i965: Implement ARB_compute_variable_group_size.
docs/features.txt| 2 +-
docs/relnotes/18.2.0.html
Adds suppport for ARB_fragment_shader_interlock. We achieve
the interlock and fragment ordering by issuing a memory fence
via sendc.
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/18.1.0.html| 1 +
src/intel/compiler
e that the
critical section of the fragment shader will be executed for
only one fragment at a time.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 10 ++
src/compiler/glsl/ast_to_hir.cpp | 10 ++
src/compiler/glsl/ast_type.cpp
Thank you so much for reviewing these patches Curro!
I'll make the suggested changes and resubmit.
On Thu, 5 Apr 2018, 19:25 Francisco Jerez, wrote:
> Plamena Manolova writes:
>
> > Adds suppport for ARB_fragment_shader_interlock. We achieve
> > the interlock and fragmen
e that the
critical section of the fragment shader will be executed for
only one fragment at a time.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 10
src/compiler/glsl/ast_to_hir.cpp | 10
src/compiler/glsl/ast_type.cpp | 30 +++
Adds suppport for ARB_fragment_shader_interlock. We achieve
the interlock and fragment ordering by issuing a memory fence
via sendc.
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/18.1.0.html| 1 +
src/intel/compiler
es of any
of the predicate registers.
Fixes: piglit.spec.arb_indirect_parameters.tf-count-arrays
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103085
Signed-off-by: Plamena Manolova
CC: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_draw.c | 45 +++---
sters.
Fixes: piglit.spec.arb_indirect_parameters.tf-count-arrays
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103085
Signed-off-by: Plamena Manolova
CC: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_draw.c | 75 +---
1 file changed, 44 insertions(+
Hi Ken,
Sorry for missing this and thank you for catching it!
Reviewed-by: Plamena Manolova
On 11 Oct 2017 03:27, "Kenneth Graunke" wrote:
The original implementation allocated a new BO here, but we decided to
switch to intel_upload_space, which returns a reference to the current
: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_draw.c | 236 ++-
1 file changed, 119 insertions(+), 117 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
b/src/mesa/drivers/dri/i965/brw_draw.c
index 513a05bb96..48d782ee86 100644
--- a/src/mesa/drivers
We can implement ARB_indirect_parameters for i965 by
taking advantage of the conditional rendering mechanism.
This works by issuing maxdrawcount draw calls and using
conditional rendering to predicate each of them with
"drawcount > gl_DrawID"
Signed-off-by: Plamena Manolova
---
src
.
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_draw.c | 46 +---
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
b/src/mesa/drivers/dri/i965/brw_draw.c
index 06c6ed72c9..1e93cb67c6 100644
--- a
count > gl_DrawID". The first three patches are part
of a necessary refactor of brw_try_draw_prims while the last
one actually introduces the functionality.
Plamena Manolova (4):
i965: Introduce brw_prepare_drawing.
i965: Indroduce brw_finish_drawing.
i965: Refactor brw_try_draw_
.
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_draw.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
b/src/mesa/drivers/dri/i965/brw_draw.c
index 1e93cb67c6..513a05bb96 100644
--- a/src/mesa/drivers
brw_draw_prims needs to be refactored prior to
ARB_indirect_parameters implementation.
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_draw.c | 343 +++
1 file changed, 189 insertions(+), 154 deletions(-)
diff --git a/src/mesa/drivers/dri/i965
We can implement ARB_indirect_parameters for i965 by
taking advantage of the conditional rendering mechanism.
This works by issuing maxdrawcount draw calls and using
conditional rendering to predicate each of them with
"drawcount > gl_DrawID"
Signed-off-by: Plamena Manolova
---
src
ARB_texture_filter_anisotropic is the ARB variation of
EXT_texture_fitter_anisotropic and it operates in the
same way, so there's no reason not to advertise it.
Signed-off-by: Plamena Manolova
---
src/mesa/main/extensions_table.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa
ARB_polygon_offset_clamp is just the ARB variation
of EXT_polygon_offset_clamp and they operate in an
identical manner, so there's no reason for us not
to advertise it.
Signed-off-by: Plamena Manolova
---
src/mesa/main/extensions_table.h | 1 +
1 file changed, 1 insertion(+)
diff --git
In prepare_target it's plausible that the parameters of
_mesa_lookup_texture might be invalid and NULL is returned,
so we need a NULL pointer check.
CID: 1412566
Signed-off-by: Plamena Manolova
---
src/mesa/main/copyimage.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
In blit_framebuffer we're already doing a NULL
pointer check for readFb and drawFb so it makes
sense to do it before we actually use the pointers.
CID: 1412569
Signed-off-by: Plamena Manolova
---
src/mesa/main/blit.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
In frame_buffer_texture it's plausible that the parameters of
get_framebuffer_target might be invalid and NULL is returned,
so we need a NULL pointer check.
CID: 1412565
Signed-off-by: Plamena Manolova
---
src/mesa/main/fbobject.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src
Adds suppport for ARB_fragment_shader_interlock. We achieve
the interlock and fragment ordering by issuing a memory fence
via sendc.
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/17.1.0.html| 1 +
src/intel/compiler
e that the
critical section of the fragment shader will be executed for
only one fragment at a time.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 10 +++
src/compiler/glsl/ast_to_hir.cpp | 21 ++
src/compiler/glsl/ast_type.cpp
off-by: Plamena Manolova
---
docs/features.txt | 2 +-
docs/relnotes/17.0.0.html | 1 +
src/mesa/drivers/dri/i965/brw_defines.h | 8 +++
src/mesa/drivers/dri/i965/brw_sampler_state.c | 31 ++--
src/mesa/drivers/dri/i965/brw_s
s/EXT/EXT_compressed_ETC1_RGB8_sub_texture.txt
Note: OES_compressed_ETC1_RGB8_sub_texture seems to be listed
in gl2ext.h, but there's no documentation for it in the KHR
registry
Signed-off-by: Plamena Manolova
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/teximage.c | 1 -
2 files changed, 1
/EXT_compressed_ETC1_RGB8_sub_texture.txt
Note: OES_compressed_ETC1_RGB8_sub_texture seems to be listed
in gl2ext.h, but there's no documentation for it in the KHR
registry
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
src/mesa/main/extensions_table.h | 1 +
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
docs/features.txt| 2 +-
docs/relnotes/13.1.0.html
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 5 +
src/compiler/glsl/ast_to_hir.cpp
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
docs/relnotes/13.1.0.html| 1 +
src/mesa/drivers/dri/i965/brw_compiler.h
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 5 +
src/compiler/glsl/ast_to_hir.cpp
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_compiler.h | 1 +
src/mesa/drivers/dri/i965/brw_fs.cpp
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/compiler/glsl/ast.h | 5 +
src/compiler/glsl/ast_to_hir.cpp
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_compiler.h | 1 +
src/mesa/drivers/dri/i965/brw_fs.cpp
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
src/compiler/shader_info.h | 1 +
src/mesa/main/shaderapi.c | 1 +
2 files changed, 2
This extension allows the fragment shader to control whether values in
gl_SampleMaskIn[] reflect the coverage after application of the early
depth and stencil tests.
Signed-off-by: Plamena Manolova
---
include/GL/glext.h | 4
src/compiler/glsl/ast.h
When validating attributes during surface creation we should account
for the default values of texture target and format (EGL_NO_TEXTURE)
since the user is not obligated to explicitly set both via the
attribute list passed to eglCreatePbufferSurface.
Signed-off-by: Plamena Manolova
---
src/egl
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
Reviewed-by: Brian Paul
---
src/egl/main/eglapi.c
the dEQP-EGL.functional.negative_api.create_pbuffer_surface test.
Signed-off-by: Plamena Manolova
Reviewed-by: Ben Widawsky
---
src/egl/main/eglsurface.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c
index 2971bb0
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c
the dEQP-EGL.functional.negative_api.create_pbuffer_surface test.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglsurface.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c
index 2971bb0..d6b8083
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglcurrent.h | 33 ++---
1
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c | 2 ++
src/egl/main/eglcurrent.h
GLES should be
disregarded and "OpenGL_ES" should be attached once instead of
"OpenGL_ES2" and "OpenGL_ES3".
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c
We should check whether check_explicit_uniform_locations has
failed before we pass the number of explicit uniform locations
to link_assign_uniform_locations.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94549#c3
---
src/compiler/glsl/linker.cpp | 7 ++-
1 file changed, 6 insertions(
Signed-off-by: Plamena Manolova
---
src/mesa/main/enable.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
index 3985457..b90a60b 100644
--- a/src/mesa/main/enable.c
+++ b/src/mesa/main/enable.c
@@ -105,6 +105,8 @@ client_state(struct
tps://bugs.freedesktop.org/show_bug.cgi?id=42187
Signed-off-by: Plamena Manolova
---
src/mesa/main/enable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
index 3985457..ecc04f4 100644
--- a/src/mesa/main/enable.c
+++ b/src/mesa/main/enable.c
@@ -105,6 +10
Signed-off-by: Plamena Manolova
---
src/mesa/drivers/dri/i965/brw_sf_state.c | 19 +++
src/mesa/drivers/dri/i965/gen6_sf_state.c | 23 +--
src/mesa/drivers/dri/i965/gen7_sf_state.c | 17 ++---
src/mesa/drivers/dri/i965/gen8_sf_state.c | 17
-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array
Signed-off-by: Tapani Pälli
Signed-off-by: Plamena Manolova
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696
---
src/compiler/glsl/link_uniforms.cpp | 80 -
src/compiler/glsl/linker.cpp
-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array
Signed-off-by: Tapani Pälli
Signed-off-by: Plamena Manolova
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696
---
src/compiler/glsl/link_uniforms.cpp | 85 -
src/compiler/glsl/linker.cpp
-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array
Signed-off-by: Tapani Pälli
Signed-off-by: Plamena Manolova
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696
---
src/compiler/glsl/link_uniforms.cpp | 79 -
src/compiler/glsl/linker.cpp
66 matches
Mail list logo
