Re: [Mesa-dev] [PATCH] mesa: remove DummyShader from atifragshader.c

On 24/01/18 17:16, Emil Velikov wrote: On 20 December 2017 at 16:33, Miklós Máté wrote: It's much cleaner to allocate a normal shader struct when GenFragmentShadersATI is called. Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 21 ++--- 1 file change

Re: [Mesa-dev] [PATCH] mesa: remove DummyShader from atifragshader.c

Could someone please take a look at this patch? MM On 20/12/17 17:33, Miklós Máté wrote: It's much cleaner to allocate a normal shader struct when GenFragmentShadersATI is called. Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 21 ++--- 1 file change

[Mesa-dev] [PATCH] mesa: remove DummyShader from atifragshader.c

It's much cleaner to allocate a normal shader struct when GenFragmentShadersATI is called. Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa

Re: [Mesa-dev] [PATCH 9/9] mesa: always compare optype with symbolic name in ATI_fs

Thanks for the review. I'll also need somebody to commit these, because I have no access. MM On 11/12/17 19:50, Marek Olšák wrote: For the series: Reviewed-by: Marek Olšák Marek On Sat, Dec 2, 2017 at 11:35 PM, Miklós Máté wrote: Signed-off-by: Miklós Máté --- src/mesa

[Mesa-dev] [PATCH 7/9] mesa: move ATI_fs state compile changes after the error checks

Both in setup and arithmetic instructions. Also, remove the useless new_*_inst() functions, and refactor check_arith_arg(), because it did two completely different things. Piglit: spec/ati_fragment_shader/error04-endshader Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 107

[Mesa-dev] [PATCH 9/9] mesa: always compare optype with symbolic name in ATI_fs

Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index 8538e3a53e..6b636f1dc7 100644 --- a/src/mesa/main/atifragshader.c +++ b/src/mesa/main

[Mesa-dev] [PATCH 8/9] mesa: document ati_fragment_shader::cur_pass and swizzlerq

Signed-off-by: Miklós Máté --- src/mesa/main/mtypes.h | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0e8a05359a..8c8151c496 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2390,10 +2390,14 @@ struct

[Mesa-dev] [PATCH 0/9] Fixes for ATI_fragment_shader

These are fixes for the problems my Piglit tests uncovered so far. After this series all gallium drivers (I could only test softpipe, llvmpipe and radeonsi) and swrast should pass all tests. Unfortunately I can't test on r200. Miklós Máté (9): mesa: add fallback texture for SampleMapA

[Mesa-dev] [PATCH 2/9] mesa: fix crash when an ATI_fs pass begins with an alpha inst

This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst, second pass begins with alpha inst Also, use the symbolic name instead of a number. Piglit: spec/ati_fragment_shader/api-alphafirst v2: fixed formatting Signed-off-by: Miklós Máté --- src/mesa/main

[Mesa-dev] [PATCH 5/9] mesa: fix not having secondary color in ATI_fs in swrast

ATI_fs in swrast only had secondary color if GL_COLOR_SUM was enabled. This patch probably fixes the same issue in r200. Piglit: spec/ati_fragment_shader/render-sources and render-precedence Signed-off-by: Miklós Máté --- src/mesa/main/state.h | 17 ++--- 1 file changed, 10

[Mesa-dev] [PATCH 4/9] mesa: fix validate for secondary interpolator

error msg Piglit: spec/ati_fragment_shader/error08-secondary v2: fixed formatting, added spec quotations Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 1/9] mesa: add fallback texture for SampleMapATI if there is nothing

This fixes crash in the state tracker. Piglit: spec/ati_fragment_shader/render-notexture v2: fixed formatting, moved stuff inside the loop, moved the fallback later to fix more cases Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 30 ++ 1 file

[Mesa-dev] [PATCH 6/9] tnl: fix not having texture coords in ATI_fs in swrast

ATI_fs in swrast only had access to texture coordinates if there was a valid texture bound and texturing was enabled. Piglit: spec/ati_fragment_shader/render-sources and render-notexture Signed-off-by: Miklós Máté --- src/mesa/tnl/t_context.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Mesa-dev] [PATCH 3/9] mesa: fix typo in ATI_fs dstMod error checking

Piglit: spec/ati_fragment_shader/error14-invalidmod Signed-off-by: Miklós Máté Reviewed-by: Ian Romanick --- src/mesa/main/atifragshader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index d61455e12f

Re: [Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

Hi, I've already prepared a patch that documents this, I was going to post it with the v2 of this series. My version looks like this: diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6b5c5bbb36..9c04a3c727 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

On 21/11/17 02:09, Ian Romanick wrote: On 11/20/2017 04:07 PM, Miklós Máté wrote: This patch fixes multiple problems: - the interpolator check was duplicated - both had arg instead of argRep - I split it into color and alpha for better readability and error msg - the DOT4 check only applies to

Re: [Mesa-dev] [PATCH 3/4] mesa: fix typo in ATI_fs dstMod error checking

On 21/11/17 01:51, Ian Romanick wrote: On 11/20/2017 04:07 PM, Miklós Máté wrote: Piglit: spec/ati_fragment_shader/error14-invalidmod Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH 1/4] mesa: mesa: add fallback texture for SampleMapATI if there is nothing

On 21/11/17 01:27, Ian Romanick wrote: Only need one mesa: in the subject. :) On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash in the state tracker. Piglit: spec/ati_fragment_shader/render-notexture Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 35

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

On 21/11/17 03:04, Roland Scheidegger wrote: Am 21.11.2017 um 01:40 schrieb Ian Romanick: On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst, second pass begins with alpha inst Also, use the symbolic name

[Mesa-dev] [PATCH 3/4] mesa: fix typo in ATI_fs dstMod error checking

Piglit: spec/ati_fragment_shader/error14-invalidmod Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index d6fc37ac8f..313ba0c66d 100644 --- a/src/mesa

[Mesa-dev] [PATCH 0/4] Fixes for ATI_fragment_shader

These are fixes for the problems my WIP Piglit tests uncovered so far. After this series gallium drivers should pass all tests, but swrast has some issues that I'm still working on. Unfortunately I can't test on r200. Miklós Máté (4): mesa: mesa: add fallback texture for SampleMapAT

[Mesa-dev] [PATCH 1/4] mesa: mesa: add fallback texture for SampleMapATI if there is nothing

This fixes crash in the state tracker. Piglit: spec/ati_fragment_shader/render-notexture Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index

[Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst, second pass begins with alpha inst Also, use the symbolic name instead of a number. Piglit: spec/ati_fragment_shader/api-alphafirst Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 6

[Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

error msg Piglit: spec/ati_fragment_shader/error08-secondary Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index 313ba0c66d

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

On 12/11/17 00:06, Timothy Arceri wrote: On 12/11/17 04:10, Miklós Máté wrote: Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. Thanks for testing :) Is there

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

Combining the two reduces code and make it easier to follow. Cc: Miklós Máté --- NOTE: compile tested only. src/mesa/drivers/common/driverfuncs.c | 3 - src/mesa/drivers/dri/r200/r200_context.h| 2 +- src/mesa/drivers/dri/r200/r200_fragshader.c | 86 ++--- src/me

Re: [Mesa-dev] [PATCH] st/atifs: remove unrequired initialisation of gl_program fields

Reviewed-by: Miklós Máté MM On 10/11/17 09:49, Timothy Arceri wrote: As far as I can tell these fields are only used to query arb program info and are not related to ATI_fragment_shader. Cc: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 1 file changed, 4 deletions

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

On 03/11/17 11:04, Nicolai Hähnle wrote: On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete

[Mesa-dev] [PATCH] mesa: fix deleting the dummy ATI_fs

ld not assert on DummyShader, just remove the hash entry. Normally one would define a shader after GenFragmentShadersATI(), and BindFragmentShaderATI() replaces the placeholder with a real object. However, the specification doesn't say that one has to define a shader for each allocated ID. Signe

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete / delete[] / realloc() ==15060==    at 0x482F478: free (vg_replace_malloc.c:530

[Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

atch also fixes this: name=glGenFragmentShadersATI(1); glDeleteFragmentShaderATI(name); Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index 27d8b86

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

On 16/10/17 01:59, Timothy Arceri wrote: On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowin

Re: [Mesa-dev] [PATCH] configure.ac: set -O0 on --enable-debug

On 16/10/17 13:21, Emil Velikov wrote: Hi Miklós, On 15 October 2017 at 18:46, Miklós Máté wrote: Autoconf sets CFLAGS="-g -O2" by default. Signed-off-by: Miklós Máté --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index

[Mesa-dev] [PATCH] configure.ac: set -O0 on --enable-debug

Autoconf sets CFLAGS="-g -O2" by default. Signed-off-by: Miklós Máté --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 62d33a1941..c833d258ed 100644 --- a/configure.ac +++ b/configure.ac @@ -522,6 +522,8 @@ if test "x$enabl

[Mesa-dev] [PATCH] st/mesa: set dimension for constants in ATI_fragment_shader

This fixes an assertion failure introduced by 30a2f0dfd46de. Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c b/src/mesa/state_tracker/st_atifs_to_tgsi.c index 2a171b5a84

[Mesa-dev] [PATCH] main: remove redundant NULL check

update_single_program_texture() never returns NULL. Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index edd2253731..776806d632 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the texture targets until the draw call. When an ATI_fs is created, st_init_atifs_prog()

Re: [Mesa-dev] MESA and KOTOR

Hello! I'm sorry for being late to the party. The patch you linked did land in mesa: https://cgit.freedesktop.org/mesa/mesa/commit/?id=baab345b192d207236253ce67b320fb32fa67625 However, that area of the code has since been altered a lot. Back then I made sure that KOTOR ran perfectly with Win

Re: [Mesa-dev] [PATCH 2/8] radeonsi: do EarlyCSEMemSSA LLVM pass

On 05/06/17 18:50, Marek Olšák wrote: From: Marek Olšák so that LLVM IR looks like CSE has been run on it. It's also recommended by the instruction combining pass. This also fixes: - GL45-CTS.arrays_of_arrays_gl.InteractionFunctionCalls2 (crash) - piglit/spec/arb_shader_ballot/execution/fs-rea

Re: [Mesa-dev] [PATCH 1/2] st/mesa: remove the "Gallium 0.4 on" prefix from GL_RENDERER

On 08/06/17 05:17, Timothy Arceri wrote: On 08/06/17 12:04, Michel Dänzer wrote: On 08/06/17 05:09 AM, Marek Olšák wrote: From: Marek Olšák If you want to keep it for your driver, please raise your hand. The prefix will probably have to be added into the driver instead of here. I cringe wh

Re: [Mesa-dev] MESA and KOTOR

Hi, I took a look at the wgl code and I think the problem is that MakeCurrent fails if the pixel format of the context and the pbuffer don't match. The main window is double-buffered, so I guess the context is also double-buffered, but the pbuffers are single-buffered and they have no depth o

Re: [Mesa-dev] [PATCH 2/3] st/wgl: add support for WGL_ARB_make_current_read

Hi, On 24/03/17 22:42, Brian Paul wrote: This adds the wglMakeContextCurrentARB() and wglMakeContextCurrentARB() One of these should be wglGetCurrentReadDCARB(). functions. --- src/gallium/state_trackers/wgl/stw_context.c | 77 ++ src/gallium/state_trackers/wgl/st

Re: [Mesa-dev] [PATCH 1/3] stw/wgl: add null context check in wglBindTexImageARB()

On 24/03/17 22:42, Brian Paul wrote: To avoid dereferencing a null pointer in case wglMakeCurrent() wasn't called. Found while debugging SWKOTOR game. Reviewed-by: Neha Bhende Reviewed-by: Charmaine Lee --- src/gallium/state_trackers/wgl/stw_ext_rendertexture.c | 6 ++ 1 file changed,

Re: [Mesa-dev] [PATCH] mesa: set thread name for glthread

Thank you for the review. Could someone please commit this? I have no access. MM On 20/03/17 17:36, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Sat, Mar 18, 2017 at 10:55 PM, Miklós Máté wrote: Signed-off-by: Miklós Máté --- src/mesa/main/glthread.c | 3 +++ 1 file changed

Re: [Mesa-dev] [PATCH 0/2] Compilation fixes for mingw

On 19/03/17 22:13, Emil Velikov wrote: Hi Miklós, On 19 March 2017 at 12:28, Miklós Máté wrote: After this series the build goes further, but eventually stops with: scons: Building targets ... Archiving build\windows-x86-debug\gallium\auxiliary\libgallium.a ... Installing build\windows

Re: [Mesa-dev] MESA and KOTOR

mplemented wglBindTexImageARB as a zero-copy render-to-texture method (as it was originally meant to be), the performance would be better. This issue is not new: a guy named Miklós Máté, here in the Mesa mailing list somehow managed to fix it in Mesa 11, but his patches do not seem to work any

[Mesa-dev] [PATCH 2/2] c11: comment out thrd_equal()

unused, and mingw doesn't have GetThreadId() Signed-off-by: Miklós Máté --- include/c11/threads_win32.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/c11/threads_win32.h b/include/c11/threads_win32.h index 649baa1ee8..83ecce24f3 100644 --- a/include/c11/threads_win32.h

[Mesa-dev] [PATCH 1/2] c11: fix include with mingw

uintprt_t needs this Signed-off-by: Miklós Máté --- include/c11/threads_win32.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/c11/threads_win32.h b/include/c11/threads_win32.h index d017c31c34..649baa1ee8 100644 --- a/include/c11/threads_win32.h +++ b/include/c11/threads_win32.h

[Mesa-dev] [PATCH 0/2] Compilation fixes for mingw

. Unfortunately, my buildsystem knowledge is too weak for this. Miklós Máté (2): c11: fix include with mingw c11: comment out thrd_equal() include/c11/threads_win32.h | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [PATCH] mesa: set thread name for glthread

Signed-off-by: Miklós Máté --- src/mesa/main/glthread.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c index 623266f484..06115b916d 100644 --- a/src/mesa/main/glthread.c +++ b/src/mesa/main/glthread.c @@ -36,6 +36,7 @@ #include "

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

On 26/08/16 21:17, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 3:08 PM, Miklós Máté wrote: On 08/26/2016 07:47 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

On 09/13/2016 04:26 AM, Romain Failliot wrote: Hi! I've just bought myself an RX 480 (because of the open source drivers). I have Fedora 24 with GNOME 3.20, linux 4.7.2, mesa 12.0.2, llvm 3.8.0. I tested Alien: Isolation (that I couldn't even launch with my old HD 6870), but there is a texture

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

On 08/26/2016 07:47 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa rejects them, because the

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa rejects them, because the local size qualifiers require 430. Signed-off-by: Miklós Máté --- src/compiler/glsl

[Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa rejects them, because the local size qualifiers require 430. Signed-off-by: Miklós Máté --- src/compiler/glsl/glsl_parser.yy | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl

Re: [Mesa-dev] [PATCH] vbo: set draw_id

On 08/26/2016 02:53 PM, Brian Paul wrote: On 08/26/2016 06:48 AM, Miklós Máté wrote: Fixes conditional jump depending on uninitialized value in si_state_draw.c:593 Cc: Signed-off-by: Miklós Máté --- src/mesa/vbo/vbo_exec_array.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src

[Mesa-dev] [PATCH] vbo: set draw_id

Fixes conditional jump depending on uninitialized value in si_state_draw.c:593 Cc: Signed-off-by: Miklós Máté --- src/mesa/vbo/vbo_exec_array.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 1997039..46543f8 100644 --- a

Re: [Mesa-dev] Possible memory leak with `glxMakeCurrent`?

On 08/18/2016 05:08 AM, Michel Dänzer wrote: On 18/08/16 05:39 AM, Itai wrote: (Posted initially in mesa-users, but got no reply - the list seems dead. Couldn't find any bug report, and sadly not well versed enough in mesa to file one myself). FWIW, there's no need to be versed in Mesa to file

Re: [Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

On 08/04/2016 06:51 PM, Brian Paul wrote: On 08/04/2016 10:40 AM, Miklós Máté wrote: On 07/14/2016 10:43 PM, Miklós Máté wrote: On 07/07/2016 07:11 PM, Miklós Máté wrote: On 06/26/2016 09:48 PM, Miklós Máté wrote: Only include the ones that can be used by the shader. This fixes texture

Re: [Mesa-dev] [PATCH] st/mesa: in ATI fs don't assume TEMP0=REG0

Thanks. I forgot to add that this should also be applied to the 12.0 stable branch. MM On 08/10/2016 03:07 PM, Marek Olšák wrote: Pushed, thanks. Marek On Mon, Aug 8, 2016 at 12:48 AM, Miklós Máté wrote: The temporaries are allocated dynamically. Signed-off-by: Miklós Máté --- src

Re: [Mesa-dev] [PATCH] mesa: simplify ff fs generator a bit

On 08/08/2016 04:15 PM, Brian Paul wrote: On 08/06/2016 03:34 PM, Miklós Máté wrote: Literally. Signed-off-by: Miklós Máté --- src/mesa/main/ff_fragment_shader.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src

[Mesa-dev] [PATCH] st/mesa: in ATI fs don't assume TEMP0=REG0

The temporaries are allocated dynamically. Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c b/src/mesa/state_tracker/st_atifs_to_tgsi.c index 66f442a

[Mesa-dev] [PATCH] mesa: simplify ff fs generator a bit

Literally. Signed-off-by: Miklós Máté --- src/mesa/main/ff_fragment_shader.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index b0ce8c4..ad3d666 100644 --- a/src/mesa/main

Re: [Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

On 07/14/2016 10:43 PM, Miklós Máté wrote: On 07/07/2016 07:11 PM, Miklós Máté wrote: On 06/26/2016 09:48 PM, Miklós Máté wrote: Only include the ones that can be used by the shader. This fixes texture coordinates, which were completely wrong, because WPOS was included in the list of attribs

Re: [Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

On 07/07/2016 07:11 PM, Miklós Máté wrote: On 06/26/2016 09:48 PM, Miklós Máté wrote: Only include the ones that can be used by the shader. This fixes texture coordinates, which were completely wrong, because WPOS was included in the list of attribs. It also increases performance noticeably

Re: [Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

On 06/26/2016 09:48 PM, Miklós Máté wrote: Only include the ones that can be used by the shader. This fixes texture coordinates, which were completely wrong, because WPOS was included in the list of attribs. It also increases performance noticeably. Signed-off-by: Miklós Máté --- src/mesa

[Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

Only include the ones that can be used by the shader. This fixes texture coordinates, which were completely wrong, because WPOS was included in the list of attribs. It also increases performance noticeably. Signed-off-by: Miklós Máté --- src/mesa/swrast/s_context.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

On 05/20/2016 05:42 PM, Ilia Mirkin wrote: On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: From: Marek Olšák This allows drivers to use their own fast path for texture uploads. --- src/mesa/state_tracker/st_cb_texture.c | 43

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 08:50 PM, Ian Romanick wrote: On 04/07/2016 10:57 AM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 07:57 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel D

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel Dänzer" wrote: On 07.04.2016 18:01, Marek Olšák wrote: On Thu, Apr 7, 2016 at 7:32 AM, Ian Roman

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel Dänzer" > wrote: > > On 07.04.2016 18:01, Marek Olšák wrote: > > On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick > wrote: > >> Why would you do that? I've NAKe

Re: [Mesa-dev] [PATCH 5/8] main: rework the compatibility check of visuals in glXMakeCurrent

On 04/06/2016 12:52 PM, Marek Olšák wrote: This looks good to me. I'll commit this on April 9th if there are other comments. Marek Thanks for not forgetting this. MM On Thu, Mar 24, 2016 at 1:12 AM, Miklós Máté wrote: Now it follows the compatibility criteria listed in section 2.1 o

Re: [Mesa-dev] [PATCH] mesa/st: Fix NULL access if no fragment shader is bound

On 03/28/2016 05:01 PM, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/mesa/state_tracker/st_atom_constbuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index

[Mesa-dev] [PATCH 4/8] st/mesa: enable GL_ATI_fragment_shader

Signed-off-by: Miklós Máté --- docs/relnotes/11.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.3.0.html b/docs/relnotes/11.3.0.html index 04564a8..0a1ecbf 100644 --- a/docs/relnotes/11.3.0.html +++ b/docs

[Mesa-dev] [PATCH 2/8] program: add ATI_fragment_shader to shader stages list

Signed-off-by: Miklós Máté --- src/mesa/program/program.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/program/program.h b/src/mesa/program/program.h index 24e0597..09e6928 100644 --- a/src/mesa/program/program.h +++ b/src/mesa/program/program.h @@ -172,6 +172,8

[Mesa-dev] [PATCH 5/8] main: rework the compatibility check of visuals in glXMakeCurrent

Now it follows the compatibility criteria listed in section 2.1 of the GLX 1.4 specification. This is needed for post-process effects in SW:KotOR. Signed-off-by: Miklós Máté --- src/mesa/main/context.c | 42 -- 1 file changed, 12 insertions(+), 30

[Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

characters in SW:KotOR when soft shadows are enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93955 Signed-off-by: Miklós Máté --- src/glx/dri_common.c | 3 ++- src/glx/glx_pbuffer.c | 8 ++-- src/glx/glxcmds.c | 8 ++-- 3 files changed, 14 insertions(+), 5 deletions

[Mesa-dev] [PATCH 1/8] mesa: optionally associate a gl_program to ATI_fragment_shader

the state tracker will use it Acked-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 5 + src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 6/8] st/mesa: fix handling the fallback texture

This fixes crash when post-processing is enabled in SW:KotOR. v2: fix const-ness v3: move assignment into the if() block Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atom_sampler.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker

[Mesa-dev] [PATCH 8/8] mesa: optimize out the realloc from glCopyTexImagexD()

v2: comment about the purpose of the code v3: also compare texFormat, add a perf debug message, formatting fixes Reviewed-by: Ian Romanick Signed-off-by: Miklós Máté --- src/mesa/main/teximage.c | 36 1 file changed, 36 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 0/8] Fixes for SW:KotOR (v4)

d at maximum graphical settings. MM Miklós Máté (8): mesa: optionally associate a gl_program to ATI_fragment_shader program: add ATI_fragment_shader to shader stages list st/mesa: implement GL_ATI_fragment_shader st/mesa: enable GL_ATI_fragment_shader main: rework the compatibility chec

[Mesa-dev] [PATCH 3/8] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes v4: adapt to the compile early, fix later architecture, formatting fixes Signed-off-by: Miklós Máté

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 03/04/2016 12:11 AM, Miklós Máté wrote: On 02/25/2016 08:20 PM, Ian Romanick wrote: On 02/25/2016 07:48 AM, Brian Paul wrote: On 02/25/2016 08:26 AM, Miklós Máté wrote: On 02/25/2016 02:37 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/25/2016 08:20 PM, Ian Romanick wrote: On 02/25/2016 07:48 AM, Brian Paul wrote: On 02/25/2016 08:26 AM, Miklós Máté wrote: On 02/25/2016 02:37 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. Can you elaborate on that a bit

Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

On 02/25/2016 10:01 PM, Marek Olšák wrote: On Thu, Feb 25, 2016 at 9:31 PM, Miklós Máté wrote: I noticed that this has been reviewed, but has not been committed. Does it require further action from me, or was it just forgotten? Ideally you would ask somebody to push the patch for you. I'

Re: [Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

On 02/25/2016 07:38 PM, Ian Romanick wrote: On 02/24/2016 05:37 PM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: the state tracker will use it Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13

Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

I noticed that this has been reviewed, but has not been committed. Does it require further action from me, or was it just forgotten? MM On 02/03/2016 10:06 AM, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: It was already done in

Re: [Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

On 02/25/2016 02:40 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: This fixes post-processing in SW:KotOR. Can you elaborate on exactly what's happening and why this change fixes things? Sometimes no texture is bound during the post-processing, which results in ms

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/25/2016 02:37 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. Can you elaborate on that a bit? Section 2.1 of the GLX spec lists a few criteria for a context and a drawable to be compatible. This fixes post-processing in

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 02:37 AM, Brian Paul wrote: I think this patch could be broken up a bit... Yes, I agree that this is very long, but I couldn't decide on how to split it up. On 02/24/2016 04:35 PM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, clean

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 11:40 AM, Marek Olšák wrote: On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes

[Mesa-dev] [PATCH 6/7] glx: fix the refcounting of dri drawables

characters in KotOR when soft shadows are enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93955 Signed-off-by: Miklós Máté --- src/glx/dri_common.c | 3 ++- src/glx/glx_pbuffer.c | 8 ++-- src/glx/glxcmds.c | 8 ++-- 3 files changed, 14 insertions(+), 5 deletions

[Mesa-dev] [PATCH 3/7] st/mesa: enable GL_ATI_fragment_shader

Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 24c6444..6d0c200 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa

[Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v3)

are fixed by the following Wine patch: https://www.winehq.org/pipermail/wine-patches/2016-February/147513.html MM Miklós Máté (7): mesa: optionally associate a gl_program to ati_fragment_shader st/mesa: implement GL_ATI_fragment_shader st/mesa: enable GL_ATI_fragment_shader main: rework

[Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

Now it follows the GLX 1.4 specification. This fixes post-processing in SW:KotOR. Signed-off-by: Miklós Máté --- src/mesa/main/context.c | 42 -- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main

[Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

This fixes post-processing in SW:KotOR. v2: fix const-ness Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atom_sampler.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c b/src/mesa/state_tracker/st_atom_sampler.c index

[Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes Signed-off-by: Miklós Máté --- src/mesa/Makefile.sources | 1 + src/mesa/main

[Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

the state tracker will use it Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 7 ++- src/mesa/main/mtypes.h| 1 + src/mesa/main/state.c

[Mesa-dev] [PATCH 7/7] mesa: optimize out the realloc from glCopyTexImagexD()

v2: comment about the purpose of the code v3: also compare texFormat, add a perf debug message, formatting fixes Signed-off-by: Miklós Máté --- src/mesa/main/teximage.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa

  1   2   >