[Mesa-dev] MR!2161: Some random warning fixes

Hey, just for visibility and maybe a quick merge: I sent MR!2161 () last week and would be much appreciated if somebody could click on that merge button. All changes are trivial and NFC. There is one open discussion, for which I could u

[Mesa-dev] [MR!1706] Bump C++ standard requirement to C++17 to fix FTBFS with LLVM 10

Hey, I sent an MR to fix a build failure with LLVM 10 (). Comments and merge welcome. 😉 (Can I add labels myself, I don't think so?) Cheers, Kai signature.asc Description: OpenPGP digital signature __

[Mesa-dev] autotools/meson transition: meson uses hardcoded list of llvm-config binaries, FTBFS with new upstream LLVM (development) versions

Hey, I just discovered that meson hardcodes the list of llvm-config binary names to try in mesonbuild/dependencies/dev.py, line 214ff ([0]). This is breaking now since LLVM upstream switched to version 9 and branched version 8 of to become a stable release soon. See [1] for the upstream ticket I fi

Re: [Mesa-dev] last call for autotools

Hey Dylan, Dylan Baker wrote on 11.12.18 00:10: > Meson 0.49.0 has been out for a couple of days now, and I'd like to make the > final call for autotools. My patch is so massive that it's a huge pain to send > to the list, the latest versions is here: > https://gitlab.freedesktop.org/dbaker/mesa/co

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build after clang r348827

e, you can have my: Reviewed-by: Kai Wasserbäch Cheers, Kai > --- > src/gallium/state_trackers/clover/llvm/compat.hpp | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp > b/src/gallium/state_tra

Re: [Mesa-dev] [PATCH] clover: Fix include of CodeGenOptions.h, upstream moved it in r348827

Hey, I'm just noticing, that there's also a bug report for this, so please add Bugzilla: https://bugs.freedesktop.org/109039 before commiting this, in case you accept it (I don't have commit access). Cheers, Kai Kai Wasserbäch wrote on 14.12.18 17:26: > Signed-off-

[Mesa-dev] [PATCH] clover: Fix include of CodeGenOptions.h, upstream moved it in r348827

Signed-off-by: Kai Wasserbäch --- src/gallium/state_trackers/clover/llvm/compat.hpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp b/src/gallium/state_trackers/clover/llvm/compat.hpp index 975012cbda..9c5b9d8917 100644 --- a/src/gallium

Re: [Mesa-dev] Lets talk about autotools

Hey Dylan, Dylan Baker wrote on 19.11.18 20:02: > Sorry, cell phones are really bad for responding to email... no worries. > The file has the same rules as cross files, it can be a local file, passed as > an > absolute path, or read from $XDG directories (local files will be read before > XDG on

Re: [Mesa-dev] Lets talk about autotools

Hey Dylan, Dylan Baker wrote on 17.11.18 05:04: > Quoting Dylan Baker (2018-09-17 09:44:07) >> I feel like for !windows meson is in good enough shape at this point that we >> can start having the discussion about deleting the autotools build. So, is >> there >> anything left that autotools can do

Re: [Mesa-dev] Lets talk about autotools

Hey Dylan, Dylan Baker wrote on 9/19/18 6:24 PM: > Quoting Kai Wasserbäch (2018-09-19 08:04:35) > [...] >> In any case, thanks for your replies. I'll see if I can scare up some time >> over >> the weekend and check if I can get Mesa building with meson. Neverthele

Re: [Mesa-dev] Lets talk about autotools

Hey Dylan, Dylan Baker wrote on 9/18/18 10:43 PM: > Quoting Kai Wasserbäch (2018-09-18 11:14:19) >> Dylan Baker wrote on 9/18/18 6:40 PM: >>> Quoting Kai Wasserbäch (2018-09-18 08:56:30) >>>> Dylan Baker wrote on 9/18/18 5:35 PM: >>>>> [...] >&g

Re: [Mesa-dev] Lets talk about autotools

Dylan Baker wrote on 9/18/18 6:40 PM: > Quoting Kai Wasserbäch (2018-09-18 08:56:30) >> Dylan Baker wrote on 9/18/18 5:35 PM: >>> [...] >>> >>> This is something we've discussed upstream several times. I will freely >>> admit >>> that l

Re: [Mesa-dev] Lets talk about autotools

Dylan Baker wrote on 9/18/18 5:35 PM: > Quoting Kai Wasserbäch (2018-09-18 07:43:08) >> Hey, >> Dylan Baker wrote on 9/17/18 6:44 PM: >>> I feel like for !windows meson is in good enough shape at this point that we >>> can start having the discussion about del

Re: [Mesa-dev] Lets talk about autotools

Hey, Dylan Baker wrote on 9/17/18 6:44 PM: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there > anything left that autotools can do that meson cannot (that we actually want > to > impl

Re: [Mesa-dev] [PATCH] intel: tools: Fix aubinator_error's fprintf call (format-security)

Hey Lionel, Lionel Landwerlin wrote on 8/25/18 5:50 PM: > On 25/08/2018 11:00, Kai Wasserbäch wrote: >> The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced >> the new function aubinator_error() which is a trivial wrapper around >> fprintf() to STDERR

[Mesa-dev] [PATCH] intel: tools: Fix aubinator_error's fprintf call (format-security)

This patch fixes this trivially by introducing a catch-all "%s" format argument. Fixes: 4616639b49b ("intel: tools: split aub parsing from aubinator") Cc: Lionel Landwerlin Signed-off-by: Kai Wasserbäch --- Hey, just tried compiling the latest ver

Re: [Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

#include "c99_compat.h" > ^~ > compilation terminated. > > Signed-off-by: Mariusz Ceier please add: Fixes 15ca5ce99a (amd/addrlib: mark returnCode as MAYBE_UNUSED in) and you can have my Acked-by: Kai Wasserbäch No R-b from me, because I have never

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

Kai Wasserbäch wrote on 8/22/18 5:19 PM: > Hey Marek, > Marek Olšák wrote on 8/22/18 3:13 AM: >> Get you send me a "git fetch" line that I can use to download your patches? > > sure. I rebased them on top of the current master and pushed the five patches >

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

2 for you to fetch changes up to 88f825e915cd3d52b13489633e1c805bf2cf765b: amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled (2018-08-22 17:08:04 +0200) ---- Kai Wasserbäch (

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

Hey Marek, Marek Olšák wrote on 8/21/18 2:23 AM: > I've sent comments on patches 3 & 4. With those addressed, patches 1-5 are: > > Reviewed-by: Marek Olšák thanks for the review! I've just sent updated versions of patches 3 and 4. (Just as a side note: I only reindented the other variable defini

[Mesa-dev] [PATCH 04/12] amd/addrlib: mark numPipes as MAYBE_UNUSED in Addr::V1::EgBasedLib::SanityCheckMacroTiled (v2)

ng: unused variable 'numPipes' [-Wunused-variable] UINT_32 numPipes= HwlGetPipes(pTileInfo); ^~~~ v2: Don't realign other variable definitions, to keep in line with file style (Marek) Cc: Marek Olšák Signed-off-by: Kai Wasserbäch Reviewed-by: Marek Ol

[Mesa-dev] [PATCH 03/12] amd/addrlib: mark *pEqToCheck as MAYBE_UNUSED in Addr::V2::Gfx9Lib::ComputeStereoInfo (v2)

gn other variable definitions, to keep in line with file style (Marek) Cc: Marek Olšák Signed-off-by: Kai Wasserbäch Reviewed-by: Marek Olšák --- src/amd/addrlib/gfx9/gfx9addrlib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/addrlib/gfx9/gfx9addrli

Re: [Mesa-dev] [PATCH 00/12] Compiler warning fixes, round 2

Hey Linoel, Lionel Landwerlin wrote on 20.08.2018 11:19: > On 20/08/18 09:16, Kai Wasserbäch wrote: >> Lionel Landwerlin wrote on 19.08.2018 11:05: >>> Patches 6, 7, 10 & 11 are : >>> >>> Reviewed-by: Lionel Landwerlin >> thanks! Feel free to push

Re: [Mesa-dev] [PATCH 00/12] Compiler warning fixes, round 2

Hey Lionel, Lionel Landwerlin wrote on 19.08.2018 11:05: > Patches 6, 7, 10 & 11 are : > > Reviewed-by: Lionel Landwerlin thanks! Feel free to push, I don't have commit access (see cover letter). > There are 2 existing series touching the same code, in patches 8, 9 & 12, I > think should land b

[Mesa-dev] [PATCH 11/12] intel/decoder: mark total_length as MAYBE_UNUSED in gen_spec_load

iable] uint32_t text_offset = 0, text_length = 0, total_length; ^~~~ Signed-off-by: Kai Wasserbäch --- src/intel/common/gen_decoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.

[Mesa-dev] [PATCH 09/12] intel: aubinator: mark *res as MAYBE_UNUSED in get_ppgtt_batch_bo

ap((uint8_t *)bo.map + (page - bo.addr), 4096, PROT_READ, ^~~ Signed-off-by: Kai Wasserbäch --- src/intel/tools/aubinator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 96ac39248d..abdebba

[Mesa-dev] [PATCH 10/12] intel/tools: initialise bo_addr to 0 in main

Supresses a maybe-uninitialized warning with GCC 8. Signed-off-by: Kai Wasserbäch --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 2030593691..8a23d5ef1e 100644 --- a/src/intel

[Mesa-dev] [PATCH 08/12] intel: aubinator: mark *res as MAYBE_UNUSED in get_ggtt_batch_bo

ap((uint8_t *)bo.map + map_offset, 4096, PROT_READ, ^~~ Signed-off-by: Kai Wasserbäch --- src/intel/tools/aubinator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 66a7db1043..96ac39248d 100644 -

[Mesa-dev] [PATCH 02/12] amd/addrlib: mark microBlockDim as MAYBE_UNUSED in Addr::V2::Gfx9Lib::HwlComputeBlock256Equation

ATION*) const': ../../../src/amd/addrlib/gfx9/gfx9addrlib.cpp:2473:15: warning: variable 'microBlockDim' set but not used [-Wunused-but-set-variable] Dim2d microBlockDim = Block256_2d[elementBytesLog2]; ^ Cc: Marek Olšák Signed-off-by: Kai Wass

[Mesa-dev] [PATCH 12/12] intel/decoder: mark result as MAYBE_UNUSED in gen_field_iterator_next

bool result = iter_decode_field(iter); ^~~~~~ Signed-off-by: Kai Wasserbäch --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index c14c23aad1..0600449db6 100644 --

[Mesa-dev] [PATCH 04/12] amd/addrlib: mark numPipes as MAYBE_UNUSED in Addr::V1::EgBasedLib::SanityCheckMacroTiled

ng: unused variable 'numPipes' [-Wunused-variable] UINT_32 numPipes= HwlGetPipes(pTileInfo); ^~~~ Cc: Marek Olšák Signed-off-by: Kai Wasserbäch --- src/amd/addrlib/r800/egbaddrlib.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/

[Mesa-dev] [PATCH 00/12] Compiler warning fixes, round 2

sier to keep only one series active. Please review and, if you should accept these patches, please commit them for me, as I do not have commit access for Mesa. Cheers, Kai Kai Wasserbäch (12): amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm amd/addrlib: mark microBlockDim a

[Mesa-dev] [PATCH 06/12] intel/aubinator_error_decode: mark ret as MAYBE_UNUSED in main

sed-but-set-variable] int ret; ^~~ Signed-off-by: Kai Wasserbäch --- src/intel/tools/aubinator_error_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 4e3359bba9..d7f

[Mesa-dev] [PATCH 03/12] amd/addrlib: mark *pEqToCheck as MAYBE_UNUSED in Addr::V2::Gfx9Lib::ComputeStereoInfo

int*) const': ../../../src/amd/addrlib/gfx9/gfx9addrlib.cpp:3879:34: warning: unused variable 'pEqToCheck' [-Wunused-variable] const ADDR_EQUATION *pEqToCheck= &m_equationTable[eqIndex]; ^~ Cc: Marek O

[Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

~~~ Cc: Marek Olšák Signed-off-by: Kai Wasserbäch --- src/amd/addrlib/r800/egbaddrlib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/addrlib/r800/egbaddrlib.cpp b/src/amd/addrlib/r800/egbaddrlib.cpp index 37a60c7a85..edc7a13070 100644 --- a/src/amd/addrlib/r800/egba

[Mesa-dev] [PATCH 01/12] amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm

: variable 'returnCode' set but not used [-Wunused-but-set-variable] ADDR_E_RETURNCODE returnCode = ADDR_OK; ^~ Cc: Marek Olšák Signed-off-by: Kai Wasserbäch --- src/amd/Makefile.addrlib.am | 1 + src/amd/addrlib/addrinterface.cpp | 4 +++- 2 files c

[Mesa-dev] [PATCH 07/12] intel: aubinator: mark ftruncate_res as MAYBE_UNUSED in ensure_phys_mem

cate_res = ftruncate(mem_fd, mem_fd_len += 4096); ^~~~~ Signed-off-by: Kai Wasserbäch --- src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9a3b1d1ef1..66a7db1043 10

[Mesa-dev] [PATCH 4/4] amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm

: variable 'returnCode' set but not used [-Wunused-but-set-variable] ADDR_E_RETURNCODE returnCode = ADDR_OK; ^~~~~~ Signed-off-by: Kai Wasserbäch --- src/amd/Makefile.addrlib.am | 1 + src/amd/addrlib/addrinterface.cpp | 4 +++- 2 files changed, 4 inser

[Mesa-dev] [PATCH 2/4] nir: mark *prev_block as MAYBE_UNUSED in opt_peel_loop_initial_if

ir_block *prev_block = ^~~~~~ Signed-off-by: Kai Wasserbäch --- src/compiler/nir/nir_opt_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/nir/nir_opt_if.c index b3d0bf1dec..dacf2d6c66 100644 --- a/src/compi

[Mesa-dev] [PATCH 1/4] util: mark s as MAYBE_UNUSED in _mesa_half_to_unorm8

= (val >> 15) & 0x1; ^ Signed-off-by: Kai Wasserbäch --- src/util/half_float.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/half_float.c b/src/util/half_float.c index 2eff2c84f5..63aec5c5c1 100644 --- a/src/util/half_float.c +++ b/src/util/half_float

[Mesa-dev] [PATCH 3/4] vulkan/wsi: initialise image_index to 0 in x11_manage_fifo_queues

Supresses a maybe-uninitialized warning with GCC 8. Note: image_index should always be initialised due to the result check, but the compiler doesn't see that. Signed-off-by: Kai Wasserbäch --- src/vulkan/wsi/wsi_common_x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 0/4] Fix some compile warnings

Mesa. The commits can also be found on GitLab <https://gitlab.freedesktop.org/curan/mesa/commits/fix-some-warnings>. Cheers, Kai Kai Wasserbäch (4): util: mark s as MAYBE_UNUSED in _mesa_half_to_unorm8 nir: mark *prev_block as MAYBE_UNUSED in opt_peel_loop_initial_if vulkan/wsi:

Re: [Mesa-dev] [PATCH] mesa: Make sure that imm draws are flushed before other draws execute.

7 (7.0 devel) - X.Org: 2:1.19.6-1 - Linux: 4.16.13 - Firmware (firmware-amd-graphics): 20170823-1 - libclc: Git:master/a2118d58fc - DDX (xserver-xorg-video-amdgpu): 18.0.1-1 Therefore you can (still) have my Tested-by: Kai Wasserbäch Cheers, Kai signature.asc Descr

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Hey Jan, Jan Vesely wrote on 15.05.2018 04:50: > I've pushed the patch. thank you very much! I went ahead and closed the associated bug in the meantime. > I've also kept the stable tag although the > policy is (afaik) to only support llvm versions available at the point > of mesa release. Don't b

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Ping! Can somebody *please* commit this patch? It fixes an FTBFS, has two T-b and one A-b. Kai Wasserbäch wrote on 07.05.2018 16:48: > Jan Vesely wrote on 02.05.2018 22:38: >> On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: >>> [...] >> >> Thank for looki

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Jan Vesely wrote on 02.05.2018 22:38: > On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: >> [...] > > Thank for looking into this. We probably need CLANG_LIBS handling > similar to LLVM_LIBS. I agree this is the best fix for now. > > Acked-by: Jan Vesely >

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Hey Jan, Jan Vesely wrote on 01.05.2018 23:59: > On Tue, 2018-05-01 at 18:23 +0200, Kai Wasserbäch wrote: >> Jan Vesely wrote on 01.05.2018 17:19: >>> On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: >>>> [...] >>>> >>>> src/gallium/t

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Hey Jan, Jan Vesely wrote on 01.05.2018 17:19: > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: >> Otherwise the build fails with an undefined reference to >> clang::FrontendTimesIsEnabled. >> >> Bugzilla: https://bugs.freedesktop.org/106209 >> Cc: mesa-s

[Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Otherwise the build fails with an undefined reference to clang::FrontendTimesIsEnabled. Bugzilla: https://bugs.freedesktop.org/106209 Cc: mesa-sta...@lists.freedesktop.org Cc: Jan Vesely Signed-off-by: Kai Wasserbäch --- Hey, this patch fixes a FTBFS for me with recent LLVM/Clang 7 revisions

Re: [Mesa-dev] [PATCH] st/mesa: expose 0 shader binary formats for compat profiles for Qt

Hey Marek, you can have my Tested-by: Kai Wasserbäch for this patch. Test case: updating libLLVM.so without rebuilding Mesa or building a new kernel caused a white screen (plus correctly show mouse cursor) on the next launch of SDDM. Deleting the mesa_shader_cache and qtshadercache directories

Re: [Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible (v2)

must have slipped through the cracks.) Kai Wasserbäch wrote on 23.01.2018 21:14: > Changes since v1: > * Rebased on top of e68150de263156a3f3d1b609b6506c5649967f61 and > 82adf53308c137ce0dc5f2d5da4e7cc40c5b808c. > > Cc: Timothy Arceri > Tested-by: Dieter Nützel (v1) >

[Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible (v2)

Changes since v1: * Rebased on top of e68150de263156a3f3d1b609b6506c5649967f61 and 82adf53308c137ce0dc5f2d5da4e7cc40c5b808c. Cc: Timothy Arceri Tested-by: Dieter Nützel (v1) Signed-off-by: Kai Wasserbäch --- Hey, if you accept this patch, please commit it for me – I do not have commit

Re: [Mesa-dev] [PATCH] ac: fix image load store for GLSL_SAMPLER_DIM_3D

Hey, Nicolai Hähnle wrote on 22.01.2018 14:18: > On 20.01.2018 04:11, Timothy Arceri wrote: >> Fixes the following piglit tests: >> >> arb_shader_image_load_store/layer/image3d/layered binding test >> arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1 >> arb_shader_image_load_sto

[Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible

Signed-off-by: Kai Wasserbäch --- Hey, if you accept this patch, please commit it for me – I do not have commit access. Thanks, Kai src/amd/common/ac_nir_to_llvm.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd

Re: [Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

Hey Ian, Ian Romanick wrote on 12.12.2017 17:56: > Weird that this was not noticed before... *shrug* > > Reviewed-by: Ian Romanick thank you very much for the R-b! Can you push this for me? I don't have commit access. Cheers, Kai > On 12/12/2017 07:20 AM, Kai Wasserbäch wrot

[Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

Cc: Nicolai Hähnle Fixes: 5bc03d2508 ("mesa: implement SPIR-V loading in glShaderBinary") Signed-off-by: Kai Wasserbäch --- src/mesa/main/glspirv.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c index 7eb8f906c2..81303057d0 10

Re: [Mesa-dev] [PATCH] radeonsi: try flushing unflushed fences in si_fence_finish even when timeout == 0

uring loading without this fix. > > Fixes: bc65dcab3bc4 ("radeonsi: avoid syncing the driver thread in > si_fence_finish") Tested-by: Kai Wasserbäch Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103902 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10390

Re: [Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

Can you push for me? I don't have access. Eric Engestrom wrote on 16.11.2017 13:04: > On Thursday, 2017-11-16 12:58:50 +0100, Kai Wasserbäch wrote: >> Cc: Eric Engestrom > > Thanks! > Reviewed-by: Eric Engestrom > >> Signed-off-by: Kai Wasserbäch &

[Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

Cc: Eric Engestrom Signed-off-by: Kai Wasserbäch --- docs/llvmpipe.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index e4676920ed..12dccb5eae 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -50,6 +50,12 @@ It's the fa

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

Doesn't the meson.build file need the same change? Nicolai Hähnle wrote on 15.11.2017 12:55: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2" name was reported as confusing when printing EGL infos (one > user reported thinking DRI3 was not working on his X server), and the > only alternative is Haiku, which can only be used on a Haiku machine. > > The name therefore doesn't add any information that the user wouldn'

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

Hey Matias, Matias N. Goldberg wrote on 15.11.2017 16:51: >> Why, doesn't your distro have LLVM development packages? > They aren't as up to date. Keeping up-to-date with everything mesa needs is > exhausting. > I started compiling LLVM from source when I needed to test an LLVM patch to > fix a G

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

Hey Eric, Eric Engestrom wrote on 17.10.2017 19:48: > On Tuesday, 2017-10-17 17:20:13 +, Emil Velikov wrote: >> [...] >> Yes name is a bit misleading, so I'm wondering if any of the following >> won't be better >> - s/DRI2/DRI/ - might be tad confusing >> - emit the corresponding DRI2 vs DRI3

[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name (v2)

ober/014544.html> for the exchange that sparked this patch. v2: - Fix commit message. (Michel Dänzer) - Don't capitalise "Mesa" in the driver name. (Eric Engestrom) Signed-off-by: Kai Wasserbäch --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

Hey Eric, Eric Engestrom wrote on 17.10.2017 18:31: > On Tuesday, 2017-10-17 15:26:00 +0000, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

Michel Dänzer wrote on 17.10.2017 17:42: > On 17/10/17 05:26 PM, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by the >> same name w

[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

driver has nothing to do with that kernel interface and is rather a Mesa internal versioning of an interface. See eg. the thread beginning at <https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html> for an example. Signed-off-by: Kai Wasserbäch --- src/egl/drivers/dri2/

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Hey Thomas, Thomas Hellstrom wrote on 07.09.2017 10:53: > This fixes a regression introduced with commit > eceb6710024716433069d705fbd873d6d136c2cc: > "mesa/st: Reduce the number of frontbuffer flush calls" > where we, after flushing the front buffer marked it as not-rendered-to, > the idea being t

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

On 06/09/17 13:11, Marek Olšák wrote: > On Wed, Sep 6, 2017 at 1:02 PM, Marek Olšák wrote: >> On Wed, Sep 6, 2017 at 12:38 PM, Emil Velikov >> wrote: >>> On 4 September 2017 at 21:36, Marek Olšák wrote: From: Marek Olšák Building gallium is faster by 7.5 seconds on a 4core/8thre

Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

Hey, John Brooks wrote on 15.05.2017 07:47: > This fixes the long-standing problem with Dying Light where the game would > produce a black screen when running under Mesa. This happened because the > game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin. > Mesa's GLSL compiler is a li

Re: [Mesa-dev] Bug in 17.1.0-rc4 source packaging for swr?

Hey, Emil Velikov wrote on 18.05.2017 18:17: > On 18 May 2017 at 16:34, Rowley, Timothy O wrote: >> We could use a gen_builder.h generated from llvm-3.9 for all current >> versions of llvm at this time (as the changes are now just llvm IR >> additions), but I’m not sure how to enforce that the per

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

Michel Dänzer wrote on 10.05.2017 10:27: > From: Michel Dänzer > > deregisterEHFrames doesn't take any parameters anymore. > > Signed-off-by: Michel Dänzer LGTM, CC stable? > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

Hey, Marek Olšák wrote on 29.04.2017 12:49: > On Apr 29, 2017 11:27 AM, "Timothy Arceri" wrote: > On 29/04/17 18:44, Marek Olšák wrote: >> [...] >> >> That's a good point. I didn't think of that. Still, if one game evicts all >> entries, the cache may be almost as good as disabled. >> > > I'm hap

[Mesa-dev] [PATCH] docs/features: mark KHR_no_error as started

The OpenGL extension KHR_no_error is exposed since commit d42d150ad26e29d9e894ba9f9e28f8134e2e5393 by Timothy Arceri. Therefore it should be marked as "started" in the features.txt Signed-off-by: Kai Wasserbäch --- Hey, this is a rather trivial "patch" (doesn't really

Re: [Mesa-dev] [PATCH] ac, gallium: fix building with LLVM >= r298393

h" > @@ -754,7 +760,7 @@ lp_add_attr_dereferenceable(LLVMValueRef val, uint64_t > bytes) > llvm::Argument *A = llvm::unwrap(val); > llvm::AttrBuilder B; > B.addDereferenceableAttr(bytes); > - A->addAttr(llvm::AttributeSet::get

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hey Dylan, Dylan Baker wrote on 21.03.2017 18:34: > Quoting Kai Wasserbäch (2017-03-21 09:50:52) >> I've just a few points, since I'm not too enthused by the prospect of having >> to >> deal with yet another build system with yet another slightly different >&

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hey Dylan, I've just a few points, since I'm not too enthused by the prospect of having to deal with yet another build system with yet another slightly different syntax. But ultimately this is only a "my 2 cents" e-mail, since others are way deeper involved with Mesa and their opinion is what matte

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

Not from my side. But I can't commit the patch for you. Jason? Jacob Lifshay wrote on 26.02.2017 03:17: > Just to double check, is there anything else I need to do to have this > patch committed? > Jacob Lifshay > > On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote:

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

Jason Ekstrand wrote on 19.02.2017 06:01: > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch" > wrote: > > Hey Jacob, > sorry for not spotting this the first time, but I have an additional > comment. > Please see below. > > Jacob Lifshay wrote on 18.02.2017 18:

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

= xcb_query_extension_reply(conn, pres_cookie, NULL); > - if (dri3_reply == NULL || pres_reply == NULL) { > + amd_reply = xcb_query_extension_reply(conn, amd_cookie, NULL); > + nv_reply = xcb_query_extension_reply(conn, nv_cookie, NULL); > + if (!dri3_reply || !pres_reply || !amd

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

RI3 support detected - required for > presentation\n"); > - fprintf(stderr, "Note: Buggy applications may crash, if they do please > report to vendor\n"); > + if (!wsi_x11_check_for_dri3(wsi_conn)) >return false; > - } > > unsigned visual_dept

Re: [Mesa-dev] radv cik fixes

irm, that this series resolves fdo#99692 for me (<https://bugs.freedesktop.org/show_bug.cgi?id=99692#c9>). The Talos Principle is finally up and running with radv and no more visual corruption or VM faults either! You can have my Tested-by: Kai Wasserbäch Thank you so much for

Re: [Mesa-dev] [PATCH 2/2] vdpau: skip vlVdpOutputSurfacePutBitsNative with a zero-area rectangle

urce_pitches, 0); > pipe_mutex_unlock(vlsurface->device->mutex); > > return VDP_STATUS_OK; > } > > /** > * Copy image data from application memory in a specific indexed format to In any case, this series is: Tested-by: Kai Wasserbäch Reviewed-by: Kai

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

Hey, Pierre-Loup A. Griffais wrote on 11.02.2017 03:44: > On 02/10/2017 04:01 AM, Nicolai Hähnle wrote: >> On 10.02.2017 12:46, Timothy Arceri wrote: >>> On 10/02/17 21:35, Nicolai Hähnle wrote: >>> [...] >>> It's not even clear to me how they intend to load those precompiled binaries int

Re: [Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

Kai > On Sat, Jan 7, 2017 at 2:38 PM, Kai Wasserbäch > wrote: >> See also <https://bugs.freedesktop.org/show_bug.cgi?id=93551#c27> where >> this was first observed as a requirement. >> >> Signed-off-by: Kai Wasserbäch >> --- >> src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Hey Marek, thanks for the changes to the documentation! You can have my Reviewed-by: Kai Wasserbäch Cheers, Kai Marek Olšák wrote on 07.01.2017 15:46: > From: Marek Olšák > > ~/.drirc is created by the driconf tool (GPL license) and it overrides > system drirc settings and can&

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

cause I forgot I set some option ages ago. What I really wouldn't like is the drivers behaving differently. That's sure to cause support trouble down the line. Just my 2 cents, though. Cheers, Kai > On 07/01/2017 14:23, Kai Wasserbäch wrote: >> Hey Marek, >> maybe <

[Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

See also <https://bugs.freedesktop.org/show_bug.cgi?id=93551#c27> where this was first observed as a requirement. Signed-off-by: Kai Wasserbäch --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drive

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

gApp = 0; > +userData.inDriConf = 0; > +userData.inDevice = 0; > +userData.inApp = 0; > +userData.inOption = 0; > + > +parseOneConfigFile (p); > +XML_ParserFree (p); > } > > void driDestroyOptionInfo (driOptionCache *info) { > driDe

Re: [Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

Hey Pierre, this looks like it went to the wrong list. radv patches should be sent to AFAIK (CCed with this message). Cheers, Kai Pierre-Loup A. Griffais wrote on 06.01.2017 21:57: > Interpreting layerCount literally would try to create billions of image >

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

Nicolai Hähnle wrote on 10.12.2016 19:12: > On 10.12.2016 18:19, Kai Wasserbäch wrote: >> Nicolai Hähnle wrote on 10.12.2016 14:54: >>> From: Nicolai Hähnle >>> >>> Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 >>> (Compat

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

Nicolai Hähnle wrote on 10.12.2016 14:54: > From: Nicolai Hähnle > > Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 > (Compatibility Profile) spec says: > > "If a value is so large in magnitude that it cannot be represented by the > returned data type, then

Re: [Mesa-dev] Stable release process

Hi everybody, Nicolai Hähnle wrote on 18.11.2016 17:48: > On 18.11.2016 16:56, Emil Velikov wrote: >> On 18 November 2016 at 12:34, Marek Olšák wrote: >>> On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov >>> wrote: >>> [...] Speaking of patchwork, mostly I'm fine with it. There are some

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

, 2016 at 12:16 PM, Emil Velikov >>>> >>>> wrote: >>>>> >>>>> On 19 October 2016 at 19:50, Kai Wasserbäch >>>>> >>>>> wrote: >>>>>> Hey Emil, >>>>>> just curious why you did the reve

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

5 Haixia Shi > 8 Hans de Goede > 12 Iago Toral Quiroga >139 Ian Romanick >139 Ilia Mirkin > 3 Indrajit Das > 2 Jakob Sinclair > 1 James Legg > 9 Jan Vesely > 5 Jan Ziak >506 Jason Ekstrand > 1 Jimmy Berry > 4

Re: [Mesa-dev] [PATCH 2/2] radv: Use new image load/store intrinsic signatures

Disregard this, the mbox file only contained the second patch. Sorry for the noise. Kai Wasserbäch wrote on 13.10.2016 19:20: > Dear Tom, > just FYI: this fails to apply on top of master > (761388a0eb586b1dcaec063ee561056ed132dc1a). git am chokes on the > visit_image_store()

Re: [Mesa-dev] [PATCH 2/2] radv: Use new image load/store intrinsic signatures

ms[7] = slc; > + } else { > + LLVMValueRef lwe = i1false; > + params[4] = glc; > + params[5] = slc; > + params[6] = lwe; > + params[7] = da; > + } > &

Re: [Mesa-dev] mesamatrix.net summary problem

You're probably overlooking GL_ARB_shader_group_vote. Boszormenyi Zoltan wrote on 08.10.2016 17:53: > Hi, > > I just skimmed through the list of supported extensions by > both nvc0 and radeonsi on mesamatrix and the number > at the top of the page should be equal for them. > > nvc0 supports GL_A

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

Marek Olšák wrote on 13.09.2016 19:53: > LLVM 64-bit: > > mkdir -p build > cd build > cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu > -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=O > -DCMAKE_BUILD_TYPE=RelWithDebInfo > -DLLVM_BUILD_LLVM_DYLI

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

Hey Michael, Michael Schellenberger wrote on 26.08.2016 20:19: > Am 26.08.2016 um 15:23 schrieb Kai Wasserbäch: >> [...] >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> b/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> index 4f4f87e..e5d3db3

  1   2   3   >