On Sat, Nov 23, 2019 at 3:49 AM Brian Paul wrote:
> +
> +/* MSVC doesn't have C99's _Pragma() */
> +#ifdef _MSC_VER
> +#define _Pragma(x)
> +#endif
FWIW, MSVC has its own __pragma() extension instead of _Pragma(), but
IIRC the syntax is slightly different (the contents are tokens, not a
string to
On Sat, Apr 21, 2018 at 2:16 AM, Jason Ekstrand wrote:
>
> I was thinking about this a bit this morning and it gets even more sticky.
> What happens if you have
>
> bool e = (a < b) && (c < d);
>
> where a and b are 16-bit and c and d are 32-bit? In this case, one
> comprison has a 32-bit value a
> + * 2) Haswell is a bit unique in that it's CCS tiling does not line
it's -> its
--
Giuseppe "Oblomov" Bilotta
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Sat, Dec 30, 2017 at 10:52 PM, Bas Nieuwenhuizen
wrote:
> I don't like having to fush, so this introduces the other workaround.
typo: flush
+* do a PS_APRTIAL_FLUSH before writing them, or we need to
always write it if
I assume this would be PARTIAL
(Sorry I can only grammar-nazi th
On Mon, Apr 24, 2017 at 5:06 PM, Brian Paul wrote:
> On 04/22/2017 03:46 PM, Giuseppe Bilotta wrote:
>>
>> Makes sense. As Gustaw suggests, it _shouldn't_ happen, but there's
>> nothing to lose in being cautious about it 8-). I'll respin this patch
>> wi
---
src/compiler/nir/nir_array.h | 2 +-
src/compiler/spirv/spirv_to_nir.c | 2 +-
src/gallium/winsys/svga/drm/vmw_context.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/compiler/nir/nir_array.h b/src/compiler/nir/nir_array.h
index 4d7a532a7f..049
v2: simply add an assert(0) in args_match()'s allegedly impossible case, to be
revisited for promotion to unreachable() after some time, as suggested by
Nicolai
Signed-off-by: Giuseppe Bilotta
---
src/mesa/main/ff_fragment_shader.cpp | 19 ---
1 file chang
On Sat, Apr 22, 2017 at 11:45 AM, Nicolai Hähnle wrote:
>> @@ -495,8 +492,8 @@ static GLboolean args_match( const struct state_key
>> *key, GLuint unit )
>> return GL_FALSE;
>> }
>> break;
>> - default:
>> -return GL_FALSE; /* impossible */
>> +
Hello,
On Sat, Apr 22, 2017 at 11:46 AM, Nicolai Hähnle wrote:
> Definitely split the changes up along a combination of where they are in the
> source and what types of errors they are. I'd say the split you've chosen
> looks reasonable to me.
Excellent, thanks.
>> 1. the addition of a check to
fference from the
`unreachable`, or if it's just e.g. a leftover from an older approach.
Thanks and best regards,
Giuseppe Bilotta (4):
mesa/pack: check malloc return value
glsl: early bailout if local size too large
ff_fragment_shader: mark impossible switch values with unreachable
m
Signed-off-by: Giuseppe Bilotta
---
src/mesa/main/pack.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
index 760c46afe7..16bc95311b 100644
--- a/src/mesa/main/pack.c
+++ b/src/mesa/main/pack.c
@@ -1621,6 +1621,11
being used
unitialized further down the function block.
Signed-off-by: Giuseppe Bilotta
---
src/compiler/glsl/ast_to_hir.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index aeb223db9e..2a83cfad25
Signed-off-by: Giuseppe Bilotta
---
src/mesa/main/ff_fragment_shader.cpp | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/ff_fragment_shader.cpp
b/src/mesa/main/ff_fragment_shader.cpp
index aac9de78ca..4f2d6b07a2 100644
--- a/src/mesa/main
Signed-off-by: Giuseppe Bilotta
---
src/mesa/main/get.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index cf3ee6385e..3293c00f96 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -1405,8 +1405,7 @@ find_value(const
On Fri, Feb 24, 2017 at 5:30 PM, Ilia Mirkin wrote:
> I'd like to point out that when I hooked up this logic in clover
> (after my triumphant addition of KHR_debug in gallium), I had no idea
> how OpenCL stuff worked. I still don't. If you think passing this type
> of information is inappropriate,
On Tue, Dec 20, 2016 at 2:17 AM, Matt Turner wrote:
> On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta
> wrote:
>> Just one question though —not knowing much of the shader language, can
>> I expect expm1 to be available?
>
> No, expm1 doesn't exist in GLSL.
This
Hello,
I realize that I'm a little late to comment about this, but I think
the formula used for
tanh should be changed again. Specifically, as suggested by Roland
On Fri, Dec 9, 2016 at 5:41 AM, Roland Scheidegger wrote:
> btw I'm wondering if some vendors wouldn't implement that with slightly
>
title;
* replace two 'as is' followed by 'is' to 'as-is'.
v3:
* 'a integer' => 'an integer' and similar (originally spotted by
Jason Ekstrand, I fixed a few other similar ones while at it)
Signed-off-by: Giuseppe Bilotta
---
inclu
27; followed by 'is' to 'as-is'.
Signed-off-by: Giuseppe Bilotta
---
include/GL/mesa_glinterop.h | 6 +++---
src/compiler/glsl/glsl_to_nir.cpp | 2 +-
src/compiler/nir/nir.h| 2 +-
src/compiler/nir/
On Thu, Jun 23, 2016 at 7:32 AM, Matt Turner wrote:
> On Wed, Jun 22, 2016 at 10:05 PM, Giuseppe Bilotta
> wrote:
>> Miscellaneous repetitions in commits and fly-by typo fixes.
>
> How about an actual commit title?
I'm sorry, I couldn't resist the temptation, it
Miscellaneous repetitions in commits and fly-by typo fixes.
Signed-off-by: Giuseppe Bilotta
---
include/GL/mesa_glinterop.h | 6 +++---
src/compiler/glsl/glsl_to_nir.cpp | 2 +-
src/compiler/nir/nir.h| 2 +-
src
This text transformation was done automatically via the following shell
command:
$ find -name SCons\* -exec sed -i s/\\s\\+$// '{}' \;
Signed-off-by: Giuseppe Bilotta
---
SConstruct| 14 +++---
src/compiler/SConscript.glsl |
-off-by: Giuseppe Bilotta
Cc: mesa-sta...@lists.freedesktop.org
Acked-by: Emil Velikov
---
scons/custom.py | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/scons/custom.py b/scons/custom.py
index ff7a7a9..e66f496 100644
--- a/scons/custom.py
+++ b/scons/custom.py
@@ -43,6
.
Giuseppe Bilotta (2):
scons: whitespace cleanup
scons: support 2.5.0
SConstruct| 14 +++---
scons/custom.py | 9 -
src/compiler/SConscript.glsl | 2 +-
src/gallium/SConscript| 2
> Sure. Unfortunately, the series does not apply cleanly on ToT master:
>
> % git am p[12].txt
> Applying: scons: whitespace cleanup
> Using index info to reconstruct a base tree...
> error: patch failed: src/gallium/state_trackers/wgl/SConscript:12
> error: src/gallium/state_trackers/wgl/SConscri
On Tue, May 24, 2016 at 6:13 PM, Brian Paul wrote:
> For both,
> Reviewed-by: Brian Paul
>
> Do you need me to push these for you?
Well, AFAIK I don't have write access to the mesa git tree so yes
please ;-) (Possibly with the extra commit lines with the full
Bugzilla link that Emil posted for
On Tue, May 24, 2016 at 2:13 PM, Emil Velikov wrote:
> [Adding Jose]
[Wait, I thought I did? Or did I get the email address wrong?
> On 24 May 2016 at 09:43, Giuseppe Bilotta wrote:
>> This closes #95211.
> For the future please use the full URL.
Ack. Sorry, used to LibreOffic
---
SConstruct| 4 ++--
src/gallium/SConscript| 2 +-
src/gallium/auxiliary/SConscript | 10 +-
src/gallium/drivers/svga/SConscript | 2 +-
src/gallium/state_trackers/wgl/SConscript | 2 +-
src/gallium/targets/libgl-gdi
The get_implicit_deps changed in SCons 2.5, expecting a callable rather
than a path as third argument. Detect the SCons versions and set the
argument appropriately to support both 2.5 and earlier versions.
This closes #95211.
---
scons/custom.py | 9 -
1 file changed, 8 insertions(+), 1 d
The main patch is the second, the first is just a cleanup of EOL whitespace.
Giuseppe Bilotta (2):
scons: whitespace cleanup
scons: support 2.5.0
SConstruct| 4 ++--
scons/custom.py | 9 -
src/gallium/SConscript
On Tue, May 24, 2016 at 2:26 AM, Emil Velikov wrote:
> On 23 May 2016 at 22:11, Giuseppe Bilotta wrote:
>> I'll try. I've never used scons before thought so I might need some
>> guidance along the way. (Doubly so considering that trying to run
>>
>> % sc
On Tue, May 24, 2016 at 12:46 AM, Marek Olšák wrote:
> On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta
> wrote:
>> On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote:
>>> I think it would be better to put stuff like this only into the
>>> renderer string
On Tue, May 24, 2016 at 1:03 AM, Vedran Miletic wrote:
>
> What is the state of MESA_LLVM_VERSION_STRING if you build Mesa on a system
> without LLVM?
I set it to the empty string.
--
Giuseppe "Oblomov" Bilotta
___
mesa-dev mailing list
mesa-dev@lists
Hello Emil,
On Mon, May 23, 2016 at 11:20 AM, Emil Velikov wrote:
> It seems like this won't work if one builds --enable-clover --disable-dri.
Argh, I hadn't considered this possibility.
> The following should keep mesa and gallium code separate, can we try that one
> ?
> - move the git_sha1.
On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote:
> I think it would be better to put stuff like this only into the
> renderer string of drivers which use LLVM. The majority of drivers
> don't care about the LLVM version.
Hm, that might be a good point. Is there a way to programmatically (at
so
Code generation (kernel compilation) may sometimes hit LLVM-specific
bugs. Adding the used LLVM version to the version string may make bug
triaging easier. (This was inspired by a similar patch recently
proposed for pocl.)
Signed-off-by: Giuseppe Bilotta
---
configure.ac
ion string suffix from MESA to
Mesa, and adds the previously missing git SHA1.
Signed-off-by: Giuseppe Bilotta
---
src/gallium/state_trackers/clover/api/device.cpp | 3 +-
src/gallium/state_trackers/clover/api/platform.cpp | 3 +-
src/mesa/main/version.c| 8 ++---
The first patch refactors the version string suffix `Mesa ()` so that it can also be used by Clover in device and platform version
strings, the second adds the LLVM version to the version string suffix, to
improve bug triaging in shader and kernel compilation issues.
Giuseppe Bilotta (2
On Sun, May 22, 2016 at 1:08 PM, Serge Martin wrote:
>
> Mesa or MESA spelling shouldn't be an issue. And that would be coherent with
> CL_PLATFORM_VENDOR that is returning "Mesa"
Excellent. I'll unify the version string suffix to the title-cased version.
>> Second question: shall I squash the i
On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta
wrote:
> On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić wrote:
>
>> How about also adding Mesa git version, like "OpenGL core profile
>> version string" has now?
>
> That's probably a good idea. Conver
On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić wrote:
> 2016-05-15 3:32 GMT+02:00 Francisco Jerez :
>> Giuseppe Bilotta writes:
>>
>>> Code generation (kernel compilation) may sometimes hit LLVM-specific
>>> bugs. Adding the used LLVM version to the version
Code generation (kernel compilation) may sometimes hit LLVM-specific
bugs. Adding the used LLVM version to the version string may make bug
triaging easier.
Signed-off-by: Giuseppe Bilotta
---
configure.ac | 2 +-
src/gallium/state_trackers/clover/api
This adds a first tentative .mailmap file, to canonicize contributor
name/emails in shortlogs and other statistical endeavours.
Signed-off-by: Giuseppe Bilotta
---
Hopefully the last time I need to submit this …
.mailmap | 460 +++
1
On Tue, Dec 22, 2015 at 4:11 PM, Giuseppe Bilotta
wrote:
[snip]
Doh, apparently I got Thomas' Tanner name wrong 8-/ I'm sure you guys
will be loving how much I'm managing to spam the list with this stupid
thing 8-P Do I send I patch to be squashed on top of this or a
This adds a first tentative .mailmap file, to canonicize contributor
name/emails in shortlogs and other statistical endeavours.
Signed-off-by: Giuseppe Bilotta
---
.mailmap | 460 +++
1 file changed, 460 insertions(+)
create mode
On Tue, Dec 22, 2015 at 3:36 PM, Alex Deucher wrote:
>
> Maybe it would make sense to make the personal emails the default for
> everyone. I think I'd prefer that too.
I've changed yours too for now, but for me it's not always trivial to
find which of the private emails (yes, sometimes there's m
On Tue, Dec 22, 2015 at 12:55 PM, Erik Faye-Lund wrote:
> On Tue, Dec 22, 2015 at 12:47 PM, Thomas Tanner wrote:
>> Hi,
>> my primary email address for open source contributions is tan...@gmx.net
>> cheers
>>
>
> OK, I think Giuseppe will want this info for his final version of the
> patch (CC'ed
On Tue, Dec 22, 2015 at 3:25 AM, Jason Ekstrand wrote:
>
> As with Michel, I'd rather have my "personal" e-mail as the cannonical one.
> That said, I vote we just merge this as-is and let everyone go fix their own
> e-mail address.
I have yours and Michel fixed locally now. I can resend one last
date Z) are left to separate support files for specific
tools, not included here.
Signed-off-by: Giuseppe Bilotta
---
.mailmap | 460 +++
1 file changed, 460 insertions(+)
create mode 100644 .mailmap
diff --git a/.mailmap b/.mailmap
new
On Fri, Dec 18, 2015 at 9:12 AM, Boris Peterbarg wrote:
> As far as I remember, parts of it were.
> The r300 driver, which is now the r600 driver, was a side project in 2005
> and was hosted there. I don't remember anymore, but based on this, it wasn't
> even svn.
>
> sourceforge.net/p/r300/code/
On Thu, Dec 17, 2015 at 10:09 PM, Boris Peterbarg
wrote:
> Woah, this brought back memories of fighting with X and mesa!
>
> If you want to list me, I'd prefer you use re...@users.sourceforge.net
Actually, your comment just gave me a _brilliant_ idea. If mesa was
hosted on SF's svn, I'm ready to
Hello Boris,
On Thu, Dec 17, 2015 at 10:09 PM, Boris Peterbarg
wrote:
> Woah, this brought back memories of fighting with X and mesa!
>
> If you want to list me, I'd prefer you use re...@users.sourceforge.net
Thanks, I've added the mapping. Unless of course you'd rather want to
remain anonymous
On Thu, Dec 17, 2015 at 12:30 PM, Sven M. Hallberg wrote:
> Erik Faye-Lund writes:
>>> Probably "Sven M. Hallberg "
>>> (Sources: http://sourceforge.net/p/mesa3d/mailman/message/5416179/ and
>>> https://github.com/jwiegley/lambdabot-1/blob/master/AUTHORS#L17)
>>
>> OK, this address bounced (or ra
On Thu, Dec 17, 2015 at 4:46 PM, Matt Turner wrote:
> On Thu, Dec 17, 2015 at 1:09 AM, Giuseppe Bilotta
> wrote:
>> This adds a first tentative .mailmap file, to canonicize contributor
>> name/emails in shortlogs and other statistical endeavours.
>
> If we want this kin
This adds a first tentative .mailmap file, to canonicize contributor
name/emails in shortlogs and other statistical endeavours.
Signed-off-by: Giuseppe Bilotta
---
.mailmap | 462 +++
1 file changed, 462 insertions(+)
create mode
On Thu, Dec 17, 2015 at 4:57 AM, Kenneth Graunke wrote:
>
> Absolutely. Feel free to send them to me personally. Or, I could
> include the files upstream if that's of interest to people, and then
> people could just update stuff themselves.
>
> I just threw together a best-effort set of configur
On Wed, Dec 16, 2015 at 4:38 PM, Brian Paul wrote:
> On 12/16/2015 08:24 AM, Giuseppe Bilotta wrote:
>>
>>
>> Thanks. I'll move them (maybe put a comment to remark it's not 100%
>> sure). The other root@ are most probably Brian, I'll move them there
On Wed, Dec 16, 2015 at 4:00 PM, Alex Deucher wrote:
>
> I believe all of the following are Richard Li:
>
> +Richard Li
>
> +richard
> +richard
>
> +root
Thanks. I'll move them (maybe put a comment to remark it's not 100%
sure). The other root@ are most probably Brian, I'll move them there
(
On Wed, Dec 16, 2015 at 3:18 AM, Michel Dänzer wrote:
> On 16.12.2015 06:40, Giuseppe Bilotta wrote:
>> +
>> +Adam Jackson
>> +Adam Jackson
>
> In Adam's case, you put a personal e-mail address first and his
> employer's address last.
D'oh, sor
This adds a first tentative .mailmap file, to canonicize contributor
name/emails in shortlogs and other statistical endeavours.
There's a couple of root and richard entries which I don't know who
they belong to, and hopefully not too many overeager merges.
Signed-off-by: Giusep
On Tue, Dec 15, 2015 at 10:22 PM, Kenneth Graunke wrote:
> On Tuesday, December 15, 2015 02:23:07 PM Giuseppe Bilotta wrote:
>> The only problem with these numbers is actually the lack of a .mailmap
>> to normalize contributor name/emails, which obviously skews the
>> results
Hello all,
when Steam first announced they'd give all present and future games
free to all Mesa contributors with at least 25 commits[1], I was
curious to see how many people would be affected by this choice, so I
ran some statistics on the number of committers (and contributions by
committer) on
> Hmm I thought I pushed those in a couple of days ago. Doing it now, thanks !
No, thank you 8-)
>> This is one of those
>> contexts in which things could be done marginally more elegantly with
>> C++. I am proficient enough with C macros and xincludes that I could
>> probably hack together somet
Hello Emil,
>> The comment on u_atomic_test.c is also fixed (read 'debug' where it
>> should have been 'release').
> I've split that one to a separate patch, but for the future please do
> so during submission.
Doh, sorry.
> Also can you take a look at the list of patches you've submitted [1]
>
On Tue, Dec 1, 2015 at 6:04 PM, Emil Velikov wrote:
> With the small comment in patch 3 addressed the series is
> Reviewed-by: Emil Velikov
And also:
> Reviewed-by: Ian Romanick
for patch 1 and 2. Who should I ping for to get them pushed? ;-)
>>> The long version:
>>> 1. Grep for R
Hello Emil,
On Sun, Nov 29, 2015 at 4:21 PM, Emil Velikov wrote:
> With the small comment in patch 3 addressed the series is
> Reviewed-by: Emil Velikov
Thanks. I was pretty sure the comment was wrong when I copied it over
from the other file, but I thought I might have been missing something
o
in relevant comments
Signed-off-by: Giuseppe Bilotta
---
src/gallium/state_trackers/xvmc/tests/test_blocks.c | 2 ++
src/gallium/state_trackers/xvmc/tests/test_context.c| 2 ++
src/gallium/state_trackers/xvmc/tests/test_rendering.c | 2 ++
src/gallium/state_trackers/xvmc/tests/test_subp
Add missing `const` specifier for pointer pointing to a const struct.
Signed-off-by: Giuseppe Bilotta
---
src/mesa/drivers/dri/radeon/radeon_swtcl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/radeon/radeon_swtcl.c
b/src/mesa/drivers/dri/radeon
Signed-off-by: Giuseppe Bilotta
---
src/mesa/drivers/dri/radeon/radeon_swtcl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/radeon/radeon_swtcl.c
b/src/mesa/drivers/dri/radeon/radeon_swtcl.c
index 1e19cf7..ed6b25c 100644
--- a/src/mesa/drivers/dri
The second and third patches are mostly aimed at removing non-spurious
compiler warnings. The first one is just minor whitespace cleanup in the
general area of code touched by the second patch.
Giuseppe Bilotta (3):
radeon: whitespace cleanup
radeon: const correctness
xvmc: force assertion
This follows the src/util/u_atomic_test model of undefining NDEBUG
unconditionally throughouth the XvMC tests, to force asserts regardless
of debug mode.
Signed-off-by: Giuseppe Bilotta
---
src/gallium/state_trackers/xvmc/tests/test_blocks.c | 2 ++
src/gallium/state_trackers/xvmc/tests
On Sat, Jun 6, 2015 at 3:21 PM, Francisco Jerez wrote:
> Giuseppe Bilotta writes:
>
>> What I was trying to say is that while the cap itself is per-device,
>> the OpenCL property that relies on this cap isn't.
>> In this sense, I would expect the cap to report the
On Fri, Jun 5, 2015 at 10:35 PM, Francisco Jerez wrote:
>> OTOH, at least in OpenCL, this cap wouldn't be used 'raw' as
>> performance hint, since the actual value returned (the
>> PREFERRED_WORK_GROUP_SIZE_MULTIPLE) is a kernel property rather than a
>> device property, so it may be tuned at kern
Hello,
On Fri, Jun 5, 2015 at 2:22 PM, Francisco Jerez wrote:
> Giuseppe Bilotta writes:
>>
>> Ok, scratch that. I was confused by the fact that Beignet reports a
>> preferred work-group size multiple of 16. Intel IGPs support _logical_
>> SIMD width of up to 32, bu
> On Thu, May 28, 2015 at 1:04 PM, Grigori Goronzy wrote:
>> @@ -286,6 +287,13 @@ ilo_get_compute_param(struct pipe_screen *screen,
>>ptr = &val.images_supported;
>>size = sizeof(val.images_supported);
>>break;
>> + case PIPE_COMPUTE_CAP_SUBGROUP_SIZE:
>> + /* best c
Hello,
On Thu, May 28, 2015 at 1:04 PM, Grigori Goronzy wrote:
> @@ -286,6 +287,13 @@ ilo_get_compute_param(struct pipe_screen *screen,
>ptr = &val.images_supported;
>size = sizeof(val.images_supported);
>break;
> + case PIPE_COMPUTE_CAP_SUBGROUP_SIZE:
> + /* best c
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Tom Stellard
---
src/gallium/drivers/freedreno/freedreno_screen.c | 8
src
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
Review
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/docs/source/screen.rst | 6 ++
src/gallium/include/pipe/p_screen.h | 8
2 files changed, 14 insertions
device vendor, so it needs
an actual implementation of get_device_vendor distinct from that of
get_vendor.
Giuseppe Bilotta (4):
gallium: remove trailing whitespace in p_screen.h
gallium: introduce get_device_vendor() entrypoint for pipes
gallium: implement get_device_vendor() for existing d
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index ac88506..4018f8a 100644
--- a/src/gallium
Ping, is there anything else that needs to be done for this patchset?
On Wed, Mar 11, 2015 at 3:27 PM, Giuseppe Bilotta
wrote:
> OpenCL (as opposed to OpenGL) has separate vendor strings for the
> implementation/driver/platform and the device. CL_PLATFORM_VENDOR
> is akin to the GL_VEND
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
Signed-off-by: Giuseppe Bilotta
---
src/gallium/drivers/freedreno/freedreno_screen.c | 8
src/gallium/drivers/galahad
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/docs/source/screen.rst | 6 ++
src/gallium/include/pipe/p_screen.h | 8
2 files changed, 14 insertions
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
Review
:
* vc4's get_device_vendor maps to vc4_screen_get_vendor() instead of the
non-existing vc4_screen_get_device_vendor();
* freedreno should report Qualcomm, as device vendor, so it needs
an actual implementation of get_device_vendor distinct from that of
get_vendor.
Giuseppe Bilotta (4):
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index ac88506..4018f8a 100644
--- a/src/gallium
On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer wrote:
> The shortlog of patch 4 should be prefixed by gallium: as well.
Duh, I forgot the prefix everywhere. And the signoff line.
Specifically about the last patch, the one that actually touches
clover, is there a criteria for when to use gallium:
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index ac88506..4018f8a 100644
--- a/src/gallium/include/pipe/p_screen.h
+++ b/src/gallium/include/pipe/p_screen.h
@
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
---
src/gallium/docs/source/screen.rst | 6 ++
src/gallium/include/pipe/p_screen.h | 8
2 files changed, 14 insertions(+)
diff --git a/src/gallium/docs/source/screen.rst
b/src/gallium/
non-existing vc4_screen_get_device_vendor();
* freedreno should report Qualcomm, as device vendor, so it needs
an actual implementation of get_device_vendor distinct from that of
get_vendor.
Giuseppe Bilotta (4):
Whitespace cleanup
Introduce get_device_vendor() entrypoint for pi
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
---
src/gallium/drivers/freedreno/freedreno_screen.c | 8
src/gallium/drivers/galahad/glhd_screen.c| 10 ++
src/ga
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
---
src/gallium/state_trackers/clover/core/device.cpp | 2 +-
1 file changed, 1
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index ac88506..4018f8a 100644
--- a/src/gallium/include/pipe/p_screen.h
+++ b/src/gallium/include/pipe/p_screen.h
@
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
---
src/gallium/state_trackers/clover/core/device.cpp | 2 +-
1 file changed, 1
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
---
src/gallium/drivers/freedreno/freedreno_screen.c | 8
src/gallium/drivers/galahad/glhd_screen.c| 10 ++
src/ga
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
---
src/gallium/include/pipe/p_screen.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index 4018f8a..cba4c95 1
* vc4's get_device_vendor maps to vc4_screen_get_vendor() instead of the
non-existing vc4_screen_get_device_vendor();
* freedreno should report Qualcomm, as device vendor, so it needs
an actual implementation of get_device_vendor distinct from that of
get_vendor.
Giuseppe Bilotta (4):
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
---
src/gallium/include/pipe/p_screen.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index 4018f8a..cba4c95 1
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
---
src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
src/gallium/drivers/galahad/glhd_screen.c| 10 ++
src/gallium/d
1 - 100 of 104 matches
Mail list logo
