On Tue, Dec 1, 2015 at 6:04 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
>>>>> With the small comment in patch 3 addressed the series is
>>>>> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>
And also:
> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
for patch 1 and 2. Who should I ping for to get them pushed? ;-)
>>> The long version:
>>> 1. Grep for RADEON_R{1,2}00 and look at the guarded code
>>> 1.1 Some guards can just be dropped (CHIP_FAMILY_*, get_chip_family_name),
>>> 1.2 Other hunks of code can be split/moved into the respective
>>> r100/r200 codebase (radeonTexBufferExtension and
>>> r200TexBufferExtension).
>>> 1.3 Or folded into the vtbl dispatch - get_depth_z32/16 or the
>>> respective callers, depending on the overhead (neither one is likely
>>> to be noticeable).
>>> 2. Copy/pasta an existing radeon Makefile to radeon_common. Tweak to
>>> produce an empty library and get it into the final mega_dri_drivers.so
>>> 2.1 With most/all of the RADEON_R*00 guards gone, one should be able
>>> to just git mv the files into the new location. (alongside dropping
>>> the symlinks)
>>> 2.2 Remove the symbol redefinition hack.
> Three reasons - symlinks in git is frowned upon, binary is "bloated"
> and nasty symbol redefinition(hack).
Well, much of the “bloat” would probably be there even after the
cleanup, since I'm not sure (from the cursory look I've given) how
many of the functions would manage to go into a radeon-common. I
suspect there'll end up being quite some code duplication to get rid
of the symlinks and symbol redefinition hack. This is one of those
contexts in which things could be done marginally more elegantly with
C++. I am proficient enough with C macros and xincludes that I could
probably hack together something that avoids the symlinks and the code
duplication, but whether or not this would be considered an
improvement is very much up to personal taste.
--
Giuseppe "Oblomov" Bilotta
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
