[Mesa-dev] [PATCH] radv: fix check for perftest options size

It was using the debug options array size. CC: mesa-sta...@lists.freedesktop.org Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 429d47325a3..976c

Re: [Mesa-dev] [PATCH 0/5] nir, spirv: Fix bugs uncovered by spirv-opt

This series fixes the assert I was encountering with SteamVR here: https://bugs.freedesktop.org/show_bug.cgi?id=108065 Thanks for the fixes. -Andres On 2018-09-22 05:39 PM, Jason Ekstrand wrote: This little series fixes three bugs encountered while running the Vulkan CTS with SPIR-V optimizat

[Mesa-dev] [PATCH] radv: only emit ZPASS_DONE for timestamp queries on gfx queues

A ZPASS_DONE packet doesn't make sense for the compute queue. It will result in a gpu hang. This change resolves a gpu hang for SteamVR+Vega. Cc: mesa-sta...@lists.freedesktop.org Fixes: 1f616a840eac02241c585d28e9dac8f19a297f39 "radv: emit a dummy ..." Signed-off-by: Andres Rodr

Re: [Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

On 2018-08-21 01:54 PM, Marek Olšák wrote: Note that WAVES_PER_SH should be 0x3ff on the compute ring for the ring priorities to be applied. Correct, we would need to set WAVES_PER_SH during pipeline creation. I don't know if you need to do the same thing for the gfx ring. You can ask Andre

[Mesa-dev] [PATCH] radv: fix wmaybe-uninitialized in radv_meta_fast_clear.c

Assignment and usage of this variable both happen inside an if(rad_image_has_dcc()) {} blocks. It seems gcc plays it safe and assumes that both function calls could have different return values. But in this case we should be safe. --- src/amd/vulkan/radv_meta_fast_clear.c | 2 +- 1 file changed,

[Mesa-dev] [PATCH] radv: fix wmaybe-uninitialized in radv_meta_fast_clear.c

Assignment and usage of this variable both happen inside an if(rad_image_has_dcc()) {} blocks. It seems gcc plays it safe and assumes that both function calls could have different return values. But in this case we should be safe. --- src/amd/vulkan/radv_meta_fast_clear.c | 2 +- 1 file changed,

[Mesa-dev] [PATCH] radv: disable DCC for shareable images on GFX9+

This seems to be broken at the moment for opengl interop. Which is used by steamvr opengl applications. --- Not sure if we want to merge this or not. It fixes steamvr opengl applications on vega, but the proper solution is probably in some metadata bug. Mailing it out mostly as an awareness noti

[Mesa-dev] [PATCH] radv/winsys: fix leaking resources from bo's imported by fd

A bo's ref_count was not being initialized when imported from an fd. Therefore, we would fail to free the resource during VkFreeMemory(). This patch fixes applications like hifi VR in threaded mode, which perform frequent imports/releases of IPC shared memory. Signed-off-by: Andres Rodrigue

Re: [Mesa-dev] [PATCH] mesa: fix incorrect type when allocating arrays

Pushed, thanks for the report. On 2018-02-07 02:47 PM, Matt Turner wrote: On Wed, Feb 7, 2018 at 11:46 AM, Andres Rodriguez wrote: The array members are have type 'struct gl_buffer_object *' Found by coverity. Signed-off-by: Andres Rodriguez --- I think this should fix the iss

[Mesa-dev] [PATCH] mesa: fix incorrect type when allocating arrays

The array members are have type 'struct gl_buffer_object *' Found by coverity. Signed-off-by: Andres Rodriguez --- I think this should fix the issue, if I'm interpreting the coverity message correctly. src/mesa/main/externalobjects.c | 8 1 file changed, 4 i

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v3

On 2018-02-01 08:24 AM, Emil Velikov wrote: On 31 January 2018 at 19:03, Andres Rodriguez wrote: Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors v3: fix patch Suggested-by: Emil Velikov Signed-off-by: Andres Rodr

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v3

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors v3: fix patch Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 48 +++-- 1 file change

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v2

On 2018-01-31 01:25 PM, Andres Rodriguez wrote: Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors Someone forgot to update his patch correctly before sending it out... Suggested-by: Emil Velikov Signed-off-by: Andres Rodr

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v2

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH] docs/features: mark EXT_semaphore(_fd) as DONE v2

Support for these extensions is available in radeonsi. v2: also updated relnotes Signed-off-by: Andres Rodriguez --- Let me know if the formatting for the relnotes is what is expected. I based it on the previous versions. docs/features.txt | 4 ++-- docs/relnotes/18.1.0.html | 3

[Mesa-dev] [PATCH] docs/features: mark EXT_semaphore(_fd) as DONE

Support for these extensions is available in radeonsi. Signed-off-by: Andres Rodriguez --- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 2e110d9994..1672460a2f 100644 --- a/docs/features.txt +++ b/docs

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

On 2018-01-29 02:02 PM, Marek Olšák wrote: On Tue, Jan 23, 2018 at 10:16 PM, Andres Rodriguez wrote: Also, the associated piglit patches: https://lists.freedesktop.org/archives/piglit/2017-December/023600.html You can just push the piglit patches if you get no review there. Thanks for

Re: [Mesa-dev] [PATCH] mesa: fix incorrect size/error test in _mesa_GetUnsignedBytevEXT()

Reviewed-by: Andres Rodriguez Thanks. On 2018-01-29 04:42 PM, Brian Paul wrote: get_value_size() returns -1 for an error. The similar check in _mesa_GetUnsignedBytei_vEXT() is correct. Found by chance. There are apparently no Piglit tests which exercise glGetUnsignedBytei_vEXT() or

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

Also, the associated piglit patches: https://lists.freedesktop.org/archives/piglit/2017-December/023600.html On 2018-01-23 01:13 PM, Andres Rodriguez wrote: On 2018-01-23 01:04 PM, Andres Rodriguez wrote: Rebased on latest mesa and dropped the gallium fence->semaphore rename. There

[Mesa-dev] [PATCH 10/20] mesa: add support for semaphore object signal/wait v3

Memory synchronization is left for a future patch. v2: flush vertices/bitmaps moved to mesa/main v3: removed spaces before/after braces Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 38

[Mesa-dev] [PATCH] Revert "radv: Initialize DCC on transition from preinitialized."

nsfer dest." Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_cmd_buffer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 172f95e7c9..67799a13cc 100644 --- a/src/amd/vulkan/radv_cmd_buff

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

On 2018-01-23 01:04 PM, Andres Rodriguez wrote: Rebased on latest mesa and dropped the gallium fence->semaphore rename. There is also a new bugfix on patch 7. See v3 notes there. Andres Rodriguez (20): gallium: add type parameter to create_fence_fd gallium: introd

[Mesa-dev] [PATCH 19/20] mesa: fix glGet for ext_external_objects parameters

This allows the client to actually query the enums specified in the ext_external_objects spec. Signed-off-by: Andres Rodriguez --- src/mesa/main/get.c | 3 +++ src/mesa/main/get_hash_params.py | 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa

[Mesa-dev] [PATCH 20/20] mesa: check for invalid index on UUID glGet queries

This fixes the piglit test: spec/ext_semaphore/api-errors/usigned-byte-i-v-bad-value Signed-off-by: Andres Rodriguez --- src/mesa/main/get.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 34970b8e16..302cece3ef 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 13/20] winsys/amdgpu: add support for syncobj signaling v3

Add the ability to signal a syncobj when a cs completes execution. v2: corresponding changes for gallium fence->semaphore rename v3: s/semaphore/fence for pipe objects Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/radeon_winsys.h | 12 + src/gallium/winsys/amdgpu/

[Mesa-dev] [PATCH 18/20] mesa: fix error codes for importing memory/semaphore FDs

This fixes the following piglit tests: spec/ext_semaphore_fd/api-errors/import-semaphore-fd-bad-enum spec/ext_memory_object_fd/api-errors/import-memory-fd-bad-enum Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 11/20] mesa/st: add support for semaphore object signal/wait v3

Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject v2: - corresponding changes for gallium fence->semaphore rename - flushing moved to mesa/main v3: s/semaphore/fence for pipe objects Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_semaphoreobject

[Mesa-dev] [PATCH 16/20] radeonsi: fix fence_server_sync() holding up extra work v2

fence dependency. v2: s/semaphore/fence Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_fence.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 17/20] radeonsi: advertise support for GL_EXT_semaphore

Expose the feature only when we have syncobj support available Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index

[Mesa-dev] [PATCH 05/20] u_threaded_context: add support for fence_server_signal v2

v2: s/semaphore/fence Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util/u_threaded_context.c | 20 .../auxiliary/util/u_threaded_context_calls.h| 1 + 2 files changed, 21 insertions(+) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c

[Mesa-dev] [PATCH 15/20] radeonsi: implement semaphore_server_signal v2

Syncobj based waits or signals only happen at submission boundaries. In order to guarantee that the requested signal event will occur when the state tracker requested it, we must issue a flush. v2: s/fence/semaphore for pipe objects Signed-off-by: Andres Rodriguez --- src/gallium/drivers

[Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. v2: fixed flush order with respect to wait/signal emission Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++- src/mesa/main

[Mesa-dev] [PATCH 10/20] mesa: add support for semaphore object signal/wait v2

Memory synchronization is left for a future patch. v2: flush vertices/bitmaps moved to mesa/main Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 38 ++ 2 files changed, 52 insertions

[Mesa-dev] [PATCH 04/20] gallium: add fence_server_signal()

Calling this function will emit a fence signal operation into the GPU's command stream. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/context.rst | 31 +++ src/gallium/include/pipe/p_context.h | 6 ++ 2 files changed, 37 insertions(+) diff

[Mesa-dev] [PATCH 14/20] radeonsi: add support for importing PIPE_FD_TYPE_SYNCOBJ semaphores

Hook up importing semaphores of type PIPE_FD_TYPE_SYNCOBJ Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_fence.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers

[Mesa-dev] [PATCH 08/20] mesa/st: add support for semaphore object create/import/delete v2

Add basic semaphore object operations. v2: s/semaphore/fence for pipe objects Signed-off-by: Andres Rodriguez --- src/mesa/Makefile.sources | 2 + src/mesa/meson.build| 2 + src/mesa/state_tracker/st_cb_semaphoreobjects.c | 55

[Mesa-dev] [PATCH 09/20] mesa: add semaphore parameter stub v2

EXT_semaphore and EXT_semaphore_fd define no pnames. Therefore there isn't much to do besides determining the correct error code. v2: removed useless return Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 22 ++ 1 file changed, 22 insertions(+)

[Mesa-dev] [PATCH 03/20] gallium: introduce PIPE_FD_TYPE_SYNCOBJ

Denotes that a fd is backed by a synobj. For example, radv shared semaphores. Signed-off-by: Andres Rodriguez --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index

[Mesa-dev] [PATCH 01/20] gallium: add type parameter to create_fence_fd

An fd can potentially have different types of objects backing it. Specifying the type helps us make sure we treat the FD correctly. This is in preparation to allow importing syncobj fence FDs in addition to native sync FDs. Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util

[Mesa-dev] [PATCH 07/20] mesa: add support for semaphore object creation/import/delete v3

Used by EXT_semmaphore and EXT_semaphore_fd v2: Removed unnecessary dummy callback initialization v3: Fixed attempting to free the DummySemaphoreObject Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 34 ++ src/mesa/main/externalobjects.c | 134

[Mesa-dev] [PATCH 06/20] mesa/st: introduce EXT_semaphore and EXT_semaphore_fd v2

Guarded by PIPE_CAP_SEMAPHORE_SIGNAL v2: corresponding changes for PIPE_CAP_SEMAPHORE_SIGNAL rename Signed-off-by: Andres Rodriguez --- src/mesa/main/extensions_table.h | 2 ++ src/mesa/main/mtypes.h | 2 ++ src/mesa/state_tracker/st_extensions.c | 2 ++ 3 files changed

[Mesa-dev] [PATCH 02/20] gallium: introduce PIPE_CAP_SEMAPHORE_SIGNAL

Protects semaphore signaling functionality required by GL_EXT_semaphore. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium

[Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

Rebased on latest mesa and dropped the gallium fence->semaphore rename. Andres Rodriguez (20): gallium: add type parameter to create_fence_fd gallium: introduce PIPE_CAP_SEMAPHORE_SIGNAL gallium: introduce PIPE_FD_TYPE_SYNCOBJ gallium: add fence_server_signal() u_threaded_context:

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

On 2018-01-17 06:35 PM, Marek Olšák wrote: On Wed, Jan 17, 2018 at 8:22 PM, Andres Rodriguez wrote: On 2018-01-17 08:01 AM, Nicolai Hähnle wrote: On 04.01.2018 18:37, Andres Rodriguez wrote: On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

On 2018-01-17 08:01 AM, Nicolai Hähnle wrote: On 04.01.2018 18:37, Andres Rodriguez wrote: On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like everything would be fine if we used the "fence" name for semaphores. The rename was requested by nha

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

x27;m fine with either approach. Marek On Fri, Dec 22, 2017 at 1:41 AM, Andres Rodriguez wrote: Rename fences -> semaphores in preparation for upgrading fence functionality. This series renames the following symbols: - pipe_fence_handle -> pipe_semaphore_handle

Re: [Mesa-dev] [PATCH 06/22] gallium: add semaphore_server_signal()

On 2017-12-22 10:56 AM, Roland Scheidegger wrote: Am 22.12.2017 um 01:41 schrieb Andres Rodriguez: Calling this function will emit a semaphore signal operation into the GPU's command stream. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/context.rst

Re: [Mesa-dev] [PATCH 00/22] Add support for GL_EXT_semaphore v2

roval. The reason it is being held: Message body is too big: 271096 bytes with a limit of 128 KB [snip] On 2017-12-21 07:41 PM, Andres Rodriguez wrote: Sorry for the long time to get this v2 out, past month has been a bit hectic. This incorporates the feedback I received from mareko and nha o

[Mesa-dev] [PATCH 14/22] mesa: implement buffer/texture barriers for semaphore signal/wait v2

Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. v2: fixed flush order with respect to wait/signal emission Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++- src/mesa/main

[Mesa-dev] [PATCH 13/22] mesa/st: add support for semaphore object signal/wait v2

Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject v2: - corresponding changes for gallium fence->semaphore rename - flushing moved to mesa/main Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_semaphoreobjects.c | 27 + 1 f

[Mesa-dev] [PATCH 08/22] mesa/st: introduce EXT_semaphore and EXT_semaphore_fd v2

Guarded by PIPE_CAP_SEMAPHORE_SIGNAL v2: corresponding changes for PIPE_CAP_SEMAPHORE_SIGNAL rename Signed-off-by: Andres Rodriguez --- src/mesa/main/extensions_table.h | 2 ++ src/mesa/main/mtypes.h | 2 ++ src/mesa/state_tracker/st_extensions.c | 2 ++ 3 files changed

[Mesa-dev] [PATCH 22/22] mesa: check for invalid index on UUID glGet queries

This fixes the piglit test: spec/ext_semaphore/api-errors/usigned-byte-i-v-bad-value Signed-off-by: Andres Rodriguez --- src/mesa/main/get.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 34970b8..302cece 100644 --- a/src/mesa/main/get.c

[Mesa-dev] [PATCH 16/22] radeonsi: add support for importing PIPE_FD_TYPE_SYNCOBJ semaphores

Hook up importing semaphores of type PIPE_FD_TYPE_SYNCOBJ Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_fence.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers

[Mesa-dev] [PATCH 21/22] mesa: fix glGet for ext_external_objects parameters

This allows the client to actually query the enums specified in the ext_external_objects spec. Signed-off-by: Andres Rodriguez --- src/mesa/main/get.c | 3 +++ src/mesa/main/get_hash_params.py | 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa

[Mesa-dev] [PATCH 20/22] mesa: fix error codes for importing memory/semaphore FDs

This fixes the following piglit tests: spec/ext_semaphore_fd/api-errors/import-semaphore-fd-bad-enum spec/ext_memory_object_fd/api-errors/import-memory-fd-bad-enum Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 05/22] gallium: introduce PIPE_FD_TYPE_SYNCOBJ

Denotes that a fd is backed by a synobj. For example, radv shared semaphores. Signed-off-by: Andres Rodriguez --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index e2e07ac

[Mesa-dev] [PATCH 19/22] radeonsi: advertise support for GL_EXT_semaphore

Expose the feature only when we have syncobj support available Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index

[Mesa-dev] [PATCH 12/22] mesa: add support for semaphore object signal/wait v2

Memory synchronization is left for a future patch. v2: flush vertices/bitmaps moved to mesa/main Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 38 ++ 2 files changed, 52 insertions

[Mesa-dev] [PATCH 18/22] radeonsi: fix semaphore_server_sync() holding up extra work

the fence dependency. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_fence.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers/radeonsi/si_fence.c index

[Mesa-dev] [PATCH 17/22] radeonsi: implement semaphore_server_signal

Syncobj based waits or signals only happen at submission boundaries. In order to guarantee that the requested signal event will occur when the state tracker requested it, we must issue a flush. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_fence.c | 37

[Mesa-dev] [PATCH 15/22] winsys/amdgpu: add support for syncobj signaling v2

Add the ability to signal a syncobj when a cs completes execution. v2: corresponding changes for gallium fence->semaphore rename Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/radeon_winsys.h | 12 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c |

[Mesa-dev] [PATCH 11/22] mesa: add semaphore parameter stub v2

EXT_semaphore and EXT_semaphore_fd define no pnames. Therefore there isn't much to do besides determining the correct error code. v2: removed useless return Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 22 ++ 1 file changed, 22 insertions(+)

[Mesa-dev] [PATCH 10/22] mesa/st: add support for semaphore object create/import/delete

Add basic semaphore object operations. Signed-off-by: Andres Rodriguez --- src/mesa/Makefile.sources | 2 + src/mesa/meson.build| 2 + src/mesa/state_tracker/st_cb_semaphoreobjects.c | 55 + src/mesa/state_tracker

[Mesa-dev] [PATCH 01/22] gallium: add type parameter to create_fence_fd

An fd can potentially have different types of objects backing it. Specifying the type helps us make sure we treat the FD correctly. This is in preparation to allow importing syncobj fence FDs in addition to native sync FDs. Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util

[Mesa-dev] [PATCH 07/22] u_threaded_context: add support for semaphore_server_signal

Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util/u_threaded_context.c | 20 .../auxiliary/util/u_threaded_context_calls.h| 1 + 2 files changed, 21 insertions(+) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gallium

[Mesa-dev] [PATCH 09/22] mesa: add support for semaphore object creation/import/delete v2

Used by EXT_semmaphore and EXT_semaphore_fd v2: Removed unnecessary dummy callback initialization Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 34 ++ src/mesa/main/externalobjects.c | 133 +++- src/mesa/main

[Mesa-dev] [PATCH 06/22] gallium: add semaphore_server_signal()

Calling this function will emit a semaphore signal operation into the GPU's command stream. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/context.rst | 31 +++ src/gallium/include/pipe/p_context.h | 6 ++ 2 files changed, 37 insertions(+)

[Mesa-dev] [PATCH 03/22] gallium: documentation updates for fence->semaphore rename

Kept separate from the symbol renames for review purposes. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/context.rst| 34 +++--- src/gallium/include/pipe/p_context.h | 33 +++-- src/gallium/include/pipe/p_screen.h

[Mesa-dev] [PATCH 04/22] gallium: introduce PIPE_CAP_SEMAPHORE_SIGNAL

Protects semaphore signaling functionality required by GL_EXT_semaphore. Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium

[Mesa-dev] [PATCH 00/22] Add support for GL_EXT_semaphore v2

- Moved the flush from gallium into the radeonsi pipe - Added tests (on piglit mailing list) - Some fixups for bugs found with the tests are at the end of the series Thanks for taking the time to review. Kind Regards, Andres Andres Rodriguez (22): gallium: add type parameter to

[Mesa-dev] [PATCH 3/3] mesa/st: add missing copyright headers to memoryobjects files

Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_memoryobjects.c | 24 src/mesa/state_tracker/st_cb_memoryobjects.h | 24 2 files changed, 48 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_memoryobjects.c b/src/mesa

[Mesa-dev] [PATCH 2/3] mesa: minor tidy up for memory object error strings

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index e70280c..4e9f8f8 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 1/3] broadcom/vc4: fix indentation in vc4_screen.c

Stumbled into this when adding a new PIPE_CAP. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/vc4/vc4_screen.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c index 1a9eaad

[Mesa-dev] [PATCH 0/3] Minor tidy ups

Split off some cleanup patches from my GL_EXT_semaphore series. There are no functional changes in this series. Andres Rodriguez (3): broadcom/vc4: fix indentation in vc4_screen.c mesa: minor tidy up for memory object error strings mesa/st: add missing copyright headers to memoryobjects

Re: [Mesa-dev] [PATCH 0/4] st/mesa: use asynchronous flushes

Reviewed-by: Andres Rodriguez Been going through these patches as they are tightly related to the semaphore series I'm working on. Regards, Andres On 2017-11-09 08:45 AM, Nicolai Hähnle wrote: Hi all, I've previously sent some of this series, but I'm splitting it

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

For both patches: Acked-by: Andres Rodriguez On Mon, Nov 6, 2017 at 1:06 PM, Chad Versace wrote: > For both patches, > Reviewed-by: Chad Versace > Tested-by: Chad Versace > > > On Mon 06 Nov 2017, Eric Engestrom wrote: >> Cc: Dylan Baker >> Cc: Chad Versa

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On 2017-11-03 02:20 PM, Marek Olšák wrote: On Fri, Nov 3, 2017 at 7:18 PM, Andres Rodriguez wrote: On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++ src/gallium/drivers/ddebug/dd_screen.c | 25 + src/gallium

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

ing the time to point it out. Regards, Andres Not a big deal, but should be possible to fix very easily. I'm sending some more comments about flushes on individual patches. Cheers, Nicolai On 02.11.2017 04:57, Andres Rodriguez wrote: This series adds radeonsi support for GL_EXT_semap

Re: [Mesa-dev] [PATCH 13/17] mesa: implement buffer/texture barriers for semaphore wait/signal

On 2017-11-03 05:18 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. Signed-off-by: Andres Rodriguez ---   src/mesa/main/dd.h

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez ---   src/mesa/state_tracker/st_cb_semaphoreobjects.c | 28 +   1 file

Re: [Mesa-dev] Meson's default build type

On 2017-11-03 05:25 AM, Michel Dänzer wrote: On 02/11/17 07:45 PM, Andres Rodriguez wrote: On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker

Re: [Mesa-dev] Meson's default build type

On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker wrote: Quoting Ilia Mirkin (2017-11-01 16:05:17) On Wed, Nov 1, 2017 at 7:03 PM, Dylan Bake

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

That's actually a pretty good suggestion, as it would help me get my feet wet on piglit changes with something simple. Thanks, Andres On Nov 2, 2017 1:24 AM, "Timothy Arceri" wrote: > On 02/11/17 15:12, Andres Rodriguez wrote: > >> It was tested against steamv

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

It was tested against steamvr using an opengl vr client (hellovr_opengl for simplicity). Regards, Andres On 2017-11-02 12:07 AM, Jason Ekstrand wrote: Out of curiosity, how has this series been tested beyond regression testing? On November 1, 2017 20:57:57 Andres Rodriguez wrote: This

[Mesa-dev] [PATCH 17/17] radeonsi: advertise support for GL_EXT_semaphore

Expose the feature only when we have syncobj support available Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index

[Mesa-dev] [PATCH 16/17] radeonsi: implement pipe transition_resource callback

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_blit.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index abf25b6..d28eef2 100644 --- a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 13/17] mesa: implement buffer/texture barriers for semaphore wait/signal

Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++- src/mesa/main/externalobjects.c | 38 ++--- src

[Mesa-dev] [PATCH 10/17] mesa: minor tidy up for memory object error strings

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index b82d425..67912dd 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 12/17] radeonsi: implement semaphore operations

Allow importing, waiting and signaling of semaphore objects. Semaphore objects are backed by syncobj based fences. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.c | 52 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 5 +++ 2 files

[Mesa-dev] [PATCH 14/17] gallium: add transition_resource call

This operation is meant to transition resource in and out of optimized layouts for compatibility with external clients. Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util/u_threaded_context.c| 27 ++ .../auxiliary/util/u_threaded_context_calls.h | 1

[Mesa-dev] [PATCH 15/17] mesa/st: hook up resource transitions for semaphore calls

Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_semaphoreobjects.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_semaphoreobjects.c b/src/mesa/state_tracker/st_cb_semaphoreobjects.c index f6242c7

[Mesa-dev] [PATCH 11/17] winsys/amdgpu: add support for syncobj signaling

Add the ability to signal a syncobj when a cs completes execution. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/radeon_winsys.h | 12 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 81 +- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 4 ++ 3

[Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

e unsupervised effort (*fingers crossed it doesn't catch fire while I sleep*). Patches 1-12 add support for semaphore wait/signal/import Patch 13 implements buffer/texture barriers Patches 14-16 implement layout transitions Patch 17 exposes the extension Andres Rodriguez (17): gallium: introduce PI

[Mesa-dev] [PATCH 08/17] mesa: add support for semaphore object signal/wait

Memory synchronization is left for a future patch. Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 32 2 files changed, 46 insertions(+) diff --git a/src/mesa/main/dd.h b/src/mesa/main

[Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_semaphoreobjects.c | 28 + 1 file changed, 28 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_semaphoreobjects.c b/src/mesa

[Mesa-dev] [PATCH 07/17] mesa/st: add support for semaphore object create/import/delete

Add basic semaphore object operations. Signed-off-by: Andres Rodriguez --- src/mesa/Makefile.sources | 2 + src/mesa/meson.build| 2 + src/mesa/state_tracker/st_cb_semaphoreobjects.c | 56 + src/mesa/state_tracker

[Mesa-dev] [PATCH 06/17] u_threaded_context: add support for semaphore wait/signal

Signed-off-by: Andres Rodriguez --- src/gallium/auxiliary/util/u_threaded_context.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gallium/auxiliary/util/u_threaded_context.c index 7e28b87..272d846 100644

[Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++ src/gallium/drivers/ddebug/dd_screen.c | 25 + src/gallium/drivers/trace/tr_context.c | 36 ++ src/gallium/drivers/trace/tr_screen.c | 39

  1   2   3   >