Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Tapani Pälli
On 08/17/2018 07:37 AM, Jason Ekstrand wrote: On Thu, Aug 16, 2018 at 10:39 PM Matt Turner > wrote: On Thu, Aug 16, 2018 at 5:50 PM Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote: > If that's true then the extension makes no sense other than maybe "w

[Mesa-dev] [Bug 107601] Rise of the Tomb Raider Segmentation Fault when the game starts

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107601 Bug ID: 107601 Summary: Rise of the Tomb Raider Segmentation Fault when the game starts Product: Mesa Version: git Hardware: Other OS: All Stat

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Lower pipeline layouts etc. after linking

2018-08-16 Thread Jason Ekstrand
On Thu, Aug 16, 2018 at 10:11 PM Timothy Arceri wrote: > Nice numbers :) > > I'm not sure I 100% follow the why for patch 1 but the logic seems > correct for the way you want to change > I just sort-of found that one along the way. It'd be good if Lionel took a real quick look at it. > t, and

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Jason Ekstrand
On Thu, Aug 16, 2018 at 10:39 PM Matt Turner wrote: > On Thu, Aug 16, 2018 at 5:50 PM Jason Ekstrand > wrote: > > If that's true then the extension makes no sense other than maybe "we're > a > > UMA, we can make things cheap." I think it's more likely that the > intention > > is to use a fenced

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Matt Turner
On Thu, Aug 16, 2018 at 5:50 PM Jason Ekstrand wrote: > If that's true then the extension makes no sense other than maybe "we're a > UMA, we can make things cheap." I think it's more likely that the intention > is to use a fenced map through the GTT to do the detiling. That said, given > how sketc

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Lower pipeline layouts etc. after linking

2018-08-16 Thread Timothy Arceri
Nice numbers :) I'm not sure I 100% follow the why for patch 1 but the logic seems correct for the way you want to change it, and all other patches look good to me so series: Reviewed-by: Timothy Arceri On 08/08/18 18:12, Jason Ekstrand wrote: This allows us to use the link-optimized shade

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- Comment #4 from Zhaowei Yuan --- A new patch to fix this issue: https://patchwork.freedesktop.org/patch/245027/ -- You are receiving this mail because: You are the assignee for the bug.___ mesa-d

[Mesa-dev] [PATCH] glcpp: Expand macro before expanding __LINE__ in its replacement

2018-08-16 Thread Zhaowei Yuan
From: zhaowei yuan If a macro which contains __LINE__ in its replacement, we should expand the macro itself firstly and then expanding __LINE__, otherwise __LINE__ will be expanded as an wrong line number. This patch fixes following CTS test case: dEQP-GLES2.functional.shaders.preprocessor.prede

Re: [Mesa-dev] [PATCH 03/13] docs: Initial version of INTEL_shader_atomic_float_minmax spec

2018-08-16 Thread Caio Marcelo de Oliveira Filho
Hello, > +(add a new row after the exiting "atomicMax" table row, p. 179) > + > +float atomicMax(inout float mem, float data) > + > +Computes a new value by taking the maximum of the value of data and > + the contents of mem. If one of these is an IEEE signaling NaN (i.e.,

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Jason Ekstrand
If that's true then the extension makes no sense other than maybe "we're a UMA, we can make things cheap." I think it's more likely that the intention is to use a fenced map through the GTT to do the detiling. That said, given how sketchy GTT maps are, it's still a pretty questionable extension

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug 107457 depends on bug 107510, which changed state. Bug 107510 Summary: [GEN8+] up to 10% perf drop on several 3D benchmarks https://bugs.freedesktop.org/show_bug.cgi?id=107510 What|Removed |Added --

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-16 Thread Mathieu Bridon
On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > --- > > I didn't see any patches from anyone else, so I wrote some real > quick. Please > point to them if other patches already exist. I was about to send mine, but you were faster. >_< They ar every similar though, except that you missed

[Mesa-dev] [Bug 83785] Shader branches excluded by uniform values are not optimized out

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83785 --- Comment #5 from Roland Scheidegger --- Well it was already classified as an enhancement, so technically it's still open (I actually wrote some code to fix this but it's not fully fleshed out and never finished it). -- You are receiving this

[Mesa-dev] [Bug 107594] [PATCH] fix crosscompilling with meson

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107594 Dylan Baker changed: What|Removed |Added CC||baker.dyla...@gmail.com Assigne

Re: [Mesa-dev] [PATCH 09/21] mesa: remove legacy TCL dri config options

2018-08-16 Thread Roland Scheidegger
Am 15.08.2018 um 20:47 schrieb Ian Romanick: > On 08/15/2018 04:09 AM, Timothy Arceri wrote: >> On 15/08/18 20:26, Michel Dänzer wrote: >>> On 2018-08-15 12:13 PM, Timothy Arceri wrote: Use enviroment var overrides in legacy drivers instead. >>> >>> This could break existing user configuration

[Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-16 Thread Dylan Baker
--- I didn't see any patches from anyone else, so I wrote some real quick. Please point to them if other patches already exist. src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6 -- src/compiler/glsl/tests/sexps.py | 9 +++--

[Mesa-dev] [PATCH 2/2] meson: Use python3 to run glsl tests

2018-08-16 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++ b/src/compiler/glsl

Re: [Mesa-dev] [PATCH 12/13] winsys/amdgpu: add vcn jpeg cs support

2018-08-16 Thread Boyuan Zhang
On 2018-08-16 01:41 PM, Leo Liu wrote: On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Add vcn jpeg cs support, align cs by no-op. Signed-off-by: Boyuan Zhang ---   src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12   1 file changed, 12 insertions(+) diff

[Mesa-dev] [PATCH 2/4] i965: Allow creation of brw_bo from system memory (userptr)

2018-08-16 Thread Chris Wilson
Since v3.16 (though universal access was only enabled by default in v4.6), the kernel has offered the ability to wrap any system memory (i.e. RAM and not I/O mapped memory) into an object that can be used by the GPU. The caveat is that this object is marked as cache coherent (so that the client can

[Mesa-dev] [PATCH 1/4] intel: Mark i965g/i965gm as having buggy snoop access

2018-08-16 Thread Chris Wilson
Recent kernels do exclude snoop access for i965g/i965gm as it does not work as advertised. However to avoid depending on a recent kernel for old hardware, mark the presence of the bug in gen_device_info. See kernel commit df0700e53047662c167836bd6fdeea55d5d8dcfa Author: Chris Wilson Date: Wed S

[Mesa-dev] [PATCH 3/4] i965: Expose AMD_pinned_memory

2018-08-16 Thread Chris Wilson
All GEN GPU can bind to any piece of memory (thanks UMA), and so through a special ioctl we can map a chunk of page-aligned client memory into the GPU address space. However, not all GEN are equal. Some have cache-coherency between the CPU and the GPU, whilst the others are incoherent and rely on s

[Mesa-dev] [PATCH 4/4] docs/relnotes: Add AMD_pinned_memory for i965

2018-08-16 Thread Chris Wilson
Technically only for Sandybridge and later core designs, but finally we can claim support for allowing clients to create glBufferObjects from their own memory. --- docs/relnotes/18.3.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html in

Re: [Mesa-dev] [PATCH 07/13] st/va: get mjpeg slice header

2018-08-16 Thread Boyuan Zhang
On 2018-08-16 01:26 PM, Leo Liu wrote: On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang ---   src/gallium/state_trackers/va/picture.c   |   3 +   src/galliu

Re: [Mesa-dev] [PATCH 06/13] radeon/vcn: add jpeg decode implementation

2018-08-16 Thread Boyuan Zhang
On 2018-08-16 01:19 PM, Leo Liu wrote: On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang ---   src/gallium/drivers/radeo

[Mesa-dev] [PATCH 06/13] radeon/vcn: add jpeg decode implementation

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/galliu

[Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_uvd.c | 147 1 file changed, 147 deletions(-) diff --git a/src/gallium/drivers/radeon/

[Mesa-dev] [PATCH 07/13] st/va: get mjpeg slice header

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 13 ++- src/gallium/state_trackers/va/picture_mjpeg.c | 132 ++ src/gallium/state

[Mesa-dev] [PATCH] intel/tools: new i965_disasm tool

2018-08-16 Thread Sagar Ghuge
Adds a new i965 instruction disassemble tool Signed-off-by: Sagar Ghuge --- src/intel/Makefile.tools.am | 15 +++ src/intel/tools/i965_disasm.c | 202 ++ src/intel/tools/i965_disasm.h | 46 src/intel/tools/meson.build | 11 ++ 4 files changed, 274

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: don't unmap what wasn't mapped

2018-08-16 Thread Lepton Wu
On Thu, Aug 16, 2018 at 1:37 PM Ray Strode wrote: > > From: Ray Strode > > At the moment, depending on pipe transfer flags, the dumb > buffer map address can end up at either kms_sw_dt->ro_mapped > or kms_sw_dt->mapped. > > When it's time to unmap the dumb buffer, both locations get unmapped, > e

Re: [Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

2018-08-16 Thread Dylan Baker
Quoting Emil Velikov (2018-08-16 09:19:06) > On 16 August 2018 at 14:27, Emil Velikov wrote: > > On 15 August 2018 at 17:18, Dylan Baker wrote: > >> We don't want to support older versions of python 2 anymore, and we > >> don't support python 3.x in autotools currently. > >> --- > >> configure.a

[Mesa-dev] [PATCH] gallium/winsys/kms: don't unmap what wasn't mapped

2018-08-16 Thread Ray Strode
From: Ray Strode At the moment, depending on pipe transfer flags, the dumb buffer map address can end up at either kms_sw_dt->ro_mapped or kms_sw_dt->mapped. When it's time to unmap the dumb buffer, both locations get unmapped, even though one is probably initialized to 0. That leads to the cod

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-16 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-16 09:52:05) > On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently we use AC_CHECK_PROGS looking for python2.7, python2 and > > finally python. That is due to the varying names used across the > > different OS. > >

Re: [Mesa-dev] [PATCH 2/2] configure: use distutils in ax_check_python_mako_module

2018-08-16 Thread Dylan Baker
Quoting Emil Velikov (2018-08-16 09:18:57) > From: Emil Velikov > > Handling the version comparison by hand is a bad idea. Python has a handy > module distutils for that - use it. > > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > Not entirely sure if Loose or Strict version should be u

Re: [Mesa-dev] [PATCH mesa] intel: various python cleanups

2018-08-16 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-16 07:43:23) > Signed-off-by: Eric Engestrom > --- > Didn't feel like sending 15 patches for these, but I can split out some > of it if needed. > --- > src/intel/genxml/gen_bits_header.py | 1 - > src/intel/genxml/gen_pack_header.py | 29 ++

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #8 from Alexander Tsoy --- (In reply to Samuel Pitoiset from comment #7) > 1) RADV_DEBUG=nodcc fixes the rendering issue Yes. Also your patch [1] fixes it. > 2) RADV_DEBUG=nohiz seems to fix the VM faults I confirm that. [1] https:

Re: [Mesa-dev] [PATCH v2 9/9] meson: Build with Python 3

2018-08-16 Thread Mathieu Bridon
Hi Emil, On Thu, 2018-08-16 at 17:11 +0100, Emil Velikov wrote: > On 9 August 2018 at 09:27, Mathieu Bridon > wrote: > > Now that all the build scripts are compatible with both Python 2 > > and 3, we can flip the switch and tell Meson to use the latter. > > > > Since Meson already depends on Pyt

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: do not munmap NULL pointers

2018-08-16 Thread Lepton Wu
Hi Jan, On Thu, Aug 16, 2018 at 10:37 AM Emil Velikov wrote: > > Hi Jan, > > On 13 July 2018 at 20:57, Jan Palus wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107098 > > Signed-off-by: Jan Palus > > --- Thanks for fixing this, actually after digging in some kernel code, it se

Re: [Mesa-dev] [PATCH 1/9] util/dynarray: add a clone function

2018-08-16 Thread Caio Marcelo de Oliveira Filho
On Thu, Aug 16, 2018 at 07:29:40AM +0200, Thomas Helland wrote: > 2018-08-15 23:56 GMT+02:00 Caio Marcelo de Oliveira Filho > : > > --- > > src/util/u_dynarray.h | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > > index dcbbc06d

[Mesa-dev] [Bug 107594] [PATCH] fix crosscompilling with meson

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107594 Bug ID: 107594 Summary: [PATCH] fix crosscompilling with meson Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: blocker P

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Ian Romanick
My recollection is that we never implemented this because it required linear textures instead of tiled textures. In every speed test we did, the read performance of tiled textures was so much better than the read performance of linear textures that it seemed unlikely to be a benefit. Instead, we c

Re: [Mesa-dev] [PATCH 13/13] radeonsi: enable vcn jpeg decode for raven

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Enable vcn jpeg decode for raven. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c

Re: [Mesa-dev] [PATCH 12/13] winsys/amdgpu: add vcn jpeg cs support

2018-08-16 Thread Leo Liu
On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Add vcn jpeg cs support, align cs by no-op. Signed-off-by: Boyuan Zhang --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amd

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: do not munmap NULL pointers

2018-08-16 Thread Emil Velikov
Hi Jan, On 13 July 2018 at 20:57, Jan Palus wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107098 > Signed-off-by: Jan Palus > --- Thanks for fixing this issue. For the future, feel free to use a fixes tag (+cc) as below. It provides a nice reference when picking the fix for sta

Re: [Mesa-dev] [PATCH 11/13] amd/common: add vcn jpeg ip info query

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gp

Re: [Mesa-dev] [PATCH 10/13] radeon/vcn: implement jpeg target buffer cmd

2018-08-16 Thread Leo Liu
Patch 9-10: Acked-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Implement jpeg target buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_

Re: [Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_uvd.c | 136 1 file

Re: [Mesa-dev] [PATCH 07/13] st/va: get mjpeg slice header

2018-08-16 Thread Leo Liu
On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 3 + src/gallium/state_trackers/va/picture_mjpeg.c | 132 ++

Re: [Mesa-dev] [PATCH 06/13] radeon/vcn: add jpeg decode implementation

2018-08-16 Thread Leo Liu
On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/galli

Re: [Mesa-dev] [PATCH 05/13] radeon/vcn: separate send cmd call from end frame

2018-08-16 Thread Leo Liu
Patch 1-5: Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Use function pointer for sending cmd in end_frame call. By doing this, we can assign different cmd sending logics for Jpeg decode later. Signed-off-by: Boyuan Zhang --- src/gallium/dri

[Mesa-dev] [PATCH] docs: update required mako version

2018-08-16 Thread Emil Velikov
From: Emil Velikov The requirement was bumped a while back, but we forgot to update the docs. Fixes: ed871af91c2 ("configure.ac: raise Mako required version to 0.8.0") Cc: Eric Engestrom Signed-off-by: Emil Velikov --- docs/install.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Mesa-dev] [PATCH] radv: do not use CP predication for DCC decompressions

2018-08-16 Thread Samuel Pitoiset
This fixes a regression with some Unity demos. Not sure what the root cause of the problem is, especially because the driver doesn't perform any fast color clears. So, it shouldn't be needed to decompress DCC. RadeonSI says that the decompression is relatively cheap if the surface has been decompre

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Phi Nguyen
Cool. Thanks Lionel! Best, Phi On Thu, Aug 16, 2018 at 12:03 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hey Phi, > > I can confirm this extension isn't implemented in Mesa. > I don't why it wasn't. > > Talking briefly with Jason, it seems that mapping texture makes less sens

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-16 Thread Eric Engestrom
On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently we use AC_CHECK_PROGS looking for python2.7, python2 and > finally python. That is due to the varying names used across the > different OS. > > Use the handy AM_PATH_PYTHON which finds the correct name

Re: [Mesa-dev] [PATCH mesa] i965: drop duplicate assignments

2018-08-16 Thread Caio Marcelo de Oliveira Filho
On Thu, Aug 16, 2018 at 04:00:16PM +0100, Eric Engestrom wrote: > These are all already assigned when declared, a few lines above. > > Signed-off-by: Eric Engestrom > --- > Note: I'm not 100% certain the value can never change by the time this > second assignment is done, so maybe it's the initia

[Mesa-dev] [Bug 107098] Segfault after munmap(kms_sw_dt->ro_mapped)

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107098 --- Comment #3 from Jan Palus --- Note that I ultimately went for "setting AccelMethod=none" since rxvt-unicode lags pretty badly in VirtualBox with glamor. -- You are receiving this mail because: You are the QA Contact for the bug. You are th

[Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-16 Thread Emil Velikov
From: Emil Velikov Currently we use AC_CHECK_PROGS looking for python2.7, python2 and finally python. That is due to the varying names used across the different OS. Use the handy AM_PATH_PYTHON which finds the correct name and checks for the version. Note: python2.7 has been an unofficial requi

[Mesa-dev] [PATCH 2/2] configure: use distutils in ax_check_python_mako_module

2018-08-16 Thread Emil Velikov
From: Emil Velikov Handling the version comparison by hand is a bad idea. Python has a handy module distutils for that - use it. Cc: Dylan Baker Signed-off-by: Emil Velikov --- Not entirely sure if Loose or Strict version should be used. Input highly appreciated. --- m4/ax_check_python_mako_m

Re: [Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 14:27, Emil Velikov wrote: > On 15 August 2018 at 17:18, Dylan Baker wrote: >> We don't want to support older versions of python 2 anymore, and we >> don't support python 3.x in autotools currently. >> --- >> configure.ac | 7 +++ >> 1 file changed, 7 insertions(+) >> >>

Re: [Mesa-dev] [PATCH v2 9/9] meson: Build with Python 3

2018-08-16 Thread Emil Velikov
Hi Mathieu, On 9 August 2018 at 09:27, Mathieu Bridon wrote: > Now that all the build scripts are compatible with both Python 2 and 3, > we can flip the switch and tell Meson to use the latter. > > Since Meson already depends on Python 3 anyway, this means we don't need > two different Python sta

[Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_uvd.c | 136 1 file changed, 136 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c

[Mesa-dev] [PATCH 06/13] radeon/vcn: add jpeg decode implementation

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/galliu

[Mesa-dev] [PATCH 09/13] radeon/vcn: implement jpeg bitstream buffer cmd

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Implement jpeg bitstream buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec_jpeg.c | 46 +++- 1 file changed, 45 insertions(+), 1 deletion

[Mesa-dev] [PATCH 13/13] radeonsi: enable vcn jpeg decode for raven

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Enable vcn jpeg decode for raven. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index fc2be33..de587bb 100644 --- a/sr

[Mesa-dev] [PATCH 10/13] radeon/vcn: implement jpeg target buffer cmd

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Implement jpeg target buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec_jpeg.c | 73 +++- 1 file changed, 72 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 12/13] winsys/amdgpu: add vcn jpeg cs support

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add vcn jpeg cs support, align cs by no-op. Signed-off-by: Boyuan Zhang --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c inde

[Mesa-dev] [PATCH 11/13] amd/common: add vcn jpeg ip info query

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 73fc362..a1db3b9 100644 --- a/src/amd/common/ac_gpu_info.c +++ b/

[Mesa-dev] [PATCH 07/13] st/va: get mjpeg slice header

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 3 + src/gallium/state_trackers/va/picture_mjpeg.c | 132 ++ src/gallium/state_trackers/va/va

[Mesa-dev] [PATCH 04/13] radeon/vcn: create cs based on ring type

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add RING_VCN_JPEG for VCN Jpeg decode, and keep RING_VCN_DEC for other codecs. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c

[Mesa-dev] [PATCH 05/13] radeon/vcn: separate send cmd call from end frame

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Use function pointer for sending cmd in end_frame call. By doing this, we can assign different cmd sending logics for Jpeg decode later. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 30 - src/gallium/drivers/radeon

[Mesa-dev] [PATCH 02/13] radeon/vcn: add vcn jpeg decode interface

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add VCN Jpeg decode interfaces and register defines. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec.h | 91 + 1 file changed, 91 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.h b/src/gallium/driv

[Mesa-dev] [PATCH 03/13] radeon/winsys: add vcn jpeg ring type

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Add a new ring type for vcn jpeg. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 0a56539..6290eef 10

[Mesa-dev] [PATCH 01/13] radeon/vcn: move radeon decoder define to header file

2018-08-16 Thread boyuan.zhang
From: Boyuan Zhang Move radeon_decoder definition from "radeon_vcn_dec.c" to "radeon_vcn_dec.h", so that it can be included by other files later. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 28 src/gallium/drivers/radeon/radeon_vcn

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #12 from amonpaike --- > run "apitrace trace blender"), get to the point where things go wrong in > blender, and after it has made visible you can just close blender and then > try to attach the resulting blender.trace file to the b

Re: [Mesa-dev] INTEL_map_texture on i915/i965

2018-08-16 Thread Lionel Landwerlin
Hey Phi, I can confirm this extension isn't implemented in Mesa. I don't why it wasn't. Talking briefly with Jason, it seems that mapping texture makes less sense on Skylake and above generations. There we maintain compressed version of the textures in memory to further reduce memory bandwidth

Re: [Mesa-dev] [PATCH mesa] mailmap: add various typos of Emil's address from the log

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 16:08, Eric Engestrom wrote: > Cc: Emil Velikov > Signed-off-by: Eric Engestrom > --- > .mailmap | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/.mailmap b/.mailmap > index ff60ba7ea8548ee2c6b0..848d71400c0e146c9eab 100644 > --- a/.mailmap > +++ b/.mailmap > @

Re: [Mesa-dev] [PATCH mesa] intel: various python cleanups

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 15:43, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Didn't feel like sending 15 patches for these, but I can split out some > of it if needed. Seems like a few C-isms got in there. Fwiw the patch is Reviewed-by: Emil Velikov -Emil _

Re: [Mesa-dev] [PATCH mesa] egl: check for buffer overflow *before* corrupting our memory

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 15:35, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- It's very unlikely to happen since we have ClientAPIsString[100] and the supported API are not going to overflow it anytime soon. Regardless, patch is perfectly valid. Reviewed-by: Emil Velikov -Emil __

Re: [Mesa-dev] [PATCH] fixup! anv: Use central api generation scripts.

2018-08-16 Thread Eric Engestrom
On Thursday, 2018-08-16 15:47:11 +0100, Emil Velikov wrote: > --- > src/intel/Android.vulkan.mk | 8 > src/intel/Makefile.vulkan.am| 10 +- > src/intel/vulkan/anv_entrypoints_gen.py | 9 ++--- > src/intel/vulkan/anv_extensions_gen.py | 9 ++--- >

Re: [Mesa-dev] [PATCH mesa] egl/wayland: remove sign from bitfield `formats`

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 15:29, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.h | 2 +- > src/egl/drivers/dri2/platform_wayland.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Emil Velikov -Emil ___

Re: [Mesa-dev] [PATCH mesa] egl/wayland: upcast before bitwise ops

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 15:23, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_wayland.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/egl/drivers/dri2/platform_wayland.c > b/src/egl/drivers/dri2/platform_wayland.c

Re: [Mesa-dev] [PATCH mesa v2 1/3] git_sha1: simplify logic

2018-08-16 Thread Emil Velikov
On 16 August 2018 at 14:24, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 6 +- > src/Makefile.am | 2 +- > src/git_sha1.h.in| 1 - > src/mesa/Android.libmesa_git_sha1.mk | 2 +- > 4 files changed

[Mesa-dev] [PATCH mesa] mailmap: add various typos of Emil's address from the log

2018-08-16 Thread Eric Engestrom
Cc: Emil Velikov Signed-off-by: Eric Engestrom --- .mailmap | 5 + 1 file changed, 5 insertions(+) diff --git a/.mailmap b/.mailmap index ff60ba7ea8548ee2c6b0..848d71400c0e146c9eab 100644 --- a/.mailmap +++ b/.mailmap @@ -145,6 +145,11 @@ Edward O'Callaghan Emeric Grange Emeric Emi

[Mesa-dev] [PATCH mesa] util/xmlpool: make indentation coherent

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/util/xmlpool/t_options.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/util/xmlpool/t_options.h b/src/util/xmlpool/t_options.h index f0537e965b8a3cda894c..a31fafac14c6ffb55bb2 100644 --- a/src/util/xmlpoo

[Mesa-dev] [PATCH mesa] i965: drop duplicate assignments

2018-08-16 Thread Eric Engestrom
These are all already assigned when declared, a few lines above. Signed-off-by: Eric Engestrom --- Note: I'm not 100% certain the value can never change by the time this second assignment is done, so maybe it's the initial one that should be dropped? --- src/mesa/drivers/dri/i965/brw_cs.c | 1 -

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

2018-08-16 Thread Emil Velikov
On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > radv was always just mirroring a derived version of the anv > version, sometimes hacked together and sometimes very behind. > > As we grow more vulkan drivers this repetition makes even less > sense, so lets merge them. I took the anv generator

Re: [Mesa-dev] [PATCH mesa] i965: drop unused assignment

2018-08-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 16/08/18 15:49, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index b0f83f

Re: [Mesa-dev] [PATCH mesa] anv: drop cast-to-void of used variable

2018-08-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 16/08/18 15:48, Eric Engestrom wrote: `device` is used 2 lines below, even visible in the diff context printed. Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH mesa] anv: use safer snprintf() to ensure NULL string-terminator

2018-08-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 16/08/18 15:46, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index c40b94d69f349828b96

[Mesa-dev] [PATCH] fixup! radv: Integrate with common generators.

2018-08-16 Thread Emil Velikov
--- src/amd/vulkan/Android.mk | 4 ++-- src/amd/vulkan/Makefile.am | 16 src/amd/vulkan/meson.build | 26 -- src/amd/vulkan/radv_entrypoints_gen.py | 9 ++--- src/amd/vulkan/radv_extensions_gen.py | 9 ++---

[Mesa-dev] [PATCH] fixup! anv: Use central api generation scripts.

2018-08-16 Thread Emil Velikov
--- src/intel/Android.vulkan.mk | 8 src/intel/Makefile.vulkan.am| 10 +- src/intel/vulkan/anv_entrypoints_gen.py | 9 ++--- src/intel/vulkan/anv_extensions_gen.py | 9 ++--- src/intel/vulkan/anv_icd.py | 7 +-- src/intel/vulkan

[Mesa-dev] [PATCH mesa] i965: drop unused assignment

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index b0f83fb832066094f044..f1675b191c1003883f90 100644 --- a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH mesa] anv: drop cast-to-void of used variable

2018-08-16 Thread Eric Engestrom
`device` is used 2 lines below, even visible in the diff context printed. Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 897249baa6aea4958c23..d8b67b54d638fb42d

[Mesa-dev] [PATCH mesa] anv: use safer snprintf() to ensure NULL string-terminator

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index c40b94d69f349828b964..897249baa6aea4958c23 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/i

[Mesa-dev] [PATCH mesa] intel: various python cleanups

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Didn't feel like sending 15 patches for these, but I can split out some of it if needed. --- src/intel/genxml/gen_bits_header.py | 1 - src/intel/genxml/gen_pack_header.py | 29 ++--- src/intel/genxml/gen_zipped_file.py | 1 - src/intel/

Re: [Mesa-dev] [PATCH mesa] intel/batch-decoder: replace local ARRAY_LENGTH() macro with global ARRAY_SIZE()

2018-08-16 Thread Lionel Landwerlin
On 16/08/18 15:38, Eric Engestrom wrote: Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decod

[Mesa-dev] [PATCH mesa] intel/batch-decoder: replace local ARRAY_LENGTH() macro with global ARRAY_SIZE()

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/common/gen_batch_decoder.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index f5be0018afce507685b4..f93f4df0066b8191ca5f 100644 --- a/src/intel/comm

[Mesa-dev] [PATCH mesa] egl: check for buffer overflow *before* corrupting our memory

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 19fae12f5b7596e07959..5e5048c4d69fdcf02a15 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/egl

[Mesa-dev] [PATCH mesa] egl/wayland: remove sign from bitfield `formats`

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.h | 2 +- src/egl/drivers/dri2/platform_wayland.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h index f8001ec4b661f6dce20b..

[Mesa-dev] [PATCH mesa] egl/wayland: upcast before bitwise ops

2018-08-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0913394b365255f6af63..f1680495210987d57ba6 100644 --- a/sr

Re: [Mesa-dev] [PATCH v5 1/2] intel/ppgtt: memory address alignment

2018-08-16 Thread Sergii Romantsov
And also thanks to you :). On Thu, Aug 16, 2018 at 4:16 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Both patches pushed to master. > > Thanks! > > - > Lionel > > > On 15/08/18 16:03, Lionel Landwerlin wrote: > >> On 15/08/18 12:23, Sergii Romantsov wrote: >> >>> Kernel (for pp

  1   2   >