Hi Emil, On Thu, 2018-08-16 at 17:11 +0100, Emil Velikov wrote: > On 9 August 2018 at 09:27, Mathieu Bridon <boche...@daitauha.fr> > wrote: > > Now that all the build scripts are compatible with both Python 2 > > and 3, we can flip the switch and tell Meson to use the latter. > > > > Since Meson already depends on Python 3 anyway, this means we don't > > need two different Python stacks to build Mesa. > > Just did a quick test of enabling python3 for the autoconf build and > noticed that some parts are not converted to python2+3. > Namely, invoking the following fail. > glsl/tests/optimization-test.sh > glsl/glcpp/tests/glcpp-test.sh > > I'm concerned that this didn't flag as failure with meson
Those Bash scripts aren't used anywhere by the meson build. However, the Python scripts that they run are: * src/compiler/glsl/tests/optimization_test.py * src/compiler/glsl/glcpp/tests/glcpp_test.py Both are run directly (they are executables), and their shebang is Python 2. :-/ They just aren't hooked up using prog_python like all the build scripts, so I indeed completely missed them. Are you already porting them over? Otherwise I'll try to have a look ASAP. Thanks, -- Mathieu _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
