Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote: [snip] > I've been doing this for Intel. Developers are on the hook to fix their > bugs, but you can't make them do it. They have many pressures on them, > and a maintainer can't make the call as to whether a rendering bug is > more impor

Re: [Mesa-dev] [PATCH 2/2] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

On Mon, 2018-03-12 at 07:37 -0700, Jason Ekstrand wrote: > On Mon, Mar 12, 2018 at 1:40 AM, Iago Toral Quiroga m> wrote: > > af5f2322d0c64 addressed this for extension commands, but the spec > > mandates > > > > this behavior also for core API commands. From the Vulkan spec, > > > > Table 2. vkG

Re: [Mesa-dev] [PATCH 02/50] glsl: Add "built-in" functions to do neg(fp64) (v2)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > v2: use mix. > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 51 > + > src/compiler/glsl/builtin_functions.cpp | 4 +++ > src/compiler/glsl/builtin_functio

[Mesa-dev] [PATCH 49/50] gallium: add pipe double support enum + docs

From: Dave Airlie --- src/gallium/docs/source/screen.rst | 4 +++- src/gallium/include/pipe/p_defines.h | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index e375d67..42e4f32 100644 --- a/src/g

[Mesa-dev] [PATCH 45/50] glsl: Add a lowering pass for 64-bit float frac()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 25 + 1 file changed, 25 insertions(+) diff --git a/src/compiler/glsl/lower_instructions.cpp b/src/compiler/glsl/lower_instructions.cpp index 3064eef..94b262d 100644 --- a/s

[Mesa-dev] [PATCH 44/50] glsl: Add a lowering pass for 64-bit float ceil()

From: Elie Tournier [airlied: handle vector case] Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/lower_instructions.cpp b/src/compiler/glsl/lower_in

[Mesa-dev] [PATCH 24/50] glsl: Add a lowering pass for 64-bit float less()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 17d

[Mesa-dev] [PATCH 48/50] glsl: add lowering for mod64()

From: Elie Tournier This lowers to floor using the same code as the float lowering, it also fixes things to avoid creating more instructions that need lowering. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 9 +++--

[Mesa-dev] [PATCH 35/50] glsl: Add a lowering pass for 64-bit float round()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 6ef75

[Mesa-dev] [PATCH 34/50] glsl: Add a lowering pass for 64-bit float trunc()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 1b5d5

[Mesa-dev] [PATCH 39/50] glsl: Add a lowering pass for 64-bit float gequal()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index c4b8e78..0dc6070 100644 --- a/src/compiler/glsl/lower_64bit.

[Mesa-dev] [PATCH 29/50] glsl: Add a lowering pass for 64-bit float d2i()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index a4cb7

[Mesa-dev] [PATCH 27/50] glsl: Add a lowering pass for 64-bit float d2u()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 6506e

[Mesa-dev] [PATCH 33/50] glsl: Add a lowering pass for 64-bit float sqrt()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index c649c

[Mesa-dev] [PATCH 50/50] st/glsl: enable fp64 lowering support

From: Dave Airlie This enables fp64 emulation if the driver requests it with PIPE_CAP_DOUBLES set to PIPE_DOUBLES_EMULATE. It moves the mat->vec lowering earlier as we don't want to hit any matrix operation in double lowering, and if we lower div->rcp we end up getting the wrong type of matrix m

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

On 13 March 2018 at 14:24, Dave Airlie wrote: > This is the main code for the soft fp64 work. It's mostly Elie's > code with a bunch of changes by me. > All the patches are in my tree here, along with some other bits: https://cgit.freedesktop.org/~airlied/mesa/log/?h=glsl_arb_gpu_shader_fp64_v4

[Mesa-dev] [PATCH 47/50] glsl: add a lowering pass for dfma to dmuladd.

From: Dave Airlie Just lowering dfma to dmuladd for now, I don't think it will matter for anything we care about. This also fixes the double dot to fma lowering to take this flag into account and avoid creating further fma's. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 46/50] glsl: Add a lowering pass for 64-bit float rsq()

From: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 25 + 2 files changed, 26 insertions(+) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index ba0c101..e6f9ad3 1006

[Mesa-dev] [PATCH 42/50] glsl: Add a lowering pass for 64-bit float max()

From: Elie Tournier [airlied: update to handle max(dvec, double) case] Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/compiler/glsl/lower_instructions.cpp b/src/compiler/glsl/lower_i

[Mesa-dev] [PATCH 43/50] glsl: Add a lowering pass for 64-bit float floor()

From: Elie Tournier [airlied: handle vector cases] Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 34 ++-- 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/

[Mesa-dev] [PATCH 32/50] glsl: Add a lowering pass for 64-bit float f2d()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index e7860

[Mesa-dev] [PATCH 40/50] glsl: Add a lowering pass for 64-bit float nequal()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index 0dc6070..f085dae 100644 --- a/src/compiler/glsl/lower_64bit.

[Mesa-dev] [PATCH 41/50] glsl: Add a lowering pass for 64-bit float min()

From: Elie Tournier [airlied: update to handle min(dvec, double) case. Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 33 2 files changed, 34 insertions(+) diff --git a/src/compiler/

[Mesa-dev] [PATCH 38/50] glsl/lower_64bit: lower d2b using comparison

From: Dave Airlie This just does a compare to 0 and inverts the result to lower d2b. Not 100% sure this is always correct, but it passes piglit --- src/compiler/glsl/lower_64bit.cpp | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower

[Mesa-dev] [PATCH 30/50] glsl: Add a lowering pass for 64-bit float i2d()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 3cc7f

[Mesa-dev] [PATCH 31/50] glsl: Add a lowering pass for 64-bit float d2f()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index f73

[Mesa-dev] [PATCH 37/50] glsl/lower_64bit: handle any/all operations

From: Dave Airlie This just splits them out and combines the results. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/g

[Mesa-dev] [PATCH 25/50] glsl: Add a lowering pass for 64-bit float add()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index b5f

[Mesa-dev] [PATCH 23/50] glsl: Add a lowering pass for 64-bit float equal()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 3a406

[Mesa-dev] [PATCH 22/50] glsl: Add a lowering pass for 64-bit float sign()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/lower_64bit.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 2d9728d..3a

[Mesa-dev] [PATCH 28/50] glsl: Add a lowering pass for 64-bit float u2d()

From: Elie Tournier Handle non 64bit sources (airlied) Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compile

[Mesa-dev] [PATCH 26/50] glsl: Add a lowering pass for 64-bit float mul()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/lower_64bit.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 691803e..65

[Mesa-dev] [PATCH 12/50] glsl: Add "built-in" functions to do int_to_fp64(int) (v2)

From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 129 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 23 ++

[Mesa-dev] [PATCH 21/50] glsl: Add a lowering pass for 64-bit float neg()

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 37081

[Mesa-dev] [PATCH 16/50] glsl: Add "built-in" functions to do trunc(fp64) (v2)

From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 62 + src/compiler/glsl/builtin_functions.cpp | 4 +++ src/compiler/glsl/builtin_functions.h | 3 ++ src/compiler/glsl/float64.glsl | 21

[Mesa-dev] [PATCH 17/50] glsl: Add "built-in" functions to do round(fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 225 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 41 ++ src/compil

[Mesa-dev] [PATCH 15/50] glsl: Add "built-in" functions to do sqrt(fp64)

From: Elie Tournier This currently uses fp64->fp32, sqrt(fp32), fp32->fp64. [airlied: The code is include from soft float for doing proper sqrt64 but it needs to be decided if we need to pursue this and how to optimise it better.] Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_flo

[Mesa-dev] [PATCH 18/50] glsl: Add "built-in" functions to do rcp(fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 1829 +++ src/compiler/glsl/builtin_functions.cpp |4 + src/compiler/glsl/builtin_functions.h |3 + src/compiler/glsl/float64.glsl | 10 + src/compiler

[Mesa-dev] [PATCH 19/50] glsl: Add a lowering pass for 64-bit float abs()

From: Elie Tournier Squashed with: glsl/lower_64bit: fix return type conversion (airlied) Only do conversion for the 64-bit types, add a path to do result merging without conversion. Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_64bit.cpp

[Mesa-dev] [PATCH 20/50] glsl: add define to lower all double operations

From: Dave Airlie We will add all fp64 ops to this for now, later drivers may want to only lower some. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization

[Mesa-dev] [PATCH 11/50] glsl: Add "built-in" functions to do fp64_to_int(fp64) (v2)

From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 179 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 41 +

[Mesa-dev] [PATCH 04/50] glsl: Add "built-in" functions to do eq(fp64, fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 104 src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 44 ++ s

[Mesa-dev] soft fp64 support - main body (glsl/gallium)

This is the main code for the soft fp64 work. It's mostly Elie's code with a bunch of changes by me. This patchset has all the glsl lowering code. (using float64.glsl, yes I know checked in files are bad, but not bad enough for anyone to have solved int64.glsl yet, so we have a precedent). It int

[Mesa-dev] [PATCH 02/50] glsl: Add "built-in" functions to do neg(fp64) (v2)

From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 51 + src/compiler/glsl/builtin_functions.cpp | 4 +++ src/compiler/glsl/builtin_functions.h | 3 ++ src/compiler/glsl/float64.glsl | 24

[Mesa-dev] [PATCH 10/50] glsl: Add "built-in" functions to do uint_to_fp64(uint)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 71 + src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 ++ src/compiler/glsl/float64.glsl | 22 ++ src/com

[Mesa-dev] [PATCH 09/50] glsl: Add "built-in" functions to do fp64_to_uint(fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 209 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 61 ++ src/co

[Mesa-dev] [PATCH 13/50] glsl: Add "built-in" functions to do fp64_to_fp32(fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 388 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 100 src/comp

[Mesa-dev] [PATCH 08/50] glsl: Add "built-in" functions to do mul(fp64, fp64) (v2)

From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 1348 +++ src/compiler/glsl/builtin_functions.cpp |4 + src/compiler/glsl/builtin_functions.h |3 + src/compiler/glsl/float64.glsl | 148 +++

[Mesa-dev] [PATCH 14/50] glsl: Add "built-in" functions to do fp32_to_fp64(fp32)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 192 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 38 +++ src/compi

[Mesa-dev] [PATCH 05/50] glsl: add utility function to extract 64-bit sign.

From: Elie Tournier [airlied: left over from dropping le64] Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 18 ++ src/compiler/glsl/float64.glsl | 7 +++ 2 files changed, 25 insertions(+) diff --git a/src/compiler/glsl/builtin_float64.h b/src/

[Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 28 src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3 +++ src/compiler/glsl/float64.glsl | 9 +++

[Mesa-dev] [PATCH 01/50] glsl: Add "built-in" function to do abs(fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/builtin_float64.h | 19 +++ src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3 +++ src/compiler/glsl/float64.g

[Mesa-dev] [PATCH 06/50] glsl: Add "built-in" functions to do lt(fp64, fp64)

From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 135 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 42 ++ src/co

[Mesa-dev] [PATCH] r600: fix abs for op3 sources

From: Roland Scheidegger If a src was referencing the same temp as the dst, the per-component copy code didn't work. e.g. cndge r0.xy, r0.xx, |r2|, r3 got expanded into mov r12.x, |r2| cndge r0.x, r0.x, r12, r3 mov r12.y, |r2| cndge r0.y, r0.x, r12, r3 hence for the second cndge r0.x

[Mesa-dev] [PATCH 1/2] r600: add simple ib dumping under a env var

From: Dave Airlie I've used this a lot when developing, and keep rebasing it around a lot, seems like it could be useful to have upstream. R600_DUMP witll make lots of /tmp/rad_dump_.txt for every command submitted to the hw. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_debug.c

[Mesa-dev] [PATCH 2/2] r600: assert on double opcodes if we hit them

From: Dave Airlie This asserts on any double opcocde getting into the shader assembler on gpus that don't support them. This is a better way to find holes in the soft fp64 coverage than gpu hangs. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 14 ++ 1 file

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Quoting Mark Janes (2018-03-12 14:59:29) > Dylan Baker writes: > > > Quoting Mark Janes (2018-03-12 12:40:47) > >> Handling a screw-up could be done by maintainers by force-pushing the > >> commits off the WIP branch, and adding some annotations that prevent the > >> broken commit from being re-a

[Mesa-dev] [Bug 105444] Enable GL disk shader cache when transform feedback is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=105444 Jordan Justen changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #1 from Jordan Justen

Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

Acked-by: Matt Turner Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

Jason Ekstrand writes: > On Fri, Feb 23, 2018 at 3:43 PM, Keith Packard wrote: > > Once we're sure that's what we want, create an MR against the spec that > just adds enough to the XML to reserve your extension number. That will > get merged almost immediately. Then make a second one with the

Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

On 2018-03-12 14:51:56, Timothy Arceri wrote: > This only seems to be needed by i965. Alternative can't you just remove the: > > if (prog->sh.data->LinkStatus != LINKING_SKIPPED) >goto fail; > > from brw_disk_cache_upload_program() and let the cache search do its job? > > I believe i

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Dylan Baker writes: > Quoting Mark Janes (2018-03-12 12:40:47) >> Handling a screw-up could be done by maintainers by force-pushing the >> commits off the WIP branch, and adding some annotations that prevent the >> broken commit from being re-applied to WIP by automation. >> > > That sounds like

Re: [Mesa-dev] [PATCH 1/2] glsl/serialize: Save shader program metadata sha1

Reviewed-by: Timothy Arceri On 12/03/18 11:25, Jordan Justen wrote: When the shader cache is used, this can be generated. In fact, the shader cache uses this sha1 to lookup the serialized GL shader program. If a GL shader program is restored with ProgramBinary, the shaders are not available, a

Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

This only seems to be needed by i965. Alternative can't you just remove the: if (prog->sh.data->LinkStatus != LINKING_SKIPPED) goto fail; from brw_disk_cache_upload_program() and let the cache search do its job? I believe its possible to end up linking the GLSL IR i.e. prog->sh.data->

Re: [Mesa-dev] [PATCH 0/2] Enable shader cache for ARB_get_program_binary

On 13/03/18 04:31, Emil Velikov wrote: On 12 March 2018 at 00:25, Jordan Justen wrote: git://people.freedesktop.org/~jljusten/mesa program-binary-shader-cache I found that when running DOTA2, most programs were skipping the shader cache. It appears that since DOTA2 uses ARB_get_program_binary,

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #2 from Philip Rebohle --- Created attachment 138044 --> https://bugs.freedesktop.org/attachment.cgi?id=138044&action=edit Tessellation demo screenshot -- You are receiving this mail because: You are the assignee for the bug. You

Re: [Mesa-dev] [PATCH 2/3] nv50, nvc0: Support BGRX1010102 and RGBX1010102 for sampling.

Reviewed-by: Ilia Mirkin It should be possible to get rendering on them BTW, with a bit of state fixups for DST_ALPHA blending. Just haven't gotten around to it. On Mon, Mar 12, 2018 at 4:45 PM, Mario Kleiner wrote: > Add them as usable for textures, so they can be used by > Wayland drm in 10 b

[Mesa-dev] [PATCH 2/3] nv50, nvc0: Support BGRX1010102 and RGBX1010102 for sampling.

Add them as usable for textures, so they can be used by Wayland drm in 10 bpc mode and for X11 compositing under GLX and EGL. We need these formats to be supported at least for sampling, otherwise GLX_texture_from_pixmap and the equivalent EGL image extension won't work with X11 drawables of depth

[Mesa-dev] More pieces for xbgr2101010/abgr2101010 support.

These are needed together with Daniel Stone's 10 bpc bgr patches to make nouveau's 10 bpc support more complete. All tested on nouveau on a nv96 as primary/display gpu and also with a radeon as prime renderoffload gpu, and then the other way round with radeon primary + nouveau renderoffload. Also

[Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

We need to distinguish if a backing pixmap of a window is XRGB2101010 or XBGR2101010, as different gpu hw supports different formats. NVidia hw prefers XBGR, whereas AMD and Intel are happy with XRGB. We use the red channel mask of the visual to distinguish at depth 30, but because we can't easily

[Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

This way the wayland server can signal support for these formats to wayland EGL clients. This is currently used by nouveau for 10 bpc support. Tested with glmark2-wayland and glmark2-es2-wayland under weston to now expose 10 bpc EGL configs under nouveau. Signed-off-by: Mario Kleiner --- src/eg

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Quoting Mark Janes (2018-03-12 12:40:47) > Dylan Baker writes: > > > Quoting Emil Velikov (2018-03-12 08:38:31) > >> On 12 March 2018 at 11:31, Juan A. Suarez Romero > >> wrote: > >> > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > >> >> Ilia Mirkin writes: > >> >> > >> >> > On Tue, Ma

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 05:58, Marek Olšák wrote: > On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: >> On 13 March 2018 at 03:59, Marek Olšák wrote: >>> This is good, though some older distros only have libxcb 1.11. >> >> On those distros you likely just want to --disable-dri3 anyways. >> >> Dav

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: > On 13 March 2018 at 03:59, Marek Olšák wrote: >> This is good, though some older distros only have libxcb 1.11. > > On those distros you likely just want to --disable-dri3 anyways. > > Dave. Good one. I know you don't care, but we are talking

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Emil Velikov writes: > On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >>> - Patches are applied to proposed stable branch by automation when the >>>associated commit is pushed to master. The existing commit message >>>ann

Re: [Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

On Mon, Mar 5, 2018 at 10:21 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > OpSConvert interprets the MSB of the unsigned value as the sign bit and > extends it to the new type. If we want to preserve the value, we need > to use OpUConvert opcode. > > v2: > - No need to check dst t

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Dylan Baker writes: > Quoting Emil Velikov (2018-03-12 08:38:31) >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> >> Ilia Mirkin writes: >> >> >> >> > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov >> >> > wrote: >> >> > > S

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #1 from Philip Rebohle --- Created attachment 138038 --> https://bugs.freedesktop.org/attachment.cgi?id=138038&action=edit Witcher 3 hull shader which may suffer from the same issue FWIW, the tessellation demo works correctly with

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 12 March 2018 at 18:48, Dave Airlie wrote: > On 13 March 2018 at 03:24, Emil Velikov wrote: >> Hi Dave, >> >> On 11 March 2018 at 23:26, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> I'm not sure everyone wants to be updating their dri3 in a forced >>> march setting, this allows a nicer a

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 Bug ID: 105464 Summary: Reading per-patch outputs in Tessellation Control Shader returns undefined values Product: Mesa Version: git Hardware: Other OS: Al

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

ping. --Aaron On Thu, Mar 1, 2018 at 8:02 PM, Aaron Watry wrote: > Used to calculate the default CLC language version based on the --cl-std in > build args > and the device capabilities. > > According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: > 1) If you have -cl-std=C

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 03:59, Marek Olšák wrote: > This is good, though some older distros only have libxcb 1.11. On those distros you likely just want to --disable-dri3 anyways. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Thomas Helland writes: > Walking the whole hash table, inserting entries by hashing them first > is just a really bad idea. We can simply memcpy the whole thing. > --- > src/compiler/glsl/opt_copy_propagation.cpp | 13 -- > .../glsl/opt_copy_propagation_elements.cpp | 29

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Hi Thomas, If I were you I'd split out the introduction of clone_acp() into a separate patch. Regardless of that suggestions, there seems to be a bug in this patch. On 12 March 2018 at 17:55, Thomas Helland wrote: > Walking the whole hash table, inserting entries by hashing them first > is just

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 03:24, Emil Velikov wrote: > Hi Dave, > > On 11 March 2018 at 23:26, Dave Airlie wrote: >> From: Dave Airlie >> >> I'm not sure everyone wants to be updating their dri3 in a forced >> march setting, this allows a nicer approach, esp when you want >> to build on distro that ar

Re: [Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

Hi Thomas, On 12 March 2018 at 17:55, Thomas Helland wrote: > V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) > --- > src/util/hash_table.c | 22 ++ > src/util/hash_table.h | 2 ++ > 2 files changed, 24 insertions(+) > > diff --git a/src/util/hash_tabl

Re: [Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

Reviewed-by: Ian Romanick On 03/12/2018 11:21 AM, Eric Anholt wrote: > v2: Use assume() at the srcs[] definition instead. > > Cc: Jason Ekstrand > Cc: Ian Romanick > Cc: Eric Engestrom > --- > src/compiler/spirv/spirv_to_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/com

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

Quoting Eric Engestrom (2018-03-12 11:05:51) > On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-03-12 07:33:27) > > > We're trying to be -Wundef clean so that we can turn it on (and > > > eventually make it an error). > > > > > > Note that the OMX code alre

Re: [Mesa-dev] Few issues with Meson

This is my cross file (Arch doesn't have a pkg-config for x86, so I have a shell wrapper that sets PKG_CONFIG_PATH), you'll probably need to adjust some paths ``` [binaries] c = '/usr/bin/gcc' cpp = '/usr/bin/g++' ar = '/usr/bin/ar' strip = '/usr/bin/strip' pkgconfig = '/home/dylan/.local/bin/pkg-

[Mesa-dev] [PATCH] meson: don't use compiler.has_header

Meson's compiler.has_header is completely useless, it only checks that a header exists, not whether it's usable. This creates problems if a header contains a conditional #error declaration, like so: > #if __x86_64__ > # error "Doesn't work with x86_64!" > #endif Compiler.has_header will return tr

[Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

v2: Use assume() at the srcs[] definition instead. Cc: Jason Ekstrand Cc: Ian Romanick Cc: Eric Engestrom --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 6a358c597316..3de45c4

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On 12 March 2018 at 17:45, Lepton Wu wrote: > Ping. Any more comments or missing stuff to get this commited into master? > As things have changed a bit (the original map/unmap behaviour is preserved) I was hoping that Tomasz will give it another look. If he prefers, I could add some revision summ

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-12 07:33:27) > > We're trying to be -Wundef clean so that we can turn it on (and > > eventually make it an error). > > > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > > of #ifd

Re: [Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

I've also uploaded this series to my github, if you wan to pull them down from there [1]. I've also uploaded my previously talked about pointer_map to my github account [2]. There's a pointer map, pointer set, and some patches for nir in there, and some for disabling asserts in some places. So it'

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

Hi Andres, On 12 March 2018 at 15:57, Andres Gomez wrote: > On Mon, 2018-03-12 at 16:45 +0100, Juan A. Suarez Romero wrote: >> > >> On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: > > [...] > I'm fully on board with your initial suggestion. >> > My proposal would be, similarly to what In

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

This is good, though some older distros only have libxcb 1.11. Marek On Sun, Mar 11, 2018 at 7:26 PM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distr

Re: [Mesa-dev] Few issues with Meson

Hi Dylan Do you have the link to patch on patchwork? I'll give it a go I'm using meson 0.45 however the cross-file requires more than just defining llvm-config, everything else is normally picked up from what portage is setting in the build environment - though strangely not if clang is used - I'

[Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Walking the whole hash table, inserting entries by hashing them first is just a really bad idea. We can simply memcpy the whole thing. --- src/compiler/glsl/opt_copy_propagation.cpp | 13 -- .../glsl/opt_copy_propagation_elements.cpp | 29 -- 2 files cha

[Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index b7421a0144..f8d5d0f88a 100644 --- a/src/u

[Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

This is a revival of some old patches I had around to improve the compile times in the glsl compiler by reducing the time spend inserting items in the hash table in opt_copy_propagation. I've only rebased this, as my system don't even want to compile anything right now. I also don't remember if it

  1   2   >