[Mesa-dev] [Bug 104376] [ILK] Browser crashes while switching between fullscreen and windowed video on youtube.

2018-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104376 ta...@outlook.com changed: What|Removed |Added Status|RESOLVED|VERIFIED Resolution|DUPLICAT

[Mesa-dev] [PATCH] ac: fix image load store for GLSL_SAMPLER_DIM_3D

2018-01-19 Thread Timothy Arceri
Fixes the following piglit tests: arb_shader_image_load_store/layer/image3d/layered binding test arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1 arb_shader_image_load_store/max-size/image3d max size test/8x2048x8x1 arb_shader_image_load_store/max-size/image3d max size test/8x

Re: [Mesa-dev] [PATCH] radv: add an option that allows to dump pre-optimization ir

2018-01-19 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 19/01/18 22:12, Samuel Pitoiset wrote: With RADV_DEBUG=preoptir. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 +++ src/amd/common/ac_nir_to_llvm.h | 1 + src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c| 1 +

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

2018-01-19 Thread Gurkirpal Singh
I've added the right patches as a reply. Sry again for the inconvenience On Sat, Jan 20, 2018 at 3:38 AM, Gurkirpal Singh wrote: > > > On Fri, Jan 19, 2018 at 8:30 PM, Leo Liu wrote: > >> >> >> On 01/19/2018 04:46 AM, Julien Isorce wrote: >> >> Hi Leo, >> >> Do you have enough data to start th

[Mesa-dev] [PATCH 6/6] st/omx/tizonia/h264d: Add EGLImage support

2018-01-19 Thread Gurkirpal Singh
Example Gstreamer pipeline : MESA_ENABLE_OMX_EGLIMAGE=1 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! omxh264dec ! glimagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce --- src/gallium/state_trackers/omx/Makefile.am | 1 + s

[Mesa-dev] [PATCH 5/6] st/omx/tizonia: Add H.264 encoder

2018-01-19 Thread Gurkirpal Singh
v2: Refactor out screen functions to st/omx Example Gstreamer pipeline : gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! avdec_h264 ! videoconvert ! omxh264enc ! h264parse ! avdec_h264 ! videoconvert ! ximagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce --- src/gallium/s

[Mesa-dev] [PATCH 3/6] st/omx/tizonia: Add entrypoint

2018-01-19 Thread Gurkirpal Singh
Adds base files for adding components Acked-by: Leo Liu Reviewed-by: Julien Isorce --- .../state_trackers/omx/tizonia/Makefile.sources| 4 ++- .../state_trackers/omx/tizonia/entrypoint.c| 37 ++ .../state_trackers/omx/tizonia/entrypoint.h| 35 +++

[Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

2018-01-19 Thread Gurkirpal Singh
Allow only bellagio or tizonia to be used at the same time. Detect tizonia package config file Generate libomx_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328 Acked

[Mesa-dev] [PATCH v2] ac: fix emit vertex stream parameter

2018-01-19 Thread Timothy Arceri
Fixes the following piglit test on radeonsi: ./bin/arb_enhanced_layouts-gs-stream-location-aliasing --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3741b74dc5..781e

Re: [Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

2018-01-19 Thread Jason Ekstrand
On Fri, Jan 19, 2018 at 3:47 PM, Jason Ekstrand wrote: > This pass performs an "ambiguate" operation on a CCS-compressed surface > by manually writing zeros into the CCS. On gen8+, ISL gives us a fairly > detailed notion of how the CCS is laid out so this is fairly simple to > do. On gen7, the

[Mesa-dev] [PATCH] broadcom/vc5: Fix source file name.

2018-01-19 Thread Vinson Lee
Fixes: c9b2cb78972d ("vc5: add missing files to the tarball") Signed-off-by: Vinson Lee --- src/gallium/drivers/vc5/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc5/Makefile.sources b/src/gallium/drivers/vc5/Makefile.sources index bc145

[Mesa-dev] [Bug 104710] [swrast] piglit draw-batch regression

2018-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104710 Bug ID: 104710 Summary: [swrast] piglit draw-batch regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: b

[Mesa-dev] [PATCH] broadcom/vc5: Add missing include paths.

2018-01-19 Thread Vinson Lee
Fixes: 954a704da305 ("broadcom/vc5: Port the RCL setup to V3D4.1.") Signed-off-by: Vinson Lee --- src/gallium/drivers/vc5/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/vc5/Makefile.am b/src/gallium/drivers/vc5/Makefile.am index b8f7e484b3

[Mesa-dev] [PATCH] i965: Accept CONTEXT_ATTRIB_PRIORITY for brwCreateContext

2018-01-19 Thread Chris Wilson
The forward port of commit 6d87500fe12e ("dri: Change __DriverApiRec::CreateContext to take a struct for attribs") failed to adapt the set of allowed attributes for the earlier introduction of context priorities (commit 1617fca6d12e "i965: Pass the EGL/DRI context priority through to the kernel").

Re: [Mesa-dev] [PATCH 17/17] vbo: whitespace/formatting fixes in vbo_split_inplace.c

2018-01-19 Thread Roland Scheidegger
Looks all good to me albeit I'm still no vbo expert... For the series: Reviewed-by: Roland Scheidegger Am 19.01.2018 um 18:47 schrieb Brian Paul: > --- > src/mesa/vbo/vbo_split_inplace.c | 215 > --- > 1 file changed, 111 insertions(+), 104 deletions(-) > >

[Mesa-dev] [PATCH v2 23/24] intel/blorp: Use isl_aux_op instead of blorp_hiz_op

2018-01-19 Thread Jason Ekstrand
--- src/intel/blorp/blorp.c | 2 +- src/intel/blorp/blorp.h | 19 + src/intel/blorp/blorp_clear.c | 2 +- src/intel/blorp/blorp_genX_exec.h | 39 ++- src/intel/blorp/blorp_priv.h

[Mesa-dev] [PATCH v2 24/24] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

2018-01-19 Thread Jason Ekstrand
Completely untested. --- src/intel/blorp/blorp_clear.c | 6 ++ src/intel/blorp/blorp_genX_exec.h | 5 + 2 files changed, 11 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index e9f5463..c5b05b8 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/

[Mesa-dev] [PATCH v2 22/24] intel/blorp: Use isl_aux_op instead of blorp_fast_clear_op

2018-01-19 Thread Jason Ekstrand
--- src/intel/blorp/blorp.h | 9 +-- src/intel/blorp/blorp_clear.c | 10 src/intel/blorp/blorp_genX_exec.h | 16 ++-- src/intel/blorp/blorp_priv.h | 2 +- src/intel/vulkan/anv_blorp.c | 14 +-

[Mesa-dev] [PATCH v2 15/24] anv/cmd_buffer: Pull the undefined layout condition into the if

2018-01-19 Thread Jason Ekstrand
Now that this isn't a multi-case if and it's just the one case, it's a bit clearer if the condition is just part of the if instead of being pulled out into a boolean variable. --- src/intel/vulkan/genX_cmd_buffer.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/s

[Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-19 Thread Jason Ekstrand
Even though the blorp pass looks a bit on the sketchy side, the end result in the Vulkan driver is very nice. Instead of having this weird case where you do a fast clear and then maybe have to resolve, we just do the ambiguate and are done with it. The ambiguate does exactly what we want of setti

[Mesa-dev] [PATCH v2 19/24] anv/cmd_buffer: Move the mi_alu helper higher up

2018-01-19 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 9e2eba3..15e805f 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/

[Mesa-dev] [PATCH v2 20/24] anv/cmd_buffer: Rework aux tracking

2018-01-19 Thread Jason Ekstrand
This commit completely reworks aux tracking. This includes a number of somewhat distinct changes: 1) Since we are no longer fast-clearing multiple slices, we only need to track one fast clear color and one fast clear type. 2) We store two bits for fast clear instead of one to let us di

[Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-01-19 Thread Jason Ekstrand
Now that we're tracking aux properly per-slice, we can enable this for applications which actually care. --- src/intel/vulkan/anv_blorp.c | 22 +++--- src/intel/vulkan/genX_cmd_buffer.c | 13 + 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/src/i

[Mesa-dev] [PATCH v2 13/24] anv: Only fast clear single-slice images

2018-01-19 Thread Jason Ekstrand
The current strategy we use for managing resolves has an issues where we track clear colors and the need for resolves per-LOD but we still allow resolves of only a subset of the slices in any given LOD and doing so sets the "needs resolve" flag for that LOD to false while leaving the remaining laye

[Mesa-dev] [PATCH v2 16/24] anv/cmd_buffer: Re-arrange the logic around UNDEFINED fast-clears

2018-01-19 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 67d3839..77fdadf 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/int

[Mesa-dev] [PATCH v2 12/24] anv/cmd_buffer: Add a mark_image_written helper

2018-01-19 Thread Jason Ekstrand
Currently, this helper does nothing but we call it every place where an image is written through the render pipeline. This will allow us to properly mark the aux state so that we can handle resolves correctly. --- src/intel/vulkan/anv_blorp.c | 44 +- src

[Mesa-dev] [PATCH v2 18/24] anv/image: Simplify some verbose commennts

2018-01-19 Thread Jason Ekstrand
--- src/intel/vulkan/anv_image.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index e34ac95..94b9ecb 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -235,18 +235,11 @@

[Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

2018-01-19 Thread Jason Ekstrand
This pass performs an "ambiguate" operation on a CCS-compressed surface by manually writing zeros into the CCS. On gen8+, ISL gives us a fairly detailed notion of how the CCS is laid out so this is fairly simple to do. On gen7, the CCS tiling is quite crazy but that isn't an issue because we can

[Mesa-dev] [PATCH v2 10/24] anv/cmd_buffer: Add an anv_genX_call macro

2018-01-19 Thread Jason Ekstrand
This is copied and pasted from the similar macro we added to ISL. Reviewed-by: Topi Pohjolainen Reviewed-by: Nanley Chery --- src/intel/vulkan/anv_cmd_buffer.c | 40 --- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/anv_cmd_

[Mesa-dev] [PATCH v2 11/24] anv/blorp: Add src/dst_level helper variables in CmdCopyImage

2018-01-19 Thread Jason Ekstrand
--- src/intel/vulkan/anv_blorp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index ccb9d18..e4e4135 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@ -247,6 +247,7 @@ vo

[Mesa-dev] [PATCH v2 08/24] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

2018-01-19 Thread Jason Ekstrand
Reviewed-by: Topi Pohjolainen --- src/intel/vulkan/genX_cmd_buffer.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index be263f8..6a6d8b2 100644 --- a/src/intel/vulkan/genX_cmd_buffer.

[Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-19 Thread Jason Ekstrand
This moves it to being based on layout_to_aux_usage instead of being hard-coded based on bits of a priori knowledge of how transitions interact with layouts. This conceptually simplifies things because we're now using layout_to_aux_usage and layout_supports_fast_clear to make resolve decisions so

[Mesa-dev] [PATCH v2 03/24] anv/blorp: Support ISL_AUX_USAGE_HIZ in surf_for_anv_image

2018-01-19 Thread Jason Ekstrand
If the function gets passed ANV_AUX_USAGE_DEFAULT, it still has the old behavior of setting ISL_AUX_USAGE_NONE for depth/stencil which is what we want for blits/copies. Reviewed-by: Topi Pohjolainen Reviewed-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 22 ++ 1 file c

[Mesa-dev] [PATCH v2 05/24] anv/image: Update a comment

2018-01-19 Thread Jason Ekstrand
This got lost in all of the aspect vs. plane rebasing of YCBCR. Reviewed-by: Topi Pohjolainen Reviewed-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4d13e05.

[Mesa-dev] [PATCH v2 07/24] anv/image: Support color aspects in layout_to_aux_usage

2018-01-19 Thread Jason Ekstrand
Reviewed-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 48 ++-- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 84e4b96..e34ac95 100644 --- a/src/intel/vulkan/anv_image.

[Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

2018-01-19 Thread Jason Ekstrand
v2 (Jason Ekstrand): - Return an enum instead of a boolean Reviewed-by: Topi Pohjolainen --- src/intel/vulkan/anv_image.c | 70 ++ src/intel/vulkan/anv_private.h | 13 2 files changed, 83 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v2 04/24] anv/blorp: Rework HiZ ops to look like MCS and CCS

2018-01-19 Thread Jason Ekstrand
Reviewed-by: Topi Pohjolainen --- src/intel/vulkan/anv_blorp.c | 38 ++ src/intel/vulkan/anv_private.h | 9 + src/intel/vulkan/genX_cmd_buffer.c | 13 +++-- 3 files changed, 34 insertions(+), 26 deletions(-) diff --git a/src/intel/vu

[Mesa-dev] [PATCH v2 00/24] Rework CCS state tracking

2018-01-19 Thread Jason Ekstrand
This is more-or-less a rework of the first 13 patches or so from this series: https://patchwork.freedesktop.org/series/34511/ There are a bunch of patches in this series that came from the original but some are new. In particular, the final patch has been completely rewritten. Instead of trying

[Mesa-dev] [PATCH v2 02/24] anv/blorp: Rework image clear/resolve helpers

2018-01-19 Thread Jason Ekstrand
This replaces image_fast_clear and ccs_resolve with two new helpers that simply perform an isl_aux_op whatever that may be on CCS or MCS. This is a bit cleaner as it separates performing the aux operation from which blorp helper we have to call to do it. Reviewed-by: Topi Pohjolainen --- src/in

[Mesa-dev] [PATCH v2 01/24] intel/isl: Codify AUX operations in an enum

2018-01-19 Thread Jason Ekstrand
Right now, we have different entrypoints and enums in blorp for these different operations. This provides us a central enum which we can begin to transition to. Reviewed-by: Topi Pohjolainen Reviewed-by: Nanley Chery --- src/intel/isl/isl.h | 74 +++-

Re: [Mesa-dev] [AppVeyor] mesa master #6655 failed

2018-01-19 Thread Bas Nieuwenhuizen
Does not seem like a build issue: Build started git clone -q --depth=100 --branch=master git://anongit.freedesktop.org/mesa/mesa C:\projects\mesa remote: error: Could not read 6bc54a6fc26d022b77e72f7498aa427aa2544062 remote: fatal: bad tree object 6bc54a6fc26d022b77e72f7498aa427aa2544062 remote: a

Re: [Mesa-dev] [PATCH] swr/rast: Fix llvm5 behavior

2018-01-19 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jan 19, 2018, at 5:03 PM, George Kyriazis > wrote: > > For some reason llvm5 is picky about accepting a void * type in the > case of building an argument list. > > Since we don't care about the type (we ignore the argument for now), > pick another pointer typ

[Mesa-dev] [PATCH] swr/rast: Fix llvm5 behavior

2018-01-19 Thread George Kyriazis
For some reason llvm5 is picky about accepting a void * type in the case of building an argument list. Since we don't care about the type (we ignore the argument for now), pick another pointer type --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 ++- 1 file changed, 2 insertions(

Re: [Mesa-dev] [PATCH 00/20] rollup patchset for swr rasterizer

2018-01-19 Thread Cherniak, Bruce
Entire set. Reviewed-by: Bruce Cherniak > On Jan 19, 2018, at 3:46 PM, George Kyriazis > wrote: > > Also including: > - enabling of SIMD16 VS > - Early Rasterization implementation > > George Kyriazis (20): > swr/rast: Fix one more invalid object format for windows. > swr/rast: Added mis

[Mesa-dev] [AppVeyor] mesa master #6655 failed

2018-01-19 Thread AppVeyor
Build mesa 6655 failed Commit 61a790409e by Bas Nieuwenhuizen on 1/16/2018 1:08 AM: radv: Always re-emit the sample position offset user SGPR.\n\nThe user SGPR location can change between pipelines, so we need to\nemit it again to the pottentially changed SGPR

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-19 Thread Dylan Baker
Quoting Daniel Stone (2018-01-19 08:50:17) > Hi, > > On 19 January 2018 at 16:26, Emil Velikov wrote: > > On 18 January 2018 at 21:30, Dylan Baker wrote: > >> I'm willing to defer to you on this, if you think that checking headers for > >> ETIME is too fragile then we can leave it (you definitel

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-19 Thread Dylan Baker
Quoting Emil Velikov (2018-01-19 08:26:41) > On 18 January 2018 at 21:30, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-18 10:57:02) > >> On 18 January 2018 at 18:29, Greg V wrote: > >> > > >> > On 01/18/2018 21:18, Emil Velikov wrote: > >> >> > >> >> Hi Greg, > >> >> > >> >> On 31 Decembe

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

2018-01-19 Thread Gurkirpal Singh
On Fri, Jan 19, 2018 at 8:30 PM, Leo Liu wrote: > > > On 01/19/2018 04:46 AM, Julien Isorce wrote: > > Hi Leo, > > Do you have enough data to start the merge ? > > Hi Julien, > > What I can help is to have the patches pushed to upstream, and which I > think anyone with write-permission account a

[Mesa-dev] [PATCH 13/20] swr/rast: silence generated file warnings

2018-01-19 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp index 61c3132..9db6c61 100644 --- a/src/g

[Mesa-dev] [PATCH 11/20] swr/rast: AVX-512 changes to enable 16-wide VS

2018-01-19 Thread George Kyriazis
Add a new define (USE_SIMD16_VS), to denote calling a 16-wide vertex shader. This is needed because the mesa driver can do 16-wide shaders, but rasty cannot yet, so we need to distinguish. Create a new VertexID entry (VertexID16) for the USE_SIMD16_VS case, since we need to format the vertex id in

[Mesa-dev] [PATCH 15/20] swr/rast: Added ICLAMP builder function

2018-01-19 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 4 ++-- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp b/src/gallium/drivers/swr/rasterize

[Mesa-dev] [PATCH 17/20] swr: Support simd16 vertex shaders

2018-01-19 Thread George Kyriazis
Supporting simd16 vertex shaders involves packing the output of the fetch shader appropriately, especially the vertexID buffers that have to be formatted in one simd16 register, needed by the VS. As part of this support, we needed to remove the 2nd JitManager, since it was not accounting for vecto

[Mesa-dev] [PATCH 19/20] swr/rast: Implement Early Rasterization optimization

2018-01-19 Thread George Kyriazis
Early Rasterization is an optimization for small triangles. Scientific workloads often contain very small triangles that has non-zero area and cannot be trivially rejected as falling between pixel centers, but does not cover any pixel center. Those triangles can be initially rasterized as early as

[Mesa-dev] [PATCH 20/20] swr/rast: Enable early rasterization

2018-01-19 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h b/src/gallium/drivers/swr/rasterizer/core/knobs.h index 23a2876..d88a3aa 100644 --- a/src/gallium/drivers/swr/rasterizer/core/kno

[Mesa-dev] [PATCH 10/20] swr/rast: x86 autogenerated macro work

2018-01-19 Thread George Kyriazis
Add name argument to x86 autogenerated macros. Add useful variable names for DCL_inputVec implementation. --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py| 2 +- .../swr/rasterizer/codegen/templates/gen_builder.hpp| 2 +- .../drivers/swr/rasterizer/jitter/builder_misc.cpp |

[Mesa-dev] [PATCH 12/20] swr/rast: jit shader lib debug work

2018-01-19 Thread George Kyriazis
Create shader_lib during build, link with shaders at DLL generation time --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 5 + src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 6 ++ 2 files changed, 11 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/j

[Mesa-dev] [PATCH 16/20] swr/rast: changed jit debug magic number

2018-01-19 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index ed4193e..a9a416a 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 18/20] swr/rast: Enable simd16 vertex shaders

2018-01-19 Thread George Kyriazis
Flip the switch(es) to enable simd16 vertex shaders: USE_SIMD16_SHADERS and USE_SIMD16_VS Both have to be enabled at the same time. Currently, just setting USE_SIMD16_SHADERS does not work correctly. --- src/gallium/drivers/swr/rasterizer/core/knobs.h | 4 ++-- 1 file changed, 2 insertions(+),

[Mesa-dev] [PATCH 05/20] swr/rast: Debug Symbols work

2018-01-19 Thread George Kyriazis
Added support for Fetch / Sample / LD functions Added DLL link to JitCache implementation --- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 92 ++ .../drivers/swr/rasterizer/jitter/JitManager.h | 7 +- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 2 + .../d

[Mesa-dev] [PATCH 04/20] swr/rast: Initial work for debugging support.

2018-01-19 Thread George Kyriazis
Adds ability to step into jitted llvm IR in Visual Studio. - Updated llvm type generation script to also generate corresponding debug types. - New module pass inserts debug metadata into the IR for each function Disabled by default. --- .../swr/rasterizer/codegen/gen_llvm_types.py | 10 +-

[Mesa-dev] [PATCH 07/20] swr/rast: Add debugging type support for function types.

2018-01-19 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 20 .../drivers/swr/rasterizer/jitter/JitManager.h | 1 + 2 files changed, 21 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/Jit

[Mesa-dev] [PATCH 14/20] swr/rast: Jit debug work

2018-01-19 Thread George Kyriazis
Properly validate DLL matches OBJ for jitted function --- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 111 +++-- 1 file changed, 81 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/j

[Mesa-dev] [PATCH 02/20] swr/rast: Added missing define for Linux/gcc

2018-01-19 Thread George Kyriazis
+ ZeroMemory() macro definition for non win32-compilation in common/os.h --- src/gallium/drivers/swr/rasterizer/common/os.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 358cb33..c7e87e2 1

[Mesa-dev] [PATCH 09/20] swr/rast: Shorten some filenames

2018-01-19 Thread George Kyriazis
in shader and fetch dump files --- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 2 +- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp b/src/gallium/d

[Mesa-dev] [PATCH 08/20] swr/rast: work supporting optimizations in Debug builds.

2018-01-19 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/JitManager.cpp| 21 + .../drivers/swr/rasterizer/jitter/JitManager.h | 11 ++- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/

[Mesa-dev] [PATCH 03/20] swr/rast: Add private state parameter in fetcher

2018-01-19 Thread George Kyriazis
--- .../drivers/swr/rasterizer/core/frontend.cpp | 8 ++--- src/gallium/drivers/swr/rasterizer/core/state.h| 4 +-- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 3 ++ .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 39 +- .../drivers/swr/rasterizer/jit

[Mesa-dev] [PATCH 06/20] swr/rast: Shader debugging work

2018-01-19 Thread George Kyriazis
- Move debug .ll files to JIT_CACHE_DIR - Don't link against jitter SRGBLut table, add global data to shader that needs it. --- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc

[Mesa-dev] [PATCH 00/20] rollup patchset for swr rasterizer

2018-01-19 Thread George Kyriazis
Also including: - enabling of SIMD16 VS - Early Rasterization implementation George Kyriazis (20): swr/rast: Fix one more invalid object format for windows. swr/rast: Added missing define for Linux/gcc swr/rast: Add private state parameter in fetcher swr/rast: Initial work for debugging

[Mesa-dev] [PATCH 01/20] swr/rast: Fix one more invalid object format for windows.

2018-01-19 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index 508bc02..40ca644 100644 --- a/src/gallium/driv

[Mesa-dev] [Bug 104182] Seti@Home OpenCL program starts then returns: "CL file build failure"

2018-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104182 --- Comment #2 from thinkingbeyondthesqu...@gmail.com --- (In reply to Pavel Ondračka from comment #1) > Can you please provide full output from the failing task? It might give some > clue what is the cause of the build failure. Hi Pavel I will

[Mesa-dev] [PATCH v2 12/12] anv: Use clear address for HiZ fast clears too.

2018-01-19 Thread Rafael Antognolli
Store the default clear address for HiZ fast clears on a global bo, and point to it when needed. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/anv_device.c | 19 +++ src/intel/vulkan/anv_image.c | 11 --- src/intel/vulkan/anv_private.h | 1 + 3 files changed,

[Mesa-dev] [PATCH v2 08/12] i965/blorp: Update the fast clear color entry buffer.

2018-01-19 Thread Rafael Antognolli
On Gen10, whenever the fast clear color changes, update it on the clear color entry buffer. This allow us to use it directly when emitting the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_blorp.c | 26 ++ 1 file changed, 26 insertions(

[Mesa-dev] [PATCH v2 03/12] intel/genxml: Use a single field for clear color address on gen10.

2018-01-19 Thread Rafael Antognolli
genxml does not support having two address fields with different names but same position in the state struct. Both "Clear Color Address" and "Clear Depth Address Low" mean the same thing, only for different surface types. To workaround this genxml limitation, rename "Clear Color Address" to "Clear

[Mesa-dev] [PATCH v2 09/12] i965/surface_state: Emit the clear color address instead of value.

2018-01-19 Thread Rafael Antognolli
On Gen10, when emitting the surface state, use the value stored in the clear color entry buffer by using a clear color address in the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 1 file changed, 16 insertions(+) diff

[Mesa-dev] [PATCH v2 05/12] anv: Make the clear address 64 bytes aligned.

2018-01-19 Thread Rafael Antognolli
On Gen10+, if we use the clear state address field in the surface state instead of the clear color directly, there's a restriction that the address must point to the lower part of a 64 byte cache-line. So we add a padding to the state buffer to make it align to 64 bytes when multiple LOD is present

[Mesa-dev] [PATCH v2 10/12] i965/surface_state: Silence warning.

2018-01-19 Thread Rafael Antognolli
This warning showed up after aux_bo started being used inside if (use_clear_address) {... But use_clear_address depends on aux_surf being not null, in which case aux_bo would also be set. Make the compiler happy anyway. Signed-off-by: Rafael Antognolli Reviewed-by: Nanley Chery --- src/mesa/d

[Mesa-dev] [PATCH v2 02/12] genxml: Preserve fields that share dword space with addresses.

2018-01-19 Thread Rafael Antognolli
Some instructions contain fields that are either an address or a value of some type based on the content of other fields, such as clear color values vs address. That works fine if these fields are in the less significant dword, the lower 32 bits of the address, because they get OR'ed with the addre

[Mesa-dev] [PATCH v2 11/12] anv: Emit the fast clear color address, instead of value.

2018-01-19 Thread Rafael Antognolli
On Gen10+, instead of copying the clear color from the state buffer to the surface state, just use the address of the state buffer in the surface state directly. This way we can avoid the copy from state buffer to surface state. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v2 06/12] intel/blorp: Add suport for fast clear address.

2018-01-19 Thread Rafael Antognolli
On gen10+, if surface->clear_color_addr is present, use it directly intead of copying it to the surface state. Signed-off-by: Rafael Antognolli --- src/intel/blorp/blorp_genX_exec.h | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h

[Mesa-dev] [PATCH v2 04/12] intel/isl: Add support to emit clear value address.

2018-01-19 Thread Rafael Antognolli
gen10 can emit the clear color by setting it on a buffer somewhere, and then adding only the address to the surface state. This commit add support for that on isl_surf_fill_state, and if that is requested, skip setting the clear value itself. v2: Add assert to make sure we are at least on gen10.

[Mesa-dev] [PATCH v2 07/12] i965/miptree: Add space to store the clear value in the aux surface.

2018-01-19 Thread Rafael Antognolli
Similarly to vulkan where we store the clear value in the aux surface, we can do the same in GL. v2: Remove unneeded extra function. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drive

[Mesa-dev] [PATCH v2 01/12] anv/image: Do not override lower bits of dword.

2018-01-19 Thread Rafael Antognolli
The lower bits seem to have extra fields in every platform but gen8 (even though we don't use them in gen9). So just go ahead and avoid using them for the address. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/anv_image.c | 30 +- 1 file changed, 17 insertions

[Mesa-dev] [PATCH v2 00/12] Use clear color address in surface state.

2018-01-19 Thread Rafael Antognolli
Second version of this series, with (hopefully) full support for this in Vulkan. Rafael Antognolli (12): anv/image: Do not override lower bits of dword. genxml: Preserve fields that share dword space with addresses. intel/genxml: Use a single field for clear color address on gen10. intel/i

Re: [Mesa-dev] [7/6] meson: use va-api version reported by pkg-config

2018-01-19 Thread Marc Dietrich
Am Donnerstag, 18. Januar 2018, 19:05:41 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > --- > meson.build | 2 +- > src/gallium/state_trackers/va/meson.build | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) vainfo reports no longer an error, s

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

2018-01-19 Thread Emil Velikov
On 17 January 2018 at 21:34, Dylan Baker wrote: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will default to

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-19 Thread Jordan Justen
On 2018-01-19 03:03:43, Tapani Pälli wrote: > On 01/19/2018 11:22 AM, Jordan Justen wrote: > > On 2018-01-18 22:08:17, Tapani Pälli wrote: > >> On 01/18/2018 08:18 PM, Jordan Justen wrote: > >>> On 2018-01-15 04:31:43, Tapani Pälli wrote: > This can/should be modified depending on needs. AFAIK

Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

2018-01-19 Thread Emil Velikov
On 18 January 2018 at 19:36, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-18 11:12:30) >> On 17 January 2018 at 18:34, Dylan Baker wrote: >> > The linkage of all of the gallium media targets is broken in various >> > ways in the meson build. This series should correct that by doing more >>

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

2018-01-19 Thread Emil Velikov
On 18 January 2018 at 00:22, Dylan Baker wrote: > This adds the meson.build, meson_options.txt, and a few scripts that are > used exclusively by the meson build. > > Signed-off-by: Dylan Baker > --- With the nit mentioned by Eric, the patch is Reviewed-by: Emil Velikov -Emil ___

Re: [Mesa-dev] [PATCH v2 1/5] meson: fix missing dependencies

2018-01-19 Thread Emil Velikov
On 18 January 2018 at 22:54, Greg V wrote: > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/meson.build > b/src/gallium/drivers/radeonsi/mes

[Mesa-dev] [PATCH 17/17] vbo: whitespace/formatting fixes in vbo_split_inplace.c

2018-01-19 Thread Brian Paul
--- src/mesa/vbo/vbo_split_inplace.c | 215 --- 1 file changed, 111 insertions(+), 104 deletions(-) diff --git a/src/mesa/vbo/vbo_split_inplace.c b/src/mesa/vbo/vbo_split_inplace.c index a2717ab..2c363c2 100644 --- a/src/mesa/vbo/vbo_split_inplace.c +++ b/src/m

[Mesa-dev] [PATCH 16/17] vbo: whitespace/formatting fixes in vbo.h

2018-01-19 Thread Brian Paul
--- src/mesa/vbo/vbo.h | 112 - 1 file changed, 68 insertions(+), 44 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 30c83fc..164477f 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@ -42,7 +42,8 @@ struct gl_ve

[Mesa-dev] [PATCH 14/17] vbo: remove unused vbo_any_varyings_in_vbos() function

2018-01-19 Thread Brian Paul
--- src/mesa/vbo/vbo.h| 3 --- src/mesa/vbo/vbo_rebase.c | 10 -- 2 files changed, 13 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index ec2ac0e..0007029 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@ -153,10 +153,7 @@ void vbo_split_prims( struc

[Mesa-dev] [PATCH 15/17] vbo/i965: move vbo_all_varyings_in_vbos() to brw_draw.c

2018-01-19 Thread Brian Paul
It's only used in brw_draw_prims(). s/GLboolean/bool/, etc. --- src/mesa/drivers/dri/i965/brw_draw.c | 18 +- src/mesa/vbo/vbo.h | 2 -- src/mesa/vbo/vbo_rebase.c| 11 --- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 13/17] vbo: remove unneeded #includes

2018-01-19 Thread Brian Paul
--- src/mesa/vbo/vbo_primitive_restart.c | 1 - src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_split.c | 2 -- src/mesa/vbo/vbo_split_inplace.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mesa/vbo/vbo_primitive_rest

[Mesa-dev] [PATCH 09/17] mesa: use new _vbo_install_exec_vtxfmt() function

2018-01-19 Thread Brian Paul
Instead of reaching into the vbo_context object in vtxfmt.c --- src/mesa/main/vtxfmt.c | 3 +-- src/mesa/vbo/vbo_context.c | 10 ++ src/mesa/vbo/vbo_context.h | 4 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/vtxfmt.c b/src/mesa/main/vtxfmt.c ind

[Mesa-dev] [PATCH 07/17] i965: use vbo_set_[indirect]_draw_func()

2018-01-19 Thread Brian Paul
Instead of poking into the vbo_context object. --- src/mesa/drivers/dri/i965/brw_draw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index fc349ad..73f2e1f 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 11/17] vbo: move remaining items from vbo_context.h to vbo.h

2018-01-19 Thread Brian Paul
Non-VBO sources files sometimes included vbo.h while others included vbo_context.h. We're moving all public types, functions to the former. --- src/mesa/vbo/vbo.h | 6 ++ src/mesa/vbo/vbo_context.c | 2 +- src/mesa/vbo/vbo_context.h | 40 ---

[Mesa-dev] [PATCH 12/17] vbo: remove vbo_context.h and change includes to use vbo.h instead

2018-01-19 Thread Brian Paul
Now vbo.h is the public interface to the VBO module. --- src/mesa/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/nouveau/nouveau_render.h | 2 +- src/mesa/main/state.c

[Mesa-dev] [PATCH 10/17] vbo: move VBO-private types, prototypes, etc. into new vbo_private.h header

2018-01-19 Thread Brian Paul
Things which should not be used outside the VBO module. More public/private clean-ups coming. --- src/mesa/vbo/vbo.h | 9 -- src/mesa/vbo/vbo_context.c | 19 src/mesa/vbo/vbo_context.h | 158 +--- src/mesa/vbo/vbo_exec.c

[Mesa-dev] [PATCH 03/17] mesa: whitespace clean-ups in mtypes.h

2018-01-19 Thread Brian Paul
--- src/mesa/main/mtypes.h | 150 +++-- 1 file changed, 82 insertions(+), 68 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5fda348..fe5f9d7 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -270,11 +27

  1   2   >