Re: [Mesa-dev] [PATCH] i915: No longer rely on compatability define in intel_bufmgr.h

On Tuesday, January 16, 2018 9:48:07 PM PST Rhys Kidd wrote: > Symbol rename from dri_* to drm_intel_* introduced a number of compatability > defines within intel_bufmgr.h. > > Replace the old function with the new function, consistent with the balance > of this file. > > Signed-off-by: Rhys Kidd

[Mesa-dev] [PATCH v4] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_image.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4d13e05e11f..72e408764d8 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/

Re: [Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

On 16/01/18 17:10, Jason Ekstrand wrote: > I'm a bit unclear here.  Was ISL crashing before or was it returning > false and anv crashing?  If it was anv crashing due to an assert(ok), > then maybe it's best to just make anv fail gracefully with > VK_ERROR_OUT_OF_DEVICE_MEMORY.  Setting size to UINT

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock with X11

https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #7 from mais...@archlinux.us --- This might not be a bug after all. The app destroyed the X window before tearing down the swapchain, which is bogus, and probably where the deadlock comes from. It stopped once it was done properly. -

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

On Tue, Jan 16, 2018 at 4:30 PM, Nanley Chery wrote: > On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > > Sorry for all the list spam, but I'm sort of thinking out-loud and > writing > > > it on the list for all

[Mesa-dev] [PATCH] i915: No longer rely on compatability define in intel_bufmgr.h

Symbol rename from dri_* to drm_intel_* introduced a number of compatability defines within intel_bufmgr.h. Replace the old function with the new function, consistent with the balance of this file. Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i915/intel_regions.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

On 01/17/2018 05:49 AM, Marek Olšák wrote: On Wed, Jan 17, 2018 at 3:21 AM, Mario Kleiner wrote: On 01/16/2018 11:47 PM, Marek Olšák wrote: Why? Because the bug reports i've seen so far seem to be not caused by something specific to the i965 implementation, but by some other client applica

[Mesa-dev] [PATCH 07/11] vbo: use inputs_read var to simplify code

--- src/mesa/vbo/vbo_exec_draw.c | 7 +++ src/mesa/vbo/vbo_save_draw.c | 7 +++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index 5d1e588..68e9918 100644 --- a/src/mesa/vbo/vbo_exec_draw.c +++ b/src/mesa/vbo/vbo

[Mesa-dev] [PATCH 08/11] vbo: whitespace, formatting fixes in vbo_exec_draw.c

--- src/mesa/vbo/vbo_exec_draw.c | 128 +-- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index 68e9918..3e1556b 100644 --- a/src/mesa/vbo/vbo_exec_draw.c +++ b/src/mesa/vbo/vbo_ex

[Mesa-dev] [PATCH 06/11] vbo: whitespace, formatting fixes in vbo_split_copy.c

--- src/mesa/vbo/vbo_split_copy.c | 304 -- 1 file changed, 144 insertions(+), 160 deletions(-) diff --git a/src/mesa/vbo/vbo_split_copy.c b/src/mesa/vbo/vbo_split_copy.c index 8e35e44..2de909f 100644 --- a/src/mesa/vbo/vbo_split_copy.c +++ b/src/mesa/vbo/v

[Mesa-dev] [PATCH 11/11] vbo: reindent vbo_attrib.h to use 3 spaces

--- src/mesa/vbo/vbo_attrib.h | 100 +++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/src/mesa/vbo/vbo_attrib.h b/src/mesa/vbo/vbo_attrib.h index f4a3a66..fb11596 100644 --- a/src/mesa/vbo/vbo_attrib.h +++ b/src/mesa/vbo/vbo_attrib.h @@

[Mesa-dev] [PATCH] mesa/program: change validate_inputs() local var 'inputs' to GLbitfield64

Both state->prog->info.inputs_read and state->InputsBound are GLbitfield64 so it seems that the OR of those values should be of the same type. I'm not sure this fixes any actual issues though. --- src/mesa/program/program_parse.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH 09/11] vbo: add assertions, comments in vbo_exec_api.c

--- src/mesa/vbo/vbo_exec_api.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 019f986..800fac8 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -270,6 +270,7 @@ vbo_exec_copy_f

[Mesa-dev] [PATCH 02/11] vbo: change vbo_context attribute map arrays to GLubyte

The values will never be larger than VBO_ATTRIB_MAX (currently 44). --- src/mesa/vbo/vbo_context.h | 4 ++-- src/mesa/vbo/vbo_exec_draw.c | 2 +- src/mesa/vbo/vbo_save_draw.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_context.h b/src/mesa/vbo/vbo_co

[Mesa-dev] [PATCH 05/11] vbo: use a new local 'array' variable in bind_vertex_list() loop

Make the code a bit more concise. --- src/mesa/vbo/vbo_save_draw.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c index c1298f9..5d299d8 100644 --- a/src/mesa/vbo/vbo_save_draw.c +++ b/src/

[Mesa-dev] [PATCH 10/11] vbo: whitespace, formatting fixes in vbo_exec_api.c

--- src/mesa/vbo/vbo_exec_api.c | 197 ++-- 1 file changed, 98 insertions(+), 99 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 800fac8..6f1c550 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_

[Mesa-dev] [PATCH 03/11] vbo: whitespace, formatting fixes in vbo_context.c

--- src/mesa/vbo/vbo_context.c | 59 +++--- 1 file changed, 35 insertions(+), 24 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c index a5f915d..971f298 100644 --- a/src/mesa/vbo/vbo_context.c +++ b/src/mesa/vbo/vbo_context.

[Mesa-dev] [PATCH 01/11] vbo: lift common code out of switch cases

Both switch cases began with the same code. --- src/mesa/vbo/vbo_exec_draw.c | 15 ++- src/mesa/vbo/vbo_save_draw.c | 15 ++- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index 34cb4ff..de17322

[Mesa-dev] [PATCH 04/11] vbo: remove unneeded #includes in vbo_context.c

--- src/mesa/vbo/vbo_context.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c index 971f298..02989d5 100644 --- a/src/mesa/vbo/vbo_context.c +++ b/src/mesa/vbo/vbo_context.c @@ -25,9 +25,7 @@ *Keith Whitwell */ -#include "mai

[Mesa-dev] [PATCH 10/10] glsl: remove unneeded extern "C" {} bracketing around Mesa includes

The two headers already have the right extern "C" annotations. --- src/compiler/glsl/serialize.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/serialize.cpp b/src/compiler/glsl/serialize.cpp index 769ab56..63ce41d 100644 --- a/src/compiler/glsl/seria

[Mesa-dev] [PATCH 06/10] util: include string.h in u_dynarray.h

To get memset() prototype. --- src/util/u_dynarray.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h index cc31632..dcbbc06 100644 --- a/src/util/u_dynarray.h +++ b/src/util/u_dynarray.h @@ -28,6 +28,7 @@ #define U_DYNARRAY_H #include +#includ

[Mesa-dev] [PATCH 09/10] mesa: move gl_external_samplers() to program.[ch]

The function is only called from a couple places. It doesn't make sense to have it in mtypes.h --- src/mesa/main/mtypes.h | 17 - src/mesa/program/program.c | 17 + src/mesa/program/program.h | 5 + 3 files changed, 22 insertions(+), 17 deletions(-) diff

[Mesa-dev] [PATCH 05/10] mesa: remove unneeded #includes of main/compiler.h

--- src/mesa/drivers/x11/glxapi.c| 1 - src/mesa/main/debug_output.h | 1 - src/mesa/main/errors.h | 1 - src/mesa/main/fbobject.h | 1 - src/mesa/main/formatquery.h | 1 - src/mesa/main/formats.h

[Mesa-dev] [PATCH 01/10] mesa: include compiler.h in disk_cache.c

Instead of indirect inclusion to get CPU_TO_LE32() macro. --- src/util/disk_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 7ebfa8c..2884d3c 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -46,6 +46,7 @@ #include "u

[Mesa-dev] [PATCH 07/10] glsl: include util/bitscan.h in serialize.cpp

Instead of relying on indirect inclusion of the header. --- src/compiler/glsl/serialize.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/serialize.cpp b/src/compiler/glsl/serialize.cpp index 57c91d9..769ab56 100644 --- a/src/compiler/glsl/serialize.cpp +++ b/src/compiler/g

[Mesa-dev] [PATCH 08/10] st/mesa: include util/bitscan.h in st_glsl_to_tgsi_temprename.cpp

And use "" instead of <> for including Mesa headers, as we do elsewhere. --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp b/src/mesa/state_tracker/st_glsl

[Mesa-dev] [PATCH 02/10] mesa: include util/macros.h in format_fallback.c

To get definition of unreachable() macro. --- src/mesa/main/format_fallback.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/format_fallback.py b/src/mesa/main/format_fallback.py index 2f02d0d..4a2b85c 100644 --- a/src/mesa/main/format_fallback.py +++ b/src/mesa/main/format_fal

[Mesa-dev] [PATCH 04/10] st/mesa: remove unneeded #includes of main/compiler.h

--- src/mesa/state_tracker/st_cb_bitmap.h| 1 - src/mesa/state_tracker/st_cb_blit.h | 2 -- src/mesa/state_tracker/st_cb_bufferobjects.h | 1 - src/mesa/state_tracker/st_cb_compute.h | 2 -- src/mesa/state_tracker/st_cb_drawpixels.h| 1 - src/mesa/state_tracker/st_cb_dra

[Mesa-dev] [PATCH 03/10] st/mesa: include main/compiler.h in st_cb_queryobj.c

To get CPU_TO_LE32() macro. --- src/mesa/state_tracker/st_cb_queryobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_queryobj.c b/src/mesa/state_tracker/st_cb_queryobj.c index a470ff6..69e6004 100644 --- a/src/mesa/state_tracker/st_cb_queryobj.c +++ b/src/mesa/

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

On Wed, Jan 17, 2018 at 3:21 AM, Mario Kleiner wrote: > On 01/16/2018 11:47 PM, Marek Olšák wrote: >> >> Why? > > > Because the bug reports i've seen so far seem to be not caused by something > specific to the i965 implementation, but by some other client application or > compositor being incompat

Re: [Mesa-dev] [PATCH] svga: add num-commands-per-draw HUD query

Looks good. Reviewed-by: Neha Bhende From: Brian Paul Sent: Friday, January 12, 2018 2:22:07 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee Subject: [PATCH] svga: add num-commands-per-draw HUD query This query shows the ratio of total command

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #30 from Mario Kleiner --- We should also get this cherry-picked into the 1.19 branch. Otherwise it might happen that the new Mesa ships in spring distribution releases with an old 1.19 X-Server, e.g., Ubuntu 18.04-LTS. -- You are

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

On 01/16/2018 11:47 PM, Marek Olšák wrote: Why? Because the bug reports i've seen so far seem to be not caused by something specific to the i965 implementation, but by some other client application or compositor being incompatible. Therefore i'd expect the same problems in clients/compositor

[Mesa-dev] [PATCH 09/23] radv: Merge vs state computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 83 +- src/amd/vulkan/radv_private.h | 8 2 files changed, 34 insertions(+), 57 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9b557f9c23..2f4561d1c2 100644 --- a/s

[Mesa-dev] [PATCH 17/23] radv: Move blend state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 130 +++-- src/amd/vulkan/radv_private.h | 12 2 files changed, 73 insertions(+), 69 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 16dad89f4c..9d95073260 100644 --- a/

[Mesa-dev] [PATCH 23/23] radv: Merge raster state with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 115 ++--- src/amd/vulkan/radv_private.h | 10 2 files changed, 50 insertions(+), 75 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index e1d6fe159d..232c06c9a8 100644 --- a/

[Mesa-dev] [PATCH 11/23] radv: Merge ps_input_cntl computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 160 - src/amd/vulkan/radv_private.h | 2 - 2 files changed, 79 insertions(+), 83 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index bd8a2feb8c..8c5706f4b4 100644 --- a/src

[Mesa-dev] [PATCH 20/23] radv: Merge VGT_GS_MODE computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 51 +- src/amd/vulkan/radv_private.h | 2 -- 2 files changed, 25 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 4357669baa..a5239e7a6d 100644 --- a/src

[Mesa-dev] [PATCH 01/23] radv: emit pa_sc_mode_cntl_0 with multisample state.

We don't have the meta kludge with 0 viewports anymore, so we can always enable them. --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- src/amd/vulkan/radv_pipeline.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_b

[Mesa-dev] [PATCH 10/23] radv: Merge vtx_reuse_depth computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 13 ++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 2f4561d1c2..bd8a2feb8c 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 21/23] radv: Split out cliprect rule generation.

--- src/amd/vulkan/radv_pipeline.c | 57 -- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 33 insertions(+), 25 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index a5239e7a6d..639eb032bb 100644 --- a/src/

[Mesa-dev] [PATCH 22/23] radv: Move gs state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 78 +++--- src/amd/vulkan/radv_private.h | 8 - 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 639eb032bb..e1d6fe159d 100644 --- a/

[Mesa-dev] [PATCH 19/23] radv: Split out processing the vertex input state.

--- src/amd/vulkan/radv_pipeline.c | 78 +++--- 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index cc88a7b10e..4357669baa 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd

[Mesa-dev] [PATCH 18/23] radv: Move tessellation state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 95 ++ src/amd/vulkan/radv_private.h | 13 -- 2 files changed, 58 insertions(+), 50 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9d95073260..cc88a7b10e 100644 --- a

[Mesa-dev] [PATCH 16/23] radv: Split out generating VGT_SHADER_STAGES_EN.

--- src/amd/vulkan/radv_pipeline.c | 50 +++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9d6663e977..16dad89f4c 100644 --- a/src/

[Mesa-dev] [PATCH 13/23] radv: Compute shader_z_format when emitting it.

--- src/amd/vulkan/radv_pipeline.c | 10 +++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index dbe33d3cc5..b39ee4308b 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/s

[Mesa-dev] [PATCH 04/23] radv: Add a PM4 sequence data structure + utils.

--- src/amd/vulkan/radv_pipeline.c | 66 ++ src/amd/vulkan/radv_private.h | 19 2 files changed, 85 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 82d9546cc3..ffd5aab7f9 100644 --- a/src/amd/vu

[Mesa-dev] [PATCH 14/23] radv: Split out db_shader_control computation.

--- src/amd/vulkan/radv_pipeline.c | 43 +- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index b39ee4308b..be71abd858 100644 --- a/src/

[Mesa-dev] [PATCH 02/23] radv: Always re-emit the sample position offset user SGPR.

The user SGPR location can change between pipelines, so we need to emit it again to the pottentially changed SGPR index. --- src/amd/vulkan/radv_cmd_buffer.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/

[Mesa-dev] [PATCH 15/23] radv: Split out the ia_multi_vgt_param precomputation.

Also moved everything in a struct and then return the struct from the helper function, so it is clear in the caller what part of the pipeline gets modified. --- src/amd/vulkan/radv_pipeline.c | 169 ++--- src/amd/vulkan/radv_private.h | 16 ++-- src/amd/vulkan

[Mesa-dev] [PATCH 03/23] radv: Determine unneeded dynamic states.

Which avoids setting or emitting them. --- src/amd/vulkan/radv_cmd_buffer.c | 40 +++-- src/amd/vulkan/radv_pipeline.c | 64 +--- src/amd/vulkan/radv_private.h| 1 + 3 files changed, 65 insertions(+), 40 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 07/23] radv: Constify some pipeline helpers.

--- src/amd/vulkan/radv_pipeline.c | 8 src/amd/vulkan/radv_private.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 22dd6566a1..1eddacfe51 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/sr

[Mesa-dev] [PATCH 08/23] radv: Merge binning state generation with pm4 emission.

We don't need the pipeline state struct anymore. --- src/amd/vulkan/radv_pipeline.c | 48 +- src/amd/vulkan/radv_private.h | 6 -- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pip

[Mesa-dev] [PATCH 12/23] radv: Merge depth stencil state with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 117 +++-- src/amd/vulkan/radv_private.h | 8 --- 2 files changed, 55 insertions(+), 70 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 8c5706f4b4..dbe33d3cc5 100644 --- a/s

[Mesa-dev] [PATCH 05/23] radv: Record a PM4 sequence for graphics pipeline switches.

This gives about 2% performance improvement on dota2 for me. This is mostly a mechanical copy and replacement, but at bind time we still do: 1) Some stuff that is only based on num_samples changes. 2) Some command buffer state setting. --- src/amd/vulkan/radv_cmd_buffer.c | 458 +

[Mesa-dev] [PATCH 00/23] Rework pipeline emitting.

This changes emitting pipelines to pregenerate the PM$ sequences to bind the pipeline at pipeline creation time, so we can just memcpy it in the command buffer. This gives minor CPU improvements on dota2. In the process I also refactored stuff to: 1) Not have all the state in the pipeline struct

[Mesa-dev] [PATCH 06/23] radv: Add PM4 pregeneration for compute pipelines.

--- src/amd/vulkan/radv_cmd_buffer.c | 60 ++-- src/amd/vulkan/radv_pipeline.c | 66 2 files changed, 68 insertions(+), 58 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

On 01/16/2018 10:11 AM, Ian Romanick wrote: > On 01/13/2018 01:47 PM, Jason Ekstrand wrote: >> On January 12, 2018 14:56:26 "Ian Romanick" wrote: >> >>> From: Ian Romanick >>> >>> With the exception of NVIDIA hardware, these are is the values that all >>> hardware and Gallium want.  The remapping

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

On 01/16/2018 10:59 AM, Brian Paul wrote: > On 01/16/2018 11:12 AM, Ian Romanick wrote: >> On 01/15/2018 11:23 AM, Brian Paul wrote: >>> On 01/12/2018 03:56 PM, Ian Romanick wrote: From: Ian Romanick With the exception of NVIDIA hardware, these are is the values that all hardwa

[Mesa-dev] [PATCH 3/8] nir: Undo possible damage caused by rearranging or-compounded float compares

From: Ian Romanick shader-db results: Skylake and Broadwell had similar results (Skylake shown) total instructions in shared programs: 14526033 -> 14526021 (<.01%) instructions in affected programs: 1450 -> 1438 (-0.83%) helped: 12 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped s

[Mesa-dev] [PATCH 7/8] nir: Rearrange logic op-compounded integer compares

From: Ian Romanick Skylake, Broadwell, and Haswell had similar results. Skylake shown. total instructions in shared programs: 14521954 -> 14521938 (<.01%) instructions in affected programs: 8782 -> 8766 (-0.18%) helped: 16 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel

[Mesa-dev] [PATCH 4/8] nir: Simplify min and max of b2f

From: Ian Romanick v2: Rebase on almost 2 years. Require that one of the arguments to fmin or fmax be used only once. This prevents some regressions. shader-db results: Skylake, Broadwell, and Haswell had similar results. Skylake shown. total instructions in shared programs: 14526021 -> 1452

[Mesa-dev] [PATCH 2/8] nir: Be more conservative about rearranging or-compounded compares

From: Ian Romanick If both comparisons are used as sources for instructions other than the ior, this transformation is detrimental. If the non-identical value in both compares is constant, the fmin or fmax will be constant-folded away, so the transformation is always a win. shader-db results:

[Mesa-dev] [PATCH 8/8] nir: Distribute binary operations with constants into bcsel

From: Ian Romanick This was specifically designed to simplify 1+mix(0, a-1, condition) to mix(1, a, condition) by pushing the 1+ inside. Skylake, Broadwell, and Haswell had similar results. Skylake shown. total instructions in shared programs: 14521938 -> 14521901 (<.01%) instructions in affect

[Mesa-dev] [PATCH 5/8] nir: Separate a weird compare with zero to two compares with zero

From: Ian Romanick min(a+b, c+d) >= 0 becomes (a+b >= 0 && c+d >= 0). No shader-db changes, but it does prevent 6 to 12 instruction regressions in the next patch on all measured Intel platforms. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 2 ++ 1 file changed, 2 in

[Mesa-dev] [PATCH 1/8] nir: See through an fneg to apply existing optimizations

From: Ian Romanick Doing the same for the existing feq and fne transformations didn't help anything in shader-db. shader-db results: Skylake total instructions in shared programs: 14529598 -> 14526282 (-0.02%) instructions in affected programs: 402420 -> 399104 (-0.82%) helped: 2136 HURT: 131 h

[Mesa-dev] [PATCH 6/8] nir: Rearrange and-compounded float compares

From: Ian Romanick If both comparisons are used as sources for instructions other than the iand, this transformation is detrimental. If the non-identical value in both compares is constant, the fmin or fmax will be constant-folded away, so the transformation is always a win. It is interesting t

[Mesa-dev] [PATCH 0/8] Algebraic optimizations

This is the first series to resurrect some work that I started as long as 2.5 years ago. A lot of that work produced mixed bag results, but that was before nir_opt_algebraic.py had the "is_used_once" modifier. Without this, the last patch was more like 50 helped / 500 hurt on most platforms. All

Re: [Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

On Tuesday, January 16, 2018 4:21:57 PM PST Kenneth Graunke wrote: > On Wednesday, January 10, 2018 11:22:39 AM PST Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_draw.c | 41 > > > > 1 file changed, 41 insertions(+) > > > > diff --git a/src/

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: disable io lowering to temps for tess

Reviewed-by: Marek Olšák Marek On Thu, Jan 11, 2018 at 3:47 AM, Timothy Arceri wrote: > Lowering these to temps makes a big mess, and results in some > piglit test failures. Also the radeonsi backend (the only backend > to support tess) has support for indirects so there is no need to > lower t

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #3 from Gert Wollny --- Now, considering that compute shaders don't use sb there are likely two issues at hand here. Without sb AI hangs quite often for a second or so (especially when opening the map), and it completely hung like re

Re: [Mesa-dev] [PATCH 4/4] gallium/hud: Fix support for PIPE_DRIVER_QUERY_TYPE_FLOAT

For the series: Reviewed-by: Marek Olšák Marek On Fri, Jan 12, 2018 at 11:21 PM, Brian Paul wrote: > Evidently, nobody has used PIPE_DRIVER_QUERY_TYPE_FLOAT up to this > point. Adding a driver query of this type which returns the query > value in pipe_query_result::f resulted in garbage outpu

Re: [Mesa-dev] [PATCH 1/3] i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

On Tuesday, January 16, 2018 3:15:40 PM PST Jason Ekstrand wrote: > This makes sure we flush things out of other caches prior to using a > surface through the render cache. Currently, this is a no-op because GL > won't let you bind anything other than a color surface as color so it > should never

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > > it on the list for all to read. > > > > I'm thinking that what we want this list to ret

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #2 from Gert Wollny --- Actually, the GPU lockups also happen without sb, only not to the point that one has to kill the program. It is likely that #104665 is actually a duplicate of this. -- You are receiving this mail because: Yo

Re: [Mesa-dev] [PATCH 6/6] i965: Enable CCS_E sampling of sRGB textures as UNORM

On Wednesday, January 10, 2018 11:22:40 AM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] Mesa 18.0.0 release plan

On 2018-01-16 13:57:37, Kenneth Graunke wrote: > On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: > > Hi all, > > > > As you've know the Mesa 18.0.0 release plan has been available for a while > > on the mesa3d.org website [1]. > > > > In case you've missed it here it is: > > > >

Re: [Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

On Wednesday, January 10, 2018 11:22:39 AM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_draw.c | 41 > > 1 file changed, 41 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/src/mesa/drivers/dri/i965/brw_draw.c > inde

Re: [Mesa-dev] [PATCH v1 7/7] android: Add accessor functions for gralloc_handle_t variables

On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > Supply accessor functions for most of the common gralloc_handle_t > variables. > > Signed-off-by: Robert Foss > --- > android/gralloc_handle.h | 57 > > 1 file changed, 57 insertions(+) > > d

Re: [Mesa-dev] [PATCH 2/6] i965: Track format and aux usage in the render cache

On Wednesday, January 10, 2018 11:22:36 AM PST Jason Ekstrand wrote: > This lets us perform render cache flushes whenever a surface goes from > being used with one aux+format to a different aux+format. > > This is the "proper" fix for https://bugs.freedesktop.org/102435. > ee57b15ec764736e2d5360be

Re: [Mesa-dev] [PATCH 4/6] i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage

On Wednesday, January 10, 2018 11:22:38 AM PST Jason Ekstrand wrote: > This commit unifies the CCS_E and CCS_D cases. This should fix a couple > of subtle issues. One is that when you use INTEL_DEBUG=norbc to disable > CCS_E, we don't get the sRGB blending workaround. By unifying the code, > we

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH 1/3] i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

This makes sure we flush things out of other caches prior to using a surface through the render cache. Currently, this is a no-op because GL won't let you bind anything other than a color surface as color so it should never end up in the depth cache. However, this does complete the flush/add_bo p

Re: [Mesa-dev] [PATCH 1/3] i965/gen6-7/sol: Restructure primitive counter into a separate type.

On Friday, November 17, 2017 2:28:47 PM PST Francisco Jerez wrote: > A primitive counter encapsulates a scalar aggregating counter for each > vertex stream along with a section within the primitive tally buffer > which hasn't been read out yet. Defining this as a separate type will > allow us to k

Re: [Mesa-dev] [PATCH] radeon: remove unneeded semicolons

Acked-by: Marek Olšák Marek On Sun, Jan 14, 2018 at 10:59 PM, Grazvydas Ignotas wrote: > Trivial. Found by Coccinelle. > --- > src/gallium/drivers/radeon/radeon_vcn_dec.c | 6 +++--- > src/mesa/drivers/dri/radeon/radeon_debug.c | 2 +- > src/mesa/drivers/dri/radeon/radeon_state_init.c

Re: [Mesa-dev] [PATCH] st/mesa: enable ARB_enhanced_layouts on nir drivers

Reviewed-by: Marek Olšák Marek On Fri, Jan 12, 2018 at 6:52 AM, Timothy Arceri wrote: > I'm guessing this may have been disable because of missing > component packing support. However recent nir linking changes > required nir based gallium drivers to support component packing > so this should n

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

https://bugs.freedesktop.org/show_bug.cgi?id=104662 --- Comment #3 from Vedran Miletić --- (In reply to Stewart Little from comment #2) > How do I then get steam to switch to the 4.5 OpenGL and get it as default on > Arch Linux then? Any help would be appreciated I seriously don't know how to > c

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

Why? Marek On Tue, Jan 16, 2018 at 5:39 AM, Mario Kleiner wrote: > For consistency with the i965 default of "off". > > Signed-off-by: Mario Kleiner > --- > src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/a

Re: [Mesa-dev] Mesa 18.0.0 release plan

On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: > Hi all, > > As you've know the Mesa 18.0.0 release plan has been available for a while > on the mesa3d.org website [1]. > > In case you've missed it here it is: > > Jan 19 2018 - Feature freeze/Release candidate 1 > Jan 26 2018

Re: [Mesa-dev] [PATCHv2] intel/fs: Optimize and simplify the copy propagation dataflow logic.

Ian Romanick writes: > On 12/20/2017 11:27 AM, Francisco Jerez wrote: >> Previously the dataflow propagation algorithm would calculate the ACP >> live-in and -out sets in a two-pass fixed-point algorithm. The first >> pass would update the live-out sets of all basic blocks of the program >> base

Re: [Mesa-dev] [PATCHv2] intel/fs: Optimize and simplify the copy propagation dataflow logic.

On 12/20/2017 11:27 AM, Francisco Jerez wrote: > Previously the dataflow propagation algorithm would calculate the ACP > live-in and -out sets in a two-pass fixed-point algorithm. The first > pass would update the live-out sets of all basic blocks of the program > based on their live-in sets, whil

Re: [Mesa-dev] [PATCH 2/3] swr: allow a single swr architecture to be builtin

> On Jan 16, 2018, at 1:59 PM, Chuck Atkins wrote: > > Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes) > > When only a single SWR architecture is being used, this allows that > architecture to be builtin rather than as a separate libswrARCH.so that > gets loaded via dlopen. Sin

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=104665 Bug ID: 104665 Summary: r600: computer shaders break Bioshock on barts (bisected) Product: Mesa Version: git Hardware: Other OS: All Status: NE

[Mesa-dev] [PATCH] meson: add llvm dependency for swr build

cc: Dylan Baker --- src/gallium/drivers/swr/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index c8c69b0..8dffb4c 100644 --- a/src/gallium/drivers/swr/meson.build +++ b/src/gallium/drivers/swr/meson.build

[Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: stop passing pipe_shader_state to st_store_tgsi_in_disk_cache()

We can instead just get this from st_*_program. V2: store tokens to to st_compute_program before attempting to write to cache (fixes crash). Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_program.c | 8 src/mesa/state_tracker/st_shader_cache.c | 22 ---

[Mesa-dev] [PATCH 3/5] st/glsl_to_tgsi: add (de)serialise program helpers

These will be shared between the on-disk shader cache and ARB_get_program_binary. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_shader_cache.c | 265 --- src/mesa/state_tracker/st_shader_cache.h | 8 + 2 files changed, 146 insertions(+), 127 deletions(-) d

[Mesa-dev] [PATCH 4/5] st/glsl_to_tgsi: add st_get_program_binary_driver_sha1() helper

This will be used by ARB_get_program_binary. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_shader_cache.c | 6 ++ src/mesa/state_tracker/st_shader_cache.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/mesa/state_tracker/st_shader_cache.c b/src/mesa/state_tracker/st_sh

[Mesa-dev] [Resend] Gallium ARB_get_program_binary support (Dead Island fix)

I've been contacted by people waiting for this to land so they can play Dead Island so it would be really great if someone could review this before the 18.0 freeze in two days. The feature is enable for any driver that currently enables a tgsi disk cache so it will be enabled for r600, radeonsi an

[Mesa-dev] [PATCH 1/5] st/glsl_to_tgsi: store num_tgsi_tokens in st_*_program

We will need this for ARB_get_program_binary binary support. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_program.c | 21 - src/mesa/state_tracker/st_program.h | 12 src/mesa/state_tracker/st_shader_cache.c | 15 +-- src/mesa/state

  1   2   >