Re: [Mesa-dev] [PATCH] loader/dri3: Avoid freeing renderbuffers in use

On 01/11/2018 04:32 PM, Michel Dänzer wrote: On 2018-01-11 10:53 AM, Thomas Hellstrom wrote: Upon reception of an event that lowered the number of active back buffers, the code would immediately try to free all back buffers with an id equal to or higher than the new number of active back buffers

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #47 from Thomas Hellström --- (In reply to Mark Janes from comment #45) > Thomas: do you have any ideas on how we could catch this category of bug in > automated testing? We have comprehensive automated tests for GL/Vulkan > apis,

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

Hi; On 11.01.2018 20:20, Mario Kleiner wrote: On 01/11/2018 09:14 AM, Tapani Pälli wrote: Yes, but as it broke regular visuals (on some of our testing machines as well) we needed a fast fix for this. While this is an issue, I think the visual corruption has higher priority than this. This ca

Re: [Mesa-dev] [PATCH] i965/screen: Allow drirc to set 'allow_rgb10_configs' again.

Yeah that works, thanks Mario! Reviewed-by: Tapani Pälli On 11.01.2018 18:00, Mario Kleiner wrote: Since setup of ALLOW_RGB10_CONFIGS was moved to i965's own brw_config_options.xml, this was hard-coded to false and could not be overriden by drirc. Add some parsing into i965's private screen->o

[Mesa-dev] [PATCH] st/mesa: enable ARB_enhanced_layouts on nir drivers

I'm guessing this may have been disable because of missing component packing support. However recent nir linking changes required nir based gallium drivers to support component packing so this should now be ok to enable. Cc: Rob Clark --- src/mesa/state_tracker/st_extensions.c | 4 +--- 1 file c

[Mesa-dev] [PATCH V2 5/5] radeonsi: bump glsl version to 450 for nir backend

We still have more work to do but piglit results are looking pretty good. At GLSL 1.50 we have 30647/31118 piglit tests passing. Al GLSL 4.50 we have 37927/38551 piglit tests passing. --- src/gallium/drivers/radeonsi/si_get.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/driver

Re: [Mesa-dev] [PATCH] radv: Initialize DCC on transition from preinitialized.

On 11 January 2018 at 22:21, Bas Nieuwenhuizen wrote: > Looks like the decompress does not handle invalid encodings well, > which happens with random memory. Of course apps should not use it > with random memory, but they are allowed to Preinitialised does sound like it should already have i

[Mesa-dev] [PATCH 3/5] radeonsi/nir: add some missing tcs bits to the nir scan pass

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 2218b7ad81..20b3beccc4 100644 --- a/src/gallium/drivers/radeonsi/si_shader_nir.c +

[Mesa-dev] [PATCH 5/5] radeonsi: bump glsl version to 420 for nir backend

We still have more work to do but piglit results are looking pretty good. At GLSL 1.50 we have 30647/31118 piglit tests passing. Al GLSL 4.20 we have 36236/36854 piglit tests passing. --- src/gallium/drivers/radeonsi/si_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH 2/5] ac: rework load_tcs_{inputs,outputs}

This shares mode code and calls the new shared load_tess_varyings() abi so that the radeonsi nir path now supports tcs output loads. --- src/amd/common/ac_nir_to_llvm.c | 126 +--- 1 file changed, 53 insertions(+), 73 deletions(-) diff --git a/src/amd/common/ac

[Mesa-dev] [PATCH 4/5] st/glsl_to_nir: disable io lowering to temps for tess

Lowering these to temps makes a big mess, and results in some piglit test failures. Also the radeonsi backend (the only backend to support tess) has support for indirects so there is no need to lower them anyway. Fixes the following piglit tests on radeonsi: tests/spec/arb_tessellation_shader/exe

[Mesa-dev] [PATCH 1/5] ac/radeonsi: add tcs load outputs support

The code to load outputs is essentially the same as load inputs so we make the interface more generic to maximise code sharing. We will make use of the new support in the following patch. --- src/amd/common/ac_nir_to_llvm.c | 20 ++- src/amd/common/ac_shader_abi.h

[Mesa-dev] [PATCH 2/2] [rfc] radv: inline push constants where possible. (v2)

From: Dave Airlie Instead of putting the push constants into the upload buffer, if we have space in the sgprs we can upload the per-stage constants into the shaders directly. This saves a few reads from memory in the meta shaders, we should also be able to inline other objects like descriptors.

[Mesa-dev] [PATCH 1/2] ac/shader: gather more push constant info

From: Dave Airlie This gathers the min/max push consts used, and whether the shader uses indirect push constants. It also adds an init function to handle the combined shaders. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 ++ src/amd/common/ac_shader_info.c | 25

Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

On 11 January 2018 at 20:15, Alex Smith wrote: > Hi Dave, > > This seems to cause some breakage when both push constants and dynamic > descriptors are used. > > I've commented 2 fixes inline below needed to avoid a crash, but with those > F1 2017 will still hang pretty quick before the main menu,

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

https://bugs.freedesktop.org/show_bug.cgi?id=104558 Jason Ekstrand changed: What|Removed |Added CC|ja...@jlekstrand.net| -- You are receiving this mail becau

[Mesa-dev] [PATCH 4/4] i965: Set tiling on BOs imported with modifiers

We need this to ensure that GTT maps work on buffers we get from Vulkan on the off chance that someone does a readpixels or something. Soon, we will be removing GTT maps from i965 entirely and this can be reverted. None the less, it's needed for stable. Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 1/4] i965/miptree: Add an explicit tiling parameter to create_for_bo

From: Jason Ekstrand Otherwise, create_for_bo will just grab the tiling from the BO which is not what we want when using modifiers. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_blorp.c | 6 -- src/mesa/drivers/dri/i965/brw_context.c | 4 src/m

[Mesa-dev] [PATCH 2/4] i965/miptree: Use the tiling from the modifier instead of the BO

From: Jason Ekstrand This fixes a bug where we were taking the tiling from the BO regardless of what the modifier said. When we got images in from Vulkan where it doesn't set the tiling on the BO, we would treat them as linear even though the modifier expressly said to treat it as Y-tiled. Cc:

[Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

This helper should be used carefully as setting tiling is a racy operation since it potentially interacts with other processes. Still, it is a useful thing to be able to do. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 27 +++ src/mes

[Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_b2i for doubles

--- Open to suggestions for better ways to do this. src/amd/common/ac_nir_to_llvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b0a8a94a2d..f013b4b387 100644 --- a/src/amd/common/ac_ni

[Mesa-dev] [PATCH 1/2] ac: add i64_1 to llvm build context

--- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index f0a1788eaf..0b8dcf2734 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

On Thu, Nov 30, 2017 at 06:20:51PM +0200, Pohjolainen, Topi wrote: > On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > > Currently, this helper does nothing but we call it every place where an > > image is written through the render pipeline. This will allow us to > > properly mark

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #46 from Sven --- (In reply to Evangelos Foutras from comment #30) > (In reply to Thomas Hellström from comment #29) > > Created attachment 136647 [details] [review] [review] > > Updated patch to avoid freeing renderbuffers currently

Re: [Mesa-dev] [PATCH v2 2/2] broadcom/vc4: Add support for HW perfmon

Boris Brezillon writes: > The V3D engine provides several perf counters. > Implement ->get_driver_query_[group_]info() so that these counters are > exposed through the GL_AMD_performance_monitor extension. This all looks good to me! I'm looking forward to the piglit tests, but this patch is: R

Re: [Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

Tested-by: Dieter Nützel This offer an additional 1-1,5% (~20 fps) boost with 'smoketest'. 6290 presents in 5.00045 seconds (FPS: 1257.89) 6291 presents in 5.00041 seconds (FPS: 1258.1) 6293 presents in 5.00065 seconds (FPS: 1258.44) 6289 presents in 5.0006 seconds (FPS: 1257.65) But _only_ wi

[Mesa-dev] [PATCH] radv/radeonsi/nir: lower 64bit flrp

Fixes a bunch of arb_gpu_shader_fp64 piglit tests for example: generated_tests/spec/arb_gpu_shader_fp64/execution/built-in-functions/fs-mix-double-double-double.shader_test --- src/amd/vulkan/radv_shader.c | 1 + src/gallium/drivers/radeonsi/si_get.c | 1 + 2 files changed, 2 insertions(

Re: [Mesa-dev] meson: vdpau broken on r600

It looks at the vdpau provider sent down down via the X DRI2 protocol. You can also force it to load any particular driver with VDPAU_DRIVER=foo, which would load $vdpau_dir_that_libvdpau_is_built_with/vdpau/libfoo_vdpau.so.1. You can also override the directory with VDPAU_DRIVER_PATH or VDPAU_DRIV

[Mesa-dev] [PATCH 09/10] meson: Build gallium trivial tests

Signed-off-by: Dylan Baker --- meson.build | 2 +-- src/gallium/meson.build | 6 -- src/gallium/tests/meson.build | 21 - src/gallium/tests/trivial/meson.build | 29 - 4 files changed, 54 inserti

[Mesa-dev] [PATCH 10/10] meson: build gallium unit tests

Signed-off-by: Dylan Baker --- src/gallium/tests/meson.build | 1 +- src/gallium/tests/unit/meson.build | 31 +++- 2 files changed, 32 insertions(+) create mode 100644 src/gallium/tests/unit/meson.build diff --git a/src/gallium/tests/meson.build b/src/gallium/t

[Mesa-dev] [PATCH 02/10] meson: run glsl compiler warnings test

Signed-off-by: Dylan Baker --- src/compiler/glsl/tests/meson.build | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index 27f3407..11fb4fb 100644 --- a/src/compiler/glsl/tests/meson.build +++

[Mesa-dev] [PATCH 08/10] meson: Remove TODO about mesa/main tests

They're already done. Signed-off-by: Dylan Baker --- src/mesa/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index ab6bc27..ce612fb 100644 --- a/src/mesa/meson.build +++ b/src/mesa/meson.build @@ -18,8 +18,6 @@ # OUT OF OR IN CONNECT

[Mesa-dev] [PATCH 07/10] meson: enable glcpp test

Signed-off-by: Dylan Baker --- src/compiler/glsl/glcpp/meson.build | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 17ee1a2..9f869da 100644 --- a/src/compiler/glsl/glcpp/meson.bu

[Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbols exposed

Signed-off-by: Dylan Baker --- src/gallium/targets/vdpau/meson.build | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/gallium/targets/vdpau/meson.build b/src/gallium/targets/vdpau/meson.build index 67f1469fb0f..432a32a7340 100644 --- a/src/gallium/targets

[Mesa-dev] [PATCH 05/10] glsl/tests: Remove unused compare_ir.py script

Signed-off-by: Dylan Baker --- src/compiler/glsl/tests/compare_ir.py | 58 + 1 file changed, 58 deletions(-) delete mode 100644 src/compiler/glsl/tests/compare_ir.py diff --git a/src/compiler/glsl/tests/compare_ir.py b/src/compiler/glsl/tests/compare_ir.py deleted f

[Mesa-dev] [PATCH 03/10] glsl/tests: Convert optimization-test.sh to pure python

This patch converts optimization-test.sh to python, in this process it removes external shell dependencies including diff. It replaces the python script that generates shell scripts with a python library that generates test cases and runs them using subprocess. Signed-off-by: Dylan Baker --- src

[Mesa-dev] [PATCH 00/10] Finish unit tests for meson build

This series adds the rest of the unit tests in the mesa tree, including the gallium test binaries. The relevant tests are wired into the `ninja test` command, and all tests pass. A big part of this series is converting tests from shell based to a pure python base. These are mostly straight forward

Re: [Mesa-dev] meson: vdpau broken on r600

I couldn't reproduce with nouveau, vdpauinfo seems hardcoded to look for vdpau_nvidia, and just ignores vdpau_nouveau. I have a patch that adds the symbol, but it feels ugly. I'm sending it and we can test it, if it does fix it I guess we should figure out why we need to keep adding --Wl,-whole-a

Re: [Mesa-dev] [PATCH v2] r600: Allow egd_tables.py to run with python3 too

This is somewhat insufficient, it might run okay with python3, but the behavior will be different between the two. Please add `from __future__ import print_function`, so that the behavior will be the same, not just the syntax. Also, the StringTable, InteTable, Field, and Reg classes is also an old

[Mesa-dev] [PATCH 06/10] glcpp/tests: Convert shell scripts to a python script

This ports glcpp-test.sh and glcpp-test-cr-lf.sh to a python script that accepts arguments for each line ending type. This should allow for better reporting to users. Signed-off-by: Dylan Baker --- src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh | 148 +-- src/compiler/glsl/glcpp/tests

[Mesa-dev] [PATCH 01/10] glsl/tests: reimplement warnings-test in python

This reimplements the test in python with a shell script wrapper that allows autotools to continue to run the test without realizing that anything has changed. Using python has two advantages, first it's portable so this test can be run on windows as well as Linux since it just requires python, no

[Mesa-dev] [PATCH 04/10] meson: enable optimization-test

Signed-off-by: Dylan Baker --- src/compiler/glsl/tests/meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index 11fb4fb..d5e6b5f 100644 --- a/src/compiler/glsl/tests/meson.build +++ b/src/compiler/glsl/te

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

> > So I had a look into implementing this, and using function pointers is > problematic due to this struct being passed between processes which would > prevent mesa calling a function assigned in gbm_gralloc for example. Which function? In theory, anything with a dependency on libdrm and a gral

Re: [Mesa-dev] [PATCH] loader/dri3: Avoid freeing renderbuffers in use

On Thursday, January 11, 2018 1:53:48 AM PST Thomas Hellstrom wrote: > Upon reception of an event that lowered the number of active back buffers, > the code would immediately try to free all back buffers with an id equal to or > higher than the new number of active back buffers. > > However, that

[Mesa-dev] [PATCH] r600: fix relocs for PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE query

From: Roland Scheidegger The command parser is very sad if we don't emit the relocs per hw query... However, don't enable it. It mostly works, but piglit arb_transform_feedback_overflow_query-basic shows 2 failures (it's really the same case for the hw), conditional_render_any and conditional_re

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #45 from Mark Janes --- Thomas: do you have any ideas on how we could catch this category of bug in automated testing? We have comprehensive automated tests for GL/Vulkan apis, but not much for dri3. -- You are receiving this mai

[Mesa-dev] [PATCH] nouveau: Support fence FDs

From: Thierry Reding Implements fence FDs based on new libdrm API and the accompanying IOCTL. Signed-off-by: Thierry Reding --- For the kernel patches that add the new IOCTL, see the series at: https://patchwork.freedesktop.org/series/36361/ The libdrm patch that adds the new API is h

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

Sorry. It's taken a bit of time but the WG has a decision and that is that we are supposed to throw VK_ERROR_OUT_OF_DEVICE_MEMORY in this case. I believe you had an alternate version of the patch that did something like that. If so, we should revive it. On Thu, Jan 11, 2018 at 5:04 AM, Samuel I

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

https://bugs.freedesktop.org/show_bug.cgi?id=104558 Paul Menzel changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from Paul Menzel ---

Re: [Mesa-dev] [PATCH 17/29] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

On Fri, Dec 08, 2017 at 04:16:04PM +0200, Pohjolainen, Topi wrote: > On Mon, Nov 27, 2017 at 07:06:07PM -0800, Jason Ekstrand wrote: > > This doesn't really change much now but it will give us more/better > > control over clears in the future. The one interesting functional > > change here is that

Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

On 01/11/2018 04:03 AM, Dave Airlie wrote: From: Dave Airlie Instead of putting the push constants into the upload buffer, if we have space in the sgprs we can upload the per-stage constants into the shaders directly. This saves a few reads from memory in the meta shaders, we should also be

Re: [Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_fsign for doubles

Series is: Reviewed-by: Samuel Pitoiset On 01/11/2018 12:35 PM, Timothy Arceri wrote: Without this we end up with the llvm error message: "Both operands to a binary operator are not of the same type!" --- src/amd/common/ac_nir_to_llvm.c | 26 +++--- 1 file changed, 19 i

Re: [Mesa-dev] [PATCH] radv: set no-signed-zeros-fp-math

On 01/11/2018 11:08 AM, Józef Kucia wrote: On Wed, Jan 10, 2018 at 10:31 PM, Samuel Pitoiset wrote: + LLVMAddTargetDependentFunctionAttr(main_function, + "no-signed-zeros-fp-math", + "true"); + Is this o

Re: [Mesa-dev] [PATCH] ac/nir: fix translation of nir_op_frcp for doubles

Reviewed-by: Samuel Pitoiset On 01/11/2018 11:14 AM, Timothy Arceri wrote: Without this we end up with the llvm error message: "Both operands to a binary operator are not of the same type!" --- This is an additional fix on top of this series: https://patchwork.freedesktop.org/series/3631

Re: [Mesa-dev] [PATCH 3/3] ac: add 'const' qualifiers to the shader info pass

Reviewed-by: Bas Nieuwenhuizen for the series On Thu, Jan 11, 2018 at 10:07 PM, Samuel Pitoiset wrote: > For clarification purposes. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_shader_info.c | 17 ++--- > src/amd/common/ac_shader_info.h | 2 +- > 2 files changed,

[Mesa-dev] [PATCH 1/3] nir: add a 'const' qualifier to nir_ssa_def_components_read()

To avoid compilation warnings and because this helper shouldn't update anything. Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.c | 2 +- src/compiler/nir/nir.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 6

[Mesa-dev] [PATCH 2/3] ac: remove unused ac_nir_compiler_options from gather_info_input_decl()

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index 443980c7d1..9dc85fb74f 100644 --- a/src/amd/common/ac_shader_info.c +++ b/src/amd/co

[Mesa-dev] [PATCH 3/3] ac: add 'const' qualifiers to the shader info pass

For clarification purposes. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 17 ++--- src/amd/common/ac_shader_info.h | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

Heya, On 12/22/17 1:09 PM, Tomasz Figa wrote: On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh wrote: So the plan is for alloc_handle_t to not be sub-classed by the implementations, but have all necessary information that an implementation would need? If so, how do we reconcile the implement

Re: [Mesa-dev] [PATCH] i965/screen: Allow drirc to set 'allow_rgb10_configs' again.

Reviewed-by: Marek Olšák Marek On Thu, Jan 11, 2018 at 5:00 PM, Mario Kleiner wrote: > Since setup of ALLOW_RGB10_CONFIGS was moved to i965's own > brw_config_options.xml, this was hard-coded to false and > could not be overriden by drirc. Add some parsing into > i965's private screen->optionCa

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: skip padded empty buffers in chain.

On Thu, Jan 11, 2018 at 5:56 AM, Dave Airlie wrote: > From: Dave Airlie > > When chaining buffers if we see an empty one (just padded) > skip over it. > --- > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 09:14 AM, Tapani Pälli wrote: Yes, but as it broke regular visuals (on some of our testing machines as well) we needed a fast fix for this. While this is an issue, I think the visual corruption has higher priority than this. This can be fixed meanwhile or afterwards when things

Re: [Mesa-dev] meson: vdpau broken on r600

On Tuesday, 2018-01-09 10:09:16 -0800, Dylan Baker wrote: > I'm not sure off the top of my head. I don't have an r600 anymore, but I have > an > SI and a nouveau machine, so I'll see if I can reproduce the problem there and > fix it. I can confirm, the symbol is missing when building with meson:

Re: [Mesa-dev] [PATCH] r600: add support for ARB_shader_clock.

I can't test it with my 6870 HD, piglit clock2x32  need OGL 4.3 (wich I force), and then it fails with  evergreen_state.c:4762: evergreen_emit_atomic_buffer_setup:  Assertion `resource' failed. Compute shader piglits with atomics work though. The patch itself looks fine, so Reviewed-by

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

Please make sure the new .c file is added in the meson build as well before pushing. Dylan Quoting Christian König (2018-01-10 05:03:44) > My last status was that Leo wanted to commit this. > > Leo are you still waiting for something? > > Christian. > > Am 10.01.2018 um 10:29 schrieb Julien Is

Re: [Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

I also prefer Jason's approach of moving just the creation of the mako Template inside the if __main__ block, but leaving the actual string at the top level. Alternatively we could split anv_extensions.py into two files: one that has the constant data, and one that generates anv_extensions.c. I th

Re: [Mesa-dev] [PATCH v2] anv: Import mako templates only during execution of anv_extensions

Reviewed-by: Dylan Baker Quoting Andres Gomez (2018-01-10 13:11:51) > anv_extensions usage from anv_icd was bringing the unwanted dependency > of mako templates for the latter. We don't want that since it will > force the dependency even for distributable tarballs which was not > needed until now

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 02:39 PM, Marek Olšák wrote: On Jan 11, 2018 7:14 AM, "Mario Kleiner" > wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false")

[Mesa-dev] [PATCH] i965/screen: Allow drirc to set 'allow_rgb10_configs' again.

Since setup of ALLOW_RGB10_CONFIGS was moved to i965's own brw_config_options.xml, this was hard-coded to false and could not be overriden by drirc. Add some parsing into i965's private screen->optionCache to enable drirc again. Fixes: b391fb26df9f1b ("dri_util: remove ALLOW_RGB10_CONFIGS option (

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On Wed, 2018-01-10 at 14:04 +0200, Tapani Pälli wrote: > > On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: > > Please, could someone take a look at this patch? Thanks in advance. > > > > This looks correct to me. Is there some dEQP/Piglit test for this situation? Yes. It fixes KHR-GL*.sha

[Mesa-dev] [PATCH] ac: replace llvm.AMDGPU.kilp by llvm.amdgcn.kill with LLVM 6

This also replaces llvm.AMDGPU.kilp by llvm.AMDGPU.kill with LLVM < 6. Similar to RadeonSI codepath. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/s

Re: [Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

On Thu, Jan 11, 2018 at 1:48 AM, Iago Toral wrote: > On Wed, 2018-01-10 at 11:22 -0800, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_draw.c | 41 > > > > 1 file changed, 41 insertions(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_dr

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

https://bugs.freedesktop.org/show_bug.cgi?id=104558 --- Comment #4 from Michel Dänzer --- (In reply to Paul Menzel from comment #2) > I have LLVM 4.0.0 installed built with `-DLLVM_BUILD_LLVM_DYLIB=ON` from > Linux from Scratch [1]. Does adding -DLLVM_LINK_LLVM_DYLIB=ON for the LLVM build, then

[Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

Enable these kind of texture when proper extensions are available. Fixes KHR-GLES2.texture_3d.* with these textures. --- src/mesa/main/teximage.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c ind

Re: [Mesa-dev] [PATCH] loader/dri3: Avoid freeing renderbuffers in use

On 2018-01-11 10:53 AM, Thomas Hellstrom wrote: > Upon reception of an event that lowered the number of active back buffers, > the code would immediately try to free all back buffers with an id equal to or > higher than the new number of active back buffers. > > However, that could lead to an acti

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

https://bugs.freedesktop.org/show_bug.cgi?id=104558 --- Comment #3 from Paul Menzel --- Created attachment 136663 --> https://bugs.freedesktop.org/attachment.cgi?id=136663&action=edit Output of `./configure …` The errors below are shown. ``` […] llvm-config: error: missing: /usr/lib/libLLVMDe

Re: [Mesa-dev] [PATCH] mesa: require at least 14 UBOs for GL 4.3

On 01/10/2018 06:14 PM, srol...@vmware.com wrote: From: Roland Scheidegger ARB_ubo requires 12 UBOs (per stage) at least, but this limit has been raised by GL 4.3 to 14, so don't advertize GL 4.3 without it (only checking the vertex stage since all drivers probably have the same limit anyway fo

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

https://bugs.freedesktop.org/show_bug.cgi?id=104558 --- Comment #2 from Paul Menzel --- (In reply to Bas Nieuwenhuizen from comment #1) > This looks like it fails to link with LLVM. What LLVM version do you have > installed? I have LLVM 4.0.0 installed built with `-DLLVM_BUILD_LLVM_DYLIB=ON` fro

[Mesa-dev] [PATCH v2] r600: Allow egd_tables.py to run with python3 too

diff --git a/src/gallium/drivers/r600/egd_tables.py b/src/gallium/drivers/r600/egd_tables.py index d7b78c7fb1..7bda44ce83 100644 --- a/src/gallium/drivers/r600/egd_tables.py +++ b/src/gallium/drivers/r600/egd_tables.py @@ -1,4 +1,4 @@ - +#!/usr/bin/python3 CopyRight = ''' /* * Copyright 2015 A

Re: [Mesa-dev] [PATCH 0/6] i965: Misc sRGB and CCS fixes

Hi, This series increases performance except in SynMark DrvState, where drop is acceptable & expected [1]. BXT J4205 improvements: 1-2% in GfxBench Manhattan 3.1 1% in GfxBench CarChase & SynMark Deferred KBL GT2 improvements: 2-3% in GfxBench Manhattan 3.1 1-2% in GfxBench CarChase & Syn

Re: [Mesa-dev] r600 sb tessellation support

Hi Dave, Am Mittwoch, den 10.01.2018, 16:48 +1000 schrieb Dave Airlie: > This is an attempt to add tessellation support to the SB backend. > I tried to dig a bit more in the failing piglits, specifically  "1in-1out" that passed with your WIP branch form Jan/9. Now, with sb it fails by drawing

Re: [Mesa-dev] [PATCH] amd/common: fix loading InstanceID for tess on < GFX9

On 01/11/2018 02:56 PM, Samuel Pitoiset wrote: InstanceID is in VGPR2, not 1. One more failure that CTS didn't catch up... Reported-by: Alex Smith Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/s

[Mesa-dev] [PATCH] amd/common: fix loading InstanceID for tess on < GFX9

InstanceID is in VGPR2, not 1. One more failure that CTS didn't catch up... Reported-by: Alex Smith Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_ni

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

Oh. I see. I was distracted by the hard coded 16! Thanks. Best Regards, David -Original Message- From: Bas Nieuwenhuizen [mailto:b...@basnieuwenhuizen.nl] Sent: Thursday, January 11, 2018 9:29 PM To: Mao, David Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] radv

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On Jan 11, 2018 7:14 AM, "Mario Kleiner" wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: > Hi Marek; > > This one works but only if you add > > DRI_CONF_ALLOW_RGB10_CONFIGS("false") > > to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that > change: Reviewed-by: Tapani Päll

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

Right, that matches with what I wrote on how to use it? e.g. to write out my first example (3 rects, inclusive): 0/b unset, as none of the first 3 bits are set 1/b0001 set 2/b0010 set 3/b0011 set 4/b0100 set 5/b0101 set 6/b0110 set 7/b0111 set 8/b1000 unset, as none of the first 3 bi

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

On Jan 11, 2018 1:45 PM, "Rob Clark" wrote: On Wed, Jan 10, 2018 at 4:41 PM, Marek Olšák wrote: > On Wed, Jan 10, 2018 at 9:36 PM, Rob Clark wrote: >> On Wed, Jan 10, 2018 at 3:33 PM, Rob Clark wrote: >>> On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: From: Marek Olšák --

[Mesa-dev] [PATCH v2] i965/meta-util: Convert the clear color through the surf format

When programming the fast clear color there was previously a chunk of code to try to make the color match the constraints of the surface format such as by filling in missing components and handling luminance formats. These cases are not handled by the hardware. There are some additional possible re

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

Actually it is not calculated in this way. - The `inside` flags for each of the four clip rectangles form a 4-bit binary number. The corresponding bit in this 16-bit number specifies whether the pixel is visible 1: we can only set clip rules for 4 rectangles at the same time. (b0011 means when

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

This patch is still unreviewed. Sam On 14/11/17 09:45, Samuel Iglesias Gonsálvez wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. This patch > logs a debug error and set the size to the UINT64_MAX in order to > avoid a

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

On Wed, Jan 10, 2018 at 4:41 PM, Marek Olšák wrote: > On Wed, Jan 10, 2018 at 9:36 PM, Rob Clark wrote: >> On Wed, Jan 10, 2018 at 3:33 PM, Rob Clark wrote: >>> On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/freedreno/freedren

Re: [Mesa-dev] [PATCH] anv: VkDescriptorSetLayoutBinding can have descriptorCount == 0

Reviewed-by: Lionel Landwerlin Probably Cc stable too. Thanks! On 11/01/18 11:09, Samuel Iglesias Gonsálvez wrote: From Vulkan spec: "descriptorCount is the number of descriptors contained in the binding, accessed in a shader as an array. If descriptorCount is zero this binding entry is rese

[Mesa-dev] [PATCH] radv: Initialize DCC on transition from preinitialized.

Looks like the decompress does not handle invalid encodings well, which happens with random memory. Of course apps should not use it with random memory, but they are allowed to Fixes: 44fcf58744 "radv: Disable DCC for GENERAL layout and compute transfer dest." --- src/amd/vulkan/radv_cmd_bu

[Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_fsign for doubles

Without this we end up with the llvm error message: "Both operands to a binary operator are not of the same type!" --- src/amd/common/ac_nir_to_llvm.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/a

[Mesa-dev] [PATCH 1/2] ac: add f64_0 to the llvm build context

--- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 75cc0dc63c..f0a1788eaf 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Thu, Jan 11, 2018 at 3:51 AM, Gert Wollny wrote: > Am Donnerstag, den 11.01.2018, 08:09 +0100 schrieb Gert Wollny: >> Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: >> [...] >> > >> > If your hardware executes all the vertices in parallel, then a >> > barrier should be unnecessar

[Mesa-dev] [PATCH] anv: VkDescriptorSetLayoutBinding can have descriptorCount == 0

From Vulkan spec: "descriptorCount is the number of descriptors contained in the binding, accessed in a shader as an array. If descriptorCount is zero this binding entry is reserved and the resource must not be accessed from any stage via this binding within any pipeline using the set layout." Fi

Re: [Mesa-dev] [PATCH] loader/dri3: Avoid freeing renderbuffers in use

Tested-by: Vadym Shovkoplias This patch also fixes similar issue with SHENZHEN I/O game ( https://bugs.freedesktop.org/show_bug.cgi?id=104392) Tested on HP Zbook. 2018-01-11 11:53 GMT+02:00 Thomas Hellstrom : > Upon reception of an event that lowered the number of active back buffers, > the cod

Re: [Mesa-dev] [PATCH] loader/dri3: Avoid freeing renderbuffers in use

Tested-by: Andriy.Khulap Fixes Bug 104301 (https://bugs.freedesktop.org/show_bug.cgi?id=104301) on Intel(R) HD Graphics 530 (Skylake GT2) (0x191b) Ubuntu 16.04 Kernel 4.4.0 Mesa 17.4.0-devel (git-4f1e500) mpv 0.14.0-git-e1993d5 *Andriy Khulap | Software Engineer* Mobile: +38-067-607-27-80 Skype

[Mesa-dev] [PATCH] etnaviv: dirty TS state when framebuffer has changed

When switching between framebuffers with and without TS, the TS state needs to be flushed to the command stream even if the derived state isn't changed. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

  1   2   >