[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #19 from Tapani Pälli --- Created attachment 135745 --> https://bugs.freedesktop.org/attachment.cgi?id=135745&action=edit fix/workaround I've sent this patch to xorg-devel for review/discussion. Problem is that GLX may pick sRGB c

[Mesa-dev] [PATCH] i965: fix KHR-GL46.enhanced_layouts.varying_* failures

This resolves following test failures by partially reverting "mesa: shrink VERT_ATTRIB bitfields to 32 bits": KHR-GL46.enhanced_layouts.varying_array_locations KHR-GL46.enhanced_layouts.varying_locations KHR-GL46.enhanced_layouts.varying_structure_locations Fixes: 78942e7dbfd234c ("mesa: shrink VE

Re: [Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

I really don't think you wanted to remove the cur_pass variable there :-). With that fixed, Reviewed-by: Roland Scheidegger Am 28.11.2017 um 04:10 schrieb Ian Romanick: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > Having this information would have helped me review recent patch

Re: [Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

On 11/27/2017 07:08 PM, Jason Ekstrand wrote: > On Mon, Nov 27, 2017 at 7:00 PM, Ian Romanick > wrote: > > I am strongly in favor of this precedent.  One thing that has annoyed me > for years about Mesa's OpenGL code is the use of mixed suffixes through >

[Mesa-dev] [PATCH 20/29] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

This moves the decision out of begin_subpass and into BeginRenderPass like the decision for color clears. We use a similar name for the function for depth/stencil as for color even though no aux usage is really getting computed. --- src/intel/vulkan/genX_cmd_buffer.c | 84 +++-

[Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

From: Ian Romanick Signed-off-by: Ian Romanick --- Having this information would have helped me review recent patches from Miklós... src/mesa/main/mtypes.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2f2163

[Mesa-dev] [PATCH 21/29] anv/cmd_buffer: Iterate all subpass attachments when clearing

This unifies things a bit because we now handle depth and stencil at the same time. It also ensures that clears happen for input attachments. --- src/intel/vulkan/genX_cmd_buffer.c | 69 -- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/src/int

[Mesa-dev] [PATCH 15/29] anv/cmd_buffer: Add begin/end_subpass helpers

Having begin/end_subpass is a bit nicer than the begin/next/end hooks that Vulkan gives us. --- src/intel/vulkan/genX_cmd_buffer.c | 55 +- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/gen

[Mesa-dev] [PATCH 17/29] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

This doesn't really change much now but it will give us more/better control over clears in the future. The one interesting functional change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and friends for each clear. However, this only happens at begin_subpass time so it shouldn't be su

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

On 11/27/2017 01:27 PM, Roland Scheidegger wrote: > Am 27.11.2017 um 21:29 schrieb Ian Romanick: >> On 11/20/2017 06:04 PM, Roland Scheidegger wrote: >>> Am 21.11.2017 um 01:40 schrieb Ian Romanick: On 11/20/2017 04:07 PM, Miklós Máté wrote: > This fixes crash when: > - first pass begi

[Mesa-dev] [PATCH 14/29] anv/cmd_buffer: Apply subpass flushes before set_subpass

This seems slightly more correct because it means that the flushes happen before any clears or resolves implied by the subpass transition. --- src/intel/vulkan/genX_cmd_buffer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/in

[Mesa-dev] [PATCH 29/29] anv: Use blorp_ccs_ambiguate instead of fast-clears

Even though the blorp pass looks a bit on the sketchy side, the end result in the Vulkan driver is very nice. Instead of having this weird case where you do a fast clear and then maybe have to resolve, we just do the ambiguate and are done with it. The ambiguate does exactly what we want of setti

[Mesa-dev] [PATCH 05/29] anv/image: Update a comment

This got lost in all of the aspect vs. plane rebasing of YCBCR. --- src/intel/vulkan/anv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index ba932ba..a872149 100644 --- a/src/intel/vulkan/anv_image.c +++ b/sr

[Mesa-dev] [PATCH 13/29] anv/cmd_buffer: Rework aux tracking

This makes us start tracking two bits per level for aux to describe both whether or not something is fast-cleared and whether or not it is compressed as opposed to a single "needs resolve" bit. The previous scheme only worked because we assumed that CCS_E compressed images would always be read wit

[Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

--- src/intel/vulkan/anv_blorp.c | 243 - src/intel/vulkan/anv_private.h | 17 ++- src/intel/vulkan/genX_cmd_buffer.c | 68 ++- 3 files changed, 188 insertions(+), 140 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan

Re: [Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

On Mon, Nov 27, 2017 at 7:00 PM, Ian Romanick wrote: > I am strongly in favor of this precedent. One thing that has annoyed me > for years about Mesa's OpenGL code is the use of mixed suffixes through > the code base as an extension progresses from vendor -> EXT -> ARB -> core. > I'm having a b

[Mesa-dev] [PATCH 09/29] anv/cmd_buffer: Generalize transition_color_buffer

This moves it to being based on layout_to_aux_usage instead of being hard-coded based on bits of a priori knowledge of how transitions interact with layouts. This conceptually simplifies things because we're now using layout_to_aux_usage and layout_supports_fast_clear to make resolve decisions so

[Mesa-dev] [PATCH 25/29] anv/cmd_buffer: Avoid unnecessary transitions before fast clears

Previously, we would always apply the layout transition at the beginning of the subpass and then do the clear whether fast or slow. This meant that there were some cases, specifically when the initial layout is VK_IMAGE_LAYOUT_UNDEFINED, where we would end up doing a fast-clear or ambiguate follow

[Mesa-dev] [PATCH 28/29] anv/cmd_buffer: Re-arrange the logic around UNDEFINED fast-clears

--- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 9e584c1..dcd5a8f 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/int

[Mesa-dev] [PATCH 18/29] intel/blorp: Add a blorp_hiz_clear_depth_stencil helper

This is similar to blorp_gen8_hiz_clear_attachments except that it takes actual images instead of trusting in the already set depth state. --- src/intel/blorp/blorp.h | 11 ++ src/intel/blorp/blorp_clear.c | 50 +++ 2 files changed, 61 insertio

[Mesa-dev] [PATCH 27/29] anv/cmd_buffer: Pull the undefined layout condition into the if

Now that this isn't a multi-case if and it's just the one case, it's a bit clearer if the condition is just part of the if instead of being pulled out into a boolean variable. --- src/intel/vulkan/genX_cmd_buffer.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 04/29] anv/blorp: Rework HiZ ops to look like MCS and CCS

--- src/intel/vulkan/anv_blorp.c | 38 ++ src/intel/vulkan/anv_private.h | 9 + src/intel/vulkan/genX_cmd_buffer.c | 11 ++- 3 files changed, 33 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulk

[Mesa-dev] [PATCH 24/29] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

--- src/intel/vulkan/genX_cmd_buffer.c | 187 + 1 file changed, 65 insertions(+), 122 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 7901b0c..2c4ab38 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b

[Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

Currently, this helper does nothing but we call it every place where an image is written through the render pipeline. This will allow us to properly mark the aux state so that we can handle resolves correctly. --- src/intel/vulkan/anv_blorp.c | 36 src/i

[Mesa-dev] [PATCH 10/29] anv/cmd_buffer: Add an anv_genX_call macro

This is copied and pasted from the similar macro we added to ISL. --- src/intel/vulkan/anv_cmd_buffer.c | 40 --- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 69acafa

[Mesa-dev] [PATCH 12/29] anv/cmd_buffer: Drop the genX from get/set_needs_resolve

They are static functions so there's no real need to have the genX and it just makes the function names longer. --- src/intel/vulkan/genX_cmd_buffer.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/

[Mesa-dev] [PATCH 00/29] anv: Rework resolves and fast clears

This patch series is a major rework of the aux tracking and fast clear code in our Vulkan driver. It's broken up into three basic pieces: 1) Patches 1-13 rework the way layout transitions work and add some additional granularity to our aux tracking scheme. This is required to support Y-

[Mesa-dev] [PATCH 16/29] anv/cmd_buffer: Pass a subpass id into begin_subpass

This is a bit less awkward than passing in the subpass because it means we don't have to extract the subpass id from the subpass. --- src/intel/vulkan/genX_cmd_buffer.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/

[Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

--- src/intel/vulkan/anv_image.c | 58 ++ src/intel/vulkan/anv_private.h | 5 2 files changed, 63 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index a872149..561da28 100644 --- a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 01/29] intel/isl: Codify AUX operations in an enum

Right now, we have different entrypoints and enums in blorp for these different operations. This provides us a central enum which we can begin to transition to. --- src/intel/isl/isl.h | 74 +++-- 1 file changed, 49 insertions(+), 25 deletions(-) d

[Mesa-dev] [PATCH 08/29] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

--- src/intel/vulkan/genX_cmd_buffer.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 0c1ae83..be717eb 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_c

[Mesa-dev] [PATCH 23/29] anv/cmd_buffer: Sync clear values in begin_subpass

This is quite a bit cleaner because we now sync the clear values at the same time as we do the fast clear. For loading the clear values into the surface state, we now do it once when we handle the LOAD_OP_LOAD instead of every subpass. --- src/intel/vulkan/anv_private.h | 8 ++ src/intel/vu

[Mesa-dev] [PATCH 26/29] intel/blorp: Add a CCS ambiguation pass

--- src/intel/blorp/blorp.h | 5 ++ src/intel/blorp/blorp_clear.c | 106 ++ 2 files changed, 111 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 208b2db..dda0bf9 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel

[Mesa-dev] [PATCH 03/29] anv/blorp: Support ISL_AUX_USAGE_HIZ in surf_for_anv_image

If the function gets passed ANV_AUX_USAGE_DEFAULT, it still has the old behavior of setting ISL_AUX_USAGE_NONE for depth/stencil which is what we want for blits/copies. --- src/intel/vulkan/anv_blorp.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

This replaces image_fast_clear and ccs_resolve with two new helpers that simply perform an isl_aux_op whatever that may be on CCS or MCS. This is a bit cleaner as it separates performing the aux operation from which blorp helper we have to call to do it. --- src/intel/vulkan/anv_blorp.c | 2

[Mesa-dev] [PATCH 22/29] anv/cmd_buffer: Add a concept of pending load aspects

These are the same as pending clear aspects only for the "load" operation. --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/genX_cmd_buffer.c | 22 -- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulka

[Mesa-dev] [PATCH 07/29] anv/image: Support color aspects in layout_to_aux_usage

--- src/intel/vulkan/anv_image.c | 48 ++-- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 561da28..7e89f75 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/an

Re: [Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

I am strongly in favor of this precedent. One thing that has annoyed me for years about Mesa's OpenGL code is the use of mixed suffixes through the code base as an extension progresses from vendor -> EXT -> ARB -> core. On 11/27/2017 06:36 PM, Jason Ekstrand wrote: > --- > src/amd/vulkan/radv_de

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On 11/23/2017 05:32 AM, Emil Velikov wrote: > Hi Eric, > > On 22 November 2017 at 17:59, Eric Engestrom > wrote: >> A recent thread [1] made me check our local specs to see which ones were >> upstream. This series removes the ones that are identical upstream >> (modulo "TBD" extension numbers in

[Mesa-dev] [PATCH] radv: Implemnet VK_EXT_external_memory_dma_buf

--- This is only compile-tested as there are no tests for this extension at present. However, I'd really like use the DMA_BUF handle type in my WSI rework instead of using OPAQUE_FD and trusting that the exported FD really is a prime FD. src/amd/vulkan/radv_device.c | 8 ++-- src/amd/v

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On 11/27/2017 02:24 AM, Eric Engestrom wrote: > On Sunday, 2017-11-26 17:24:09 -0800, Eric Anholt wrote: >> Eric Engestrom writes: >> >>> On Wednesday, 2017-11-22 12:28:17 -0800, Eric Anholt wrote: Jordan Justen writes: > On 2017-11-22 09:59:34, Eric Engestrom wrote: >> A recent

[Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

--- src/amd/vulkan/radv_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 722c768..8e5ae0b 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -895,13 +895,13 @@ radv_ge

[Mesa-dev] [PATCH 3/3] anv: Implement VK_EXT_external_memory_dma_buf

This is a modified version of the patch originally sent by Chad Versace. The primary difference is that this version claims that OPQAUE_FD and DMA_BUF are compatible handle types. --- src/intel/vulkan/anv_device.c | 13 ++--- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan

[Mesa-dev] [PATCH 1/3] vulkan: Update the XML and headers to 1.0.66

--- include/vulkan/vulkan.h| 69 ++-- src/vulkan/registry/vk.xml | 71 -- 2 files changed, 116 insertions(+), 24 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index 048866c..ec67a

[Mesa-dev] [Bug 103945] FireFox Error Abort with flash objects

https://bugs.freedesktop.org/show_bug.cgi?id=103945 --- Comment #1 from Timothy Arceri --- Mesa 11.0.7 is very old and no longer supported, you should try a newer Mesa version. Also you should provide details of the hardware you are running. -- You are receiving this mail because: You are the a

[Mesa-dev] [Bug 103945] FireFox Error Abort with flash objects

https://bugs.freedesktop.org/show_bug.cgi?id=103945 Bug ID: 103945 Summary: FireFox Error Abort with flash objects Product: Mesa Version: 11.0 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v3] util: Add Mesa ARB_get_program_binary helper functions

From: Jordan Justen V2 (Timothy Arceri): - add extra code comment - stop passing around void *binary and just pass program_binary_header *hdr instead. - move to src/mesa/main rather than src/util Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri --- src/mesa/Makefile.sources

Re: [Mesa-dev] [PATCH 08/24] mesa: add gl_constants::SpirVCapabilities

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > For drivers to declare which SPIR-V features they support. > --- > src/mesa/main/mtypes.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index f19477eb027.

Re: [Mesa-dev] [PATCH 06/24] mesa: implement SPIR-V loading in glShaderBinary

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > v2: Add a gl_shader_spirv_data member to gl_shader, which already >encapsulates a gl_spirv_module where the binary will be saved. >(Eduardo Lima) > --- > src/mesa/main/glspirv.c | 52 > +++

Re: [Mesa-dev] [PATCH 05/24] mesa/glspirv: Add struct gl_shader_spirv_data

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > This is a per-shader structure holding the SPIR-V data associated with the > shader (binary module, specialization constants and entry-point). > > This is needed because both gl_shader and gl_linked_shader need to share this > data. Instead of co

Re: [Mesa-dev] [PATCH 04/24] mesa/glspirv: Add struct gl_spirv_module

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > v2: Make the SPIR-V module struct part of a larger gl_shader_spirv_data > struct that will be introduced later, and don't reference it directly > in gl_shader. (Eduardo Lima) > --- > src/mesa/main/glspirv.c | 19

Re: [Mesa-dev] [PATCH 03/24] mesa: refuse to compile SPIR-V shaders or link mixed shaders

This patch is Reviewed-by: Ian Romanick On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > Note that gl_shader::CompileStatus will also indicate whether a shader > has been successfully specialized. > --- > src/mesa/main/shaderapi.c | 12 > src/mes

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

On 11/27/2017 02:15 PM, Ian Romanick wrote: > On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: >> From: Nicolai Hähnle >> >> --- >> src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ >> src/mapi/glapi/gen/Makefile.am | 1 + >> src/mapi/glapi/gen/gl_API.xml | 4 +++

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > --- > src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 4 +++ > src/mapi/glapi/gen/gl_genexec.py| 1 + >

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Thu, 2017-11-23 at 16:32 +, Emil Velikov wrote: > On 23 November 2017 at 16:04, Eric Engestrom > wrote: > > On Thursday, 2017-11-23 13:32:47 +, Emil Velikov wrote: > > > > > > > - GLX_MESA_release_buffers > > > > > > Extension is implemented only for Xlib based libGL. The DRI codepat

Re: [Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > --- > src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 2 ++ > src/mesa/Makefile.sources

Re: [Mesa-dev] [PATCH 12/24] spirv_extensions: define spirv_extensions_supported

On 11/27/2017 01:25 PM, Ian Romanick wrote: > On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: >> From: Alejandro Piñeiro >> >> Add a struct to maintain which SPIR-V extensions are supported, and an >> utility method to initialize it based on >> nir_spirv_supported_capabilities. >> --- >> src/co

Re: [Mesa-dev] 10-bit Mesa/Gallium support

On Mon, Nov 27, 2017 at 5:01 PM, Adam Jackson wrote: > On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: >> Hi everybody, >> >> Mario, feel free to push your patches if you haven't yet. (except the >> workaround) >> >> For AMD, I applied Mario's patches (except Wayland - that didn't >> apply)

Re: [Mesa-dev] [PATCH 07/24] spirv_extensions: rename nir_spirv_supported_extensions

This patch is Reviewed-by: Ian Romanick On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Renamed to nir_spirv_supported_capabilities. > > The original name seemed to suggest that it was directly related to > the SPIR-V extensions supported, but that is not the c

Re: [Mesa-dev] [PATCH 09/24] i965: initialize SPIR-V capabilities

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Needed for ARB_gl_spirv. Right now those are the same that the intel > vulkan driver, but those are not shared. From the ARB_spirv_extensions > spec: > >"3. If a new GL extension is added that includes SPIR-V sup

Re: [Mesa-dev] 10-bit Mesa/Gallium support

On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: > Hi everybody, > > Mario, feel free to push your patches if you haven't yet. (except the > workaround) > > For AMD, I applied Mario's patches (except Wayland - that didn't > apply) and added initial Gallium support: > https://cgit.freedesktop

Re: [Mesa-dev] [PATCH] mesa/gles: adjust internal format in glTexSubImage2D error checks

Thanks Tapani. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Fix typo nagivation -> navigation

On 27/11/17 23:02, Nicolai Hähnle wrote: Reviewed-by: Nicolai Hähnle Pushed. Thanks! On 25.11.2017 15:08, Gwan-gyeong Mun wrote: Signed-off-by: Mun Gwan-gyeong ---   src/compiler/glsl/ir_hierarchical_visitor.h | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compi

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

On 28/11/17 01:01, Gert Wollny wrote: Am Montag, den 27.11.2017, 12:14 +0100 schrieb Gert Wollny: Am Sonntag, den 26.11.2017, 18:01 -0800 schrieb Eric Anholt: This looks like something that should be done with (at most) a small change to opt_array_splitting.cpp, rather than reimplementing i

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

Am 27.11.2017 um 21:29 schrieb Ian Romanick: > On 11/20/2017 06:04 PM, Roland Scheidegger wrote: >> Am 21.11.2017 um 01:40 schrieb Ian Romanick: >>> On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst

Re: [Mesa-dev] [PATCH 12/24] spirv_extensions: define spirv_extensions_supported

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Add a struct to maintain which SPIR-V extensions are supported, and an > utility method to initialize it based on > nir_spirv_supported_capabilities. > --- > src/compiler/spirv/spirv_extensions.c | 29 +++

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Ideally this should be generated somehow. One option would be gather > all the extension dependencies listed on the core grammar, but there > would be the possibility of not including some of the extensions. > > Note

Re: [Mesa-dev] [PATCH] util: hash_table: move NULL assert to string hashing function

On 11/27/2017 08:27 AM, Lionel Landwerlin wrote: > Hash maps might use pointer keys (which people surely might want to > use to hash values) in which case a 0 value is perfectly acceptable. > It's only if the hash function needs to deference the pointer that we > want to be sure it's not NULL. > >

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

Hey Rob, On Mon, 2017-11-27 at 13:42 -0600, Rob Herring wrote: > On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss om> wrote: > > From: Tomasz Figa > > > > There is no API available to properly query the > > IMPLEMENTATION_DEFINED > > format. As a workaround we rely here on gralloc allocating either

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

On 11/27/2017 10:46 AM, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-27 09:46:57) >> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: >>> Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: Signed-off-by: Eric Engestrom ---  src/util/ralloc.c | 18 +

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

On 11/21/2017 04:22 PM, Miklós Máté wrote: > On 21/11/17 02:09, Ian Romanick wrote: >> On 11/20/2017 04:07 PM, Miklós Máté wrote: >>> This patch fixes multiple problems: >>> - the interpolator check was duplicated >>> - both had arg instead of argRep >>> - I split it into color and alpha for better

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

On 11/20/2017 06:04 PM, Roland Scheidegger wrote: > Am 21.11.2017 um 01:40 schrieb Ian Romanick: >> On 11/20/2017 04:07 PM, Miklós Máté wrote: >>> This fixes crash when: >>> - first pass begins with alpha inst >>> - first pass ends with color inst, second pass begins with alpha inst >>> >>> Also, u

Re: [Mesa-dev] i965: Kicking off fp16 glsl support

El 27/11/17 a las 21:11, Matt Turner escribió: > 1-14, except 4 are > > Reviewed-by: Matt Turner > > I started getting to things that made me realize I needed to review > Igalia's work before I continued here. I'm submitting tomorrow the v4 for our VK_KHR_16bit_storage series. So better have a lo

Re: [Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

On Mon, Nov 27, 2017 at 11:44 AM, Ben Crocker wrote: > Power8, Power8NV, and Power9 are supported on an equal footing > with X86. > > Cc: "17.2" "17.3" > Signed-off-by: Ben Crocker > --- > docs/llvmpipe.html | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff

[Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

Power8, Power8NV, and Power9 are supported on an equal footing with X86. Cc: "17.2" "17.3" Signed-off-by: Ben Crocker --- docs/llvmpipe.html | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 12dccb5eae..5f93c0

[Mesa-dev] [PATCH 2/2] docs/llvmpipe.html: Minor edits

Language and spelling fixups in three places. Cc: "17.2" "17.3" Signed-off-by: Ben Crocker --- docs/llvmpipe.html | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 5f93c0b807..a36a31ece3 100644 --- a/docs/llvmpipe.html +

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 27, 2017 at 11:37 AM, Roland Scheidegger wrote: > If you use a float input color, does it mean it isn't quantized? > I'm just wondering if you actually get (slightly) different values with > sampling from fast-cleared surfaces than you'd get when you'd have > cleared the surface norma

[Mesa-dev] [PATCH 0/2] docs/llvmpipe.html: Add PPC64LE

IBM PPC64LE (Power8, Power8NV, and Power9) are supported on an equal footing with X86. Ben Crocker (2): docs/llvmpipe.html: Add ppc64le as alternative architecture to x86. docs/llvmpipe.html: Minor edits docs/llvmpipe.html | 30 +- 1 file changed, 21 insertions(+)

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 27, 2017 at 11:41 AM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote: > > When sampling from fast-cleared sRGB textures on gen10, the hardware > > will not decode the clear color to linear. We must therefore do it in > > software. > > > > This makes

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 27, 2017 at 11:02 AM, Nanley Chery wrote: > When sampling from fast-cleared sRGB textures on gen10, the hardware > will not decode the clear color to linear. We must therefore do it in > software. > > This makes the following piglit tests pass: > * spec@arb_framebuffer_srgb@arb_frameb

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss wrote: > From: Tomasz Figa > > There is no API available to properly query the IMPLEMENTATION_DEFINED > format. As a workaround we rely here on gralloc allocating either > an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized > by loc

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote: > When sampling from fast-cleared sRGB textures on gen10, the hardware > will not decode the clear color to linear. We must therefore do it in > software. > > This makes the following piglit tests pass: > * spec@arb_framebuffer_srgb@arb

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

If you use a float input color, does it mean it isn't quantized? I'm just wondering if you actually get (slightly) different values with sampling from fast-cleared surfaces than you'd get when you'd have cleared the surface normally. In any case, patch 1/2 of this series looks alright (I was just w

[Mesa-dev] [PATCH] Android: disable warnings causing errors

AOSP master has changed the build default to -Werror making all the warnings errors. Override that with -Wno-error. Signed-off-by: Rob Herring --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index 5671c1c1a595..fcd9a874d538 100644 -

Re: [Mesa-dev] i965: Kicking off fp16 glsl support

1-14, except 4 are Reviewed-by: Matt Turner I started getting to things that made me realize I needed to review Igalia's work before I continued here. signature.asc Description: Digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

When sampling from fast-cleared sRGB textures on gen10, the hardware will not decode the clear color to linear. We must therefore do it in software. This makes the following piglit tests pass: * spec@arb_framebuffer_srgb@arb_framebuffer_srgb-fast-clear-blend * spec@arb_framebuffer_srgb@fbo-fast-cl

[Mesa-dev] [PATCH v2 1/2] util/srgb: Add a float sRGB -> linear helper

From: Jason Ekstrand Reviewed-by: Nanley Chery --- src/util/format_srgb.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h index 34b50afe3d..596af56f4c 100644 --- a/src/util/format_srgb.h +++ b/src/util/format_srgb.h @@ -54,6 +5

Re: [Mesa-dev] [PATCH 10/51] glsl: Allow 16-bit math

On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/ir_validate.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index 735e862141..d246af866d 100644 --- a/src/c

Re: [Mesa-dev] [PATCH 09/51] glsl: Allow 16-bit neg() and dot()

On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/ir_validate.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index a20f52e527..735e862141 100644 --- a/src

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

Quoting Eric Engestrom (2017-11-27 09:46:57) > On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > > Signed-off-by: Eric Engestrom > > > --- > > >  src/util/ralloc.c | 18 +- > > >  src/util/slab.c   |  4

Re: [Mesa-dev] [PATCH 07/51] glsl: Add conversion ops to/from 16-bit floats

On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/glsl_to_nir.cpp| 2 ++ src/compiler/glsl/ir.cpp | 8 src/compiler/glsl/ir_expression_operation.py | 5 + src/compiler/glsl/ir_validate.cpp| 8 src

Re: [Mesa-dev] [PATCH 01/51] nir: Prepare constant folding for 16-bits

On Mon, Nov 27, 2017 at 11:42:53AM -0800, Matt Turner wrote: > On 11/24, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/compiler/nir/nir_opt_constant_folding.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/compiler/nir/nir_opt_constant_folding.c

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

Quoting Dylan Baker (2017-11-27 10:40:18) > Although now that I think about it, meson does have a b_undef option, so > actually the right way to do this is to add > 'b_undef=true' to the default options in the project() call. > > Sorry for the confusion, > > Dylan > And I can't read documentati

Re: [Mesa-dev] [PATCH 04/51] glsl: Print 16-bit constants

On Mon, Nov 27, 2017 at 11:40:49AM -0800, Matt Turner wrote: > On 11/24, Topi Pohjolainen wrote: > > --- > > src/compiler/glsl/ir_print_visitor.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/compiler/glsl/ir_print_visitor.cpp > > b/src/compiler/glsl/ir_print_visitor.cpp > >

Re: [Mesa-dev] [PATCH mesa 02/16] anv: tie anv_assert() enablement to regular assert()

On Sunday, 2017-11-26 10:12:46 +1100, Timothy Arceri wrote: > On 25/11/17 08:02, Timothy Arceri wrote: > > On 25/11/17 05:07, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > --- > > >   src/intel/vulkan/anv_private.h | 2 +- > > >   1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

Although now that I think about it, meson does have a b_undef option, so actually the right way to do this is to add 'b_undef=true' to the default options in the project() call. Sorry for the confusion, Dylan Quoting Dylan Baker (2017-11-27 10:22:40) > This seems reasonable, > Reviewed-by: Dylan

Re: [Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

I had a few comments on the "build src/glx/windows" patch, but the rest of the patches are: Reviewed-by: Dylan Baker Quoting Jon Turney (2017-11-27 05:58:27) > This series lets me build a mesa for Cygwin configured with: > > -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless >

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

Quoting Jon Turney (2017-11-27 05:58:32) > --- > src/glx/meson.build | 25 +-- > src/glx/windows/meson.build | 48 > + > 2 files changed, 63 insertions(+), 10 deletions(-) > create mode 100644 src/glx/windows/meson.build >

Re: [Mesa-dev] [PATCH 01/51] nir: Prepare constant folding for 16-bits

On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/nir/nir_opt_constant_folding.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_opt_constant_folding.c b/src/compiler/nir/nir_opt_constant_folding.c index d6be807b3d..b63660ea4d 100644 --

Re: [Mesa-dev] [PATCH 04/51] glsl: Print 16-bit constants

On 11/24, Topi Pohjolainen wrote: --- src/compiler/glsl/ir_print_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index ea14cdeb6c..ab9a35d73f 100644 --- a/src/compiler/glsl/ir_print_visitor.cpp +++ b/s

  1   2   >