On 11/23/2017 05:32 AM, Emil Velikov wrote: > Hi Eric, > > On 22 November 2017 at 17:59, Eric Engestrom <eric.engest...@imgtec.com> > wrote: >> A recent thread [1] made me check our local specs to see which ones were >> upstream. This series removes the ones that are identical upstream >> (modulo "TBD" extension numbers in some cases). >> >> There are a few more specs left that are upstream, but have typo fixes >> that I'm going to submit to Khronos, and I'll remove the local copies >> once the fixes have been upstreamed: > The idea sounds great, just some minor comments - mostly about > potential deprecation. > >> - EGL_MESA_drm_image > The extension, lacks information about error handling (et al) and is > no longer used. > There is even an extra bitmask in eglmesaext.h that's quite meh thing to do. > Perhaps we should consider officially deprecating it as hinted earlier [1] > > [1] https://lists.freedesktop.org/archives/mesa-dev/2017-June/161575.html > >> - GLX_MESA_release_buffers > Extension is implemented only for Xlib based libGL. The DRI codepath > has a TODO for at least 7 years. > Worth checking if anyone uses it and not just deprecate the extension? > >> Eric Engestrom (7): >> docs/specs: remove upstreamed spec EGL_MESA_platform_surfaceless >> docs/specs: remove upstreamed spec MESA_image_dma_buf_export >> docs/specs: remove upstreamed spec MESA_shader_integer_functions >> docs/specs: remove upstreamed spec EXT_shader_integer_mix > >> docs/specs: remove upstreamed spec MESA_agp_offset >> docs/specs: remove upstreamed spec MESA_pixmap_colormap >> docs/specs: remove upstreamed spec MESA_set_3dfx_mode > These three are also Xlib libGL only. Above idea applies.
MESA_agp_offset wasn't Xlib, but it is long dead. It was killed by ARB_vertex_buffer_object. MESA_set_3dfx_mode dead when we stopped supporting the Glide (3dfx's proprietary, low-level graphics API) Mesa driver. Neither of these have been supported by any Mesa driver in many, many years, and they will never come back from that grave. >> > There are a few references to the spec files in docs/. Can you update those? > > The series looks OK, yet blessing from veterans is appreciated > Acked-by: Emil Velikov <emil.veli...@collabora.com> > > > Thanks > Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
