Re: [Mesa-dev] [PATCH 09/13] meson: build gallium vdpau state tracker

Both this and the va state tracker seem to just install a libgallium*.so file, but don't actually install the megadriver-esque links for the hardware-specific driver (e.g. radeonsi_drv_video.so and libvdpau_radeonsi*). When I copy the VA driver over my old auto-tools one, I get a libva initializat

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote: > --- > meson.build | 35 +- > meson_options.txt | 13 ++ > src/gallium/meson.build | 7 ++- > src/gallium/state_trackers/va/meson.build | 39 +

Re: [Mesa-dev] [PATCH 09/13] meson: build gallium vdpau state tracker

On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote: > --- > meson.build | 40 - > meson_options.txt| 13 + > src/gallium/meson.build | 7 ++- > src/gallium/state_trackers/vdpau/meson.build | 32 +++

Re: [Mesa-dev] Meson's default build type

On Fri, Nov 3, 2017 at 6:28 PM, Christian Schmidbauer wrote: >> On Thu, Nov 2, 2017 at 11:45 AM, Andres Rodriguez wrote: >>> >>> >>> On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: > > On Thursday, 2017-11-02 09:46:05 -

Re: [Mesa-dev] Meson's default build type

> On Thu, Nov 2, 2017 at 11:45 AM, Andres Rodriguez wrote: >> >> >> On 2017-11-02 01:52 PM, Eric Engestrom wrote: >>> >>> On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > > On Wed 01 Nov 2017, Dylan Baker

Re: [Mesa-dev] [PATCH 1/9] gallium: add CAPs to support HW atomic counters. (v2)

Not sure if the "HW" prefix everywhere makes sense since gallium doesn't imply there is a hardware driver behind it, but I don't really care much. Marek On Fri, Nov 3, 2017 at 8:24 AM, Dave Airlie wrote: > From: Dave Airlie > > This looks like an evergreen specific feature, but with atomic > co

Re: [Mesa-dev] [PATCH v3] meson: implement default driver arguments

On Friday, 2017-11-03 18:09:01 +, Dylan Baker wrote: > This allows drivers to be set by OS/arch in a sane manner. > > v2: - set _drivers to a list of drivers instead of manually assigning > each with_* > v3: - Use "auto" instead of "default", which matches the value of other > auto

Re: [Mesa-dev] Meson's default build type

Quoting Matt Turner (2017-11-03 15:05:24) [snip] > > Meson's debug build should correspond to --enable-debug. > debugoptimized vs release is a little less obvious. Perhaps > debugoptimized should default to -g -O2 but leave assertions enabled, > and release should default to -g -O2 -DNDEBUG? This

[Mesa-dev] [PATCH 1/4] intel/blorp: Use mocs.tex for depth stencil

--- src/intel/blorp/blorp_genX_exec.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index 5389262..ccbfe51 100644 --- a/src/intel/blorp/blorp_genX_exec.h +++ b/src/intel/blorp/blorp_genX_exec.h @@ -13

[Mesa-dev] [PATCH 2/4] anv/blorp: Add a device parameter to blorp_surf_for_anv_image

--- src/intel/vulkan/anv_blorp.c | 56 +++- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 70e1b2b..56f22f6 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/an

[Mesa-dev] [PATCH 3/4] intel/blorp: Make the MOCS setting part of blorp_address

This makes our MOCS settings significantly more flexible. --- src/intel/blorp/blorp.h | 7 +-- src/intel/blorp/blorp_genX_exec.h | 16 +++ src/intel/vulkan/anv_blorp.c| 12 --- src/intel/vulkan/genX_blorp_exec.c | 1 +

[Mesa-dev] [PATCH 4/4] i965: Use PTE MOCS for all external buffers

We were already using PTE for all render targets in case one happened to get scanned out. However, this still wasn't 100% correct because there are still possibly cases where we may want to texture from an external buffer even though we don't know the caching mode. This can happen, for instance,

Re: [Mesa-dev] [PATCH 2/9] gallium/tgsi: start adding hw atomics (v2)

On Fri, Nov 3, 2017 at 8:24 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds support for a hw atomic counters to TGSI. > > A new register file for storing atomic counters is added, > along with a new atomic counter semantic, along with docs > for both. > > v2: drop semantic, move hw count

Re: [Mesa-dev] [PATCH v2 2/8] util/u_atomic: add p_atomic_xchg

Reviewed-by: Marek Olšák Marek On Fri, Nov 3, 2017 at 9:09 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The closest to it in the old-style gcc builtins is __sync_lock_test_and_set, > however, that is only guaranteed to work with values 0 and 1 and only > provides an acquire barrier. I

[Mesa-dev] [PATCH 2/2] i965: Only emit 3DSTATE_DRAWING_RECTANGLE once on gen9+

--- src/mesa/drivers/dri/i965/brw_misc_state.c| 9 + src/mesa/drivers/dri/i965/genX_blorp_exec.c | 2 ++ src/mesa/drivers/dri/i965/genX_state_upload.c | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/driv

[Mesa-dev] [PATCH 1/2] i965: Be more clever about setting up our viewport clip

Before, we were trusting in the hardware to take the intersection of the viewport clip with the drawing rectangle. Unfortunately, 3DSTATE_DRAWING_RECTANGLE is fairly expensive because it implicitly does a full pipeline stall. If we're a bit more careful with our viewport clipping, we can just re-

Re: [Mesa-dev] Meson's default build type

On Thu, Nov 2, 2017 at 11:45 AM, Andres Rodriguez wrote: > > > On 2017-11-02 01:52 PM, Eric Engestrom wrote: >> >> On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: >>> >>> On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker wrote:

[Mesa-dev] [PATCH] swrast: Don't crash when there are no render slices

From: Stéphane Marchesin It is legal not to have slices (for example with a 0x0 texture) so we should handle that case. --- src/mesa/swrast/s_texrender.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/swrast/s_texrender.c b/src/mesa/swrast/s_texrender.c index 4e

[Mesa-dev] [PATCH v2 8/8] radeonsi: reduce the scope of sel->mutex in si_shader_select_with_key

From: Nicolai Hähnle We only need the lock to guard changes in the variant linked list. The actual compilation can happen outside the lock, since we use the ready fence as a guard. v2: fix double-unlock Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8

[Mesa-dev] [PATCH v2 7/8] radeonsi: use ready fences on all shaders, not just optimized ones

From: Nicolai Hähnle There's a race condition between si_shader_select_with_key and si_bind_XX_shader: Thread 1 Thread 2 si_shader_select_with_key begin compiling the first variant (guarded by sel->mutex)

[Mesa-dev] [PATCH v2 6/8] u_queue: add a futex-based implementation of fences

From: Nicolai Hähnle Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). Signaling a fence is a single atomic operation in the fast case plus a syscall in the slow case. Testing if a fence is signaled is the same as before (a simple comparison), but waiting on a fence is now no mo

[Mesa-dev] [PATCH v2 5/8] u_queue: add util_queue_fence_reset

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/util/u_queue.c | 4 +--- src/util/u_queue.h | 13 + 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 33436e0749a..2272006042f 100644 --- a/src/util/u_queue.c +++ b/src

[Mesa-dev] [PATCH v2 3/8] u_queue: group fence functions together

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/util/u_queue.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/util/u_queue.h b/src/util/u_queue.h index ff713ae54d6..7a028ef0847 100644 --- a/src/util/u_queue.h +++ b/src/util/u_queue.h @@ -47,20

[Mesa-dev] [PATCH v2 1/8] util: move futex helpers into futex.h

From: Nicolai Hähnle v2: style fixes Reviewed-by: Marek Olšák (v1) --- src/util/Makefile.sources | 1 + src/util/futex.h | 53 +++ src/util/meson.build | 1 + src/util/simple_mtx.h | 20 +- 4 files changed, 56 inse

[Mesa-dev] [PATCH v2 2/8] util/u_atomic: add p_atomic_xchg

From: Nicolai Hähnle The closest to it in the old-style gcc builtins is __sync_lock_test_and_set, however, that is only guaranteed to work with values 0 and 1 and only provides an acquire barrier. I also don't know about other OSes, so we provide a simple & stupid emulation via p_atomic_cmpxchg.

[Mesa-dev] [PATCH v2 4/8] u_queue: export util_queue_fence_signal

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/util/u_queue.c | 2 +- src/util/u_queue.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 3b05110e9f8..33436e0749a 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@

[Mesa-dev] [PATCH v2 0/8] u_queue fence patches and a radeonsi fix

Hi all, Some small style changes relative to v1, and a fix to the memory barrier semantics in the futex-based fence implementation. Patches 2 (which is new) and 6 still need a review. Please take a look! Thanks, Nicolai -- src/gallium/drivers/radeonsi/si_shader.c | 3 + src/gallium/driver

Re: [Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

On 3 November 2017 at 23:59, Gert Wollny wrote: > Am Freitag, den 03.11.2017, 17:24 +1000 schrieb Dave Airlie: >> >> diff --git a/src/gallium/drivers/r600/r600_pipe.c >> b/src/gallium/drivers/r600/r600_pipe.c >> index d67a22b..434596b 100644 >> --- a/src/gallium/drivers/r600/r600_pipe.c >> +++ b/s

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

Hi Andres, On 03.11.2017 18:36, Andres Rodriguez wrote: On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez ---   src/mesa/state_tracker/st_cb_semaph

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

On 03.11.2017 19:46, Marek Olšák wrote: On Fri, Nov 3, 2017 at 3:48 PM, Nicolai Hähnle wrote: On 31.10.2017 17:21, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_fence.c | 83 ++

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

On Fri, Nov 3, 2017 at 11:08 AM, Nanley Chery wrote: > On Fri, Nov 03, 2017 at 09:50:41AM -0700, Nanley Chery wrote: >> On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: >> > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery >> > wrote: >> > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anu

Re: [Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

On Wednesday, 2017-11-01 18:12:18 +, Lionel Landwerlin wrote: > The motivation for building this UI is to help debug the intel > drivers. It can be tricky to figure what is going wrong in the > emission of commands (figuring out if there is an off by one error in > the sampler state pointers fo

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI for Talos/Serious Sam Fusion 2017

On Fri, Nov 3, 2017 at 11:39 AM, Samuel Pitoiset wrote: > VK_FORMAT_D16_UNORM is mandatory for 2D images, but Talos and > Serious Sam Fusion 2017 can use VK_FORMAT_D32_SFLOAT instead. > > This implements some sort of drirc for radv (just based on > the application names). > > This improves perform

Re: [Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

Quoting Lionel Landwerlin (2017-11-01 11:12:18) [snip] > > +if with_intel_tools > + inc_imgui = include_directories('imgui') since aubinator_ui is the only consumer of this include, why don't we just put the call to include_directories in the argument to the executable? > + aubinator_ui = exe

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Fri, Nov 03, 2017 at 11:50:44AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote: > > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> > This optimization is enabled for previous g

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote: > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: >> > This optimization is enabled for previous generations too. >> > See Mesa commit c17e214a6b >> > On CNL this bit

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Fri, Nov 03, 2017 at 11:39:34AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> This optimization is enabled for previous generations too. > >> See Mesa commit c17e214a6b > >> On CNL this bit h

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

On Fri, Nov 3, 2017 at 3:48 PM, Nicolai Hähnle wrote: > On 31.10.2017 17:21, Marek Olšák wrote: >> >> On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> --- >>> src/gallium/drivers/radeonsi/si_fence.c | 83 >>> - >>>

Re: [Mesa-dev] [PATCH 12/12] spirv: Import the latest 1.0.12 header and JSON from Khronos

I did not intend to send this patch out with this series. It will be in the next block. On 11/02/2017 01:25 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/spirv/spirv.core.grammar.json | 266 > - > src/compiler/sp

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: >> This optimization is enabled for previous generations too. >> See Mesa commit c17e214a6b >> On CNL this bit has been moved to CACHE_MODE_SS register. >> >> Cc: Nanley Chery >> Sig

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

https://bugs.freedesktop.org/show_bug.cgi?id=103505 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On 2017-11-03 02:20 PM, Marek Olšák wrote: On Fri, Nov 3, 2017 at 7:18 PM, Andres Rodriguez wrote: On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On Fri, Nov 3, 2017 at 7:18 PM, Andres Rodriguez wrote: > > > On 2017-11-03 01:56 PM, Marek Olšák wrote: >> >> On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez >> wrote: >>> >>> Signed-off-by: Andres Rodriguez >>> --- >>> src/gallium/drivers/ddebug/dd_context.c | 23 +++ >>> s

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++ src/gallium/drivers/ddebug/dd_screen.c | 25 + src/gallium/drivers

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

FLUSH_VERTICES should be called by mesa/main if it's inside a GL call. st/mesa should only flush bitmaps. Marek On Fri, Nov 3, 2017 at 6:36 PM, Andres Rodriguez wrote: > > > On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: >> >> On 02.11.2017 04:57, Andres Rodriguez wrote: >>> >>> Bits to implemen

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

On Fri, Nov 03, 2017 at 09:50:41AM -0700, Nanley Chery wrote: > On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > > >> V2: Remove the bits enabling Float blend o

[Mesa-dev] [PATCH v3] meson: implement default driver arguments

This allows drivers to be set by OS/arch in a sane manner. v2: - set _drivers to a list of drivers instead of manually assigning each with_* v3: - Use "auto" instead of "default", which matches the value of other automatically configured options. - Set vulkan drivers as well -

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > > This optimization is enabled for previous generations too. > > See Mesa commit c17e214a6b > > On CNL this bit has been moved to CACHE_MODE_SS register. > > > > Cc: Nanle

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

On 2017-11-03 05:15 AM, Nicolai Hähnle wrote: Hi Andres, Thank you for doing this. I haven't read the series in detail yet, but I have a bunch of questions and comments. Thanks for all the feedback. I find it very unfortunate to have both fence and semaphore objects in the Gallium inter

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/ddebug/dd_context.c | 23 +++ > src/gallium/drivers/ddebug/dd_screen.c | 25 + > src/gallium/drivers/trace/tr_context.c | 36 +++

Re: [Mesa-dev] [PATCH 04/17] mesa: add semaphore parameter stub

On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > EXT_semaphore and EXT_semaphore_fd define no pnames. Therefore there > isn't much to do besides determining the correct error code. > > Signed-off-by: Andres Rodriguez > --- > src/mesa/main/externalobjects.c | 23 +++ >

Re: [Mesa-dev] [PATCH 13/17] mesa: implement buffer/texture barriers for semaphore wait/signal

On 2017-11-03 05:18 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. Signed-off-by: Andres Rodriguez ---   src/mesa/main/dd.h   

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez ---   src/mesa/state_tracker/st_cb_semaphoreobjects.c | 28 +   1 file c

Re: [Mesa-dev] [PATCH 03/17] mesa: add support for semaphore object creation/import/delete

On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > Used by EXT_semmaphore and EXT_semaphore_fd > > Signed-off-by: Andres Rodriguez > --- > src/mesa/drivers/common/driverfuncs.c | 3 + > src/mesa/main/dd.h| 34 +++ > src/mesa/main/externalobjects.c | 161 >

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

Pushed with a fixed typo and whitespace, thanks. Marek On Thu, Nov 2, 2017 at 3:50 PM, Andrey Grodzovsky wrote: > Fixes reverted patch f03b7c9 by doing VMID reservation per > process and not per context. > Also updates required amdgpu libdrm version since the change > involved interface updates

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > >> V2: Remove the bits enabling Float blend optimization. It is > >> enabled through CACHE_MODE_SS register. >

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > This optimization is enabled for previous generations too. > See Mesa commit c17e214a6b > On CNL this bit has been moved to CACHE_MODE_SS register. > > Cc: Nanley Chery > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 3/5] st/mesa: use asynchronous flushes

On 31.10.2017 18:59, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:18 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_flush.c | 4 ++-- src/mesa/state_tracker/st_cb_syncobj.c | 26 -- 2 files changed, 26 insertions(+), 4 deletions(

Re: [Mesa-dev] [PATCH 11/13] meson: build gallium omx state tracker

Quoting Marc Dietrich (2017-11-03 03:06:17) > Am Mittwoch, 1. November 2017, 23:49:46 CET schrieb Dylan Baker: > > --- > > meson.build| 54 ++- > > meson_options.txt | 13 > > src/gallium/meson.build

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #6 from tjb...@scarlet.be --- I rebuilt llvm with LLVM_LINK_LLVM_DYLIB. That now installs lots of .sa libraries and an enormous /usr/lib/libLLVM-5.0.so I then auccessfully rebuilt mesa using autotools, but the mesaon build still fai

Re: [Mesa-dev] Meson's default build type

On 2017-11-03 05:25 AM, Michel Dänzer wrote: On 02/11/17 07:45 PM, Andres Rodriguez wrote: On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker

Re: [Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out ofglx

Quoting Marc Dietrich (2017-11-03 02:24:46) > Hi Dylan, > > Am Freitag, 3. November 2017, 01:06:27 CET schrieb Dylan Baker: > > Because the same generation logic is required by xlib glx and > > gallium-xlib glx, it makes sense to pull it out. > > > > Signed-off-by: Dylan Baker > > --- > > src/g

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock on Wayland compositor with X11

https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #2 from Henri Verbeet --- That backtrace looks a lot like the issue for which I originally wrote https://patchwork.freedesktop.org/patch/183215/. Unfortunately it looks like it's harder than that. -- You are receiving this mail bec

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

On 03.11.2017 14:56, Miklós Máté wrote: On 03/11/17 11:04, Nicolai Hähnle wrote: On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtr

Re: [Mesa-dev] [PATCH 2/2] glsl/linker: location aliasing requires types to have the same width

On Fri, Nov 3, 2017 at 6:56 AM, Iago Toral Quiroga wrote: > Regarding location aliasing requirements, the OpenGL spec says: > > "Further, when location aliasing, the aliases sharing the location >must have the same underlying numerical type (floating-point or >integer)." > > Khronos has

[Mesa-dev] [Bug 101378] interpolateAtSample check for input parameter is too strict

https://bugs.freedesktop.org/show_bug.cgi?id=101378 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] glsl/linker: use without_array() to retrieve type

Reviewed-by: Ilia Mirkin However I might recommend doing like const glsl_type *type_without_array = type->without_array(); if (type_without_array->is_interface()) { for (... ; i < type_without_array->length; i++) { field = &type_without_array->fields.structure[i] Otherwise it's just redo

Re: [Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

On Thursday, 2017-11-02 15:01:45 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.c | 11 ++- > src/egl/drivers/dri2/egl_dri2.h | 1 + > src/egl/main/eglapi.c | 1 + > src/egl/main/eglcontext.c

Re: [Mesa-dev] [PATCH] radv: Don't expose heaps with 0 memory.

Bas, this commit landed without mentioning any specific stable queue. For 17.2, this is quite an extensive change and has several trivial conflicts. I think it is OK to merge if you really meant it for 17.2 too, but just double checking. Thanks! On Wed, 2017-11-01 at 20:58 +0100, Bas Nieuwenhuiz

Re: [Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

Dylan pushed this series through our CI, and there were no regressions. Emil Velikov writes: > [removing Neil's old email as it bounces] > > On 2 November 2017 at 19:01, Adam Jackson wrote: >> From: Neil Roberts >> >> It shouldn't be necessary to flush the context within the driver >> implemen

Re: [Mesa-dev] [PATCH 08/25] gallium/u_threaded: mark queries flushed only for non-deferred flushes

On 30.10.2017 13:31, Marek Olšák wrote: On Mon, Oct 30, 2017 at 2:57 AM, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The driver uses (and must use) the flushed flag of queries as a hint that it does not have to check for synchronization wit

Re: [Mesa-dev] [PATCH 09/25] gallium/u_threaded: implement asynchronous flushes

On 31.10.2017 03:15, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: @@ -107,20 +138,46 @@ static boolean si_fence_finish(struct pipe_screen *screen, uint64_t timeout) { struct radeon_winsys *rws = ((struct r600_common_screen*

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

On 31.10.2017 17:21, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_fence.c | 83 - 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

Am Freitag, den 03.11.2017, 17:24 +1000 schrieb Dave Airlie: > > diff --git a/src/gallium/drivers/r600/r600_pipe.c > b/src/gallium/drivers/r600/r600_pipe.c > index d67a22b..434596b 100644 > --- a/src/gallium/drivers/r600/r600_pipe.c > +++ b/src/gallium/drivers/r600/r600_pipe.c > @@ -74,6 +74,8 @@

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

On 03/11/17 11:04, Nicolai Hähnle wrote: On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete /

Re: [Mesa-dev] create src/wsi

Hi, On 1 November 2017 at 17:33, Emil Velikov wrote: > On 31 October 2017 at 21:07, Dylan Baker wrote: >> My intention is to pull some of the generated files that are shared >> between vulkan/wsi/wayland and egl/wayland/wayland-drm. Daniel has said that >> he >> has more generated files that wi

Re: [Mesa-dev] [PATCH v3] mesa: Add new fast mtx_t mutex type for basic use cases

On 03.11.2017 14:23, Nicolai Hähnle wrote: What's the status of this? On 16.10.2017 14:36, Emil Velikov wrote: On 16 October 2017 at 08:06, Timothy Arceri wrote: While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features

Re: [Mesa-dev] [PATCH v3] mesa: Add new fast mtx_t mutex type for basic use cases

What's the status of this? On 16.10.2017 14:36, Emil Velikov wrote: On 16 October 2017 at 08:06, Timothy Arceri wrote: While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features of pthread mutexes. Most mutexes in mesa onl

Re: [Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

On Thursday, 2017-11-02 15:01:40 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > src/egl/drivers/dri2/egl_dri2.c | 35 +-- > 1 file changed, 9 insertions(+), 26 deletions(-) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/e

Re: [Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

On 3 November 2017 at 09:50, Nicolai Hähnle wrote: > On 02.11.2017 20:01, Adam Jackson wrote: >> >> From: Neil Roberts >> >> Previously the CreateContext method of __DriverApiRec took a set of >> arguments to describe the attribute values from the window system API's >> CreateContextAttribs funct

Re: [Mesa-dev] [PATCH 1/9] gallium: add CAPs to support HW atomic counters. (v2)

Am Freitag, den 03.11.2017, 17:24 +1000 schrieb Dave Airlie: > From: Dave Airlie > [...] > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c > b/src/gallium/drivers/radeonsi/si_pipe.c > index 875aff6..39f7b7b 100644 > --- a/src/gallium/drivers/radeonsi/si_pipe.c > +++ b/src/gallium/drivers/rad

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #7 from Valentin Novikov --- (In reply to Bas Nieuwenhuizen from comment #6) > As said in comment #1, can you get a backtrace of the segfault? I have fust upgradet all graphics throw oibaff ppa, and IT WORKS! -- You are receiving

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

On Wed, 2017-11-01 at 20:58 +0200, Tapani Pälli wrote: > > On 11/01/2017 06:33 PM, Jason Ekstrand wrote: > > Do either of you mind if I cc the first one to stable? It does fix a > > potential memory leak in the case where compilation fails. > > IMO CC stable would be fine for that one. Jason,

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

Hi Andres, Am Freitag, den 03.11.2017, 14:39 +0200 schrieb Andres Gomez: > On Wed, 2017-11-01 at 12:47 +0100, Lucas Stach wrote: > > Am Mittwoch, den 01.11.2017, 12:34 +0100 schrieb Wladimir J. van > > der Laan: > > > On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > > > > Am Mittwoch

Re: [Mesa-dev] gallium/r600 hw atomic support v2

On 03.11.2017 08:24, Dave Airlie wrote: Ilia pointed out a bad assumption I made, so I've decided to move to allocating the hw indices in the backend, a bit ugly but seems to work. Thanks for doing this. I want to get GDS atomics into radeonsi as well. I've already sent some minor comments, wi

[Mesa-dev] [PATCH v5 7/9] egl: add dri2_surface_free_image() helper (v4)

To share common free DRIimage code. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use them to replace the old code in the same patch

Re: [Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

On 03.11.2017 08:24, Dave Airlie wrote: From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. v2: move hw

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wed, 2017-11-01 at 12:47 +0100, Lucas Stach wrote: > Am Mittwoch, den 01.11.2017, 12:34 +0100 schrieb Wladimir J. van der Laan: > > On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > > > Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > > > > GC3000 resolve

[Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

It turned out that with recent changes that call into dri3 from glFinish(), it appears like different thread end up waiting for X events simultaneously, causing deadlocks since they steal events from eachoter and update the dri3 counters behind eachothers backs. This patch intends to improve on th

Re: [Mesa-dev] [PATCH 6/9] st/mesa: setup hw atomic limits.

On 03.11.2017 08:24, Dave Airlie wrote: From: Dave Airlie HW atomics need to use caps to set some limits, and some other limits may also need limiting. This fixes things up to work for evergreen hw, it may need more changes in the future if other hw wants to use this path. Signed-off-by: Dave

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Revert absolute mode for constant buffer pointers.

Hi, After some brainstorming, we decided to go big and grab all the hardware provided defaults for all registers. That's for the sake of not having to decide which registers are important. This will also allow us not to be concerned of any context registers possibly containing 'secure' informatio

Re: [Mesa-dev] [PATCH 12/17] radeonsi: implement semaphore operations

On 02.11.2017 04:57, Andres Rodriguez wrote: Allow importing, waiting and signaling of semaphore objects. Semaphore objects are backed by syncobj based fences. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.c | 52 +++ src/gallium/dri

Re: [Mesa-dev] [PATCH 19/21] intel/nir: Use the correct indirect lowering masks in link_shaders

On 29/10/17 05:36, Jason Ekstrand wrote: Previously, if we were linking a vec4 VS with a SIMD8/16 FS, we wouldn't lower indirects on the fragment shader which is wrong. Instead of using a single indirect mask, take advantage of our new little helper. It took me a while to actually see the bug

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

On 11/03/2017 12:30 PM, Chih-Wei Huang wrote: 2017-11-03 15:47 GMT+08:00 Tapani Pälli : Hi Chih-Wei; This looks good to me. Only thing that causes a bit of headache is ... what is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? OUT_DIR is also set to "out" if it's not already se

[Mesa-dev] [PATCH 2/2] glsl/linker: location aliasing requires types to have the same width

Regarding location aliasing requirements, the OpenGL spec says: "Further, when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer)." Khronos has further clarified that this also requires the underlying types to have

[Mesa-dev] [PATCH 1/2] glsl/linker: use without_array() to retrieve type

This is what we do in the condition too, so it makes sense. --- src/compiler/glsl/link_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 66a20a2c9b..af938611f4 100644 --- a/src/compiler/

[Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI for Talos/Serious Sam Fusion 2017

VK_FORMAT_D16_UNORM is mandatory for 2D images, but Talos and Serious Sam Fusion 2017 can use VK_FORMAT_D32_SFLOAT instead. This implements some sort of drirc for radv (just based on the application names). This improves performance with Talos (73->76FPS) and Serious Sam 2017 (119->134FPS) becaus

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

On 11/03/2017 11:10 AM, Samuel Pitoiset wrote: On 11/03/2017 11:07 AM, Alex Smith wrote: Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Missed that point, I'm going to have a look right now. Thanks. Yeah, we can't

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 15:47 GMT+08:00 Tapani Pälli : > Hi Chih-Wei; > > This looks good to me. Only thing that causes a bit of headache is ... what > is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? OUT_DIR is also set to "out" if it's not already set. PRODUCT_OUT is where all target files go.

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

On 11/03/2017 11:07 AM, Alex Smith wrote: Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Missed that point, I'm going to have a look right now. Thanks. Thanks, Alex On 3 November 2017 at 10:02, Samuel Pitoiset

  1   2   >