Re: [Mesa-dev] [PATCH 2/2] gles2: support for GL_EXT_occlusion_query_boolean

On 10/24/2017 09:56 PM, Eric Anholt wrote: Tapani Pälli writes: From: Harish Krupo Following test checking entrypoints passes: dEQP-EGL.functional.get_proc_address.extension.gl_ext_occlusion_query_boolean Piglit test 'ext_occlusion_query_boolean-any-samples' passes with these changes

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

Am Dienstag, den 24.10.2017, 18:21 +0100 schrieb Emil Velikov: > > > Right on both counts, as I don't really have a way of testing on > > Windows. > > > > There's an Appveyour integration similar to Travis. One should be > able to select the MSVC/toolchain version, but I'm not versed enough > fo

[Mesa-dev] [PATCH] radv: add support for local bos.

From: Dave Airlie This uses the new kernel interfaces for reduced cs overhead, We only set the local flag for memory allocations that don't have a dedicated allocation and ones that aren't imports. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 3 +++ src/amd/v

Re: [Mesa-dev] [PATCH] meson: add opt-out of libunwind

Am Dienstag, den 24.10.2017, 16:44 +0200 schrieb Erik Faye-Lund: >   >  dep_unwind = dependency('libunwind', required : false) > -if dep_unwind.found() > +if dep_unwind.found() and with_libunwind >    pre_args += '-DHAVE_LIBUNWIND' >  endif Wouldn't it be better to do something like <<< if with_l

Re: [Mesa-dev] [PATCH 2/2] i965: fix unused var warnings in release build

On 2017-10-24 21:15:45, Matt Turner wrote: > I would suggest just marking the devinfo variables as UNUSED. Or, MAYBE_UNUSED? :) I considered that suggestion, since you recently suggested it to me. I noticed that in all but one case the local variable was only referenced 1 time, by the assert. The

Re: [Mesa-dev] [PATCH 2/2] i965: fix unused var warnings in release build

I would suggest just marking the devinfo variables as UNUSED. I really wish we didn't have to deal with this triviality :( ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 8/8] glsl/linker: validate explicit locations for SSO programs

For all the patches in the series that I didn't have comments on, Reviewed-by: Ilia Mirkin On Tue, Oct 24, 2017 at 5:28 AM, Iago Toral Quiroga wrote: > v2: > - we only need to validate inputs to the first stage and outputs > from the last stage, everything else has already been validated >

Re: [Mesa-dev] [PATCH v2 4/8] glsl/linker: outputs in the same location must share interpolation

On Tue, Oct 24, 2017 at 5:28 AM, Iago Toral Quiroga wrote: > From ARB_enhanced_layouts: > > "[...]when location aliasing, the aliases sharing the location > must have the same underlying numerical type (floating-point or > integer) and the same auxiliary storage and > interpolation qualificatio

Re: [Mesa-dev] [PATCH v2 2/8] glsl/linker: refactor link-time validation of output locations

On Tue, Oct 24, 2017 at 5:28 AM, Iago Toral Quiroga wrote: > Move the checks for explicit locations to a separate function. We > will use this in a follow-up patch to validate locations for interface > variables where we need to validate each interface member rather than > the interface variable i

Re: [Mesa-dev] [PATCH 2/2] i965: fix unused var warnings in release build

Reviewed-by: Jordan Justen On 2017-10-22 18:26:12, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/i965/gen6_sol.c | 3 +-- > src/mesa/drivers/dri/i965/gen7_sol_state.c | 9 +++-- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 16 > src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 3/3] radv: Compute ac keys from pipeline key.

Thanks! This is a good start, much cleaner. Series: Reviewed-by: Timothy Arceri On 25/10/17 09:17, Bas Nieuwenhuizen wrote: The beginning of the end for the shader keys. Not entirely sure what I'm going to replace them with for the compiler though, so this is the first step. --- src/amd/vul

[Mesa-dev] [PATCH] radv: Fix truncation issue hexifying the cache uuid for the disk cache.

Going from binary to hex has a 2x blowup. Fixes: 14216252923 'radv: create on-disk shader cache' --- src/amd/vulkan/radv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index c4e25222eaf..6cc793654c7 1006

Re: [Mesa-dev] [PATCH] radv: use device name in cache creation like radeonsi.

Reviewed-by: Bas Nieuwenhuizen On Wed, Oct 25, 2017 at 3:24 AM, Dave Airlie wrote: > From: Dave Airlie > > Not sure how useful this is, but it makes it more consistent. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletion

[Mesa-dev] [PATCH] radv: use device name in cache creation like radeonsi.

From: Dave Airlie Not sure how useful this is, but it makes it more consistent. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index c4e25222eaf..eb

[Mesa-dev] [PATCH] gallium/util: remove some block alignment assertions

From: Roland Scheidegger These assertions were revisited a couple of times in the past, and they still weren't quite right. The problem I was seeing (with some other state tracker) was a copy between two 512x512 s3tc textures, but from mip level 0 to mip level 8. Therefore, the destination has on

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

Jan Vesely writes: > On Sun, 2017-10-22 at 20:40 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > From: Jan Vesely >> > >> > v2: use a more generic compat function >> > >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103388 >> > Signed-off-by: Jan Vesely >> > --- >> >

Re: [Mesa-dev] [PATCH 5/7] radv: enable lower to scalar nir pass

On Mon, Oct 23, 2017 at 2:10 AM, Timothy Arceri wrote: > This will allow dead components of varyings to be removed. > --- > src/amd/vulkan/radv_pipeline.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeli

Re: [Mesa-dev] [PATCH V2 4/7] ac: add support for explicit component packing

On Wed, Oct 25, 2017 at 1:04 AM, Timothy Arceri wrote: > This is needed for RADV to support explicit component packing. > > This is also required to use the new NIR component splitting / > packing passes. > > V2: > - add commponent packing support for interpolate_at* intrinsics > - improve store

[Mesa-dev] [PATCH V2 4/7] ac: add support for explicit component packing

This is needed for RADV to support explicit component packing. This is also required to use the new NIR component splitting / packing passes. V2: - add commponent packing support for interpolate_at* intrinsics - improve store packing support when not all varyings are scalar as spotted by Bas

Re: [Mesa-dev] [PATCH] radv: use a define for the transition point between cp and compute shader

Reviewed-by: Samuel Pitoiset On 10/25/2017 12:06 AM, Dave Airlie wrote: From: Dave Airlie For certain buffer meta ops we can use the CP or a compute shader, we should use a define to rather than hardcoding 4096, allows for easier testing and more consistency. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH] radv: use a define for the transition point between cp and compute shader

r-b On Wed, Oct 25, 2017 at 12:06 AM, Dave Airlie wrote: > From: Dave Airlie > > For certain buffer meta ops we can use the CP or a compute shader, > we should use a define to rather than hardcoding 4096, allows > for easier testing and more consistency. > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH 2/3] radv: Add single pipeline cache key.

To decouple the key used for info gathering and the cache from whatever we pass to the compiler. --- src/amd/vulkan/radv_pipeline.c | 44 +--- src/amd/vulkan/radv_pipeline_cache.c | 6 ++--- src/amd/vulkan/radv_private.h| 13 +-- 3 files chang

[Mesa-dev] [PATCH 1/3] Don't compute as_ls/as_es before hashing.

--- src/amd/vulkan/radv_pipeline.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 669d9a4858e..1d7ebfb85e8 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_p

[Mesa-dev] [PATCH 3/3] radv: Compute ac keys from pipeline key.

The beginning of the end for the shader keys. Not entirely sure what I'm going to replace them with for the compiler though, so this is the first step. --- src/amd/vulkan/radv_pipeline.c | 113 +++-- 1 file changed, 41 insertions(+), 72 deletions(-) diff --git

[Mesa-dev] [PATCH] radv: use a define for the transition point between cp and compute shader

From: Dave Airlie For certain buffer meta ops we can use the CP or a compute shader, we should use a define to rather than hardcoding 4096, allows for easier testing and more consistency. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_buffer.c | 12 +--- 1 file changed, 9 inse

[Mesa-dev] [PATCH mesa] meson: bring MESA_GIT_SHA1 in line with other build systems

Meson's vcs_tag() uses the output of `git describe`, eg. 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ Whereas the other build systems used a script that outputs only the sha1 of the HEAD commit, eg. fbf29c3cd1 Given that this information is used by printing it next to the version number, there's

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

Quoting Eric Engestrom (2017-10-24 10:32:36) > On Tuesday, 2017-10-24 09:40:22 -0700, Dylan Baker wrote: > > This seems reasonable, could you wrap the hanging indent like meson_options > > with > > the closing brace on it's own line and with each option on its own line? > > ie: > > project( > >

[Mesa-dev] [PATCH v3 04/10] egl: add a missed initialization of buffer age.

It add an initialization of buffer age on dri2_surface_set_back_buffer(). Fixes from Emil's review - Split out separated patch for adding of missed initialization of buffer age. [1] [1] https://lists.freedesktop.org/archives/mesa-dev/2017-October/173129.html Signed-off-by: Mun Gwan-gyeong -

[Mesa-dev] [PATCH v3 09/10] egl: add dri2_surface_get_front_image() helper (v3)

To share common get and create dri_image_front code. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use them

[Mesa-dev] [PATCH v3 10/10] egl/wayland: add dri2_wl_free_buffers() helper (v2)

This deduplicates free routines of color_buffers array. v2: - Add clear_all argument to check clearing all of color_buffers or not. - Fixes from Eric's review: a) polish check routine of check_lock and color_buffers[i].locked b) move 'native_buffer = NULL' to avoid leaking locked buffers

[Mesa-dev] [PATCH v3 08/10] egl: add dri2_surface_destroy_front_image() helper (v3)

To share common destroy dri_image_front code. In preparation to adding of new platform which uses this helper. v2: - Move dri_image_front to outside of android ifdef block for removing of ifdef magic on dri2_egl_surface_destroy_image_front(). - Fixes from Eric's review: a) Split out serie

[Mesa-dev] [PATCH v3 03/10] egl: add dri2_surface_set_back_buffer() helper (v3)

To share common record buffers and update back buffer code. This records all the buffers created by each platform's native window and update back buffer for updating buffer's age in swap_buffers. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic

[Mesa-dev] [PATCH v3 07/10] egl: add dri2_surface_destroy_back_image() helper (v3)

To share common destroy dri_image_back code. In preparation to adding of new platform which uses this helper. v2: - Move dri_image_back to outside of android ifdef block for removing of ifdef magic on dri2_egl_surface_destroy_image_back(). - Fixes from Eric's review: a) Split out series o

[Mesa-dev] [PATCH v3 02/10] egl: refactor color_buffers structure for deduplicating (v2)

From: "Mun, Gwan-gyeong" This is added for preventing adding of new color buffers structure and back* when new platform backend is added. This refactoring separates out the common and platform specific bits. This makes odd casting in the platform_foo.c but it prevents adding of new ifdef magic. B

[Mesa-dev] [PATCH v3 06/10] egl: add dri2_surface_update_age() helper (v3)

To share common update buffer age code. This updates old buffer's age and sets current back buffer's age to 1. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new h

[Mesa-dev] [PATCH v3 05/10] egl: add going out of the loop when color_buffer is set.

If color_buffer is set once, we don't need to set a same native buffer to remained free slot of color_buffers. So we can go out of the loop when color_buffer is set first. Fixes from Emil's review - Add setting "updated" and bailing out when the color_buffer is set.[1] [1] https://lists.freedesk

[Mesa-dev] [PATCH v3 01/10] egl: add dri2_surface_fixup() helper (v3)

From: "Mun, Gwan-gyeong" To share common free outdated buffers and update size code. This compares width and height arguments with current egl surface dimension, if the compared surface dimension is differ, then it free local buffers and updates dimension. In preparation to adding of new platfor

Re: [Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

On Tue, Oct 24, 2017 at 2:10 PM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-10-24 22:03:36) > > On Tue, Oct 24, 2017 at 9:06 AM, Chris Wilson > wrote: > > > > Through the use of mocs, we can define the cache usage for any > surface > > used by the GPU. In particular, we can reque

Re: [Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

Quoting Jason Ekstrand (2017-10-24 22:03:36) > On Tue, Oct 24, 2017 at 9:06 AM, Chris Wilson > wrote: > > Through the use of mocs, we can define the cache usage for any surface > used by the GPU. In particular, we can request that L3 cache be > allocated for either a read/write miss

Re: [Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

On Tue, Oct 24, 2017 at 9:06 AM, Chris Wilson wrote: > Through the use of mocs, we can define the cache usage for any surface > used by the GPU. In particular, we can request that L3 cache be > allocated for either a read/write miss so that subsequent reads can be > fetched from cache rather than

Re: [Mesa-dev] [PATCH 2/3] freedreno: context priority support

On Tue, Oct 24, 2017 at 3:34 PM, Emil Velikov wrote: > On 24 October 2017 at 19:48, Rob Clark wrote: >> For devices (and kernels) which support different priority ringbuffers, >> expose context priority support. >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/drivers/freedreno/freedreno_co

Re: [Mesa-dev] [PATCH 2/3] freedreno: context priority support

On 24 October 2017 at 19:48, Rob Clark wrote: > For devices (and kernels) which support different priority ringbuffers, > expose context priority support. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/freedreno_context.c | 9 - > src/gallium/drivers/freedreno/freedr

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] auxiliary: use vl_drm_screen_create method for surfaceless

On 24 October 2017 at 02:26, Sharma, Deepak wrote: > Hi Emil, > > Is your suggestion is to build mesa in chrome using --with-platforms=drm and > --with-platforms=surfaceless both ? I am not sure if that is required for > chrome. > The approach we are taking here is to build mesa only with > --w

Re: [Mesa-dev] [PATCH] radv: allow to use a compute shader for resetting the query pool

On 10/24/2017 09:00 PM, Bas Nieuwenhuizen wrote: Can you run this through CTS? Kind of worried about cache flushes when using a compute shader. Yeah, I will try to run CTS during the night. Thanks. Otherwise r-b On Tue, Oct 24, 2017 at 2:02 PM, Samuel Pitoiset wrote: Serious Sam Fusion

Re: [Mesa-dev] [PATCH] radv: allow to use a compute shader for resetting the query pool

Can you run this through CTS? Kind of worried about cache flushes when using a compute shader. Otherwise r-b On Tue, Oct 24, 2017 at 2:02 PM, Samuel Pitoiset wrote: > Serious Sam Fusion 2017 uses a huge number of occlusion queries, > and the allocated query pool buffer is greater than 4096 bytes

Re: [Mesa-dev] [PATCH] radv: print NIR before LLVM IR and disassembly

yay, bikeshedding. Fair enough though, r-b. On Tue, Oct 24, 2017 at 5:23 PM, Samuel Pitoiset wrote: > It's still printed after linking, but it makes more sense to > have SPIRV->NIR->LLVM IR->ASM. > > Fixes: f0a2bbd1a4 (radv: move nir print after linking is done) > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 1/2] mesa: enum checks for GL_EXT_occlusion_query_boolean

Tapani Pälli writes: > Some of the checks are valid for generic ES 3.2 as well. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/queryobj.c | 44 > 1 file changed, 44 insertions(+) > > diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryo

Re: [Mesa-dev] [PATCH 2/2] gles2: support for GL_EXT_occlusion_query_boolean

Tapani Pälli writes: > From: Harish Krupo > > Following test checking entrypoints passes: > > dEQP-EGL.functional.get_proc_address.extension.gl_ext_occlusion_query_boolean > > Piglit test 'ext_occlusion_query_boolean-any-samples' passes with these > changes. > > No changes/regression observ

[Mesa-dev] [Bug 103388] Linking libcltgsi.la (llvm/codegen/libclllvm_la-common.lo) fails with "error: no match for 'operator-'" with GCC-7, Mesa from Git and current LLVM revisions

https://bugs.freedesktop.org/show_bug.cgi?id=103388 LoneVVolf changed: What|Removed |Added CC||lonew...@xs4all.nl -- You are receiving th

[Mesa-dev] [PATCH 3/3] freedreno: add debug flag to force high priority context

Mainly for testing, FD_MESA_DEBUG=hiprio will force high priority contexts. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_util.h| 1 + 3 files changed,

[Mesa-dev] [PATCH 2/3] freedreno: context priority support

For devices (and kernels) which support different priority ringbuffers, expose context priority support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 9 - src/gallium/drivers/freedreno/freedreno_screen.c | 12 +++- src/gallium/drivers/freedre

[Mesa-dev] [PATCH 1/3] gallium: plumb context priority through to driver

Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger Reviewed-by: Marek Olšák Reviewed-by: Andres Rodriguez Reviewed-by: Wladimir J. van der Laan --- Sorry, it took me a while to get back to this.. v2: add docs blurb, fix si_get_param(), rebase src/gallium/docs/source/screen.rst

Re: [Mesa-dev] [PATCH v3 19/34] intel/compiler: Add union types for prog_data and prog_key stages

On Monday, October 23, 2017 11:33:44 PM PDT Jordan Justen wrote: > On 2017-10-23 23:23:27, Kenneth Graunke wrote: > > On Sunday, October 22, 2017 1:01:27 PM PDT Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > > src/intel/compiler/brw_compiler.h | 18 ++ > > >

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

On 24 October 2017 at 20:13, Fredrik Höglund wrote: > On Tuesday 24 October 2017, Henri Verbeet wrote: >> On 24 October 2017 at 16:11, Fredrik Höglund wrote: >> >> @@ -934,9 +938,18 @@ x11_manage_fifo_queues(void *state) >> >> >> >>while (chain->last_present_msc < target_msc) { >> >>

Re: [Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

Marek Olšák writes: > From: Marek Olšák Do we have tests that the compatibility parts of GLSL are properly enabled when you have GL_ARB_compatibility enabled? I see a bunch of negative tests for them, but we should get some positive ones. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Marek Olšák writes: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compat profile. Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

On Tuesday 24 October 2017, Henri Verbeet wrote: > On 24 October 2017 at 16:11, Fredrik Höglund wrote: > >> @@ -934,9 +938,18 @@ x11_manage_fifo_queues(void *state) > >> > >>while (chain->last_present_msc < target_msc) { > >> xcb_generic_event_t *event = > >> -xcb_wai

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

On 24 October 2017 18:12:00 BST, Emil Velikov wrote: > On 24 October 2017 at 02:10, Harish Krupo > wrote: > > Hi Emil, > > > > Emil Velikov writes: > > > >> On 23 October 2017 at 11:50, Harish Krupo > wrote: > >>> This passes 33/37 deqp tests related to partial_update, 4 are not > >>> support

Re: [Mesa-dev] Build mesa-dev on Windows with AVX instruction set problem

Am 24.10.2017 um 18:26 schrieb Fabrício Ceolin: > Hi, > > I am trying to build mesa-dev on windows. > > I am learning how to do it, through the > project https://github.com/pal1000/mesa-dist-win/tree/master/buildscript > > > I tr

Re: [Mesa-dev] [PATCH] docs: Mark GL_KHR_no_error as done.

That's quite right. :) Reviewed-by: Samuel Pitoiset Though, we still need GLX_ARB_create_context_no_error. Here's the pending series https://patchwork.freedesktop.org/patch/170204/ (in case someone more familiar with the code can give some feedbacks). Thanks! On 10/24/2017 07:38 PM, Kenneth

[Mesa-dev] [PATCH] docs: Mark GL_KHR_no_error as done.

Drivers have supported KHR_no_error for a while. We'd been leaving it marked as "in progress" because there's a zillion places that could get slightly more optimized. But, Timothy and Samuel have already done piles of work, and I think we have a solid implementation at this point. Let's check it

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

On Tuesday, 2017-10-24 09:40:22 -0700, Dylan Baker wrote: > This seems reasonable, could you wrap the hanging indent like meson_options > with > the closing brace on it's own line and with each option on its own line? > ie: > project( > mesa > ... > ) Done > > With that: > Reviewed-by: Dyla

Re: [Mesa-dev] [PATCH 5/6] freedreno: context priority support

On Wed, Oct 4, 2017 at 3:37 PM, Roland Scheidegger wrote: > Am 04.10.2017 um 17:44 schrieb Rob Clark: >> For devices (and kernels) which support different priority ringbuffers, >> expose context priority support. >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/drivers/freedreno/freedreno_co

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

On 23 October 2017 at 12:20, Nicolai Hähnle wrote: >>> -#ifndef _MSC_VER >>> -struct xtime { >>> -time_t sec; >>> -long nsec; >>> -}; >>> -typedef struct xtime xtime; >>> -#endif >>> - >> >> >> We don't have a fall-back declaration of the struct, yet we use it >> below and provide a times

Re: [Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define

Quoting Greg V (2017-10-23 13:20:39) > FreeBSD only has ETIMEDOUT, not ETIME > --- > src/intel/vulkan/anv_device.c | 4 > src/intel/vulkan/anv_gem.c| 4 > src/intel/vulkan/anv_queue.c | 4 > 3 files changed, 12 insertions(+) > > diff --git a/src/intel/vulkan/anv_device.c b/src

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

On 24 October 2017 at 20:31, Emil Velikov wrote: > On 17 October 2017 at 15:18, Henri Verbeet wrote: >> Note that the usage of xcb_poll_for_special_event() requires a version >> of libxcb that includes commit fad81b63422105f9345215ab2716c4b804ec7986 >> to work properly. >> > What should we expect

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

On 24 October 2017 at 02:10, Harish Krupo wrote: > Hi Emil, > > Emil Velikov writes: > >> On 23 October 2017 at 11:50, Harish Krupo wrote: >>> This passes 33/37 deqp tests related to partial_update, 4 are not >>> supported. Tests not supported: >>> dEQP-EGL.functional.negative_partial_update.not

Re: [Mesa-dev] [PATCH] meson: add opt-out of libunwind

Reviewed-by: Dylan Baker Quoting Erik Faye-Lund (2017-10-24 07:44:21) > Libunwind has some issues on some platforms, so let's allow people > who have issues to opt-out. This is similar to what we do in automake, > and the implementation is modelled after our opt-out for valgrind. > > Signed-off-

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

On 23 October 2017 at 18:10, Eric Engestrom wrote: > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: >> I'm working on radeonsi support in the Chrome OS Android container >> (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all >> the necessary EGL bits are there, so t

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

On 17 October 2017 at 15:18, Henri Verbeet wrote: > In particular, if the window was destroyed before the present request > completed, xcb_wait_for_special_event() may never return. > > Note that the usage of xcb_poll_for_special_event() requires a version > of libxcb that includes commit fad81b63

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

On 24 October 2017 at 16:12, Rob Clark wrote: > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson build support. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/Androi

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

Hi Jerome, On 23 October 2017 at 16:58, Jerome Duval wrote: > * configure.ac: > -pthread is not available on Haiku. > Haiku doesn't require --enable-dri > build hgl on Haiku > * egl/Makefile.am: define backendfiles for Haiku > * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/h

[Mesa-dev] [PATCH v2] clover/llvm: Drop support for LLVM < 3.9.

v2: remove/inline compat stuff Reviewed-by: Francisco Jerez --- .../state_trackers/clover/llvm/codegen/native.cpp | 8 +- src/gallium/state_trackers/clover/llvm/compat.hpp | 109 + .../state_trackers/clover/llvm/invocation.cpp | 22 +++-- .../state_trackers/clover/l

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

This seems reasonable, could you wrap the hanging indent like meson_options with the closing brace on it's own line and with each option on its own line? ie: project( mesa ... ) With that: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-24 07:04:01) > This way, we know what we're al

Re: [Mesa-dev] [PATCH 3/3] meson: build freedreno

Reviewed-by: Dylan Baker Quoting Rob Clark (2017-10-24 08:12:50) > Mostly copy/pasta from Dylan Baker's conversion of nouveau and i965. > > Signed-off-by: Rob Clark > --- > meson.build | 6 + > meson_options.txt| 2 +- > src/gall

Re: [Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

On 21 October 2017 at 13:54, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/mtypes.h | 1 + > src/mesa/main/version.c | 13 - > 3 files changed, 10 insertions(+), 5 deletions(-) > Do we want to update src/

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

The python is correct, and I believe that the autotools is correct, Reviewed-by: Dylan Baker Quoting Rob Clark (2017-10-24 08:12:48) > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson bu

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

Hi, 2017-10-24 14:46 GMT+02:00 Eric Engestrom : > I had a quick glance, but there's too much at once. > > On Monday, 2017-10-23 17:58:46 +0200, Jerome Duval wrote: >> * configure.ac: >> -pthread is not available on Haiku. >> Haiku doesn't require --enable-dri >> build hgl on Haiku >> * egl/M

Re: [Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

Quoting Eric Engestrom (2017-10-24 08:24:39) > On Tuesday, 2017-10-24 11:12:49 -0400, Rob Clark wrote: > > Also needed in freedreno/ir3. > > > > Signed-off-by: Rob Clark > > --- > > src/compiler/nir/meson.build | 2 ++ > > src/intel/compiler/meson.build | 2 +- > > 2 files changed, 3 insertion

Re: [Mesa-dev] [PATCH 3/3] meson: build freedreno

On Tuesday, 2017-10-24 11:12:50 -0400, Rob Clark wrote: > Mostly copy/pasta from Dylan Baker's conversion of nouveau and i965. > > Signed-off-by: Rob Clark > --- > meson.build | 6 + > meson_options.txt| 2 +- > src/gallium/drivers

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Hi Marek, On 21 October 2017 at 13:54, Marek Olšák wrote: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compa

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #7 from Vedran Miletić --- (In reply to Cris from comment #6) > Apparently beginning with linux 4.13 you have to append "radeon.si_support=0 > radeon.cik_support=0 amdgpu.si_support=1 amdgpu.cik_support=1" to the kernel > command lin

Re: [Mesa-dev] Build mesa-dev on Windows with AVX instruction set problem

Hi, I am trying to build mesa-dev on windows. I am learning how to do it, through the project https://github.com/ pal1000/mesa-dist-win/tree/master/buildscript I tried to use the binaries from pal1000, but I got an illegal instruction problem in opengl32.dll when I tried to run my application (V

[Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

From: Emil Velikov The function is effectively a direct function call into libwayland-server.so. Thus GBM no longer depends on the wayland-drm static library, making the build more straight forward. And the resulting binary is a bit smaller. Note: we need to move struct wayland_drm_callbacks fu

[Mesa-dev] [PATCH v2 2/8] Haiku: add src/hgl/Makefile.am to the build

From: Jérôme Duval --- src/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index 5ef2d4f..7ef63f7 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -108,6 +108,10 @@ if HAVE_PLATFORM_WAYLAND SUBDIRS += egl/wayland/wayland-egl endif +i

[Mesa-dev] [PATCH v2 3/8] Haiku: add support in src/egl/Makefile.am

From: Jérôme Duval --- src/egl/Makefile.am | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am index eeb745f..9b8528645 100644 --- a/src/egl/Makefile.am +++ b/src/egl/Makefile.am @@ -52,6 +52,7 @@ libEGL_common_la_LIB

[Mesa-dev] [PATCH v2 4/8] Haiku: add src/gallium/state_trackers/hgl/Makefile.am

From: Jérôme Duval --- src/gallium/state_trackers/hgl/Makefile.am | 39 + src/gallium/state_trackers/hgl/Makefile.sources | 3 ++ 2 files changed, 42 insertions(+) create mode 100644 src/gallium/state_trackers/hgl/Makefile.am create mode 100644 src/gallium/state_t

[Mesa-dev] [PATCH v2 6/8] Haiku: add src/gallium/targets/haiku-softpipe/Makefile.am

From: Jérôme Duval --- src/gallium/targets/haiku-softpipe/Makefile.am | 69 ++ .../targets/haiku-softpipe/SoftwareRenderer.cpp| 2 + 2 files changed, 71 insertions(+) create mode 100644 src/gallium/targets/haiku-softpipe/Makefile.am diff --git a/src/gallium/targets

[Mesa-dev] [PATCH v2 8/8] Haiku: convert to autotools

From: Jérôme Duval * -pthread is not available on Haiku. * Haiku doesn't require --enable-dri --- configure.ac | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 9aa02f5..58795e5 100644 --- a/configure.ac +++ b/co

[Mesa-dev] [PATCH v2 7/8] Haiku: add gallium Haiku components to the build.

From: Jérôme Duval --- src/gallium/Makefile.am | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/Makefile.am b/src/gallium/Makefile.am index ea20799..37800b9 100644 --- a/src/gallium/Makefile.am +++ b/src/gallium/Makefile.am @@ -119,6 +119,10 @@ if HAVE_DRIS

[Mesa-dev] [PATCH v2 0/8] Haiku: convert to autotools

From: Jérôme Duval Resend as a patch series as requested by Eric Engestrom. Jérôme Duval (8): Haiku: add src/hgl/Makefile.am and its pkgconfig file Haiku: add src/hgl/Makefile.am to the build Haiku: add support in src/egl/Makefile.am Haiku: add src/gallium/state_trackers/hgl/Makefile.am

[Mesa-dev] [PATCH v2 1/8] Haiku: add src/hgl/Makefile.am and its pkgconfig file

From: Jérôme Duval --- src/hgl/Makefile.am | 50 src/hgl/Makefile.sources | 8 src/hgl/gl.pc.in | 11 +++ 3 files changed, 69 insertions(+) create mode 100644 src/hgl/Makefile.am create mode 100644 src/hgl/Makefile

[Mesa-dev] [PATCH v2 5/8] Haiku: add src/gallium/winsys/sw/hgl/Makefile.am

From: Jérôme Duval --- src/gallium/winsys/sw/hgl/Makefile.am | 34 ++ src/gallium/winsys/sw/hgl/Makefile.sources | 3 +++ 2 files changed, 37 insertions(+) create mode 100644 src/gallium/winsys/sw/hgl/Makefile.am create mode 100644 src/gallium/winsys/sw/hgl/Ma

[Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

Through the use of mocs, we can define the cache usage for any surface used by the GPU. In particular, we can request that L3 cache be allocated for either a read/write miss so that subsequent reads can be fetched from cache rather than memory. A consequence of this is that if we allocate a L3/LLC

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

looks good On Tue, Oct 24, 2017 at 12:06 AM, Jordan Justen wrote: > On 2017-10-23 19:48:51, Jason Ekstrand wrote: > > > > On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen < > jordan.l.jus...@intel.com> > > wrote: > > > > > + #define SET_UPLOAD_PARAMS(sh, sh_caps, prog) \ > >

Re: [Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

Hi Gwan-gyeong, You should use dri2_surface_free_image in the next patchset you send out (should be pretty easy to implement), but can save the polishing of struct dri2_egl_surface for later. On Mon, Oct 23, 2017 at 1:46 PM, Mun, Gwan-gyeong wrote: > Hi Gurchetan, > > 2017-10-18 6:02 GMT+09:00

Re: [Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

On Tuesday, 2017-10-24 11:12:49 -0400, Rob Clark wrote: > Also needed in freedreno/ir3. > > Signed-off-by: Rob Clark > --- > src/compiler/nir/meson.build | 2 ++ > src/intel/compiler/meson.build | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/meson.

[Mesa-dev] [PATCH] radv: print NIR before LLVM IR and disassembly

It's still printed after linking, but it makes more sense to have SPIRV->NIR->LLVM IR->ASM. Fixes: f0a2bbd1a4 (radv: move nir print after linking is done) Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) d

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

On Tuesday, 2017-10-24 11:12:48 -0400, Rob Clark wrote: > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson build support. > > Signed-off-by: Rob Clark Reviewed-by: Eric Engestrom > --

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

Hi Gwan-yeong, I'm fine with the conventions you suggested -- my main nit was with the verbosity. The downside is you're going to have to downcast every single time. Your call .. On Mon, Oct 23, 2017 at 1:22 PM, Mun, Gwan-gyeong wrote: > Hi Emil and Gurchetan, > > Thank you for reviewing the

  1   2   >