On Tue, Oct 17, 2017 at 7:41 AM, Timothy Arceri wrote:
> It looks the original indirect mask was probably copied from
> ANV.
>
> Here we drop lowering locals altogether and allow indirects
> on inputs where supported.
>
> Sascha Willems demo results:
>
> tessellation ~4000 -> ~4200 fps
> ---
>
>
On Tue, Oct 17, 2017 at 7:36 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This ports radv to using the anv entrypoint/extension generator
> code.
>
> No differences on enabled extensions list in vulkaninfo.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/.gitignore | 1 +
https://bugs.freedesktop.org/show_bug.cgi?id=103062
--- Comment #11 from alexander ---
It will be possible to download an older version of FS17.
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-de
It looks the original indirect mask was probably copied from
ANV.
Here we drop lowering locals altogether and allow indirects
on inputs where supported.
Sascha Willems demo results:
tessellation ~4000 -> ~4200 fps
---
Radeonsi also does a couple of other things.
1. It sets the following llvm
From: Dave Airlie
This ports radv to using the anv entrypoint/extension generator
code.
No differences on enabled extensions list in vulkaninfo.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/.gitignore | 1 +
src/amd/vulkan/Makefile.am | 9 +-
src/amd/vulkan/Makef
Hi Jason,
Please review and let us know if any other changes need to be done for
this patch.
We have incorporated all the review comments in the second version of the patch.
Thanks,
Aravindan
> -Original Message-
> From: Muthukumar, Aravindan
> Sent: Tuesday, October 3, 2017 10:0
Pushed, thanks!
Marek
On Sun, Oct 15, 2017 at 7:46 PM, Miklós Máté wrote:
> update_single_program_texture() never returns NULL.
>
> Signed-off-by: Miklós Máté
> ---
> src/mesa/main/texstate.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/mesa/main/texstate.c b/src/mesa/main/tex
On Mon, Oct 16, 2017 at 9:05 PM, Timothy Arceri wrote:
> On 17/10/17 11:55, Dylan Baker wrote:
>>
>> Here is build support for the three remaining classic drivers, radeon
>> (r100),
>> r200, and the nouveau-veaux driver. None of these are too crazy, but I
>> don't
>> have hardware to test any of t
Old, not calves...
On Oct 16, 2017 8:56 PM, "Dylan Baker" wrote:
Build tested only.
Signed-off-by: Dylan Baker
---
meson.build | 4 +-
meson_options.txt| 2 +-
src/mesa/drivers/dri/meson.build | 3 ++
src/mesa/drivers/dri/nouveau
---
src/compiler/nir/nir.c | 22 +++
src/compiler/nir/nir.h | 4
src/compiler/nir/nir_lower_samplers.c| 27 ++--
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 19 +
4 file
On Sun, Oct 15, 2017 at 7:10 PM, Miklós Máté wrote:
> Hi,
>
> I'd like to ask you to revert this change.
>
> As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however
> there is a major difference between the two: with ATI_fs there is no way of
> knowing the texture targets until t
---
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
index 1c86513..3ca2b04 100644
--- a/src/intel/vulkan/anv_
On 17/10/17 11:55, Dylan Baker wrote:
Here is build support for the three remaining classic drivers, radeon (r100),
r200, and the nouveau-veaux driver. None of these are too crazy, but I don't
have hardware to test any of these.
I can probably test out r200 later tonight. However are you going
Build tested only.
Signed-off-by: Dylan Baker
---
meson.build | 4 +-
meson_options.txt| 2 +-
src/mesa/drivers/dri/meson.build | 3 ++
src/mesa/drivers/dri/nouveau/meson.build | 92
4 files changed,
Build tested only
Signed-off-by: Dylan Baker
---
meson.build | 4 +-
meson_options.txt | 2 +-
src/mesa/drivers/dri/meson.build | 3 ++
src/mesa/drivers/dri/r200/meson.build | 91 +++
4 files changed, 98 insert
Instead of just the path.
Signed-off-by: Dylan Baker
---
bin/install_megadrivers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
index a5a46201ccb..a98d7dd177b 100755
--- a/bin/install_megadrivers.py
+++ b/bin/install
Here is build support for the three remaining classic drivers, radeon (r100),
r200, and the nouveau-veaux driver. None of these are too crazy, but I don't
have hardware to test any of these.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https:
build tested only
Signed-off-by: Dylan Baker
---
meson.build | 4 +-
meson_options.txt | 2 +-
src/mesa/drivers/dri/meson.build| 3 ++
src/mesa/drivers/dri/radeon/meson.build | 87 +
4 files changed, 94
I made some fairly straightforward comments. with that, and the squash you
sent, 1-6 and 8-10 are
Reviewed-by: Jason Ekstrand
I'd like to see the respin of patch 7 but I fully expect to give it my R-B
almost immediately.
--Jason
On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace
wrote:
> This i
On 17/10/17 10:02, Timothy Arceri wrote:
On 16/10/17 22:54, Bas Nieuwenhuizen wrote:
Otherwise the flag is borderline useless.
This disk cache util checks for MESA_GLSL_CACHE_DISABLE. Maybe we should
make the name more generic and combine these flags? Doesn't seem like
much use having two as
On October 16, 2017 4:18:45 PM Chad Versace wrote:
Add missing close(fd) for case
VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT_KHR,
subcase ANV_SEMAPHORE_TYPE_BO.
---
src/intel/vulkan/anv_queue.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a
As far as I can tell this looks good. for the series:
Reviewed-by: Dylan Baker
(I pushed the meson-gallium stuff so this should be possible to land)
Dylan
Quoting Eric Anholt (2017-10-16 13:57:08)
> Since I think I've sent review for all the parts of Dylan's meson
> gallium series, here's meson
On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace
wrote:
> The patch renames anv_bo_cache_import() to
> anv_bo_cache_import_with_size(); and adds a new variant,
> anv_bo_cache_import(), that lacks the 'size' parameter. Same as
> pre-patch, anv_bo_cache_import_with_size() continues to validate the
>
Add missing close(fd) for case
VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT_KHR,
subcase ANV_SEMAPHORE_TYPE_BO.
---
src/intel/vulkan/anv_queue.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_que
On 16/10/17 22:54, Bas Nieuwenhuizen wrote:
Otherwise the flag is borderline useless.
This disk cache util checks for MESA_GLSL_CACHE_DISABLE. Maybe we should
make the name more generic and combine these flags? Doesn't seem like
much use having two as you say.
---
src/amd/vulkan/radv_pi
You're missing one other caller in anv_queue.c
On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace
wrote:
> This will allow us to implement VK_ANDROID_native_buffer without dup'ing
> the fd. We must close the fd in VK_KHR_external_memory_fd, but we should
> not in VK_ANDROID_native_buffer.
> ---
> s
Tested-by: Dieter Nützel
on RX580
Thanks,
Dieter
Am 16.10.2017 18:48, schrieb Vedran Miletić:
---
src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 5 +++--
src/gallium/state_trackers/clover/llvm/compat.hpp | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --gi
No meson love?
On Mon, Oct 16, 2017 at 11:54 AM, Chad Versace
wrote:
> A first step to supporting Vulkan on ARC++. Mesa on ARC++ uses
> Autotools, not Android.mk.
>
> Doing this now, even before VK_ANDROID_native_buffer is implemented,
> allows us to incrementally add Android support to the Auto
Am 16.10.2017 20:13, schrieb Andy Furniss:
Emil Velikov wrote:
On 16 October 2017 at 03:22, Jan Vesely
wrote:
On Sun, 2017-10-15 at 00:00 +0100, Andy Furniss wrote:
Andy Furniss wrote:
Since
commit 13a53c4f5cdd664fd155c9e78fb46a4387af006c
Author: Emil Velikov
Date: Thu Oct 5 11:19:05 201
On Mon 16 Oct 2017, Kristian Høgsberg wrote:
> On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace
> wrote:
> > v9:
> > - Isolate as much Android code as possible, moving it from anv_image.c
> > to anv_android.c. Connect the files with anv_image_from_gralloc().
> > Remove VkNativeBufferANDR
On Mon, Oct 16, 2017 at 6:58 PM, Scott D Phillips
wrote:
> Dylan Baker writes:
>
>> Quoting Scott D Phillips (2017-10-16 10:04:45)
>> > Dylan Baker writes:
>> >
>> > > Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
>> > > > On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker
>> > > > wrote:
>> > > >
Since I think I've sent review for all the parts of Dylan's meson
gallium series, here's meson for the Broadcom side of things.
Note that compared to Dylan's stuff, I've put the subdir calls for my
drivers under their condition flag. This seems to be a general meson
style thing, which makes it ea
---
meson.build| 2 +
meson_options.txt | 2 +-
src/broadcom/{ => compiler}/meson.build| 25 +++-
src/broadcom/meson.build | 18 +
src/broadcom/{ => qpu}/meson.build
---
meson.build | 2 +
meson_options.txt| 2 +-
src/{ => broadcom/cle}/meson.build | 80 +++--
src/{ => broadcom}/meson.build | 50 ++---
src/gallium/drivers/vc4/meson.build
---
meson.build | 2 ++
meson_options.txt| 2 +-
src/gallium/meson.build | 4 +++-
src/gallium/targets/dri/meson.build | 5 +
src/gallium/winsys/pl111/drm/meson.build | 30 ++
5 files cha
On Mon, Oct 16, 2017 at 5:04 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> The version of the extension does not imply success for the
> queryImage(... WIDTH/HEIGHT ...) calls.
>
> With that properly handled (as of last commit), we can drop the check.
>
> Fixes: 93ebec87ed4 ("dri: Make query i
On Mon, Oct 16, 2017 at 5:04 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Fixes: 6a7dea93fa7 ("dri: Rework planar image interface")
> Cc: Jakob Bornecrantz
> Signed-off-by: Emil Velikov
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
> ---
> src/gbm/backends/dri/gbm_dri.c | 23 ++
On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace wrote:
> This implementation is correct (afaict), but takes two shortcuts
> regarding the import/export of Android sync fds.
>
> Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
> fd into a VkSemaphore or VkFence, the driver i
On Mon, Oct 16, 2017 at 2:32 PM, Kenneth Graunke wrote:
> On Monday, October 16, 2017 12:07:47 PM PDT Rob Herring wrote:
>> Commit 32fcced7b479 ("meta: Unset the textures_used_by_txf bitfield.")
>> added a dependency in libmesa_dricore to NIR headers, but failed to add
>> libmesa_nir as a dependen
Quoting Kenneth Graunke (2017-10-16 20:07:05)
> Patches 2 and 5 look good to me as well. I'd like to try out the
> AMD_pinned_memory support with Left 4 Dead 2, as I know a bunch of
> the Source 1 games use AMD_pinned_memory for better performance...
> but those games apparently started crashing t
On Monday, October 16, 2017 12:07:47 PM PDT Rob Herring wrote:
> Commit 32fcced7b479 ("meta: Unset the textures_used_by_txf bitfield.")
> added a dependency in libmesa_dricore to NIR headers, but failed to add
> libmesa_nir as a dependency resulting in a build error:
>
> In file included from exte
On Friday, October 13, 2017 2:34:51 AM PDT Chris Wilson wrote:
> We know that we will only ever need to lookup an external handle and so
> can defer adding a bo to the external ht until it is ever exported or
> imported, keeping that hashtable compact.
>
> Cc: Kenneth Graunke
> ---
> src/mesa/dr
Commit 32fcced7b479 ("meta: Unset the textures_used_by_txf bitfield.")
added a dependency in libmesa_dricore to NIR headers, but failed to add
libmesa_nir as a dependency resulting in a build error:
In file included from external/mesa3d/src/mesa/drivers/common/meta.c:90:
external/mesa3d/src/compil
It is possible that the optimizer ends up in an infinite loop in
post_scheduler::schedule_alu(), because post_scheduler::prepare_alu_group()
does not find a proper scheduling. This can be deducted from
pending.count() being larger than zero and not getting smaller.
This patch works around this pro
Am Montag, den 16.10.2017, 10:31 -0400 schrieb Chuck Atkins:
> Hi Gert, Emil,
>
> > I think that using the -std=c++11 check should be good,
>
> A few things to consider, neither of which is a deal breaker, I just
> want to make sure they're not forgotten about:
> #1 -std=c++ will cover many case
The patch renames anv_bo_cache_import() to
anv_bo_cache_import_with_size(); and adds a new variant,
anv_bo_cache_import(), that lacks the 'size' parameter. Same as
pre-patch, anv_bo_cache_import_with_size() continues to validate the
imported size.
The patch is essentially a refactor patch. It sho
From: Tapani Pälli
Now that anvil fully implements the Vulkan HAL interface, we can install
it as the vendor HAL module at /vendor/lib/hw/vulkan.${board}.so. To do
so:
- Rename LOCAL_MODULE to vulkan.$(TARGET_BOARD_PLATFORM).
- Use LOCAL_PROPRIETARY_MODULE to install under vendor path.
Test
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply blocks on
the sync fd, then puts the VkSemaphore
In src/intel/vulkan/*, redirect all instances of printf, vk_error,
anv_loge, anv_debug, anv_finishme, anv_perf_warn, anv_assert, and their
many variants to the new intel_log functions. I believe I caught them
all.
The other subdirs of src/intel are left for a future exercise.
v2:
- Rebase onto
Will use in VK_ANDROID_native_buffer.
---
src/intel/vulkan/anv_gem.c | 16
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c
index 3994c6b66c..34c0989108 100644
--- a/src/intel/vulkan/
I'm bringing up Vulkan in the Android container of Chrome OS (ARC++).
On Android, stdio goes to /dev/null. On Android, remote gdb is even more
painful than the usual remote gdb. On Android, nothing works like you
expect and debugging is hell. I need logging.
This patch introduces a small, simple
(This is v4 submission of the series, but contains v9 of the key patch).
This series adds Android support to Anvil. And Android requires
VK_ANDROID_native_buffer.
I tested the series on 64-bit ARC++ on a Skylake Chromebook with a 3.18
kernel. (ARC++ is the Android container in Chrome OS). (Yes,
From: Tapani Pälli
chadv: I made this patch by extracting the hunk from Tapani's patch in
https://lists.freedesktop.org/archives/mesa-dev/2017-September/169602.html.
Signed-off-by: Chad Versace
---
src/intel/Android.vulkan.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
A first step to supporting Vulkan on ARC++. Mesa on ARC++ uses
Autotools, not Android.mk.
Doing this now, even before VK_ANDROID_native_buffer is implemented,
allows us to incrementally add Android support to the Autotools build.
---
src/intel/Makefile.vulkan.am | 5 +
1 file changed, 5 inser
If this flag is set, then the image and the bo have the same lifetime.
vkDestroyImage will release the bo.
We need this for VK_ANDROID_native_buffer, because that extension
creates the VkImage *and* imports its memory during the same
call, vkCreateImage.
v2: Rebase onto VK_KHR_bind_memory2.
---
This will allow us to implement VK_ANDROID_native_buffer without dup'ing
the fd. We must close the fd in VK_KHR_external_memory_fd, but we should
not in VK_ANDROID_native_buffer.
---
src/intel/vulkan/anv_allocator.c | 12
src/intel/vulkan/anv_device.c| 11 +++
src/intel/vu
On 16/10/17 13:21, Emil Velikov wrote:
Hi Miklós,
On 15 October 2017 at 18:46, Miklós Máté wrote:
Autoconf sets CFLAGS="-g -O2" by default.
Signed-off-by: Miklós Máté
---
configure.ac | 4
1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index 62d33a1941..c83
Emil Velikov wrote:
On 16 October 2017 at 03:22, Jan Vesely wrote:
On Sun, 2017-10-15 at 00:00 +0100, Andy Furniss wrote:
Andy Furniss wrote:
Since
commit 13a53c4f5cdd664fd155c9e78fb46a4387af006c
Author: Emil Velikov
Date: Thu Oct 5 11:19:05 2017 +0100
configure.ac: rework llvm lib
On Mon, 2017-10-16 at 18:48 +0200, Vedran Miletić wrote:
> ---
> src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 5 +++--
> src/gallium/state_trackers/clover/llvm/compat.hpp | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/state_trackers/
Dylan Baker writes:
> Quoting Scott D Phillips (2017-10-16 10:04:45)
> > Dylan Baker writes:
> >
> > > Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
> > > > On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker
> > > > wrote:
> > > > > I'm not sure about this approach, we would need a way to add
> >
On Monday, 2017-10-16 16:10:42 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Android implements the API and does the native damage handling itself.
> At the same time it
> a) does call the vendor's eglSwapBuffersWithDamageKHR
> b) does not implement eglSetDamageRegionKHR
>
> There's some
Series is:
Reviewed-by: Francisco Jerez
Emil Velikov writes:
> From: Emil Velikov
>
> Nearly all the distributions* that build Mesa OpenCL, enable the ICD.
> Since building a non-ICD driver has the chance of conflicting with
> existing OpenCL binary (libOpenCL.so).
>
> Furthermore, some appli
Quoting Rob Clark (2017-10-15 04:04:04)
> On Sat, Oct 14, 2017 at 11:10 PM, Dylan Baker wrote:
> > Quoting Rob Clark (2017-10-14 11:41:49)
> >
> > Do we have a files() object for this? Since both freedreno and i965 need
> > this,
> > why don't we add a files_nir_algebraic_py (or whatever) in nir
On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote:
> Hi Harish,
>
> Overall looks great, a few comments/questions inline.
>
I agree with everything Emil said :)
> On 13 October 2017 at 19:49, Harish Krupo wrote:
> > This passes 33/37 deqp tests related to partial_update, 4 are not
> > s
On 10/16/2017 04:39 PM, Michel Dänzer wrote:
On 16/10/17 02:21 PM, Thomas Hellstrom wrote:
On 10/16/2017 12:53 PM, Thomas Hellstrom wrote:
Hi, Michel,
On 10/16/2017 12:35 PM, Michel Dänzer wrote:
Hi Thomas,
On 05/09/17 10:15 AM, Thomas Hellstrom wrote:
If we're seeing a drawable size change
I think there's a decent chance I'll actually get around to reviewing these
soon. Before it in my review queue is Chad's android patches and 16bit
storage.
On October 16, 2017 12:04:46 AM Louis-Francis Ratté-Boulianne
wrote:
Hi,
With full support for modifiers in DRIimage, this patch se
On 10/16/2017 10:25 AM, Eric Engestrom wrote:
All 4 other version strings do it like this.
((Also, double parentheses just look confusing))
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/svga/svga_screen.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/
Quoting Scott D Phillips (2017-10-16 10:04:45)
> Dylan Baker writes:
>
> > Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
> > > On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker wrote:
> > > > I'm not sure about this approach, we would need a way to add
> > > > depends to meson,
>
> 'add depends' m
Hi Hongxu,
The one line message is unreadable, I'm afraid. How about;
automake: intel: move expat handling where it's used
On 12 October 2017 at 02:39, Hongxu Jia wrote:
> While built with "-fvisibility=default"
> ...
> |i586-oe-linux-gcc ... -fvisibility=default ... -o
> common/.libs/common_li
Dylan Baker writes:
> Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
> > On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker wrote:
> > > I'm not sure about this approach, we would need a way to add
> > > depends to meson,
'add depends' meaning having a way for the build steps themselves to
depend on
---
src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 5 +++--
src/gallium/state_trackers/clover/llvm/compat.hpp | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/codegen/common.cpp
b/src/gallium/state_trackers/clover/l
On 16 October 2017 at 17:33, Rowley, Timothy O
wrote:
> Ping. This is useful for those building their own llvm.
>
Thanks Tim. Did not see this the first time around.
>> On Oct 3, 2017, at 3:23 PM, Rowley, Timothy O
>> wrote:
>>
>> Assert-enabled builds of llvm add _DEBUG to the LLVM_CFLAGS.
>>
Ping. This is useful for those building their own llvm.
> On Oct 3, 2017, at 3:23 PM, Rowley, Timothy O
> wrote:
>
> Assert-enabled builds of llvm add _DEBUG to the LLVM_CFLAGS.
>
> This was causing a crash with swr running the ParaView
> waveletcontour.py test, due to a bug in our _DEBUG cod
Meson already uses this, let's get the other build sys to use it too.
Note: rstrip() was dropped, as truncating to the first 10 chars already
gets rid of the terminating newline (not an issue with the env var
either, unless maliciously crafted to break the build... not sure this
is a real-world is
All 4 other version strings do it like this.
((Also, double parentheses just look confusing))
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/svga/svga_screen.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_screen.c
b/src/gall
https://bugs.freedesktop.org/show_bug.cgi?id=103062
--- Comment #10 from Emil Velikov ---
Alexander, I'm struggling to understand what you mean.
Compatibility GL Profile is _not_ aimed at old hardware, but at old software.
Newly written applications should not use it, without a very compelling r
From: Emil Velikov
Android implements the API and does the native damage handling itself.
At the same time it
a) does call the vendor's eglSwapBuffersWithDamageKHR
b) does not implement eglSetDamageRegionKHR
There's something strange happening here. For now simply note about the
'lack' of eglS
From: Emil Velikov
Fold the error handling for image creation/duplication in a single
place.
Effectively providing the same errno across the board and plugging a
memory leak in the GBM_BO_IMPORT_WL_BUFFER case.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Emil Velikov
---
src/gbm/back
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i915/intel_screen.c | 33 +---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
b/src/mesa/drivers/dri/i915/intel_screen.c
index ba49e90fef
From: Emil Velikov
The function can fail. Check and teardown accordingly.
Fixes: a43d286ef7f ("gbm: Add import from fd")
Cc: Kristian Høgsberg
Signed-off-by: Emil Velikov
---
src/gbm/backends/dri/gbm_dri.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gbm/back
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 37 +++--
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c
b/src/mesa/drivers/dri/radeon/radeon_screen.c
index 51a
From: Emil Velikov
Fixes: 6a7dea93fa7 ("dri: Rework planar image interface")
Cc: Jakob Bornecrantz
Signed-off-by: Emil Velikov
---
src/gbm/backends/dri/gbm_dri.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gb
From: Emil Velikov
The version of the extension does not imply success for the
queryImage(... WIDTH/HEIGHT ...) calls.
With that properly handled (as of last commit), we can drop the check.
Fixes: 93ebec87ed4 ("dri: Make query image WIDTH and HEIGHT be version 4")
Cc: Jakob Bornecrantz
Signed-
From: Emil Velikov
The new entry point has a way to feedback the error. Thus we no longer
need to call _mesa_error() but instead we can pass the correct value.
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i965/intel_screen.c | 31 ++-
1 file changed, 26 inse
From: Emil Velikov
The entry-point can be NULL, even if the version advertised is >= 2.
Fixes: 221c678329f ("gbm: Validate usage flags in
gbm_bo_create_from_egl_image()")
Cc: Kristian Høgsberg
Signed-off-by: Emil Velikov
---
src/gbm/backends/dri/gbm_dri.c | 1 +
1 file changed, 1 insertion(+
From: Emil Velikov
The presense of DRI_IMAGE is checked further up, at the start of the
function gbm_dri_bo_import().
Signed-off-by: Emil Velikov
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index 0a4853bf63d..531361a04d9 100644
--- a/src/gbm/backends/dri/gbm_dr
From: Emil Velikov
Entry-point was introduced with v7 and may be NULL.
Check and bail out accordingly.
Fixes: a43d286ef7f ("gbm: Add import from fd")
Cc: Kristian Høgsberg
Signed-off-by: Emil Velikov
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index 531361a04d
On Monday, 2017-10-16 14:28:57 +, Brian Paul wrote:
> On 10/16/2017 04:24 AM, Eric Engestrom wrote:
> > On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote:
> > > The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the
> > > wrong place
> >
> > Can you explain why this was wrong,
On Monday, 2017-10-16 15:37:31 +, Emil Velikov wrote:
> On 16 October 2017 at 16:21, Eric Engestrom wrote:
> > On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote:
> >> On 13 October 2017 at 19:49, Harish Krupo
> >> wrote:
> >> > This passes 33/37 deqp tests related to partial_update, 4
From: Emil Velikov
Use $(sysconfdir) instead of hardcoding /etc.
While the OpenCL spec expects the file in /etc, people building their
stack can override that, esp. !Linux users.
Furthermore this removes a fundamental violation, which results in the
system file being overwritten even as one exp
From: Emil Velikov
Nearly all the distributions* that build Mesa OpenCL, enable the ICD.
Since building a non-ICD driver has the chance of conflicting with
existing OpenCL binary (libOpenCL.so).
Furthermore, some applications expect the library to provide
annotated/versioned symbols.
https://li
On 16 October 2017 at 16:21, Eric Engestrom wrote:
> On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote:
>> On 13 October 2017 at 19:49, Harish Krupo wrote:
>> > This passes 33/37 deqp tests related to partial_update, 4 are not
>> > supported.
>> >
>> Mildly related:
>> Android's .swap_buff
On Mon, Oct 16, 2017 at 08:03:41AM -0700, Jason Ekstrand wrote:
> FYI: I'm planning to review this some time this week. Probably not today
> though.
Great, I was hoping you would. I'm just reading out of curiosity and asking
random questions. Mostly trying to remind myself how compiler works :) I
On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote:
> On 13 October 2017 at 19:49, Harish Krupo wrote:
> > This passes 33/37 deqp tests related to partial_update, 4 are not
> > supported.
> >
> Mildly related:
> Android's .swap_buffers_with_damage seems to be missing. AFAICT should
> be able
On Thu, Oct 12, 2017 at 08:38:19PM +0200, Jose Maria Casanova Crespo wrote:
> Enables the support of 16-bit types on load_input and
> store_outputs intrinsics intra-stages.
>
> The approach was based on re-using the 32-bit URB read
> and writes between stages, shuffling pairs of 16-bit values into
FYI: I'm planning to review this some time this week. Probably not today
though.
On Thu, Oct 12, 2017 at 11:37 AM, Jose Maria Casanova Crespo <
jmcasan...@igalia.com> wrote:
> Hello,
>
> this is the V3 series for the implementation of the
> SPV_KHR_16bit_storage and VK_KHR_16bit_storage extensio
On 16/10/17 02:21 PM, Thomas Hellstrom wrote:
>
> On 10/16/2017 12:53 PM, Thomas Hellstrom wrote:
>> Hi, Michel,
>>
>> On 10/16/2017 12:35 PM, Michel Dänzer wrote:
>>> Hi Thomas,
>>>
>>> On 05/09/17 10:15 AM, Thomas Hellstrom wrote:
If we're seeing a drawable size change, in particular after
On 16 October 2017 at 15:29, Brian Paul wrote:
> On 10/16/2017 08:07 AM, Emil Velikov wrote:
>>
>> On 16 October 2017 at 11:24, Eric Engestrom
>> wrote:
>>>
>>> On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote:
The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the
>>>
Hi Gert, Emil,
I think that using the -std=c++11 check should be good,
A few things to consider, neither of which is a deal breaker, I just want
to make sure they're not forgotten about:
1. -std=c++ will cover many cases, but not all. Many commercial
compilers use a different set of opti
On 13 October 2017 at 19:49, Harish Krupo wrote:
> This passes 33/37 deqp tests related to partial_update, 4 are not
> supported.
>
Mildly related:
Android's .swap_buffers_with_damage seems to be missing. AFAICT should
be able to implement it via droid_set_damage_region?
Speaking of which:
One co
1 - 100 of 158 matches
Mail list logo
