On 10/16/2017 10:25 AM, Eric Engestrom wrote:
All 4 other version strings do it like this. ((Also, double parentheses just look confusing))Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/drivers/svga/svga_screen.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index ebadf3ed5b1035c9cd7d..834a6a56c9598aeec8c4 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_screen.c @@ -49,10 +49,6 @@ /* NOTE: this constant may get moved into a svga3d*.h header file */ #define SVGA3D_DX_MAX_RESOURCE_SIZE (128 * 1024 * 1024) -#ifndef MESA_GIT_SHA1 -#define MESA_GIT_SHA1 "(unknown git revision)" -#endif - #ifdef DEBUG int SVGA_DEBUG = 0; @@ -984,7 +980,11 @@ init_logging(struct pipe_screen *screen) svga_host_log(host_log); util_snprintf(host_log, sizeof(host_log) - strlen(log_prefix), - "%s%s (%s)", log_prefix, PACKAGE_VERSION, MESA_GIT_SHA1); + "%s%s" +#ifdef MESA_GIT_SHA1 + " (" MESA_GIT_SHA1 ")" +#endif + , log_prefix, PACKAGE_VERSION); svga_host_log(host_log); /* If the SVGA_EXTRA_LOGGING env var is set, log the process's command
For both, Reviewed-by: Brian Paul <bri...@vmware.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
