As far as I can tell this looks good. for the series: Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
(I pushed the meson-gallium stuff so this should be possible to land)
Dylan
Quoting Eric Anholt (2017-10-16 13:57:08)
> Since I think I've sent review for all the parts of Dylan's meson
> gallium series, here's meson for the Broadcom side of things.
>
> Note that compared to Dylan's stuff, I've put the subdir calls for my
> drivers under their condition flag. This seems to be a general meson
> style thing, which makes it easy to bury the dependencies for the vc4
> and vc5 drivers in their subdirs. It also means we could drop the
> build_by_default falses, though I haven't done that.
>
> Tested vc4 and vc5 in simulation and vc5's unit test.
>
> Eric Anholt (3):
> meson: Add support for the vc4 driver.
> meson: Add support for the pl111 driver.
> meson: Add support for the vc5 driver.
>
> meson.build | 6 ++
> meson_options.txt | 2 +-
> src/{ => broadcom/cle}/meson.build | 80 ++++++++++----------
> src/{ => broadcom/compiler}/meson.build | 67 ++++++----------
> src/{ => broadcom}/meson.build | 62 +++++----------
> src/{ => broadcom/qpu}/meson.build | 60 +++++----------
> src/gallium/drivers/vc4/meson.build | 101
> +++++++++++++++++++++++++
> src/{ => gallium/drivers/vc5}/meson.build | 88 +++++++++++----------
> src/gallium/meson.build | 17 ++++-
> src/gallium/targets/dri/meson.build | 25 +++++-
> src/{ => gallium/winsys/pl111/drm}/meson.build | 55 +++-----------
> src/{ => gallium/winsys/vc4/drm}/meson.build | 54 +++----------
> src/{ => gallium/winsys/vc5/drm}/meson.build | 54 +++----------
> src/meson.build | 4 +-
> 14 files changed, 334 insertions(+), 341 deletions(-)
> copy src/{ => broadcom/cle}/meson.build (53%)
> copy src/{ => broadcom/compiler}/meson.build (53%)
> copy src/{ => broadcom}/meson.build (52%)
> copy src/{ => broadcom/qpu}/meson.build (53%)
> create mode 100644 src/gallium/drivers/vc4/meson.build
> copy src/{ => gallium/drivers/vc5}/meson.build (53%)
> copy src/{ => gallium/winsys/pl111/drm}/meson.build (53%)
> copy src/{ => gallium/winsys/vc4/drm}/meson.build (53%)
> copy src/{ => gallium/winsys/vc5/drm}/meson.build (53%)
>
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
