Re: [Mesa-dev] [PATCH 1/2] i965: Change intel_disable_rb_aux_buffer into get_drawbuffer_index().

Rb On October 5, 2017 10:02:58 PM Kenneth Graunke wrote: The bulk of the work in intel_disable_rb_aux_buffer() is finding the drawbuffer index for the given BO. After that, disabling the auxiliary buffers is an easy one liner. This lets us ask whether a texture is also bound as a renderbuff

Re: [Mesa-dev] [PATCH 2/2] i965: Disable auxiliary buffers when there are self-dependencies.

On October 5, 2017 10:02:58 PM Kenneth Graunke wrote: Jason and I investigated several OpenGL CTS failures where the tests bind the same texture for rendering and texturing, at the same time. This has defined results as long as the reads happen before writes, or the regions are non-overlapping.

[Mesa-dev] [PATCH 1/2] i965: Change intel_disable_rb_aux_buffer into get_drawbuffer_index().

The bulk of the work in intel_disable_rb_aux_buffer() is finding the drawbuffer index for the given BO. After that, disabling the auxiliary buffers is an easy one liner. This lets us ask whether a texture is also bound as a renderbuffer before making any decisions. We'll use this in the next pat

[Mesa-dev] [PATCH 2/2] i965: Disable auxiliary buffers when there are self-dependencies.

Jason and I investigated several OpenGL CTS failures where the tests bind the same texture for rendering and texturing, at the same time. This has defined results as long as the reads happen before writes, or the regions are non-overlapping. Normally, this just works out. However, CCS can cause p

Re: [Mesa-dev] [PATCH] i965: pass wanted format to intel_miptree_create_for_dri_image

On 10/06/2017 03:00 AM, Jason Ekstrand wrote: On Wed, Oct 4, 2017 at 6:32 AM, Tapani Pälli > wrote: Change b3a44ae7a4 caused regressions on Android where DRI and renderbuffer can disagree on the format being used. This patch removes the colorspace

Re: [Mesa-dev] [PATCH 1/2] anv: fix push descriptors with set > 0

Regardless if what you choose to do with my comments, this patch is Reviewed-by: Jason Ekstrand On Thu, Oct 5, 2017 at 9:01 PM, Jason Ekstrand wrote: > On Thu, Sep 28, 2017 at 5:05 PM, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> When writing to set > 0, we were just wrongl

Re: [Mesa-dev] [PATCH 2/2] anv: fix potential push constant buffer leaks

Oh, hey, I should have read patch 2... That said, I think I like just calling anv_cmd_state_reset a little better. On Thu, Sep 28, 2017 at 5:19 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 29/09/17 01:05, Lionel Landwerlin wrote: > >> Valgrind stats on >> dEQP-VK.pipeline.p

Re: [Mesa-dev] [PATCH 1/2] anv: fix push descriptors with set > 0

On Thu, Sep 28, 2017 at 5:05 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > When writing to set > 0, we were just wrongly writing to set 0. This > commit fixes this by lazily allocating each set as we write to them. > > We didn't go for having them directly into the command buffer

[Mesa-dev] [PATCH] anv/cmd_buffer: Reset state in cmd_buffer_destroy

This ensures that everything gets cleaned up properly. In particular, it fixes a memory leak where we were leaking the push constants structs. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/int

[Mesa-dev] [PATCH] spirv: Don't warn on the ImageCubeArray capability

--- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index a2538d6..5dccbf6 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -2802,6

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On Thu, Oct 5, 2017 at 7:39 PM, Dave Airlie wrote: > On 6 October 2017 at 12:31, Marek Olšák wrote: > > On Fri, Oct 6, 2017 at 4:10 AM, Connor Abbott > wrote: > >> On Thu, Oct 5, 2017 at 10:08 PM, Marek Olšák wrote: > >>> On Fri, Oct 6, 2017 at 3:50 AM, Connor Abbott > wrote: > Why? Whil

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On 6 October 2017 at 12:31, Marek Olšák wrote: > On Fri, Oct 6, 2017 at 4:10 AM, Connor Abbott wrote: >> On Thu, Oct 5, 2017 at 10:08 PM, Marek Olšák wrote: >>> On Fri, Oct 6, 2017 at 3:50 AM, Connor Abbott wrote: Why? While it might technically be legal, always generating an unfused

Re: [Mesa-dev] [PATCH] radv: export KHR_relaxed_block_layout

Ack On October 5, 2017 6:29:07 PM Dave Airlie wrote: From: Dave Airlie This seems to pass all the cts tests it enables. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_d

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On Fri, Oct 6, 2017 at 4:10 AM, Connor Abbott wrote: > On Thu, Oct 5, 2017 at 10:08 PM, Marek Olšák wrote: >> On Fri, Oct 6, 2017 at 3:50 AM, Connor Abbott wrote: >>> Why? While it might technically be legal, always generating an unfused >>> mul+add when the user explicitly requested fma() seems

[Mesa-dev] [PATCH 6/6] i965: call nir_lower_io_to_scalar() at link time for BDW and above

This will allow dead components of varyings to be removed. BDW shader-db results: total instructions in shared programs: 13190730 -> 13108459 (-0.62%) instructions in affected programs: 2110903 -> 2028632 (-3.90%) helped: 14043 HURT: 486 total cycles in shared programs: 541148990 -> 540544072 (-

[Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

We won't split varyings marked as always active because there is no point in doing so. This means we need to mark both sides of the interface as always active otherwise we will have a mismatch and start removing things we shouldn't. --- src/compiler/glsl/link_varyings.cpp | 13 ++--- 1 fil

[Mesa-dev] [PATCH 5/6] nir: add component level support to remove_unused_io_vars()

--- src/compiler/nir/nir_linking_helpers.c | 37 +++--- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c b/src/compiler/nir/nir_linking_helpers.c index 838054e42a4..28141a6ec89 100644 --- a/src/compiler/nir/nir_link

[Mesa-dev] [PATCH 1/6] nir: add glsl_type_is_64bit() to nir_types

From: Timothy Arceri --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 5583bc01620..b0d84aae384 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_t

[Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

This is intended to be called before nir_lower_io() so that we can do some linking optimisations with the results. It can also be used with drivers that don't use nir_lower_io() at all such as RADV. --- src/compiler/nir/nir.h| 2 + src/compiler/nir/nir_lower_io_to_scalar.c |

[Mesa-dev] [PATCH 2/6] nir: add glsl_channel_type() helper

--- src/compiler/nir_types.cpp | 29 + src/compiler/nir_types.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index b0d84aae384..44c4b5d60cf 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/n

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On Thu, Oct 5, 2017 at 10:08 PM, Marek Olšák wrote: > On Fri, Oct 6, 2017 at 3:50 AM, Connor Abbott wrote: >> Why? While it might technically be legal, always generating an unfused >> mul+add when the user explicitly requested fma() seems harsh... > > It's slow on some chips. It doesn't need any

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On Fri, Oct 6, 2017 at 3:50 AM, Connor Abbott wrote: > Why? While it might technically be legal, always generating an unfused > mul+add when the user explicitly requested fma() seems harsh... It's slow on some chips. It doesn't need any other reason. Marek ___

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

Why? While it might technically be legal, always generating an unfused mul+add when the user explicitly requested fma() seems harsh... On Thu, Oct 5, 2017 at 9:32 PM, Marek Olšák wrote: > FYI, if we switch radeonsi to NIR, we are going to disable fma > completely, exact or not. > > Marek > > On W

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

FYI, if we switch radeonsi to NIR, we are going to disable fma completely, exact or not. Marek On Wed, Oct 4, 2017 at 10:04 PM, Dave Airlie wrote: > From: Dave Airlie > > As pointed out by Connor we still need to use fma if nir wants > exact (precise) behaviour. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] radv: export KHR_relaxed_block_layout

From: Dave Airlie This seems to pass all the cts tests it enables. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 833f0ee..7e6fb52 100644 --- a/src/amd/vulkan/

Re: [Mesa-dev] [PATCH] radeonsi: add a drirc workaround for HTILE corruption in ARK: Survival Evolved

DB_META | PS_PARTIAL_FLUSH are sufficient. I'll go with those. Marek On Thu, Oct 5, 2017 at 5:10 PM, Nicolai Hähnle wrote: > Did you test whether a META flush is sufficient? I'm somewhat reminded of > commit 34124e412f00432ba8b3b8d16e3f2168aa596622 ("radeonsi/gfx9: always > flush DB metadata on

Re: [Mesa-dev] [PATCH] i965: pass wanted format to intel_miptree_create_for_dri_image

On Wed, Oct 4, 2017 at 6:32 AM, Tapani Pälli wrote: > Change b3a44ae7a4 caused regressions on Android where DRI and renderbuffer > can disagree on the format being used. This patch removes the colorspace > parameter and instead we pass renderbuffer format. For non-winsys images we > still do srgb

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

Am 06.10.2017 um 00:34 schrieb Marek Olšák: > On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote: >> On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote: >>> On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote: Like Roland, I don't see what's being gained. It's more code everywhere and hard

[Mesa-dev] [PATCH 4/5] radv: Make tess winding order a bit more intuitive.

--- src/amd/vulkan/radv_pipeline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 95a00cb357d..5da27935c2e 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -266,7 +266

[Mesa-dev] [PATCH 1/5] radv: Implement querying the point clipping behavior.

--- src/amd/vulkan/radv_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index aa7fe35d87e..ae9baf590d5 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -866,6 +866,12 @@ void radv_GetPhysi

[Mesa-dev] [PATCH 5/5] radv: Enable VK_KHR_maintenance2 extension.

--- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index ae9baf590d5..833f0eed135 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -178,6 +178,10 @@ static const VkExten

[Mesa-dev] [PATCH 2/5] radv: Disable usage checks in metadata for images with extended usage data.

The app can extend the usage, so knowing that the usage is limitied does not help us here. --- src/amd/vulkan/radv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index c017bf89553..f0645279aa1 100644 --- a/sr

[Mesa-dev] [PATCH 3/5] radv: Allow setting the domain origin in tess.

--- src/amd/vulkan/radv_pipeline.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 5800f297074..95a00cb357d 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -1542,

[Mesa-dev] [Bug 103031] [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0

https://bugs.freedesktop.org/show_bug.cgi?id=103031 --- Comment #2 from Vinson Lee --- (In reply to Roland Scheidegger from comment #1) > Created attachment 134554 [details] [review] > patch accounting for llvm nuked pabs intrinsics > > Does this patch work? > I'm also changing the non-intrinsic

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote: > On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote: >> On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote: >>> Like Roland, I don't see what's being gained. It's more code >>> everywhere and harder to read the TGSI directly. >> >> Harder to read

Re: [Mesa-dev] [PATCH v4 12/12] anv: enable VK_KHR_sampler_ycbcr_conversion

Two trivial comments which you can take or leave below. With that, 1-10 and 12 are Reviewed-by: Jason Ekstrand Once we sort out patch 11, we should be good to land. Thanks for the good work! --Jason On Thu, Oct 5, 2017 at 9:30 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: >

Re: [Mesa-dev] [PATCH] meson: generate builddir/src/amd/vulkan/dev_icd.json

I didn't add these since I didn't know if they'd be useful given that meson doesn't generate a /lib, but this looks correct. Reviewed-by: Dylan Baker Quoting Bas Nieuwenhuizen (2017-10-05 12:34:51) > --- > src/amd/vulkan/Makefile.am | 2 +- > src/amd/vulkan/dev_icd.json.in | 2 +- > src/amd

[Mesa-dev] [PATCH v3 07/12] meson: build glx

This gets GLX and the loader building. The resulting GLX and i965 have been tested on piglit and seem to work fine. This patch leaves a lot of todo's in it's wake, GLX is quite complicated, and the build options involved are many, and the goal at the moment is to get dri and gallium drivers buildin

Re: [Mesa-dev] [PATCH v2 09/12] meson: build gbm

Quoting Eric Anholt (2017-10-05 12:43:47) > Dylan Baker writes: > > > This doesn't include egl support, just dri support. > > > > +install_headers('main/gbm.h') > > + > > +pkg.generate( > > + name : 'gbm', > > + filebase : 'gbm', > > + description : 'Mesa gbm library', > > + version : meson

Re: [Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

Quoting Eric Anholt (2017-10-05 12:57:41) > Dylan Baker writes: > > > This gets pretty much the entire classic tree building, as well as > > i965, including the various glapis. There are some workarounds for bugs > > that are fixed in meson 0.43.0, which is due out on October 8th. > > > > I have

Re: [Mesa-dev] [PATCH v2 07/12] meson: build glx

Quoting Eric Anholt (2017-10-05 12:18:39) > Dylan Baker writes: > > > This gets GLX and the loader building. The resulting GLX and i965 have > > been tested on piglit and seem to work fine. This patch leaves a lot of > > todo's in it's wake, GLX is quite complicated, and the build options > > inv

Re: [Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

Dylan Baker writes: > This gets pretty much the entire classic tree building, as well as > i965, including the various glapis. There are some workarounds for bugs > that are fixed in meson 0.43.0, which is due out on October 8th. > > I have tested this with piglit using glx. > > v2: - fix typo "v

Re: [Mesa-dev] [PATCH v2 10/12] meson: build classic swrast

Dylan Baker writes: > This adds support for building the classic swrast implementation. This > driver has been tested with glxinfo and glxgears. > > Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ me

Re: [Mesa-dev] [PATCH v2 09/12] meson: build gbm

Dylan Baker writes: > This doesn't include egl support, just dri support. > +install_headers('main/gbm.h') > + > +pkg.generate( > + name : 'gbm', > + filebase : 'gbm', > + description : 'Mesa gbm library', > + version : meson.project_version(), > + libraries : libgbm, > + #libraries_priva

[Mesa-dev] [PATCH] meson: generate builddir/src/amd/vulkan/dev_icd.json

--- src/amd/vulkan/Makefile.am | 2 +- src/amd/vulkan/dev_icd.json.in | 2 +- src/amd/vulkan/meson.build | 7 +++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am index 438872bbb48..19ec3f47f74 100644 --- a/src/amd/v

Re: [Mesa-dev] [PATCH v2 08/12] meson: Add support for configuring dri drivers directory.

Dylan Baker writes: > v2: - drop with_ from dri_drivers_path variable (Eric A) > > Signed-off-by: Dylan Baker > --- > meson.build | 6 ++ > meson_options.txt| 2 ++ > src/glx/meson.build | 2 +- > src/mesa/drivers/dri/meson.build | 2 +- > 4

Re: [Mesa-dev] [PATCH v2 07/12] meson: build glx

Dylan Baker writes: > This gets GLX and the loader building. The resulting GLX and i965 have > been tested on piglit and seem to work fine. This patch leaves a lot of > todo's in it's wake, GLX is quite complicated, and the build options > involved are many, and the goal at the moment is to get d

Re: [Mesa-dev] [PATCH v2 01/12] make: change include to work for meson

Quoting Emil Velikov (2017-10-05 11:17:06) > On 5 October 2017 at 18:12, Dylan Baker wrote: > > Meson expects you to include the generated target in another target's > > sources, and it will generate the include directives for you, so change > > the source file and add the generated glx builddir t

Re: [Mesa-dev] [PATCH 4/7] Travis: add binutils 2.26 for a few more LLVM 3.9 builds

On Thu, 2017-10-05 at 17:46 +0100, Emil Velikov wrote: > On 5 October 2017 at 17:28, Jan Vesely wrote: > > On Thu, 2017-10-05 at 11:19 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Otherwise we error out at link stage as follows: > > > > > > /usr/lib/llvm-3.9/lib/libLLVMAMDGPU

Re: [Mesa-dev] [PATCH 10/10] radv: convert all COMPUTE operations to the RADV_META_SAVE_XXX flags

Besides patch 4, if you change the RADV_META_SAVE_{COMPUTE,GRAPHICS} to add _PIPELINE at the end of them, Reviewed-by: Bas Nieuwenhuizen On Tue, Oct 3, 2017 at 8:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.c| 31 -

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

Quoting Emil Velikov (2017-10-05 11:26:40) > On 5 October 2017 at 18:12, Dylan Baker wrote: > > This has the same problem as the previous commit, generated headers and > > hardcoded paths. > > > Something's strange here. You already have the "generic" > > AM_CPPFLAGS = \ >... \ >-I$(top_b

[Mesa-dev] [PATCH] i965/fs: Extend the live ranges of VGRFs which leave loops

No Shader-db changes. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/compiler/brw_fs_live_variables.cpp | 55 1 file changed, 55 insertions(+) diff --git a/src/intel/compiler/brw_fs_live_variables.cpp b/src/intel/compiler/brw_fs_live_variables.cpp index c449672

Re: [Mesa-dev] [PATCH v2 05/12] meson: de-tabularize meson_options.txt

Dylan Baker writes: > This ends up being unworkable as more options get added, and with > description wrapped onto a new line it doesn't improve readability > anyway. > > Signed-off-by: Dylan Baker Patch 1-5 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH] vc4: Don't advertise tiled dmabuf modifiers if we can't use them

Derek Foreman writes: > If the DRM_VC4_GET_TILING ioctl isn't present then we can't tell > if a dmabuf bo is tiled or linear, so will always assume it's > linear. > > By not advertising tiled formats in this situation we ensure the > assumption is correct. > > This fixes a bug where most attempts

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

On 5 October 2017 at 18:12, Dylan Baker wrote: > This has the same problem as the previous commit, generated headers and > hardcoded paths. > Something's strange here. You already have the "generic" AM_CPPFLAGS = \ ... \ -I$(top_builddir)/src/mapi \ -I$(top_srcdir)/src/mapi ... at the t

Re: [Mesa-dev] [PATCH v2] vc4: Mark BOs as purgeable when they enter the BO cache

Boris Brezillon writes: > This patch makes use of the DRM_IOCTL_VC4_GEM_MADVISE ioctl to mark all > BOs placed in the mesa BO cache as purgeable so that the system can > reclaim this memory under memory pressure. > > Signed-off-by: Boris Brezillon > --- > Hello, > > Note that this series depends

Re: [Mesa-dev] [PATCH v2 01/12] make: change include to work for meson

On 5 October 2017 at 18:12, Dylan Baker wrote: > Meson expects you to include the generated target in another target's > sources, and it will generate the include directives for you, so change > the source file and add the generated glx builddir to the autotools > include to make that work. > Whil

Re: [Mesa-dev] [PATCH v2 12/12] travis: don't run ninja test for meson

Quoting Emil Velikov (2017-10-05 10:59:04) > On 5 October 2017 at 18:12, Dylan Baker wrote: > > > - env: > > - LABEL="meson loaders/classic DRI" > > - BUILD=meson > > -- MESON_OPTIONS="-Dbuild-tests=true -Dvulkan-drivers=" > > +- MESON_OPTIONS="-Dvulkan-driv

Re: [Mesa-dev] [PATCH 3/7] configure.ac: rework llvm libs handling for 3.9+

On 5 October 2017 at 18:47, Tobias Droste wrote: > Am Donnerstag, 5. Oktober 2017, 12:19:05 CEST schrieb Emil Velikov: >> From: Emil Velikov >> >> Earlier versions need different quirks, but as of LLVM 3.9 llvm-config >> provides --link-shared/link-static toggles. >> >> The output of which seems

[Mesa-dev] [PATCH 4/5] gallium: Expose a PIPE_CAP_TILE_RASTER_ORDER on vc4.

Because vc4 can control the order that tiles are rasterized in, we can use it to implement overlapping blits using normal drawing and GL_ARB_texture_barrier, as long as we can tell the kernel what order to render the tiles in. v2: Fix on the simulator. v3: Add the cap (disabled) to other drivers,

[Mesa-dev] [PATCH 3/5] broadcom/vc4: Implement GL_ARB_texture_barrier.

Improves x11perf -copywinwin100 from ~2000/sec to ~4700/sec. More importantly, this is a prerequisite for the new GL_MESA_tile_raster_order extension. --- src/gallium/drivers/vc4/vc4_context.c | 11 +++ src/gallium/drivers/vc4/vc4_screen.c | 2 +- 2 files changed, 12 insertions(+), 1 de

[Mesa-dev] [PATCH 5/5] mesa: Implement a new GL_MESA_tile_raster_order extension.

The intent is to use this extension on vc4 to allow X11 to do overlapping CopyArea() within a pixmap without first blitting the pixmap to a temporary. With associated glamor patches, improves x11perf -copywinwin100 performance on a Raspberry Pi 3 from ~4700/sec to ~5130/sec, and is an even larger

[Mesa-dev] [PATCH 0/5] GL_MESA_tile_raster_order

I think the extension spec is about ready to get merged to the registry: https://github.com/KhronosGroup/OpenGL-Registry/pull/105 so here's an updated version of my tile_raster_order implementation. The kernel side has been merged, so this series all that's left for a huge improvement in uncompos

[Mesa-dev] [PATCH 1/5] docs: Fix a typo in the old MESA_program_debug spec.

Noticed that we had two 0x8bb4 in the spec while grepping to find an open slot in the MESA enums set. gl.xml had the right value. --- docs/specs/OLD/MESA_program_debug.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/OLD/MESA_program_debug.spec b/docs/specs/OLD

[Mesa-dev] [PATCH 2/5] docs: Update the list of used MESA GL enums.

--- docs/specs/enums.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/specs/enums.txt b/docs/specs/enums.txt index 222adbc72e71..00d808483a43 100644 --- a/docs/specs/enums.txt +++ b/docs/specs/enums.txt @@ -63,6 +63,16 @@ GL_MESAX_texture_stack: GL_TEXTURE_1D_STACK_

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote: > On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote: >> Like Roland, I don't see what's being gained. It's more code >> everywhere and harder to read the TGSI directly. > > Harder to read the "IMM" string in the operand? Yeah. You see a KILL_IF

Re: [Mesa-dev] [PATCH v2 12/12] travis: don't run ninja test for meson

On 5 October 2017 at 18:12, Dylan Baker wrote: > - env: > - LABEL="meson loaders/classic DRI" > - BUILD=meson > -- MESON_OPTIONS="-Dbuild-tests=true -Dvulkan-drivers=" > +- MESON_OPTIONS="-Dvulkan-drivers=" You add the -Dbuild-tests=true with 11/12 only to r

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

On Wed, Oct 4, 2017 at 9:29 PM, Jason Ekstrand wrote: > On Wed, Oct 4, 2017 at 3:11 PM, Anuj Phogat wrote: >> >> On Mon, Oct 2, 2017 at 7:46 PM, Jason Ekstrand >> wrote: >> > On Mon, Oct 2, 2017 at 4:08 PM, Anuj Phogat >> > wrote: >> >> >> >> Cc: mesa-sta...@lists.freedesktop.org >> >> Signed-o

Re: [Mesa-dev] [PATCH] egl: Simplify the "driver" interface

On 5 October 2017 at 17:42, Adam Jackson wrote: > "Driver" isn't a great word for what this layer is, it's effectively a > build-time choice about what OS you're targeting. Despite that both of > the extant backends totally ignore the display argument, the old code > would only set up the backend

[Mesa-dev] [PATCH] vc4: Don't advertise tiled dmabuf modifiers if we can't use them

If the DRM_VC4_GET_TILING ioctl isn't present then we can't tell if a dmabuf bo is tiled or linear, so will always assume it's linear. By not advertising tiled formats in this situation we ensure the assumption is correct. This fixes a bug where most attempts to render a gl wayland client under w

Re: [Mesa-dev] [PATCH] egl: Simplify the "driver" interface

On Thu, 2017-10-05 at 10:17 -0700, Eric Anholt wrote: > Adam Jackson writes: > > > "Driver" isn't a great word for what this layer is, it's effectively a > > build-time choice about what OS you're targeting. Despite that both of > > the extant backends totally ignore the display argument, the old

Re: [Mesa-dev] [PATCH 3/7] configure.ac: rework llvm libs handling for 3.9+

Am Donnerstag, 5. Oktober 2017, 12:19:05 CEST schrieb Emil Velikov: > From: Emil Velikov > > Earlier versions need different quirks, but as of LLVM 3.9 llvm-config > provides --link-shared/link-static toggles. > > The output of which seems to be reliable - looking at LLVM 3.9, 4.0 and > 5.0. >

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote: > Like Roland, I don't see what's being gained. It's more code > everywhere and harder to read the TGSI directly. Harder to read the "IMM" string in the operand? "more code everywhere"? 21 files changed, 22 insertions(+), 200 deletions(-) This

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 5 October 2017 at 18:11, Tom Stellard wrote: > On 10/05/2017 08:40 AM, Emil Velikov wrote: >> On 5 October 2017 at 16:16, Tom Stellard wrote: >>> On 10/05/2017 06:33 AM, Michel Dänzer wrote: On 05/10/17 12:19 PM, Emil Velikov wrote: > From: Emil Velikov > > A while back Miche

Re: [Mesa-dev] [PATCH 1/7] configure.ac: remove no longer necessary llvm-config --libs check

Reviewed-by: Tobias Droste Am Donnerstag, 5. Oktober 2017, 12:19:03 CEST schrieb Emil Velikov: > From: Emil Velikov > > Prior to the refactor/cleanup by Tobias one could add an invalid > component to LLVM_COMPONENTS. > > Since that's no longer the case we can drop the current check. > > Cc: T

Re: [Mesa-dev] [PATCH 2/7] configure.ac: factor out detection for old and buggy llvm

Reviewed-by: Tobias Droste Am Donnerstag, 5. Oktober 2017, 12:19:04 CEST schrieb Emil Velikov: > From: Emil Velikov > > As of LLVM 3.9 one could use consistent ways to handle the component. > Factor out the current handling, as it will be used for older versions. > > Cc: mesa-sta...@lists.free

Re: [Mesa-dev] [PATCH 6/7] configure.ac: add missing LLVM components for OpenCL

Reviewed-by: Tobias Droste Am Donnerstag, 5. Oktober 2017, 12:19:08 CEST schrieb Emil Velikov: > From: Emil Velikov > > Coverage and LTO seems to be hard requirements for Clang, while > coroutines is needed as of LLVM/Clang 4.0. > > Mark the last one as "optional" so we handle every case. > >

Re: [Mesa-dev] [PATCH] egl: Simplify the "driver" interface

Adam Jackson writes: > "Driver" isn't a great word for what this layer is, it's effectively a > build-time choice about what OS you're targeting. Despite that both of > the extant backends totally ignore the display argument, the old code > would only set up the backend relative to a display. > >

Re: [Mesa-dev] [PATCH 5/7] configure.ac: add llvm_add_optional_component helper

Am Donnerstag, 5. Oktober 2017, 12:19:07 CEST schrieb Emil Velikov: > From: Emil Velikov > > We want to add "optional" components, which have been added with later > LLVM versions. > > One such in-tree example is inteljitevents. Others are to follow > shortly. > > Cc: mesa-sta...@lists.freedesk

[Mesa-dev] [PATCH v2 11/12] travis: Add a travis profile for meson dri drivers

Signed-off-by: Dylan Baker --- .travis.yml | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 19fd6acf3b9..ece9b5feff3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -396,7 +396,7 @@ matrix: - env: - LABEL="meson Vulka

[Mesa-dev] [PATCH v2 08/12] meson: Add support for configuring dri drivers directory.

v2: - drop with_ from dri_drivers_path variable (Eric A) Signed-off-by: Dylan Baker --- meson.build | 6 ++ meson_options.txt| 2 ++ src/glx/meson.build | 2 +- src/mesa/drivers/dri/meson.build | 2 +- 4 files changed, 10 insertions(+), 2 del

[Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

This gets pretty much the entire classic tree building, as well as i965, including the various glapis. There are some workarounds for bugs that are fixed in meson 0.43.0, which is due out on October 8th. I have tested this with piglit using glx. v2: - fix typo "vaule" -> "value" - use gtest d

[Mesa-dev] [PATCH v2 03/12] meson: add nir_linking_helpers.c to libnir

This was missed in a rebase, and doesn't affect radv or anv, only i965. Signed-off-by: Dylan Baker --- src/compiler/nir/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build index 8a85d119530..faa69e3aa30 100644 --- a/src/comp

[Mesa-dev] [PATCH v2 12/12] travis: don't run ninja test for meson

This pulls in tons of extra dependencies because the tests are not properly guarded. Signed-off-by: Dylan Baker --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index ece9b5feff3..d16d6b3c25a 100644 --- a/.travis.yml +++ b/.travi

[Mesa-dev] [PATCH v2 10/12] meson: build classic swrast

This adds support for building the classic swrast implementation. This driver has been tested with glxinfo and glxgears. Signed-off-by: Dylan Baker --- meson.build | 2 ++ meson_options.txt | 2 +- src/mesa/drivers/dri/meson.build

[Mesa-dev] [PATCH v2 05/12] meson: de-tabularize meson_options.txt

This ends up being unworkable as more options get added, and with description wrapped onto a new line it doesn't improve readability anyway. Signed-off-by: Dylan Baker --- meson_options.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/meson_options.txt b/meson

[Mesa-dev] [PATCH v2 09/12] meson: build gbm

This doesn't include egl support, just dri support. v2: - when gbm is set to 'auto', only build if a dri driver is also enabled - Fix conditional to check for x11 modules with vulkan as well as with dri drivers Signed-off-by: Dylan Baker --- meson.build | 17 ++

[Mesa-dev] [PATCH v2 01/12] make: change include to work for meson

Meson expects you to include the generated target in another target's sources, and it will generate the include directives for you, so change the source file and add the generated glx builddir to the autotools include to make that work. Signed-off-by: Dylan Baker --- src/glx/tests/Makefile.am

[Mesa-dev] [PATCH v2 07/12] meson: build glx

This gets GLX and the loader building. The resulting GLX and i965 have been tested on piglit and seem to work fine. This patch leaves a lot of todo's in it's wake, GLX is quite complicated, and the build options involved are many, and the goal at the moment is to get dri and gallium drivers buildin

[Mesa-dev] [PATCH v2 04/12] meson: only require libelf if building radv

And add a todo about clover, r600, and radeonsi, which also need libelf. Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5de64acefd6..97809e98289 100644 --- a/meson.build +++ b/meson.build @@ -288,7 +2

[Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

This has the same problem as the previous commit, generated headers and hardcoded paths. Signed-off-by: Dylan Baker --- src/mapi/Makefile.am| 2 ++ src/mapi/shared-glapi/tests/check_table.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mapi/M

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 10/05/2017 08:40 AM, Emil Velikov wrote: > On 5 October 2017 at 16:16, Tom Stellard wrote: >> On 10/05/2017 06:33 AM, Michel Dänzer wrote: >>> On 05/10/17 12:19 PM, Emil Velikov wrote: From: Emil Velikov A while back Michel reported that LLVM has symbol versioning to avoid

Re: [Mesa-dev] [PATCH v3 10/12] anv: add nir lowering pass for ycrcb textures

Quoting Lionel Landwerlin (2017-10-05 09:37:39) > On 05/10/17 17:36, Dylan Baker wrote: > > Quoting Lionel Landwerlin (2017-10-04 10:34:55) > > This pass implements all the implicit conversions required by the > VK_KHR_sampler_ycbcr_conversion specification. > > It al

Re: [Mesa-dev] [PATCH 4/7] Travis: add binutils 2.26 for a few more LLVM 3.9 builds

On 5 October 2017 at 17:28, Jan Vesely wrote: > On Thu, 2017-10-05 at 11:19 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Otherwise we error out at link stage as follows: >> >> /usr/lib/llvm-3.9/lib/libLLVMAMDGPUCodeGen.a(R600OptimizeVectorRegisters.cpp.o): >> unrecognized relocation (0x

Re: [Mesa-dev] [PATCH v3 10/12] anv: add nir lowering pass for ycrcb textures

On 05/10/17 17:36, Dylan Baker wrote: Quoting Lionel Landwerlin (2017-10-04 10:34:55) This pass implements all the implicit conversions required by the VK_KHR_sampler_ycbcr_conversion specification. It also inserts plane sources onto sampling instructions that we then let the pipeline layout pa

[Mesa-dev] [PATCH] egl: Simplify the "driver" interface

"Driver" isn't a great word for what this layer is, it's effectively a build-time choice about what OS you're targeting. Despite that both of the extant backends totally ignore the display argument, the old code would only set up the backend relative to a display. That causes problems! One problem

Re: [Mesa-dev] [Mesa-stable] [PATCH 7/7] configure.ac: static link LLVM by default

On 5 October 2017 at 17:34, Dylan Baker wrote: > This is neither a for or against, but I thought I'd add this to the > discussion. > > Currently meson only supports using LLVM as a shared library, so this is > going to > make the meson build and the autotools build do different things by default

[Mesa-dev] [PATCH v4 07/12] anv: add new formats KHR_sampler_ycbcr_conversion

Adding new downsampling factors for each planes. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c| 158 -- src/intel/vulkan/anv_private.h| 10 +++ src/intel/vulkan/vk_format_info.h | 27 +++ 3 files changed, 189 insertions(+),

[Mesa-dev] [PATCH v4 03/12] isl: check whether a format is rgb if colorspace is yuv

Suggested by Chad. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 98de4c0f57f..e3acb0ec280 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -1512,6 +1512,8 @@ enum isl_for

[Mesa-dev] [Bug 77596] [r600g] random and reproducible crash in Left 4 Dead 2 (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=77596 mirh changed: What|Removed |Added CC||m...@protonmail.ch --- Comment #9 from mirh ---

  1   2   >