Quoting Emil Velikov (2017-10-05 11:17:06) > On 5 October 2017 at 18:12, Dylan Baker <dy...@pnwbakers.com> wrote: > > Meson expects you to include the generated target in another target's > > sources, and it will generate the include directives for you, so change > > the source file and add the generated glx builddir to the autotools > > include to make that work. > > > While correct, all of this is orthogonal to the issue. > > > Traversing back through includes is bad idea and should be avoided. > In the case here - indirect_size.h is located in the build directory > $(top_builddir)/src/glx/. > > Add the include and adjust the include path of the file. > > > > -I$(top_srcdir)/src/glx \ > > + -I$(top_builddir)/src/glx \ > builddir before srcdir, > > > With the above fix and alternative commit message (feel free to reuse > as much or as little or my wording): > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > Thanks > Emil
Done. I pulled in your message too, and cut the meson message down to small aside. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
