Re: [Mesa-dev] [PATCH 2/2] Revert "st/va: add enviromental variable to disable interlace"

On 24/08/17 06:41 AM, Leo Liu wrote: > This reverts commit 10dec2de2d9f568675d66d736b48701fa26f7b50. Every revert commit should have justification in the commit log. In this case, I imagine it could be something like "The environment variable is no longer needed with the previous change". -- Ea

Re: [Mesa-dev] [PATCH 1/2] st/va: move YUV content to deinterlaced buffer when reallocated for encoder

Am 23.08.2017 um 23:41 schrieb Leo Liu: Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 40 + 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c

Re: [Mesa-dev] [PATCH] radv: fix resolve subpass restoring in compute resolve path.

How about not setting the subpass in the first place? It is a compute shader ... On Thu, Aug 24, 2017, at 02:26, Dave Airlie wrote: > From: Dave Airlie > > We need to restore the subpass before we do the fast clear flush. > > found while hacking around on vega. > > Fixes: 19be95f71 (radv: add

Re: [Mesa-dev] [PATCH] radv: don't crash if we have no framebuffer

Reviewed-by: Bas Nieuwenhuizen Even though this is only a partial solution. On Mon, Aug 21, 2017, at 09:24, Dave Airlie wrote: > From: Dave Airlie > > Recording secondaries with no framebuffer attachment may > make this happen, though this might not be the complete solution. > > (esp if someo

[Mesa-dev] [PATCH 2/2] anv: wire up anv_perf_warn macro to do debug reporting

Signed-off-by: Tapani Pälli --- some example output from test application running on HSW: PERFORMANCE WARNING: [anv] Code 0 (loc 272) (type VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT) : vulkan/anv_image.c: Implement gen7 HiZ src/intel/vulkan/anv_device.c | 3 +- src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

Patch adds required functionality for extension to manage a list of application provided callbacks and handle debug reporting from driver and application side. Signed-off-by: Tapani Pälli --- src/intel/Makefile.sources | 1 + src/intel/vulkan/anv_debug_report.c | 133 +

[Mesa-dev] [PATCH 0/2] VK_EXT_debug_report extension + anv_perf_warn

Hi; Here's implementation for VK_EXT_debug_report extension and a patch to wire up anv_perf_warn macro to use debug reporting. If this seems good approach plan is would be to start wiring more like vk_errorf, vk_error and spirv error reporting. Also maybe add more info type messages where we'd lik

Re: [Mesa-dev] [PATCH v2] i965: Issue performance warnings when growing the program cache

On Wednesday, August 23, 2017 1:58:32 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-08-22 21:47:54) > > This involves a bunch of unnecessary copying, a batch flush, and > > state re-emission. > > > --- > > src/mesa/drivers/dri/i965/brw_program_cache.c | 3 +++ > > 1 file changed, 3 i

[Mesa-dev] [PATCH] nv50/ir: properly set sType for TXF ops to U32

All of the coordinates and LOD args are integers for TXF. This mostly doesn't matter, except for converting into a levelZero=true operation by removing an explicit zero LOD. For the comparison against zero to work properly, the sType of the instruction has to be set correctly. Fixes: KHR-GL45.robu

Re: [Mesa-dev] [PATCH v2 1/5] util/disk_cache: rename mesa cache dir and introduce cache versioning

On 08/23/2017 06:23 PM, Matt Turner wrote: On Wed, Aug 23, 2017 at 2:32 AM, Timothy Arceri wrote: Steam is already analysing cache items What does this mean? Steam will attempt to download compiled shaders for your GPU and version of Mesa, or upload the shaders you compile locally if they'

Re: [Mesa-dev] [PATCH 1/2] glx: add support for GLX_ARB_create_context_no_error

On 04/08/17 04:26, Grigori Goronzy wrote: Hi, there also is a patch needed to make this work for Xorg on the xorg-devel list as well as preliminary piglit test to verify the functionality on the piglit list. Hi Emil, Any chance you can take a look at this series? I feel you are much more f

Re: [Mesa-dev] [PATCH 10/10] radeonsi: add an assertion that only two-dimensional constant references are used

On 24/08/17 02:41, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index f02fc9e9ba2..c445c49d2aa 100644 --- a/src/

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

On 08/23/2017 11:09 AM, Jason Ekstrand wrote: > On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick > wrote: > > Reviewed-by: Ian Romanick > > > Did you submit a CTS bug? > > > No, I didn't. It does get some coverage through

Re: [Mesa-dev] [PATCH v2 1/5] util/disk_cache: rename mesa cache dir and introduce cache versioning

On Wed, Aug 23, 2017 at 2:32 AM, Timothy Arceri wrote: > Steam is already analysing cache items What does this mean? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/5] util/disk_cache: rename mesa cache dir and introduce cache versioning

On 23/08/17 21:35, Vedran Miletić wrote: On 08/23/2017 08:32 AM, Timothy Arceri wrote: Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying structural changes to cache entries earlier so the only way to do so is to rename the cache dire

[Mesa-dev] [PATCH V3 1/5] util/disk_cache: rename mesa cache dir and introduce cache versioning

Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying structural changes to cache entries earlier so the only way to do so is to rename the cache directory. Since we are renaming it we take the opportunity to give the directory a more mean

Re: [Mesa-dev] [PATCH 3/3] mesa: remove duplicate assignments in bind_xfb_buffers()

2-3: Reviewed-by: Timothy Arceri Honestly not sure about the first patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 11/11] radv: Expose VK_KHX_multiview.

On 24 August 2017 at 06:51, Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_device.c | 17 + > src/amd/vulkan/radv_pipeline.c | 1 + > 2 files changed, 18 insertions(+) I've posted some comments on a couple of the patches, with those investigated, Reviewed-by: Dave Airli

Re: [Mesa-dev] [PATCH 10/11] radv: Implement multiview draws.

On 24 August 2017 at 06:51, Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_cmd_buffer.c | 132 > ++- > src/amd/vulkan/radv_private.h| 1 + > 2 files changed, 105 insertions(+), 28 deletions(-) > This looks like it has a few more candidate for for_

Re: [Mesa-dev] [PATCH] radeonsi: do not assert when reserving bindless slot 0

Hi Samuel, do you want to fully remove the assert or should this be something the kind of MAYBE_UNUSED unsigned res = util_idalloc_alloc(&sctx->bindless_used_slots); assert(res != 0); --Michael -Ursprüngliche Nachricht- Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Au

Re: [Mesa-dev] [PATCH 07/11] radv: Add multiview clears.

On 24 August 2017 at 06:51, Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_cmd_buffer.c | 1 + > src/amd/vulkan/radv_meta_clear.c | 65 > > src/amd/vulkan/radv_private.h| 1 + > 3 files changed, 48 insertions(+), 19 deletions(-) > > diff --git

[Mesa-dev] [PATCH] radv: fix resolve subpass restoring in compute resolve path.

From: Dave Airlie We need to restore the subpass before we do the fast clear flush. found while hacking around on vega. Fixes: 19be95f71 (radv: add subpass resolve compute path) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_resolve_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #16 from Bruce Cherniak --- Created attachment 133732 --> https://bugs.freedesktop.org/attachment.cgi?id=133732&action=edit Updated swr patch to fix msaa once new_patch_to_try has been applied. Here's a patch that fixes the MSAA o

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 Bruce Cherniak changed: What|Removed |Added Attachment #133726|0 |1 is obsolete|

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [PATCH] i965: Simplify MOCS mashing in genX_state_upload.c.

Instead of having a proliferation of generation checks and MOCS values, we can just #define MOCS_ALL to the generation-specific value for "use as many caches as possible" and use that in various places. This should make it easier to change MOCS values, as there are fewer places that need updating.

Re: [Mesa-dev] [PATCH] i965: Do not store SRC after 0 on component control.

On Wed, Aug 23, 2017 at 2:59 PM, Rafael Antognolli wrote: > The PRM SKL-Vol 2b-05.16 says: > >"Within a VERTEX_ELEMENT_STATE structure, if a Component Control >field is set to something other than VFCOMP_STORE_SRC, no >higher-numbered Component Control fields may be set to >VFCOMP_

Re: [Mesa-dev] [PATCH] i965: Do not store SRC after 0 on component control.

Assuming Jenkins is happy with it (both Vulkan and GL), Reviewed-by: Jason Ekstrand On Wed, Aug 23, 2017 at 2:59 PM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > The PRM SKL-Vol 2b-05.16 says: > >"Within a VERTEX_ELEMENT_STATE structure, if a Component Control >field is set

[Mesa-dev] [PATCH] i965: Do not store SRC after 0 on component control.

The PRM SKL-Vol 2b-05.16 says: "Within a VERTEX_ELEMENT_STATE structure, if a Component Control field is set to something other than VFCOMP_STORE_SRC, no higher-numbered Component Control fields may be set to VFCOMP_STORE_SRC. In other words, only trailing components can be set to s

Re: [Mesa-dev] [PATCH] anv,i965: Move CS shared lowering into anv

Reviewed-by: Jordan Justen On 2017-08-23 14:00:29, Jason Ekstrand wrote: > Right now, OpenGL uses the GLSL lowering for shared variables and anv > uses NIR to lower them. For a long time, we've done this weird thing > where we do the NIR lowering unconditionally and then add the SLM sizes > from

[Mesa-dev] [PATCH 1/2] st/va: move YUV content to deinterlaced buffer when reallocated for encoder

Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 40 + 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 47e63d3b30..3c5eb5de97 100644 --- a/sr

[Mesa-dev] [PATCH 2/2] Revert "st/va: add enviromental variable to disable interlace"

This reverts commit 10dec2de2d9f568675d66d736b48701fa26f7b50. --- src/gallium/state_trackers/va/surface.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c index b116fc3f27..67773cf76a 100644 --- a/src/gallium/

[Mesa-dev] [PATCH] anv,i965: Move CS shared lowering into anv

Right now, OpenGL uses the GLSL lowering for shared variables and anv uses NIR to lower them. For a long time, we've done this weird thing where we do the NIR lowering unconditionally and then add the SLM sizes from the two together. This works because one of them will always be 0 but it's a bit

[Mesa-dev] [PATCH 11/11] radv: Expose VK_KHX_multiview.

--- src/amd/vulkan/radv_device.c | 17 + src/amd/vulkan/radv_pipeline.c | 1 + 2 files changed, 18 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 9bdad6ad6fd..9174562b1bf 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulka

[Mesa-dev] [PATCH 08/11] ac/nir: Add shader support for multiviews.

It uses an user SGPR to pass the view index to the shaders, except for the fragment shader where we use layer=view (which comes in handy when we want to do the NV ext that allows us to execute pre-FS stages once instead of per view). --- src/amd/common/ac_nir_to_llvm.c | 38 +++

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #15 from Marcin Gałązka --- @Gert - great catch! It seems that Steam provided via official Ubuntu/Canonical repos depends on libtxc-dxtn-s2tc:i386 only so one need to install libtxc-dxtn-s2tc:amd64 manually. See https://bugs.launchpa

[Mesa-dev] [PATCH 10/11] radv: Implement multiview draws.

--- src/amd/vulkan/radv_cmd_buffer.c | 132 ++- src/amd/vulkan/radv_private.h| 1 + 2 files changed, 105 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index ed11a4aa35e..4960bdf758a 100644

[Mesa-dev] [PATCH 06/11] radv: Store multiview info in renderpass.

--- src/amd/vulkan/radv_pass.c| 25 - src/amd/vulkan/radv_private.h | 3 +++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c index 17eff3937ac..a52dae39d93 100644 --- a/src/amd/vulkan/radv_pass.c ++

[Mesa-dev] [PATCH 09/11] radv: Implement determining the has_multiview_view_index key.

--- src/amd/vulkan/radv_pipeline.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 96917814e56..60740c58c2e 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline

[Mesa-dev] [PATCH 04/11] radv: Use 0 for the layer id if the vertex shader does not export it.

To use when we have e.g. input attachments, but there is no layer export in the previous shader and hence no layered rendering. --- src/amd/vulkan/radv_pipeline.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipelin

[Mesa-dev] [PATCH 05/11] ac/nir: Make shader key a struct.

Some bits can be passed to almost every shader, and I don't like adding 5 variables. --- src/amd/common/ac_nir_to_llvm.h | 14 -- src/amd/vulkan/radv_pipeline.c | 26 +- src/amd/vulkan/radv_pipeline_cache.c | 2 +- src/amd/vulkan/radv_private.h

[Mesa-dev] [PATCH 02/11] ac/nir: Determine if input attachments are used in the info pass.

--- src/amd/common/ac_shader_info.c | 11 ++- src/amd/common/ac_shader_info.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index 8668c4c3446..ca59965e2db 100644 --- a/src/amd/common/ac_shader_info.c

[Mesa-dev] [PATCH 07/11] radv: Add multiview clears.

--- src/amd/vulkan/radv_cmd_buffer.c | 1 + src/amd/vulkan/radv_meta_clear.c | 65 src/amd/vulkan/radv_private.h| 1 + 3 files changed, 48 insertions(+), 19 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 01/11] ac/nir: Cast sources of integer ops to int.

The int32->float semantic conversion got dropped in a testcase, because the src was already float. On closer inspection I decided to add a few more casts for integer op operands to be safe too. Cc: 17.2 --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 16 insertions(+)

[Mesa-dev] [PATCH 03/11] ac/nir: Implement input attachments with layered rendering.

--- src/amd/common/ac_nir_to_llvm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f0120a984f8..90406e88dfb 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH v2 1/2] gallivm: correct channel shift logic on big endian

Hi, Just a quick note... > From: Ray Strode > > lp_build_fetch_rgba_soa fetches a texel from a texture. > Part of that process involves first gathering the element > together from memory into a packed format, and then breaking > out the individual color channels into separate, parallel > arrays.

[Mesa-dev] [PATCH 3/4] radeonsi: clean up setting GRBM_GFX_INDEX

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index ab0bb57..4772df2 100644 --- a/src/gallium

[Mesa-dev] [PATCH 2/4] radeonsi: move PA_SC_RASTER_CONFIG emission into a separate function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 143 1 file changed, 73 insertions(+), 70 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 532388f..ab0bb57 100644 --- a/src/gallium

[Mesa-dev] [PATCH 4/4] radeonsi: get the raster config from AMDGPU on SI

From: Marek Olšák Not sure yet if we wanna do this on CIK and VI too. --- src/amd/common/ac_gpu_info.c| 3 +++ src/amd/common/ac_gpu_info.h| 2 ++ src/gallium/drivers/radeonsi/si_state.c | 17 + 3 files changed, 22 insertions(+) diff --git a/src/amd/com

[Mesa-dev] [PATCH 1/4] radeonsi: correct maximum wave count per SIMD

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index f02fc9e..186a3dd 100644 --- a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 7/8] gallium: remove TGSI opcode SCS

Am 22.08.2017 um 16:38 schrieb Roland Scheidegger: > Am 22.08.2017 um 15:17 schrieb Jose Fonseca: >> On 22/08/17 12:28, Marek Olšák wrote: >>> On Tue, Aug 22, 2017 at 1:10 PM, Jose Fonseca >>> wrote: On 20/08/17 01:49, Marek Olšák wrote: > > From: Marek Olšák > > use COS+SIN

Re: [Mesa-dev] [PATCH] llvmpipe: lp_build_gather_elem_vec BE fix for 3x16 load

Sorry, please ignore this patch in favor of the sequence emailed later today (23 Aug 2017). -- Ben - Original Message - From: "Ben Crocker" To: mesa-dev@lists.freedesktop.org Cc: "17.2 17.1" , "Dave Airlie" , "Ben Crocker" Sent: Wednesday, August 23, 2017 1:38:21 PM Subject: [Mesa-dev

[Mesa-dev] [PATCH v2 2/2] llvmpipe: lp_build_gather_elem_vec BE fix for 3x16 load

Fix loading of a 3x16 vector as a single 48-bit load on big-endian systems (PPC64, S390). Roland Scheidegger's commit e827d9175675aaa6cfc0b981e2a80685fb7b3a74 plus Ray Strode's patch reduce pre-Roland Piglit failures from ~4000 to ~2000. This patch fixes three of the four regressions observed by

[Mesa-dev] [PATCH v2 1/2] gallivm: correct channel shift logic on big endian

From: Ray Strode lp_build_fetch_rgba_soa fetches a texel from a texture. Part of that process involves first gathering the element together from memory into a packed format, and then breaking out the individual color channels into separate, parallel arrays. The code fails to account for endianes

[Mesa-dev] [PATCH v2 0/2] gallivm/llvmpipe: fix gather logic for big-endian architectures

The following patches, on top of Roland Scheidegger's commit e827d9175675aaa6cfc0b981e2a80685fb7b3a74, reduce pre-Roland Piglit failures from ~4000 to ~2000 on big-endian architectures (PPC64, S390x). Ben Crocker (1): llvmpipe: lp_build_gather_elem_vec BE fix for 3x16 load Ray Strode (1): gal

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #14 from Gert Wollny --- Maybe you're missing libtxc_dxtn? According to the glxinfo the dxt* texture compression extensions are not available. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #14 from Bruce Cherniak --- Created attachment 133726 --> https://bugs.freedesktop.org/attachment.cgi?id=133726&action=edit Patch to fix swr after "new patch to try" Hi Brian, I found the reason that swr starts failing with your

Re: [Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

On Wednesday, August 23, 2017 12:04:40 PM PDT Ilia Mirkin wrote: > You might consider also including whether the interpolation method was > forced or not. i.e. if you have > > flat varying vec4 gl_Color; > > then it doesn't matter whether shade model is flat or not, it'll be > interpolated as fla

Re: [Mesa-dev] [PATCH] ac/nir: fixup layer/viewport export for GFX9.

Hi Dave, This patch landed tagged for 17.2 only. Was it, then, not nominated for 17.1 intentionally ? Br. On Thu, 2017-08-17 at 14:27 +1000, Dave Airlie wrote: > From: Dave Airlie > > GFX9 moved where the viewport index export goes. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_n

Re: [Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

You might consider also including whether the interpolation method was forced or not. i.e. if you have flat varying vec4 gl_Color; then it doesn't matter whether shade model is flat or not, it'll be interpolated as flat. (Same with the other qualifiers made available in GL 3.0.) So you only have

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

On Wed, Aug 23, 2017 at 2:09 PM, Jason Ekstrand wrote: > On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick wrote: >> >> Reviewed-by: Ian Romanick >> >> Did you submit a CTS bug? > > > No, I didn't. It does get some coverage through the up-and-coming subgroup > tests but it should probably have it's

Re: [Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

Am 23.08.2017 um 20:32 schrieb Leo Liu: On 08/23/2017 02:10 PM, Christian König wrote: Am 23.08.2017 um 19:21 schrieb Leo Liu: Since encoder only support de-interlaced buffers. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

Am 23.08.2017 um 20:35 schrieb Leo Liu: Since encoder only support de-interlaced buffers. v2: move to parameter call to tell dec/enc Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

Since encoder only support de-interlaced buffers. v2: move to parameter call to tell dec/enc Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_tracke

Re: [Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

On 08/23/2017 02:10 PM, Christian König wrote: Am 23.08.2017 um 19:21 schrieb Leo Liu: Since encoder only support de-interlaced buffers. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/sta

[Mesa-dev] [Bug 102377] PIPE_*_4BYTE_ALIGNED_ONLY caps crashing

https://bugs.freedesktop.org/show_bug.cgi?id=102377 Bug ID: 102377 Summary: PIPE_*_4BYTE_ALIGNED_ONLY caps crashing Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

From: Zhongmin Wu Add plumbing to allow creation of per display surface out fence. Currently enabled only on android, since the system expects a valid fd in ANativeWindow::{queue,cancel}Buffer. We pass a fd of -1 with which native applications such as flatland fail. The patch enables explicit sy

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

Il 23/ago/2017 19:57, "Rob Herring" ha scritto: On Wed, Aug 23, 2017 at 12:31 PM, Emil Velikov wrote: > On 23 August 2017 at 17:50, Rob Herring wrote: >> On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: >>> On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang wrote: 2017-08-19 8:27 GMT+08:

[Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

From: Zhongmin Wu Add plumbing to allow creation of per display surface out fence. Currently enabled only on android, since the system expects a valid fd in ANativeWindow::{queue,cancel}Buffer. We pass a fd of -1 with which native applications such as flatland fail. The patch enables explicit sy

Re: [Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

Am 23.08.2017 um 19:21 schrieb Leo Liu: Since encoder only support de-interlaced buffers. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trac

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick wrote: > Reviewed-by: Ian Romanick > > Did you submit a CTS bug? > No, I didn't. It does get some coverage through the up-and-coming subgroup tests but it should probably have it's own test. That's going to be really annoying to test... > On 08/

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

On Wed, Aug 23, 2017 at 12:31 PM, Emil Velikov wrote: > On 23 August 2017 at 17:50, Rob Herring wrote: >> On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: >>> On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang >>> wrote: 2017-08-19 8:27 GMT+08:00 Emil Velikov : > On 18 August 2017 at

Re: [Mesa-dev] [PATCH] vbo: fix glVertexAttrib(index=0)

Looks good. Thanks. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, August 22, 2017 1:21:56 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] vbo: fix glVertexAttrib(index=0) Depending on which extension o

[Mesa-dev] [PATCH] llvmpipe: lp_build_gather_elem_vec BE fix for 3x16 load

Fix loading of a 3x16 vector as a single 48-bit load on big-endian systems (PPC64, S390). Roland Scheidegger's commit e827d9175675aaa6cfc0b981e2a80685fb7b3a74 plus Ray Strode's patch reduce pre-Roland Piglit failures from ~4000 to ~2000. This patch fixes three of the four regressions observed by

[Mesa-dev] [PATCH] st/va: exclude the buffer reallocation for encode case

Since encoder only support de-interlaced buffers. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index b2be7af8c4..ea86ce1b

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

On 23 August 2017 at 17:50, Rob Herring wrote: > On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: >> On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang >> wrote: >>> 2017-08-19 8:27 GMT+08:00 Emil Velikov : On 18 August 2017 at 20:46, Rob Herring wrote: > Both statically linking libLL

[Mesa-dev] [PATCH 2/2] Android: EGL: fix missing nativewindow.h include on O

The build against AOSP master and O is broken: external/mesa3d/include/EGL/eglplatform.h:100:10: fatal error: 'android/native_window.h' file not found native_window.h has moved and is now part of libnativewindow library, so add this dependency. Signed-off-by: Rob Herring --- src/egl/Android.m

[Mesa-dev] [PATCH 1/2] Android: fix Android O version check for LLVM

With the release of O, the MESA_ANDROID_MAJOR_VERSION has changed to 8. Change the LLVM check to match. There's no point to continue to support 'O' as no one is going to use an old AOSP master. Presumably, we'll be back here again to fix things again for P (or 9). Signed-off-by: Rob Herring ---

[Mesa-dev] New #intel-3d IRC channel on Freenode

Hello, The Intel Mesa team would like to welcome you to a new public IRC channel on Freenode: #intel-3d. The topic is Mesa development for Intel GPUs, in particular the "i965" OpenGL and "anv" Vulkan drivers. The open source graphics community has grown a lot over the last few years, and as a re

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

Reviewed-by: Ian Romanick Did you submit a CTS bug? On 08/21/2017 10:11 PM, Jason Ekstrand wrote: > I have no idea how this got missed but it's been missing since forever. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/spirv/vtn_variables.c | 5 - > 1 file changed, 4 insert

[Mesa-dev] [PATCH] gallium/docs: Fix an inequality sign of TGSI_SEMANTIC_SUBGROUP_LT_MASK

A previous expression presents same as TGSI_SEMANTIC_SUBGROUP_GT_MASK. It fixes a direction of an inequality for TGSI_SEMANTIC_SUBGROUP_LT_MASK. before: bit index > TGSI_SEMANTIC_SUBGROUP_INVOCATION after: bit index < TGSI_SEMANTIC_SUBGROUP_INVOCATION Signed-off-by: Mun Gwan-gyeong --- src

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: > On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang > wrote: >> 2017-08-19 8:27 GMT+08:00 Emil Velikov : >>> On 18 August 2017 at 20:46, Rob Herring wrote: Both statically linking libLLVMCore and dynamically linking libLLVM causes dupl

[Mesa-dev] [PATCH 04/10] st/glsl_to_tgsi: inline src_register into translate_src

From: Nicolai Hähnle src_register has no meaningful standalone use, it only makes sense when called from translate_src. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 150 +++-- 1 file changed, 76 insertions(+), 74 deletions(-) diff --git a/src/mesa/state_tracker/st_gl

[Mesa-dev] [PATCH 10/10] radeonsi: add an assertion that only two-dimensional constant references are used

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index f02fc9e9ba2..c445c49d2aa 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/sr

[Mesa-dev] [PATCH 09/10] gallium/radeon: always use two-dimensional constant references

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_query.c | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index ca048722672..eaff39c830d 100644 --- a/

[Mesa-dev] [PATCH 07/10] pp: always use two-dimensional constant references

From: Nicolai Hähnle --- src/gallium/auxiliary/postprocess/pp_mlaa.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/postprocess/pp_mlaa.h b/src/gallium/auxiliary/postprocess/pp_mlaa.h index 0b2c363e1c4..85c14a786a3 100644 --- a/s

[Mesa-dev] [PATCH 02/10] tgsi/ureg: always emit constants (and their decls) as 2D

From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index ca31bc4a75a..b26434ccbde 100644 --- a/src/gallium/au

[Mesa-dev] [PATCH 08/10] gallium/tests: always use two-dimensional constant references

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_tests.c | 4 ++-- src/gallium/tests/graw/fragment-shader/frag-cb-1d.sh | 8 src/gallium/tests/graw/vertex-shader/vert-cb-1d.sh | 8 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 05/10] nine: always generate two-dimensional constant file accesses

From: Nicolai Hähnle --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- src/gallium/state_trackers/nine/nine_shader.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c ind

[Mesa-dev] [PATCH 06/10] gallium/hud: always use two-dimensional constant references

From: Nicolai Hähnle --- src/gallium/auxiliary/hud/hud_context.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 2deb48d18e7..ed2e8491143 100644 --- a/src/gallium/auxiliary/hud/hu

[Mesa-dev] [PATCH 01/10] gallium: all drivers should accept two-dimensional constant buffer indexing

From: Nicolai Hähnle Most older drivers seem to just ignore the Dimension setting, so virtually no changes should be needed. --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 2 +- src/gallium/docs/source/screen.rst | 11 +++ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 03/10] st/glsl_to_tgsi: ir_load_ubo always has a second index

From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 9f021962e40..f2aae4f5183 100644 --- a/src/mesa/state_tracker/st

[Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D

Hi all, Following the discussion on Timothy's std430 packing series, here's a quick proposal to just always use 2D accesses to the CONST file in TGSI. The first patch should be sufficient for all drivers to accept those 2D accesses. It seems that most older drivers simply ignore the dimension, an

Re: [Mesa-dev] [PATCH] swr: limit pipe_draw_info->restart_index usage

Reviewed-by: Bruce Cherniak > On Aug 23, 2017, at 11:19 AM, Tim Rowley wrote: > > Only copy this value when in restart drawing mode. > > Eliminates valgrind errors when running trivial programs. > --- > src/gallium/drivers/swr/swr_draw.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deleti

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #13 from Bruce Cherniak --- Hi Brian, This appears to fix VTK tests on llvmpipe. However, it breaks SWR. Please let me see what's going on there before submitting this patch for review. -- You are receiving this mail because: Yo

Re: [Mesa-dev] TGSI 16-bit support

On Wed, Aug 23, 2017 at 3:08 PM, Nicolai Hähnle wrote: > On 22.08.2017 22:39, Roland Scheidegger wrote: >> >> Am 22.08.2017 um 19:10 schrieb Marek Olšák: >>> >>> Hi, >>> >>> I'd like to discuss 16-bit float and integer support in TGSI. I'm >>> proposing this: >>> >>> struct tgsi_instruction >>>

[Mesa-dev] [PATCH] swr: limit pipe_draw_info->restart_index usage

Only copy this value when in restart drawing mode. Eliminates valgrind errors when running trivial programs. --- src/gallium/drivers/swr/swr_draw.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_draw.cpp b/src/gallium/drivers/swr/swr_draw.cp

Re: [Mesa-dev] [PATCH] radeonsi: do not assert when reserving bindless slot 0

On 08/23/2017 05:59 PM, Nicolai Hähnle wrote: On 23.08.2017 10:10, Samuel Pitoiset wrote: Both solutions look good to me. On 08/23/2017 10:06 AM, Michael Schellenberger Costa wrote: Hi Samuel, do you want to fully remove the assert or should this be something the kind of MAYBE_UNUSED uns

Re: [Mesa-dev] [PATCH] radeonsi: do not assert when reserving bindless slot 0

On 23.08.2017 10:10, Samuel Pitoiset wrote: Both solutions look good to me. On 08/23/2017 10:06 AM, Michael Schellenberger Costa wrote: Hi Samuel, do you want to fully remove the assert or should this be something the kind of MAYBE_UNUSED unsigned res = util_idalloc_alloc(&sctx->bindless_u

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #44 from Ben Crocker --- (In reply to Ben Crocker from comment #43) > (In reply to Ben Crocker from comment #42) > > Created attachment 133677 [details] [review] [review] > > lp_build_gather_elem_vec big-endian fix for 3x16 load > >

  1   2   3   >