[Mesa-dev] [PATCH] mapi: Only install khrplatform.h with EGL or GLES

When mesa is built with "--disable-egl --disable-gles1 --disable-gles2" the KHR platform headers are not needed. Not installing the header when not needed allows using mesa for GL and another implementation for GLES+EGL (as is done in practice with userland on raspberrypi). --- src/mapi/Makefile.

[Mesa-dev] [PATCH] mesa: Return GL_INVALID_ENUM for bogus TEXTURE_SRGB_DECODE_EXT params.

Fixes dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.srgb_decode_samplerparameter{f,fv,i,Iiv,Iuiv,iv}. --- src/mesa/main/samplerobj.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index d7

[Mesa-dev] [PATCH v3 14/14] i965: Advertise the CCS modifier

From: Ben Widawsky v2: Rename modifier to be more smart (Jason) FINISHME: Use the kernel's final choice for the fb modifier bwidawsk@norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube none Read bandwidth: 603.91 MiB/s Write bandwidth: 615.28 MiB/s bwidawsk@norri

[Mesa-dev] [PATCH v3 13/14] i965/miptree: More conservatively resolve external images

Instead of always doing a full resolve, only resolve the bits that are needed. This means that we only do a partial resolve when the miptree modifier is I915_FORMAT_MOD_Y_TILED_CCS. Reviewed-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.c | 2 +

[Mesa-dev] [PATCH v3 12/14] i965: Pretend that CCS modified images are two planes

From: Ben Widawsky v2: move is_aux into if block. (Jason) Use else block instead of goto (Jason) v3: Fix up logic for is_aux (Ben) Fix up size calculations and add FIXME (Ben) v4 (Jason Ekstrand): Use the aux_pitch in the image instead of calculating it Signed-off-by: Ben Widawsky Acked-by: D

[Mesa-dev] [PATCH v3 08/14] i965: Support images with aux buffers

From: Ben Widawsky Previously images did not support any auxiliary compression surfaces (CCS, MCS, or HiZ). That's about to change. This patch just adds the fields to __DRIimageRec to make auxiliary surfaces possible. v2 (Jason Ekstrand): - Add an aux_pitch parameter as well as aux_offset Si

[Mesa-dev] [PATCH v3 07/14] intel/isl: Add support for I915_FORMAT_MOD_Y_TILED_CCS

Reviewed-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/intel/isl/isl_drm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/isl/isl_drm.c b/src/intel/isl/isl_drm.c index b7a4997..db72a34 100644 --- a/src/intel/isl/isl_drm.c +++ b/src/intel/isl/isl_drm.c @@ -54,

[Mesa-dev] [PATCH v3 10/14] i965/miptree: Allocate mcs_buf for an image's CCS

From: Ben Widawsky This code will disable actually creating these buffers for the scanout, but it puts the allocation in place. Primarily this patch is split out for review, it can be squashed in later if preferred. v2: assert(mt->offset == 0) in ccs creation (as requested by Topi) Remove bogus

[Mesa-dev] [PATCH v3 09/14] intel/isl: Add a row_pitch parameter to surf_get_ccs_surf

Reviewed-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/intel/isl/isl.c | 4 +++- src/intel/isl/isl.h | 3 ++- src/intel/vulkan/anv_image.c | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++- 4 files changed,

[Mesa-dev] [PATCH v3 11/14] i965/screen: Support import and export of surfaces with CCS

Reviewed-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_screen.c | 69 +--- 1 file changed, 64 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b292300..259e98a 100644 --- a

[Mesa-dev] [PATCH v3 02/14] i965/miptree: Allocate HiZ up-front

HiZ, like MCS and CCS_E, can compress more than just clear colors so we want it turned on whenever the miptree is being used as a depth attachment. It's theoretically possible for someone to create a depth texture, upload data with glTexSubImage2D, and texture from it without ever binding it as a

[Mesa-dev] [PATCH v3 04/14] i965/bufmgr: Add a BO_ALLOC_ZEROED flag

Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 28 ++-- src/mesa/drivers/dri/i965/brw_bufmgr.h | 1 + 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index

[Mesa-dev] [PATCH v3 01/14] i965/miptree: Gather initial aux allocation into a single function

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 83 +-- 1 file changed, 53 insertions(+), 30 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 575f04f..12b8d04 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH v3 05/14] i965/screen: Allocate ZEROED BOs for images

--- src/mesa/drivers/dri/i965/intel_screen.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 6d0588e..b292300 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/src/m

[Mesa-dev] [PATCH v3 03/14] i965/miptree: Replace is_lossless_compressed with mt->aux_usage checks

Now that we have an actual aux_usage field, we no longer need the complex logic of is_lossless_compressed in order to figure out if a miptree is CCS_E compressed. As a side-effect, there is not longer any need to overload MSAA_LAYOUT_CMS for CCS_E and we can stop doing so. --- src/mesa/drivers/dr

[Mesa-dev] [PATCH v3 00/14] i965: Add support for I916_FORMAT_MOD_Y_TILED_CCS

This is yet another respin of the patch series to enable the CCS_E format modifier. Most of v2 has been pushed and this contains the bits that still need review. Fortunately, the series gets shorter each time I send it! Most of the fixes are from review comments by Chad. Six of the fourteen pat

[Mesa-dev] [PATCH v3 06/14] i965/miptree: Use BO_ALLOC_ZEROED for CCS_E buffers

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 36 ++- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index fc7b48f..fea19a8 100644 --- a/src/mesa/drivers/dr

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

Hi Tomasz: That is right, what we needed is just the "last fence", and then where to record it and how to get it. We will check the solutions on radeonsi by Michel, if create_fence_fd can also get the last fence, of course we can use such DRI2 fence extension API in queuebuffer and canclebu

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

Hi Zhongmin, Michel, On Thu, Jul 13, 2017 at 12:21 PM, Michel Dänzer wrote: > On 13/07/17 09:28 AM, Wu, Zhongmin wrote: >> Hi Tomasz >> >> Thanks, but I am afraid we have to use the last fence from the last buffer >> flushing , According to my understanding: >> >> If the glFlush was called befo

Re: [Mesa-dev] Mesa 17.1.5 release candidate

Hi Andres, On 13/07/17 04:02 AM, Andres Gomez wrote: > > Gallivm has seen a fix for properly checking the line width in order to > use the wide line stage. The VA library, has seen fixed a leak. While > WGL has seen improved the selection of pixel format. Nitpick: "gallivm" refers only to src/

Re: [Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v3)

On 11 July 2017 at 23:49, Alex Smith wrote: > On 11 July 2017 at 14:27, Alex Smith wrote: >> >> On 10 July 2017 at 05:59, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> This patch uses addrlib to workout the tile swizzles according >>> to the surface index. It seems to produce the same va

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

On 13/07/17 09:28 AM, Wu, Zhongmin wrote: > Hi Tomasz > > Thanks, but I am afraid we have to use the last fence from the last buffer > flushing , According to my understanding: > > If the glFlush was called before swapbuffer ,there would be no new fence > after that since the batch buffer

Re: [Mesa-dev] [PATCH v2 08/27] main/formats: Autogenerate _mesa_get_srgb_format_linear

On Sat, Jul 8, 2017 at 11:38 AM, Chad Versace wrote: > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > --- > > src/mesa/main/format_fallback.py | 46 +++ > > src/mesa/main/formats.c | 117 -- > - > > 2 files changed, 46 insertions(+), 117 d

[Mesa-dev] [PATCH] radeonsi: hook up device/driver UUID queries v2

v2: move from r600_common to radeonsi Signed-off-by: Andres Rodriguez --- This fixes a build error reported by haagch on #radeon. I've updated the series on my repo to wip-mem-obj-v4 src/gallium/drivers/radeonsi/si_pipe.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

Hi Tomasz Thanks, but I am afraid we have to use the last fence from the last buffer flushing , According to my understanding: If the glFlush was called before swapbuffer ,there would be no new fence after that since the batch buffer may be flushed out, no batch flushing, no fence generat

Re: [Mesa-dev] [PATCH v2 26/27] i965/miptree: More conservatively resolve external images

On Wed, Jul 12, 2017 at 11:39 AM, Chad Versace wrote: > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > Instead of always doing a full resolve, only resolve the bits that are > > needed. This means that we only do a partial resolve when the miptree > > modifier is I915_FORMAT_MOD_Y_TILED_CCS. > >

[Mesa-dev] [PATCH 27/27] radeonsi: enable support for EXT_memory_object v3

v2: fix an indentation error v3: don't enable for r600 Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index bc0e38f..60

[Mesa-dev] [PATCH 25/27] radv: generate same device UUID as radeonsi v2

This is required for interop use cases. The same device must report identical UUIDs through the GL and Vulkan APIs so that users can identify when it is safe to perform a memory object import. v2: use ac helpers to calculate the uuid Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_devic

[Mesa-dev] [PATCH 26/27] radv: generate the same driver UUID as radeonsi

These need to match for interop compatibility queries. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 9 - src/amd/vulkan/radv_private.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c i

[Mesa-dev] [PATCH 24/27] radv: rename physical_device->uuid[] to cache_uuid[]

We have a few UUIDs, so lets be more specific. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_pipeline_cache.c | 4 ++-- src/amd/vulkan/radv_private.h| 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vul

[Mesa-dev] [PATCH 22/27] mesa: hook up queries for NUM_TILING_TYPES and TILING_TYPES

These are just basic implementations. Signed-off-by: Andres Rodriguez --- src/mesa/main/formatquery.c | 17 + src/mesa/main/mtypes.h | 3 +++ src/mesa/main/texparam.c| 27 +++ 3 files changed, 47 insertions(+) diff --git a/src/mesa/main/formatqu

[Mesa-dev] [PATCH 16/27] mesa: expose EXT_memory_object and EXT_memory_object_fd v2

v2: use PIPE_CAP_MEMOBJ to guard the extension Signed-off-by: Andres Rodriguez --- src/mesa/main/extensions_table.h | 2 ++ src/mesa/main/mtypes.h | 2 ++ src/mesa/state_tracker/st_extensions.c | 5 + 3 files changed, 9 insertions(+) diff --git a/src/mesa/main/extensio

[Mesa-dev] [PATCH 18/27] gallium: introduce device/driver UUID queries v2

v2: remove unnecessary returns Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_screen.c | 17 + src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include/pipe/p_screen.h| 13 + 3 files changed, 31 insertions(+) diff --git a/src/gallium/

[Mesa-dev] [PATCH 17/27] mesa: Implement glGetUnsignedByte{v|i_v}

These are used by EXT_external_objects to present UUIDs for the device and the driver. Signed-off-by: Andres Rodriguez --- src/mesa/main/get.c | 177 1 file changed, 177 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c ind

[Mesa-dev] [PATCH 23/27] mesa: fix error handling for memory objects

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 63 + 1 file changed, 51 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index 919a81c..73c9d4b 100644 --- a/src/mesa/main/e

[Mesa-dev] [PATCH 21/27] radeonsi: hook up device/driver UUID queries

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index fd67d9a..c14d4eb 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 19/27] mesa: hook up UUID queries for driver and device v3

v2: respective changes for new gallium interface v3: fix UUID size asserts Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 15 +++ src/mesa/main/get.c | 17 + src/mesa/main/version.c | 13 + src/mesa/ma

[Mesa-dev] [PATCH 20/27] ac/gpu: add driver/device UUID query helpers

We need vulkan and gl to produce the same UUIDs. Therefore we should keep the mechanism to compute these in a common location to guarantee they are updated in lockstep. Signed-off-by: Andres Rodriguez --- src/amd/common/ac_gpu_info.c | 27 +++ src/amd/common/ac_gpu_info.h

[Mesa-dev] [PATCH 14/27] mesa: hook up (Named)BufferStorageMem api

Include no_error variants as well. Signed-off-by: Andres Rodriguez --- src/mapi/glapi/gen/EXT_external_objects.xml | 4 +- src/mesa/main/bufferobj.c | 80 +++-- src/mesa/main/bufferobj.h | 16 +- src/mesa/main/externalobjects.c

[Mesa-dev] [PATCH 07/27] mesa: hook up memory object multisamples tex(ture)storage api

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 53 src/mesa/main/teximage.c| 76 + src/mesa/main/teximage.h| 10 ++ 3 files changed, 110 insertions(+), 29 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 13/27] mesa: implement memory objects as a backend for buffer objects

Use a memory object instead of user memory. Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 12 + src/mesa/state_tracker/st_cb_bufferobjects.c | 66 +--- 2 files changed, 61 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/

[Mesa-dev] [PATCH 15/27] gallium: introduce PIPE_CAP_MEMOBJ v2

This can be used to guard support for EXT_memory_object and related extensions. v2: update gallium docs Signed-off-by: Andres Rodriguez --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_scr

[Mesa-dev] [PATCH 08/27] mesa/st: factor out st_AllocTextureStorage into a helper

Plumbing for using memory objects as texture storage. Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_texture.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb

[Mesa-dev] [PATCH 09/27] mesa/st: implement memory objects as a backend for texture storage v3

From: Dave Airlie Instead of allocating memory to back a texture, use the provided memory object. v2: split off extension exposure logic v3: de-duplicate code with st_AllocTextureStorage Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_texture.c | 116 +

[Mesa-dev] [PATCH 11/27] radeonsi: add basic memory object support v2

From: Dave Airlie v2: also consider gfx9 metadata Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++ src/gallium/drivers/radeon/r600_texture.c | 102 ++ 2 files changed, 109 insertions(+) diff --git a/src/gallium/drivers/rad

[Mesa-dev] [PATCH 12/27] mesa: fix inconsistent indentation of st_cb_bufferobjects.c

No changes, just re-indent. Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_bufferobjects.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src/mesa/state_tracker/st_cb_bufferobjec

[Mesa-dev] [PATCH 06/27] mesa: hook up memoryobject tex(ture)storage api

Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 9 src/mesa/main/externalobjects.c | 93 - src/mesa/main/texstorage.c | 76 - src/mesa/main/texstorage.h | 13 +- 4 files changed, 160

[Mesa-dev] [PATCH 05/27] mesa/st: start adding memory object support v2

From: Dave Airlie v2: pass dedicated flag Signed-off-by: Andres Rodriguez --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_memoryobjects.c | 66 src/mesa/state_tracker/st_cb_memoryobjects.h | 25 +++ src/mesa/state_track

[Mesa-dev] [PATCH 10/27] radeonsi: factor out metadata import

Plumbing for importing memobj backed textures. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_texture.c | 63 ++- 1 file changed, 36 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/rade

[Mesa-dev] [PATCH 04/27] gallium: introduce memory object v2

From: Dave Airlie v2: fix comment regarding fd ownership, define pipe_memory_object --- src/gallium/drivers/ddebug/dd_screen.c | 40 ++ src/gallium/include/pipe/p_screen.h| 36 ++ src/gallium/include/pipe/p_state.h | 8 +++

[Mesa-dev] [PATCH 01/27] mapi: add EXT_external_objects and EXT_external_objects_fd

Includes implementation stubs. Signed-off-by: Andres Rodriguez --- src/mapi/glapi/gen/EXT_external_objects.xml| 234 + src/mapi/glapi/gen/EXT_external_objects_fd.xml | 28 +++ src/mapi/glapi/gen/Makefile.am | 2 + src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 03/27] mesa: add support for memory object parameters

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 54 - src/mesa/main/mtypes.h | 5 +++- 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index 2a

[Mesa-dev] [PATCH 00/27] Initial support for EXT_external_objects v3

This update fixes a crash observed during initialization of a steamvr opengl client. Other updates from review comments: * Fixed gfx9 metadata import * Remove r600 exposing support for PIPE_CAP_MEMOBJ * Added missing PIPE_CAP_MEMOBJ docs * Cleanups suggested by mareko New patches in this

[Mesa-dev] [PATCH 02/27] mesa: add support for memory object creation/import/delete

Used by EXT_external_objects and EXT_external_objects_fd Signed-off-by: Andres Rodriguez --- src/mesa/drivers/common/driverfuncs.c | 4 + src/mesa/main/dd.h| 36 + src/mesa/main/externalobjects.c | 145 +- src/mesa/main/externa

Re: [Mesa-dev] [PATCH 0/6] swr: rasterizer update

Reviewed-by: Bruce Cherniak > On Jul 12, 2017, at 10:38 AM, Tim Rowley wrote: > > Highlights are read-only render targets and simd16 fixes. > > Tim Rowley (6): > swr/rast: Support render target mask instead of render target count > swr/rast: Add support for read-only render targets > swr/r

Re: [Mesa-dev] [PATCH] radv: Fix possible invalid free of dynamic descriptors

Thanks, pushed. On Wed, Jul 12, 2017 at 12:14 PM, Alex Smith wrote: > This free was left in after dynamic descriptors were changed to not be > allocated separately from the descriptor set, and can cause a crash. > > Fixes: 39644fa40a3 ("radv: Don't allocate dynamic descriptors separately") > Sign

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

Thanks, pushed. On Wed, Jul 12, 2017 at 11:29 AM, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted > accordingly). This is correct when the image view is actually bound as a > st

Re: [Mesa-dev] [PATCH v2 22/27] i965/miptree: Allocate mcs_buf for an image's CCS

On Wed, Jul 12, 2017 at 11:05 AM, Chad Versace wrote: > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > This code will disable actually creating these buffers for the scanout, > > but it puts the allocation in place. > > > > Primarily this patch is split out for review,

Re: [Mesa-dev] [PATCH 16/18] i965: Convert GS_STATE to genxml.

On Friday, June 16, 2017 4:31:29 PM PDT Rafael Antognolli wrote: > Merge the code with gen6+ 3DSTATE_GS, and delete brw_gs_state.c, > together with brw_gs_unit_state. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/Makefile.sources| 1 - > src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH v2 24/27] i965/screen: Support import and export of surfaces with CCS

On Wed, Jul 12, 2017 at 11:18 AM, Chad Versace wrote: > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > Reviewed-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_screen.c | 55 > +--- > > 1 file changed, 50 insertions(+), 5 deletions(-) > > > > diff --g

Re: [Mesa-dev] [PATCH v2 21/27] i965: Support images with aux buffers

On Wed, Jul 12, 2017 at 10:22 AM, Chad Versace wrote: > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Previously images did not support any auxiliary compression surfaces > > (CCS, MCS, or HiZ). That's about to change. This patch just adds the > > fields to __DRIimag

Re: [Mesa-dev] [PATCH v4 00/10] Add precise/invariant semantics to TGSI

a little ping on this series. Would be nice if somebody could leave another comment if something is wrong or merge it if everything is right. Despite my main intention of this series was to just fix a bug, I doubt this would be able to land after the feature freeze, so it would be nice if we could

Re: [Mesa-dev] [PATCH v2 0/3] swr: Optimize large draws from client arrays.

Reviewed-by: Tim Rowley > On Jul 12, 2017, at 3:04 PM, Bruce Cherniak wrote: > > If size of client memory copy is too large, don't copy. The draw will > access user-buffer directly and then block. This is faster and more > efficient than queuing many large client draws. > > Applications that

[Mesa-dev] [PATCH v2 3/3] swr: Add path to draw directly from client memory without copy.

If size of client memory copy is too large, don't copy. The draw will access user-buffer directly and then block. This is faster and more efficient than queuing many large client draws. Applications that still use large client arrays benefit from this. VMD is an example. The threshold for this

[Mesa-dev] [PATCH v2 1/3] swr: Remove hard-coded constant and "todo" comment.

Removed the hard-coded constant in favor of a #define. Also removed TODO comment. The constant value doesn't need an environment configurable option. --- src/gallium/drivers/swr/swr_scratch.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_scra

[Mesa-dev] [PATCH v2 2/3] swr: Move environment config options into separate function.

Moved reading of environment config options out of swr_create_screen_internal, into a separate swr_validate_env_options. This is to keep from cluttering create_screen. --- src/gallium/drivers/swr/swr_screen.cpp | 60 +++--- 1 file changed, 34 insertions(+), 26 deletions

[Mesa-dev] [PATCH v2 0/3] swr: Optimize large draws from client arrays.

If size of client memory copy is too large, don't copy. The draw will access user-buffer directly and then block. This is faster and more efficient than queuing many large client draws. Applications that use large draws from client arrays benefit from this. VMD is an example. The threshold for t

Re: [Mesa-dev] [PATCH 3/3] swr: Add path to draw directly from client memory without copy.

> On Jul 11, 2017, at 8:20 PM, Bruce Cherniak wrote: > > If size of client memory copy is too large, don't copy. The draw will > access user-buffer directly and then block. This is faster and more > efficient than queuing many large client draws. > > Applications that use large draws from clie

Re: [Mesa-dev] [PATCH] Android: Fix vc4 build since XML changes.

Rob Herring writes: > On Wed, Jul 5, 2017 at 1:19 PM, Eric Anholt wrote: >> diff --git a/src/broadcom/Android.genxml.mk b/src/broadcom/Android.genxml.mk >> index df44b2ec0b79..dfd00a93fbcf 100644 >> --- a/src/broadcom/Android.genxml.mk >> +++ b/src/broadcom/Android.genxml.mk >> @@ -51,7 +51,7 @@

[Mesa-dev] Mesa 17.1.5 release candidate

Hello list, The candidate for the Mesa 17.1.5 is now available. Currently we have:  - 36 queued  - 2 nominated (outstanding)  - and 0 rejected patch(es) In the current queue we have: In Mesa Core we include a fix to prevent a potential crash. The state tracker received a fix for properly relea

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

On Tue 11 Jul 2017, Rob Herring wrote: > From: Marek Olšák > > Add support for 32-bit RGBX/RGBA formats which are required for Android. > > The original patch (commit ccdcf91104a5) was reverted (commit > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > on further invest

Re: [Mesa-dev] [PATCH v2 27/27] i965: Advertise the CCS modifier

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > v2: Rename modifier to be more smart (Jason) > > FINISHME: Use the kernel's final choice for the fb modifier > > bwidawsk@norris2:~/intel-gfx/kmscube (modifiers $) > ~/scripts/measure_bandwidth.sh ./kmscube none > Read bandwidt

Re: [Mesa-dev] [PATCH v2 26/27] i965/miptree: More conservatively resolve external images

On Thu 29 Jun 2017, Jason Ekstrand wrote: > Instead of always doing a full resolve, only resolve the bits that are > needed. This means that we only do a partial resolve when the miptree > modifier is I915_FORMAT_MOD_Y_TILED_CCS. > > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH v2 25/27] i965: Pretend that CCS modified images are two planes

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > v2: move is_aux into if block. (Jason) > Use else block instead of goto (Jason) > > v3: Fix up logic for is_aux (Ben) > Fix up size calculations and add FIXME (Ben) > > v4 (Jason Ekstrand): > Use the aux_pitch in the image inste

Re: [Mesa-dev] [PATCH v2 24/27] i965/screen: Support import and export of surfaces with CCS

On Thu 29 Jun 2017, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_screen.c | 55 > +--- > 1 file changed, 50 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH v2 22/27] i965/miptree: Allocate mcs_buf for an image's CCS

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in > later if preferred. > > v2: > assert(mt->offse

Re: [Mesa-dev] [PATCH] draw: s/unsigned/enum tgsi_semantic/

Am 12.07.2017 um 18:28 schrieb Brian Paul: > --- > src/gallium/auxiliary/draw/draw_pipe_wide_point.c | 4 ++-- > src/gallium/auxiliary/draw/draw_vs_exec.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxiliary/draw/draw_pipe_wide_point.c > b/src

Re: [Mesa-dev] [PATCH v2 21/27] i965: Support images with aux buffers

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > Previously images did not support any auxiliary compression surfaces > (CCS, MCS, or HiZ). That's about to change. This patch just adds the > fields to __DRIimageRec to make auxiliary surfaces possible. > > v2 (Jason Ekstrand):

Re: [Mesa-dev] [PATCH] draw: s/unsigned/enum tgsi_semantic/

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, July 12, 2017 9:28 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] draw: s/unsigned/enum tgsi_semantic/ --- src/gallium/auxiliary/draw/draw_pipe_wide_poi

[Mesa-dev] [Bug 101766] Assertion `!"invalid type"' failed when constant expression involves literal of different type

https://bugs.freedesktop.org/show_bug.cgi?id=101766 --- Comment #2 from David R. MacIver --- > So makes sense that i2f wants an int input. Something must be auto-converting > the int to a float, but then leaving the i2f in? Odd. Note that the correct behaviour here is a compile error. If I remo

Re: [Mesa-dev] [PATCH] svga: move comment, declaration in svga_init_shader_key_common()

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, July 12, 2017 9:28 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: move comment, declaration in svga_init_shader_key_common() put the comment before

Re: [Mesa-dev] [PATCH 3/4] st/mesa: add support for KHR_no_error flag

On Wednesday, 2017-07-12 17:58:56 +0200, Grigori Goronzy wrote: > On 2017-07-12 15:08, Emil Velikov wrote: > > On 11 July 2017 at 23:26, Grigori Goronzy wrote: > > > Add a new context flag and plumb it through the various layers of the > > > context creation code to set up dispatch tables for the

[Mesa-dev] [PATCH] svga: move comment, declaration in svga_init_shader_key_common()

put the comment before the relevant code. Move declaration of swizzle_tab var to where it's used. --- src/gallium/drivers/svga/svga_shader.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_shader.c b/src/gallium/drivers/svga/svga_shad

[Mesa-dev] [PATCH] draw: s/unsigned/enum tgsi_semantic/

--- src/gallium/auxiliary/draw/draw_pipe_wide_point.c | 4 ++-- src/gallium/auxiliary/draw/draw_vs_exec.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_wide_point.c b/src/gallium/auxiliary/draw/draw_pipe_wide_point.c index adb6

[Mesa-dev] [PATCH] src/intel/Makefile.vulkan.am: create target directories when required

In out-of-tree builds src/intel/vulkan won't exist, so always create it before writing into it. Signed-off-by: Ross Burton --- src/intel/Makefile.vulkan.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/Makefile.vulkan.am b/src/intel/Makefile.vulkan.am index 3857a5dc62..26e9cd41

Re: [Mesa-dev] [PATCH] gallium/util: Remove unused keymap

Reviewed-by: Marek Olšák Marek On Sat, Jul 8, 2017 at 11:53 PM, Thomas Helland wrote: > This is not used anywhere in the codebase. It's a hashtable > implementation that is based around cso_hash, and is therefore > (and as mentioned in a comment in the source) quite similar to > u_hash_table. >

Re: [Mesa-dev] [PATCH 3/4] st/mesa: add support for KHR_no_error flag

On 2017-07-12 15:08, Emil Velikov wrote: On 11 July 2017 at 23:26, Grigori Goronzy wrote: Add a new context flag and plumb it through the various layers of the context creation code to set up dispatch tables for the no-error mode. --- src/gallium/include/state_tracker/st_api.h | 1 + src/ga

Re: [Mesa-dev] XCOM: Enemy Unknown vs. NaN texture unit LOD bias

On Tue, Jul 11, 2017 at 3:08 PM, Roland Scheidegger wrote: > Am 11.07.2017 um 08:25 schrieb Kenneth Graunke: >> Hello, >> >> Mesa master has been hitting assert failures when running "XCOM: Enemy >> Unknown" since commit f8d69beed49c64f883bb8ffb28d4960306baf575, where we >> started asserting that

[Mesa-dev] [PATCH 6/6] swr/rast: Fix use of KNL-only intrinsics in SKX build

--- src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 4 ++-- src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl | 4 ++-- src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 0/6] swr: rasterizer update

Highlights are read-only render targets and simd16 fixes. Tim Rowley (6): swr/rast: Support render target mask instead of render target count swr/rast: Add support for read-only render targets swr/rast: Removing unneeded MSVC warning pragma swr/rast: SIMD16 Frontend - Fix USE_SIMD16_FRONTE

[Mesa-dev] [PATCH 3/6] swr/rast: Removing unneeded MSVC warning pragma

--- src/gallium/drivers/swr/rasterizer/core/pa.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa.h b/src/gallium/drivers/swr/rasterizer/core/pa.h index 77b4f7f..d2e6109 100644 --- a/src/gallium/drivers/swr/rasterizer/core/pa.h +++ b/src/gallium/dri

[Mesa-dev] [PATCH 1/6] swr/rast: Support render target mask instead of render target count

WIP to support read-only render targets. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 24 ++ .../drivers/swr/rasterizer/core/backend_impl.h | 54 ++ .../drivers/swr/rasterizer/core/backend_sample.cpp | 16 +-- .../swr/rasterizer/core/backend_singlesa

[Mesa-dev] [PATCH 5/6] swr/rast: Fix build warnings when using the Intel compiler

--- src/gallium/drivers/swr/rasterizer/common/simdlib_types.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_types.hpp b/src/gallium/drivers/swr/rasterizer/common/simdlib_types.hpp index 1964ef4..07775e7 100644 --- a/src/gal

[Mesa-dev] [PATCH 2/6] swr/rast: Add support for read-only render targets

Core will ensure hot tiles are loaded for read and write render targets, and will skip all output merger for read-only render targets. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 11 --- src/gallium/drivers/swr/rasterizer/core/state.h | 3 ++- 2 files changed, 10 insertions(+),

[Mesa-dev] [PATCH 4/6] swr/rast: SIMD16 Frontend - Fix USE_SIMD16_FRONTEND build

Previous check-ins without testing with USE_SIMD16_FRONTEND have introduced regressions. This fixes the build, not the regressions. --- .../drivers/swr/rasterizer/common/simd16intrin.h | 14 +- .../swr/rasterizer/common/simdlib_512_avx512.inl | 2 +- src/gallium/drivers/swr/

Re: [Mesa-dev] Mesa 17.2.0 release plan

On 12 July 2017 at 15:25, Lucas Stach wrote: > Hi Emil, > > Am Freitag, den 07.07.2017, 19:07 +0100 schrieb Emil Velikov: >> Hi all, >> >> As you may have noticed, for a little while now we've had the release >> plan on the mesa3d.org website [1]. >> >> Here is the current tentative schedule. >> >

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

Hey Emil, On 12 July 2017 at 16:10, Emil Velikov wrote: > There's one small bug that I've missed previously. Other than that the > patch looks great Thanks for taking a look! > On 16 June 2017 at 18:14, Daniel Stone wrote: >> + if (num_modifiers && dri2_dpy->image->base.version >= 15 && >

Re: [Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v2)

On Mon, Jul 10, 2017 at 4:20 AM, Dave Airlie wrote: > From: Dave Airlie > > This patch uses addrlib to workout the tile swizzles according > to the surface index. It seems to produce the same values as > amdgpu-pro for the deferred test. > > v2: don't apply swizzle to CMASK. the eg docs don't men

[Mesa-dev] [Bug 101766] Assertion `!"invalid type"' failed when constant expression involves literal of different type

https://bugs.freedesktop.org/show_bug.cgi?id=101766 --- Comment #1 from Ilia Mirkin --- Reproduced with with glslparsertest_gles2 in piglit. #4 0x718b50f5 in ir_expression::constant_expression_value (this=0xbb6630, variable_context=0x0) at glsl/ir_expression_operation_constant.h:228

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

Hi Dan, There's one small bug that I've missed previously. Other than that the patch looks great On 16 June 2017 at 18:14, Daniel Stone wrote: > When available, use the zwp_linux_dambuf_v1 interface to create buffers, > which allows multiple planes and buffer modifiers to be used. > > Signed-off

  1   2   >