Re: [Mesa-dev] [PATCH] anv/query: handle more cases of 'out of host memory'

Reviewed-by: Samuel Iglesias Gonsálvez On Wed, 2017-04-26 at 09:03 +0200, Iago Toral Quiroga wrote: > --- >  src/intel/vulkan/genX_query.c | 10 ++ >  1 file changed, 10 insertions(+) > > diff --git a/src/intel/vulkan/genX_query.c > b/src/intel/vulkan/genX_query.c > index 126431b..22de3c3

Re: [Mesa-dev] [PATCH 3/3] ac: eliminate duplicated VS exports

On 1 May 2017 at 22:43, Marek Olšák wrote: > From: Marek Olšák > > Only very few shaders have them (from 48486 shaders): For the series: Reviewed-by: Dave Airlie (you might want to stop radeonsi running this pass on tess ctrl if you haven't already). Dave. ___

Re: [Mesa-dev] [PATCH] anv/query: handle more cases of 'out of host memory'

Can anyone review this one? On Wed, 2017-04-26 at 09:03 +0200, Iago Toral Quiroga wrote: > --- >  src/intel/vulkan/genX_query.c | 10 ++ >  1 file changed, 10 insertions(+) > > diff --git a/src/intel/vulkan/genX_query.c > b/src/intel/vulkan/genX_query.c > index 126431b..22de3c3 100644 > --

[Mesa-dev] [PATCH] radv: fix stencil only clears.

From: Dave Airlie If we are clearing stencil only, we still need to provide a a valid Z output from the vertex shader. I'm not 100% sure if this is the super correct fix, but it does fix: dEQP-VK.renderpass.simple.stencil since I added S8 support. Signed-off-by: Dave Airlie --- src/amd/vulkan

Re: [Mesa-dev] [PATCH 8/8] android: egl: add support for software rasterizer

On 05/01/2017 06:05 PM, Mauro Rossi wrote: + Karl 2017-05-01 17:02 GMT+02:00 Mauro Rossi >: 2017-01-06 18:35 GMT+01:00 Wu Zhen mailto:wuz...@jidemail.com>>: From: WuZhen mailto:wuz...@jidemail.com>> this commit enable software rendering o

Re: [Mesa-dev] [PATCH 3/5] radv: remove some members of radeon surface.

On 2 May 2017 at 14:18, Timothy Arceri wrote: > > > On 02/05/17 10:22, Dave Airlie wrote: >> >> From: Dave Airlie >> >> We would be storing this info twice per image, no need to, >> remove it from the surface struct. >> >> Signed-off-by: Dave Airlie >> --- >> src/amd/vulkan/radv_cmd_buffer.c

Re: [Mesa-dev] [PATCH] radv/image: resize some surface members.

On 02/05/17 10:31, Dave Airlie wrote: From: Dave Airlie Oops meant to be part of previous series. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/

Re: [Mesa-dev] [PATCH 3/5] radv: remove some members of radeon surface.

On 02/05/17 10:22, Dave Airlie wrote: From: Dave Airlie We would be storing this info twice per image, no need to, remove it from the surface struct. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_image.c

Re: [Mesa-dev] [PATCH 1/5] radv: provide a helper for comparing an image extents.

On 02/05/17 10:22, Dave Airlie wrote: From: Dave Airlie This just makes it easier to do the follow in cleanups of the surface. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_clear.c | 4 ++-- src/amd/vulkan/radv_private.h| 9 + 2 files changed, 11 insertions(+), 2 d

[Mesa-dev] [PATCH] radv/wsi: report presentation error per image request

From: Dave Airlie This ports 0fcb92c17dee681bd39c08ddf0abc358a27337c7 anv: wsi: report presentation error per image request This fixes: dEQP-VK.wsi.xlib.incremental_present.scale_none.* Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 19 +-- 1 file changed, 13 inser

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 Ray Strode changed: What|Removed |Added Attachment #131171|1 |0 is obsolete|

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 Ray Strode changed: What|Removed |Added Attachment #131171|0 |1 is obsolete|

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #17 from Ray Strode --- Created attachment 131171 --> https://bugs.freedesktop.org/attachment.cgi?id=131171&action=edit another patch that may aid in understanding what's going on Just to follow up again, we played around a bit mo

[Mesa-dev] [PATCH v03 37/38] i965: Port gen6+ 3DSTATE_CC_STATE_POINTERS state to genxml.

Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 +- src/mesa/drivers/dri/i965/brw_state.h | 1 +- src/mesa/drivers/dri/i965/gen6_cc.c | 90 + src/mesa/drivers/dri/i965/genX_state_upload.c | 53 +++- 4 files cha

[Mesa-dev] [PATCH v03 33/38] i965: Port gen6+ 3DSTATE_SCISSOR_STATE_POINTERS to use genxml.

Emit 3DSTATE_SCISSOR_STATE_POINTERS using brw_batch_emit, and pack the scissor states using GENX(SCISSOR_RECT_pack), generated from genxml. v3: - Remove old code (Ken) - Style fixes (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile

[Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

These macros are defined in brw_defines.h, which contains a lot of macros that conflict with autogenerated code from genxml. But we need to use them (the MOCS macros) in some of that same genxml code. Moving them to brw_context.h solves that problem and we don't have to include brw_defines.h. Sig

[Mesa-dev] [PATCH v03 13/38] anv: Use BRW_BARYCENTRIC_NONPERSPECTIVE_BITS from common header.

In a previous patch some enums were split out from brw_eu_defines.h, so they could be used by genxml based code. anv can also benefit from this. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/genX_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/

[Mesa-dev] [PATCH v03 38/38] i965: Port gen4+ state emitting code to genxml.

On this patch, we port: - brw_polygon_stipple - brw_polygon_stipple_offset - brw_line_stipple - brw_drawing_rect v2: - Also emit states for gen4-5 with this code. v3: - Style fixes and remove excessive checks (Ken). Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH v03 07/38] genxml: 3DSTATE_VS rename Function Enable to Enable.

Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/blorp/blorp_genX_exec.h | 2 +- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 2 +- src/intel/genxml/gen75.xml| 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen

[Mesa-dev] [PATCH v03 11/38] genxml: Normalize xml for 3DSTATE_CC_STATE_POINTERS.

- "COLOR_CALC_STATE Change" -> "Color Calc State Pointer Valid" - "Pointer to COLOR_CALC_STATE" -> "Color Calc State Pointer" - "BackFace" -> "Backface" Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/blorp/blorp_genX_exec.h | 4 ++-- src/intel/genxml/gen6.xml

[Mesa-dev] [PATCH v03 19/38] i965: Port Gen6+ 3DSTATE_CLIP state to genxml.

Emit clip state on Gen6+ using brw_batch_emit helper, using pack structs from genxml. v3: - Lots style fixes (Ken) - Do not set CullTestEnableBitMask on Gen8+ (Ken) Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_state.h | 1 +- src/mesa/drivers/dri/i965/gen6_

[Mesa-dev] [PATCH v03 31/38] i965: Port gen6+ blend state code to genxml.

Upload blend states using GENX(BLEND_STATE_ENTRY_pack), generated from genxml. v3: - style fixes (Ken) - cleanup to remove excessive #ifdef's (Ken) - remove memset (Ken) - disable blend.AlphaToCoverageDitherEnable on gen6 (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Gr

[Mesa-dev] [PATCH v03 21/38] i965: Add brw_get_line_width_float.

That helper function returns the line width as a float, and is then used by brw_get_line_width to return the fixed point width. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_util.h | 25 ++--- 1 file changed, 14 insertions(+)

[Mesa-dev] [PATCH v03 25/38] i965: Port gen7+ 3DSTATE_SOL to genxml.

Emit 3DSTATE_SOL on Gen7+ using brw_batch_emit helper, that uses pack structs from genxml. v2: - Add helpers to assign struct brw_address (Kristian) v3: - Rename MOCS -> SOBufferMOCS - Do not re-declare MOCS macros (Ken). - Style and code reorganization (Ken). Signed-off-by: Rafael An

[Mesa-dev] [PATCH v03 36/38] i965: Port gen6+ multisample state emitting code to genxml.

Emit 3DSTATE_MULTISAMPLE using brw_batch_emit. v3: - Remove dead code (Ken) - Simplify #if/#endif (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h| 9 +- src/mesa/drivers/dri/i965/brw_state.h | 2

[Mesa-dev] [PATCH v03 20/38] i965: Port Gen8+ 3DSTATE_RASTER state to genxml.

Emits 3DSTATE_RASTER from genX_state_upload.c using pack structs from genxml. v3: - Style fixes (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_state.h | 1 +- src/mesa/drivers/dri/i965/gen8_sf_state.c | 125 +--

[Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

We need to use some enums inside genX_state_upload.c, but including the whole header will cause several conflicts between things defined in this header and the genxml auto-generated headers. So create a separate header that is included both by brw_eu_defines.h and genX_state_upload.c. Signed-off-

[Mesa-dev] [PATCH v03 17/38] genxml: Add rules to build gen4, gen45 and ge5.

Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.am | 12 src/mesa/drivers/dri/i965/Makefile.sources | 9 + src/mesa/drivers/dri/i965/brw_state.h | 1 + 3 files changed, 22 insertions(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b

[Mesa-dev] [PATCH v03 09/38] genxml: Rename "Function Enable" to "Enable".

Rename that field name on genxml for: - 3DSTATE_GS - gen6+ - 3DSTATE_DS - gen7+ - 3DSTATE_HS - gen7+ Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen6.xml| 2 +- src/intel/genxml/gen7.xml| 6 +++--- src/intel/genxml/gen75.xml

[Mesa-dev] [PATCH v03 28/38] i965: Port gen8+ 3DSTATE_PS_EXTRA to genxml.

Emit 3DSTATE_PS_EXTRA on Gen8+ using brw_batch_emit helper, that uses pack structs from genxml. v3: - Style fixes and moving code around to be cleaner (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 1 +- src/mesa/dri

[Mesa-dev] [PATCH v03 18/38] i965: Port Gen6+ DEPTH_STENCIL state to genxml.

From: Kenneth Graunke This emits 3DSTATE_WM_DEPTH_STENCIL on Gen8+ or DEPTH_STENCIL_STATE (and the relevant pointer packets) on Gen6-7.5 from a single function. v3: - Watch for BRW_NEW_BATCH too on gen8+ (Ken) Signed-off-by: Kenneth Graunke Signed-off-by: Rafael Antognolli Reviewed-by: Ken

[Mesa-dev] [PATCH v03 26/38] i965: Port gen7+ 3DSTATE_PS to genxml.

Emit 3DSTATE_PS on Gen7+ using brw_batch_emit helper, that uses pack structs from genxml. v2: - Use render_bo helper to setup brw_address (Kristian) v3: - Style fixes and code cleanup (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_st

[Mesa-dev] [PATCH v03 23/38] i965: Port Gen7+ 3DSTATE_SBE state to genxml.

Emit 3DSTATE_SBE on Gen7+ using brw_batch_emit helper, that uses pack structs from genxml. v2: - Use ACTIVE_COMPONENT_XYZW from gen9.xml. v3: - Style fixes (Ken) Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 2 +- src/

[Mesa-dev] [PATCH v03 22/38] i965: Port gen6+ 3DSTATE_SF to genxml.

Emit sf state on Gen6+ using brw_batch_emit helper, using pack structs from genxml. v3: - Reorganize code and reduce #if/#endif's (Ken) - Style fixes (Ken) - Always set AALINEDISTANCE_TRUE (Ken) Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_state.h | 3 +-

[Mesa-dev] [PATCH v03 24/38] i965: Remove calculate_attr_overrides.

This function now lives inside genX_state_upload.c. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 1 +- src/mesa/drivers/dri/i965/brw_state.h | 8 +- src/mesa/drivers/dri/i965/gen6_sf_state.c | 265 +-

[Mesa-dev] [PATCH v03 29/38] i965: Port gen6+ 3DSTATE_VS to genxml.

Emit 3DSTATE_VS on Gen6+ using brw_batch_emit helper, that uses pack structs from genxml. v2: - Use render_bo helper to setup brw_address (Kristian) v3: - Bring back some comments for gen6 and remove _NEW_TRANSFORM blocks from gen7+. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth

[Mesa-dev] [PATCH v03 16/38] i965: Get real per-gen atom lists

From: Kenneth Graunke Make atoms initalization compile conditionally based on the target platform. --- src/mesa/drivers/dri/i965/brw_state.h | 12 +- src/mesa/drivers/dri/i965/brw_state_upload.c | 385 +--- src/mesa/drivers/dri/i965/genX_state_upload.c | 340 +++

[Mesa-dev] [PATCH v03 35/38] i965: Port gen4+ emit vertices code to genxml.

Some code that was placed in brw_draw_upload.c and exported to be used by gen8+ was also moved to genX_state_upload, and the respective symbols are not exported anymore. v2: - Remove code from brw_draw_upload too - Emit vertices for gen4-5 too. - Use helper to setup brw_address (Kristian)

[Mesa-dev] [PATCH v03 34/38] i965: Port push constant code to genxml.

The following states are ported on this patch: - gen6_gs_push_constants - gen6_vs_push_constants - gen6_wm_push_constants - gen7_tes_push_constants v2: - Use helper to setup brw_address (Kristian) v3: - Do not use macro for upload_constant_state (Ken) - Do not re-declare MOCS

[Mesa-dev] [PATCH v03 03/38] genxml: Update xml for 3DSTATE_SF.

- Normalize "Anti-Aliasing Enable" - Add "Multisample Rasterization Mode" constants - Rename "Use Point Width on Vertex" to "Vertex" - Rename "Use Point Width from State" to "State" Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen6.xml | 15 ++---

[Mesa-dev] [PATCH v03 30/38] i965: Port gen6+ state emitting code to genxml.

Ported in this patch: - 3DSTATE_DS - 3DSTATE_GS - 3DSTATE_HS - 3DSTATE_VIEWPORT_STATE_POINTERS_SF_CL v3: - Remove NEW_TRANSFORM blocks (Ken) - Bring back some comments and workaround for Ivybridge (Ken) Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.so

[Mesa-dev] [PATCH v03 27/38] i965: Port gen6+ 3DSTATE_WM to genxml.

Emit 3DSTATE_WM on Gen6+ using brw_batch_emit helper, that uses pack structs from genxml. v2: - Use render_bo helper to setup brw_address (Kristian) - Remove TODO and use BRW_PSCDEPTH_OFF. v3: - A couple of style fixes (Ken) - Enable RASTRULE_UPPER_RIGHT on gen6+ instead of gen8+ (Ken)

[Mesa-dev] [PATCH v03 05/38] genxml: Add alias for MOCS.

Use an alias, so we can set the same value as the #define's. v3: - Call it "SO Buffer MOCS" to follow the most common naming scheme. - Add alias for gen7 and gen75 too (Ken). Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel

[Mesa-dev] [PATCH v03 15/38] i965: Add genxml related plumbing in a new genX_state_upload.c file.

From: Kenneth Graunke v3: - Drop aub parameter (Ken) Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 15 ++- src/mesa/drivers/dri/i965/genX_state_upload.c | 109 +++- 2 files changed, 119 insertions(+), 5 deletions(-) create mode 100644 s

[Mesa-dev] [PATCH v03 02/38] genxml: Rename clip enable property.

There are two variants: - Clip Enable - CLIP Enable (on gen6) Rename everything to Clip Enable. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen5.xml | 2 +- src/intel/genxml/gen6

[Mesa-dev] [PATCH v03 08/38] genxml: Clip guardbands are float, not int.

This makes genxml create the right struct types, and generate the right batch commands. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen6.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/g

[Mesa-dev] [PATCH v03 10/38] genxml: Normalize xml for 3DSTATE_MULTISAMPLE.

Name the options to "Pixel Location": - PIXLOC_CENTER -> CENTER - PIXLOC_UL_CORNER -> UL_CORNER Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/blorp/blorp_genX_exec.h | 4 +--- src/intel/genxml/gen6.xml | 4 ++-- src/intel/genxml/gen7.xml | 4 +

[Mesa-dev] [PATCH v03 32/38] i965: Port gen7+ 3DSTATE_TE to genxml.

Emit 3DSTATE_TE on Gen7+ using brw_batch_emit helper. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 1 +- src/mesa/drivers/dri/i965/brw_state.h | 1 +- src/mesa/drivers/dri/i965/gen7_te_state.c | 67 +-

[Mesa-dev] [PATCH v03 06/38] genxml: Make "Reorder Mode" fields consistent.

From: Kenneth Graunke Both GS and SOL have these fields. Some were ReorderEnable = true, some were ReorderMode = REORDER_TRAILING, and some were just TRAILING. Signed-off-by: Kenneth Graunke Reviewed-by: Rafael Antognolli --- src/intel/genxml/gen6.xml| 5 - src/intel/genxml/gen7.

[Mesa-dev] [PATCH v03 04/38] genxml: Add missing field values to 3DSTATE_SBE.

Fill out "Attribute Active Component Format" possible values. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen9.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index ee7056b

[Mesa-dev] [PATCH v03 00/38] Rebased and reviewed series to convert state emitting code to genxml.

The main difference for this one is that it includes the changes based on the review by Kenneth. Current version here: https://github.com/rantogno/mesa/commits/review/genxml-v03 Kenneth Graunke (4): genxml: Make "Reorder Mode" fields consistent. i965: Add genxml related plumbing in a new genX

Re: [Mesa-dev] [PATCH] radv: minor pahole related improvements.

Reviewed-by: Timothy Arceri On 02/05/17 10:33, Dave Airlie wrote: From: Dave Airlie This just reduces the structs by 4-8 bytes each. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.h | 2 +- src/amd/vulkan/radv_private.h| 6 +++--- 2 files changed, 4 insertions

[Mesa-dev] [PATCH] radv: minor pahole related improvements.

From: Dave Airlie This just reduces the structs by 4-8 bytes each. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.h | 2 +- src/amd/vulkan/radv_private.h| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.h b

[Mesa-dev] [PATCH] radv/image: resize some surface members.

From: Dave Airlie Oops meant to be part of previous series. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index 5614d8b..8

Re: [Mesa-dev] [PATCH 2/2] eg: explicitly size dri2_to_egl_attribute_map[]

Hi Emil, On Tue, May 2, 2017 at 3:43 AM, Emil Velikov wrote: > From: Emil Velikov > > This way we'll get an implicit zero initialization of the remaining > members, as required by dri2_add_config(). > > Fixes: e5efaeb85c3 ("egl: polish dri2_to_egl_attribute_map[]") > Cc: Tomasz Figa > Signed-of

Re: [Mesa-dev] [PATCH 05/12] Android: drop LLVM support on Lollipop

2017-04-30 11:49 GMT+02:00 Emil Velikov : > On 27 April 2017 at 20:43, Rob Herring wrote: > > Mesa no longer supports LLVM 3.5 for any targets we support. > > Android-x86 adds support for llvmpipe which could work, but android-x86 > > for L is using mesa 11.0 anyway. > > > Fine with me. An ack fr

Re: [Mesa-dev] [PATCH 1/2] dri_interface.h: define __DRI_ATTRIB_MAX

Hi Emil, On Tue, May 2, 2017 at 3:43 AM, Emil Velikov wrote: > From: Emil Velikov > > Thus we can use the value to explicitly size arrays, insteads of > __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE. > > The latter seems magical and is error prone, as we add more dri > attributes. > > Cc: Tomasz Figa >

[Mesa-dev] [PATCH 4/5] radv/image: drop blk_d

From: Dave Airlie This was pretty much unused. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c| 1 - src/amd/vulkan/radv_radeon_winsys.h| 1 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 2 +- 3 files changed, 1 insertion(+), 3 deleti

[Mesa-dev] [PATCH 3/5] radv: remove some members of radeon surface.

From: Dave Airlie We would be storing this info twice per image, no need to, remove it from the surface struct. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_image.c| 19 +++ src/amd/vulkan/radv_radeon

[Mesa-dev] [PATCH 5/5] radv: drop unused surface level members.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h| 3 --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index

[Mesa-dev] [PATCH 2/5] radv: move some image info into a separate struct.

From: Dave Airlie This is to rework the surface code like radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 4 +-- src/amd/vulkan/radv_device.c | 14 src/amd/vulkan/radv_image.c | 63 ++- src/amd/vulkan

[Mesa-dev] [PATCH 1/5] radv: provide a helper for comparing an image extents.

From: Dave Airlie This just makes it easier to do the follow in cleanups of the surface. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_clear.c | 4 ++-- src/amd/vulkan/radv_private.h| 9 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv

[Mesa-dev] radv: reduce size of image structs.

Marek cleaned up a lot of this in radeonsi previously, so I'd like to realign our code over time to end up closer to what is there, esp in light of future vega work. This series just reworks in the winsys surface info, and reduces the size of the radv_image struct from 5200 bytes to 4136 bytes, as

Re: [Mesa-dev] [PATCH v2] scons: update for LLVM 4.0

On Sat, Apr 29, 2017 at 14:24:28 +0100, Emil Velikov wrote: > Barring any objections from Jose I'll push this in a couple of days. Thanks! > P.S. For future patches please add a brief changelog. Before or after > the --- line. Ah, sorry. When reordering the libraries to look like the 3.9 block,

Re: [Mesa-dev] [PATCH 02/21] anv/cmd_buffer: Use the device allocator for QueueSubmit

On Fri, Apr 28, 2017 at 3:46 PM, Nanley Chery wrote: > On Fri, Apr 14, 2017 at 10:37:49AM -0700, Jason Ekstrand wrote: > > The command is really operating on a Queue not a command buffer and the > > nearest object to that with an allocator is VkDevice. > > > > Cc: "17.0" > > Should this have bee

Re: [Mesa-dev] [PATCH] anv/tests: Create a dummy instance as well as device

On Mon, May 1, 2017 at 4:50 PM, Jason Ekstrand wrote: > This fixes crashes caused by 35e626bd0e59e7ce9fd97ccef66b2468c09206a4 > which made us start referencing the instance in the allocators. With > this commit, the tests now happily pass again. > > Bugzilla: https://bugs.freedesktop.org/show_bug

Re: [Mesa-dev] [PATCH 06/11] genxml: Remove hyphens from pixel dispatch enable names

I've already had to make similar changes in gen7 and maybe 6. patches 5 and 6 are Reviewed-by: Jason Ekstrand On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > Newer Gens' names don't have the hyphens. Having common names will make > some later patches simpler. > --- > src/intel/genxml/ge

Re: [Mesa-dev] [PATCH 07/11] genxml: Rename "VS Function Enable" to just "Function Enable"

Reviewed-by: Jason Ekstrand On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > Other commands have a field with an identical function and call it > "Function Enable". > --- > src/intel/genxml/gen45.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/genxml/

[Mesa-dev] [PATCH] anv/tests: Create a dummy instance as well as device

This fixes crashes caused by 35e626bd0e59e7ce9fd97ccef66b2468c09206a4 which made us start referencing the instance in the allocators. With this commit, the tests now happily pass again. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100877 --- src/intel/vulkan/tests/block_pool_no_free.c

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

On Mon, Apr 24, 2017 at 11:59 PM, Eric Anholt wrote: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific and

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

On Mon, May 1, 2017 at 11:29 PM, Eric Anholt wrote: > Eric Anholt writes: > > > I wrote this code with reference to pixman, though I've only decided to > > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > > has getauxval() as a cleaner interface to the /proc entry, but

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

On 01/05/17 19:57, Samuel Pitoiset wrote: Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) Yes you should be able to push it again (although wouldn't hurt to give it a run in Jenkins first). I didn't realize the pa

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

On Sat 29 Apr 2017, Xu, Randy wrote: > > -Original Message- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Saturday, April 29, 2017 8:36 PM > > To: Chad Versace ; Emil Velikov > > ; Xu, Randy ; mesa- > > d...@lists.freedesktop.org > > Subject: Re: [Mesa-dev] [PATCH] i965

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 EoD changed: What|Removed |Added CC||e...@xmw.de --- Comment #15 from EoD --- I also

Re: [Mesa-dev] [PATCH 00/17] st/mesa cleanup

This series (on top to the other series) is Tested-by: Edmondo Tommasina Tested on Radeon RX 470: * The Witcher 2 * Two Worlds * Uningine Heaven/Valley/Superposition * Civilization 5 * Wasteland 2 * The Talos Principle (OpenGL) Thanks edmondo On Mon, May 1, 2017 at 2:52 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 02/12] android: define required __STDC* macros as cflags

On 30 April 2017 at 16:40, Mauro Rossi wrote: > > > 2017-04-30 11:43 GMT+02:00 Emil Velikov : >> >> Hi Rob, >> >> On 27 April 2017 at 20:43, Rob Herring wrote: >> > From: Mauro Rossi >> > >> > Necessary to fix the following radeonsi building errors: >> > >> > In file included from >> > external/

[Mesa-dev] [PATCH 10/11] intel/aubinator_error_decode: Stop decoding after MI_BATCH_BUFFER_END

--- src/intel/tools/aubinator_error_decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 2e62369..244bef8 100644 --- a/src/intel/tools/aubinator_error_decode.c +++ b/src/intel/tools/aubinator_erro

[Mesa-dev] [PATCH 11/11] intel/aubinator_error_decode: Disassemble shader programs

--- src/intel/Makefile.tools.am | 6 +- src/intel/tools/aubinator_error_decode.c | 178 ++- 2 files changed, 180 insertions(+), 4 deletions(-) diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am index 576beea..1175118 100644 --- a/src/

[Mesa-dev] [PATCH 08/11] intel/decoder: Fix indentation

--- src/intel/common/gen_decoder.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 15bba32..049d1be 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.c @@ -433,8 +433,8 @@

[Mesa-dev] [PATCH 09/11] intel/tools: Refactor gen_disasm_disassemble() to use annotations

Which will allow us to print validation errors found in shader assembly in GPU hang error states. --- src/intel/tools/disasm.c | 71 +--- 1 file changed, 43 insertions(+), 28 deletions(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c

[Mesa-dev] [PATCH 03/11] i965: Allow brw_eu_validate to handle compact instructions

This will allow the validator to run on shader programs we find in the GPU hang error state. --- src/intel/compiler/brw_eu_validate.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index 39363e4..3856

[Mesa-dev] [PATCH 04/11] i965: Add a weak no-op nir_print_instr() symbol

intel_asm_annotation.c is part of libintel_compiler.la, which contains code for disassembling and validating shaders that we want to call in aubinator_error_decode. dump_assembly() calls nir_print_instr() to print annotations, and although dump_assembly() is not called by aubinator_error_decode (n

[Mesa-dev] [PATCH 07/11] genxml: Rename "VS Function Enable" to just "Function Enable"

Other commands have a field with an identical function and call it "Function Enable". --- src/intel/genxml/gen45.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml index 1a5a521..b7f0c8b 100644 --- a/src/intel/genxml/gen4

[Mesa-dev] [PATCH 05/11] genxml: Remove brackets from kernel start pointer names

Newer Gens' names don't have the brackets. Having common names will make some later patches simpler. --- src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen6.xml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen4

[Mesa-dev] [PATCH 06/11] genxml: Remove hyphens from pixel dispatch enable names

Newer Gens' names don't have the hyphens. Having common names will make some later patches simpler. --- src/intel/genxml/gen4.xml | 6 +++--- src/intel/genxml/gen45.xml | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen4.xml b/src/intel/genxml/ge

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On 1 May 2017 at 21:40, Rob Herring wrote: > On Mon, May 1, 2017 at 3:27 PM, Emil Velikov wrote: >> On 27 April 2017 at 20:43, Rob Herring wrote: >>> Android O moves to LLVM 3.9 and also has some differences in header >>> dependencies as LLVM has moved to blueprint files. It seems libLLVMCore >>

[Mesa-dev] [PATCH 02/11] i965: Pass pointer and end of assembly to brw_validate_instructions

This will allow us to more easily run brw_validate_instructions() on shader programs we find in GPU hang error states. --- src/intel/compiler/brw_eu.h | 3 ++- src/intel/compiler/brw_eu_validate.c | 10 -- src/intel/compiler/brw_fs_generator.cpp | 10 -- src/i

[Mesa-dev] [PATCH 01/11] i965: Mark shader programs for capture in the error state.

When the GPU hangs, the kernel saves some state for us. Until now it has not included the shader programs, which are very often the reason the GPU hang occurred. With the programs saved in the error state, we should be more capable of debugging hangs. Thanks to Chris Wilson and Ben Widawsky who pr

[Mesa-dev] [PATCH 00/11] i965: Shader programs in the error state

This series adds the userspace portion required to save the shader programs that were running when a GPU hang occurred in the error state. From there we can feed the error state to aubinator_error_decode, which will parse the batch and find the shader programs, validate them (using brw_eu_validate

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

On 27 April 2017 at 20:43, Rob Herring wrote: > This is a series of clean-ups and fixes to the Android build files. > Overall, it removes a lot of the if conditions that aren't necessary for > normal builds and also enables "mmma external/mesa3d" to build > everything for easier build testing. > >

Re: [Mesa-dev] [PATCH 12/12] Android: Drop linking libgcc

On Mon, May 1, 2017 at 3:35 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> Including libgcc breaks on Android O (master). Not exactly sure if it is >> still needed on older versions or not. N is build with clang, so it >> should be fine at least. >> > Chih-Wei added it

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On Mon, May 1, 2017 at 3:27 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> Android O moves to LLVM 3.9 and also has some differences in header >> dependencies as LLVM has moved to blueprint files. It seems libLLVMCore >> was only needed for header dependencies. >> >> S

Re: [Mesa-dev] [PATCH 12/12] Android: Drop linking libgcc

On 27 April 2017 at 20:43, Rob Herring wrote: > Including libgcc breaks on Android O (master). Not exactly sure if it is > still needed on older versions or not. N is build with clang, so it > should be fine at least. > Chih-Wei added it with c5e11e5f7f67fe5a1d28b1446f87af7aa3ba68d8 for Android L.

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

Eric Anholt writes: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific and I didn't want to add detection

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On 27 April 2017 at 20:43, Rob Herring wrote: > Android O moves to LLVM 3.9 and also has some differences in header > dependencies as LLVM has moved to blueprint files. It seems libLLVMCore > was only needed for header dependencies. > > Signed-off-by: Rob Herring > --- > Android.common.mk

Re: [Mesa-dev] [PATCH 10/12] Android: default to building all drivers

On 27 April 2017 at 20:43, Rob Herring wrote: > If BOARD_GPU_DRIVERS is empty, build all the drivers. This doesn't > enable building mesa as that is controlled by including libGLES_mesa in > the product. > > Signed-off-by: Rob Herring > --- > Android.mk | 8 > 1 file changed, 8 insertio

Re: [Mesa-dev] [PATCH 09/12] Android: push driver build details to driver makefiles

Hi Rob, On 27 April 2017 at 20:43, Rob Herring wrote: > +classic_drivers := i915.HAVE_I915_DRI i965.HAVE_I965_DRI > +gallium_drivers := \ > + swrast.HAVE_GALLIUM_SOFTPIPE \ > + freedreno.HAVE_GALLIUM_FREEDRENO \ > + i915g.HAVE_GALLIUM_I915 \ > + nouveau.HAVE_GALLIUM_NOUVE

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-05-01 3:03 GMT+02:00 Mauro Rossi : > > > 2017-04-28 4:55 GMT+02:00 Chih-Wei Huang : > >> 2017-04-28 3:43 GMT+08:00 Rob Herring : >> > This is a series of clean-ups and fixes to the Android build files. >> > Overall, it removes a lot of the if conditions that aren't necessary for >> > normal b

Re: [Mesa-dev] [PATCH 07/12] Android: remove needless conditional including of child makefiles

On Mon, May 1, 2017 at 1:50 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> It is not necessary to filter driver and winsys directories based on the >> list of enabled drivers. Selecting the included driver libraries or not is >> sufficient to control what is built. >>

Re: [Mesa-dev] [PATCH 07/12] Android: remove needless conditional including of child makefiles

On 27 April 2017 at 20:43, Rob Herring wrote: > It is not necessary to filter driver and winsys directories based on the > list of enabled drivers. Selecting the included driver libraries or not is > sufficient to control what is built. > > Signed-off-by: Rob Herring > --- > Android.mk

  1   2   >